Zulip Chat Archive

Stream: mathlib4

Topic: Can't `SmulCommClass.symm` be an instance?


Anne Baanen (Jan 17 2023 at 11:04):

I believe the new instance synthesis algorithm should allow docs4#SMulCommClass.symm to be an instance safely, despite the warning in its docstring. @Ruben Van de Velde, what do you think?

Eric Wieser (Jan 17 2023 at 11:05):

I think we already have all the manual instances in place to make this unnecessary

Eric Wieser (Jan 17 2023 at 11:05):

So I'd be inclined to leave it as a non-instance until after the port

Anne Baanen (Jan 17 2023 at 11:08):

Makes sense, let's wait with refactors like this until the port is finished. Shall I make a PR so we don't forget?

Anne Baanen (Jan 17 2023 at 11:12):

It was an oneliner so I just went ahead and did mathlib4#1621

Ruben Van de Velde (Jan 17 2023 at 11:44):

I'm only vaguely aware of the type class changes in lean4, so have no opinion. Waiting until we can test it on a bigger mathlib makes sense to me


Last updated: Dec 20 2023 at 11:08 UTC