algebra.category.Module.projective | Mathlib porting status

Changes since the initial port

The following section lists changes to this file in mathlib3 and mathlib4 that occured after the initial port. Most recent changes are shown first. Hovering over a commit will show all commits associated with the same mathlib3 commit.

Changes in mathlib3

201a3f4a

(last sync)

Changes in mathlib3port

mathlib3

mathlib3port

1b0a28e1

bump to nightly-2024-04-06-08

mathlib commit https://github.com/leanprover-community/mathlib/commit/65a1391a0106c9204fe45bc73a039f056558cb83

e34029c9

Diff

@@ -3,7 +3,7 @@ Copyright (c) 2020 Markus Himmel. All rights reserved.
 Released under Apache 2.0 license as described in the file LICENSE.
 Authors: Markus Himmel, Scott Morrison
 -/
-import Algebra.Category.Module.EpiMono
+import Algebra.Category.ModuleCat.EpiMono
 import Algebra.Module.Projective
 import CategoryTheory.Preadditive.Projective
 import LinearAlgebra.FinsuppVectorSpace

1b0a28e1

bump to nightly-2023-09-24-06

mathlib commit https://github.com/leanprover-community/mathlib/commit/ce64cd319bb6b3e82f31c2d38e79080d377be451

5655435f

Diff

@@ -3,10 +3,10 @@ Copyright (c) 2020 Markus Himmel. All rights reserved.
 Released under Apache 2.0 license as described in the file LICENSE.
 Authors: Markus Himmel, Scott Morrison
 -/
-import Mathbin.Algebra.Category.Module.EpiMono
-import Mathbin.Algebra.Module.Projective
-import Mathbin.CategoryTheory.Preadditive.Projective
-import Mathbin.LinearAlgebra.FinsuppVectorSpace
+import Algebra.Category.Module.EpiMono
+import Algebra.Module.Projective
+import CategoryTheory.Preadditive.Projective
+import LinearAlgebra.FinsuppVectorSpace
 
 #align_import algebra.category.Module.projective from "leanprover-community/mathlib"@"1b0a28e1c93409dbf6d69526863cd9984ef652ce"

1b0a28e1

bump to nightly-2023-07-20-09

mathlib commit https://github.com/leanprover-community/mathlib/commit/8ea5598db6caeddde6cb734aa179cc2408dbd345

9c56d0dd

Diff

@@ -2,17 +2,14 @@
 Copyright (c) 2020 Markus Himmel. All rights reserved.
 Released under Apache 2.0 license as described in the file LICENSE.
 Authors: Markus Himmel, Scott Morrison
-
-! This file was ported from Lean 3 source module algebra.category.Module.projective
-! leanprover-community/mathlib commit 1b0a28e1c93409dbf6d69526863cd9984ef652ce
-! Please do not edit these lines, except to modify the commit id
-! if you have ported upstream changes.
 -/
 import Mathbin.Algebra.Category.Module.EpiMono
 import Mathbin.Algebra.Module.Projective
 import Mathbin.CategoryTheory.Preadditive.Projective
 import Mathbin.LinearAlgebra.FinsuppVectorSpace
 
+#align_import algebra.category.Module.projective from "leanprover-community/mathlib"@"1b0a28e1c93409dbf6d69526863cd9984ef652ce"
+
 /-!
 # The category of `R`-modules has enough projectives.

1b0a28e1

bump to nightly-2023-05-28-18

mathlib commit https://github.com/leanprover-community/mathlib/commit/917c3c072e487b3cccdbfeff17e75b40e45f66cb

8d353152

Diff

@@ -29,7 +29,7 @@ open CategoryTheory.Limits
 
 open LinearMap
 
-open ModuleCat
+open scoped ModuleCat
 
 #print IsProjective.iff_projective /-
 /-- The categorical notion of projective object agrees with the explicit module-theoretic notion. -/

1b0a28e1

bump to nightly-2023-05-22-03

mathlib commit https://github.com/leanprover-community/mathlib/commit/1b0a28e1c93409dbf6d69526863cd9984ef652ce

5dfda1a5

Diff

@@ -4,7 +4,7 @@ Released under Apache 2.0 license as described in the file LICENSE.
 Authors: Markus Himmel, Scott Morrison
 
 ! This file was ported from Lean 3 source module algebra.category.Module.projective
-! leanprover-community/mathlib commit 201a3f4a0e59b5f836fe8a6c1a462ee674327211
+! leanprover-community/mathlib commit 1b0a28e1c93409dbf6d69526863cd9984ef652ce
 ! Please do not edit these lines, except to modify the commit id
 ! if you have ported upstream changes.
 -/
@@ -15,6 +15,9 @@ import Mathbin.LinearAlgebra.FinsuppVectorSpace
 
 /-!
 # The category of `R`-modules has enough projectives.
+
+> THIS FILE IS SYNCHRONIZED WITH MATHLIB4.
+> Any changes to this file require a corresponding PR to mathlib4.
 -/

201a3f4a

bump to nightly-2023-05-20-12

mathlib commit https://github.com/leanprover-community/mathlib/commit/f51de8769c34652d82d1c8e5f8f18f8374782bed

cb56d47a

Diff

@@ -28,6 +28,7 @@ open LinearMap
 
 open ModuleCat
 
+#print IsProjective.iff_projective /-
 /-- The categorical notion of projective object agrees with the explicit module-theoretic notion. -/
 theorem IsProjective.iff_projective {R : Type u} [Ring R] {P : Type max u v} [AddCommGroup P]
     [Module R P] : Module.Projective R P ↔ Projective (ModuleCat.of R P) :=
@@ -43,18 +44,22 @@ theorem IsProjective.iff_projective {R : Type u} [Ring R] {P : Type max u v} [Ad
     letI : projective (ModuleCat.of R P) := h
     exact ⟨projective.factor_thru (↟g) (↟f), projective.factor_thru_comp (↟g) (↟f)⟩
 #align is_projective.iff_projective IsProjective.iff_projective
+-/
 
 namespace ModuleCat
 
 variable {R : Type u} [Ring R] {M : ModuleCat.{max u v} R}
 
+#print ModuleCat.projective_of_free /-
 -- We transport the corresponding result from `module.projective`.
 /-- Modules that have a basis are projective. -/
 theorem projective_of_free {ι : Type _} (b : Basis ι R M) : Projective M :=
   Projective.of_iso (ModuleCat.ofSelfIso _)
     (IsProjective.iff_projective.mp (Module.Projective.of_basis b))
 #align Module.projective_of_free ModuleCat.projective_of_free
+-/
 
+#print ModuleCat.moduleCat_enoughProjectives /-
 /-- The category of modules has enough projectives, since every module is a quotient of a free
     module. -/
 instance moduleCat_enoughProjectives : EnoughProjectives (ModuleCat.{max u v} R)
@@ -66,6 +71,7 @@ instance moduleCat_enoughProjectives : EnoughProjectives (ModuleCat.{max u v} R)
           (epi_iff_range_eq_top _).mpr
             (range_eq_top.2 fun m => ⟨Finsupp.single m (1 : R), by simp [Basis.constr]⟩) }⟩
 #align Module.Module_enough_projectives ModuleCat.moduleCat_enoughProjectives
+-/
 
 end ModuleCat

201a3f4a

bump to nightly-2023-04-10-18

mathlib commit https://github.com/leanprover-community/mathlib/commit/e05ead7993520a432bec94ac504842d90707ad63

72a0e1ef

Diff

@@ -37,7 +37,7 @@ theorem IsProjective.iff_projective {R : Type u} [Ring R] {P : Type max u v} [Ad
     exact
       ⟨fun E X f e epi =>
         Module.projective_lifting_property _ _ ((ModuleCat.epi_iff_surjective _).mp epi)⟩
-  · refine' Module.projectiveOfLiftingProperty _
+  · refine' Module.Projective.of_lifting_property _
     intro E X mE mX sE sX f g s
     haveI : epi (↟f) := (ModuleCat.epi_iff_surjective (↟f)).mpr s
     letI : projective (ModuleCat.of R P) := h
@@ -52,7 +52,7 @@ variable {R : Type u} [Ring R] {M : ModuleCat.{max u v} R}
 /-- Modules that have a basis are projective. -/
 theorem projective_of_free {ι : Type _} (b : Basis ι R M) : Projective M :=
   Projective.of_iso (ModuleCat.ofSelfIso _)
-    (IsProjective.iff_projective.mp (Module.projectiveOfBasis b))
+    (IsProjective.iff_projective.mp (Module.Projective.of_basis b))
 #align Module.projective_of_free ModuleCat.projective_of_free
 
 /-- The category of modules has enough projectives, since every module is a quotient of a free

201a3f4a

bump to nightly-2023-04-04-02

mathlib commit https://github.com/leanprover-community/mathlib/commit/3cacc945118c8c637d89950af01da78307f59325

2ee17135

Diff

@@ -59,7 +59,7 @@ theorem projective_of_free {ι : Type _} (b : Basis ι R M) : Projective M :=
     module. -/
 instance moduleCat_enoughProjectives : EnoughProjectives (ModuleCat.{max u v} R)
     where presentation M :=
-    ⟨{  P := ModuleCat.of R (M →₀ R)
+    ⟨{  p := ModuleCat.of R (M →₀ R)
         Projective := projective_of_free Finsupp.basisSingleOne
         f := Finsupp.basisSingleOne.constr ℕ id
         Epi :=

201a3f4a

bump to nightly-2023-02-21-16

mathlib commit https://github.com/leanprover-community/mathlib/commit/bd9851ca476957ea4549eb19b40e7b5ade9428cc

1107b979

Changes in mathlib4

mathlib3

mathlib4

201a3f4a

chore: remove more autoImplicit (#11336)

... or reduce its scope (the full removal is not as obvious).

59f72a90

Diff

@@ -15,9 +15,7 @@ import Mathlib.Data.Finsupp.Basic
 # The category of `R`-modules has enough projectives.
 -/
 
-set_option autoImplicit true
-
-universe v u
+universe v u u'
 
 open CategoryTheory

201a3f4a

Revert "chore: revert #7703 (#7710)"

This reverts commit f3695eb2.

ab56fa28

Diff

@@ -69,7 +69,9 @@ instance moduleCat_enoughProjectives : EnoughProjectives (ModuleCat.{max u v} R)
               -- Porting note: simp [Finsupp.total_single] fails but rw succeeds
               dsimp [Basis.constr]
               simp only [Finsupp.lmapDomain_id, comp_id]
-              rw [Finsupp.total_single, one_smul]
+              -- This used to be `rw`, but we need `erw` after leanprover/lean4#2644
+              erw [Finsupp.total_single]
+              rw [one_smul]
               rfl ⟩) }⟩
 set_option linter.uppercaseLean3 false in
 #align Module.Module_enough_projectives ModuleCat.moduleCat_enoughProjectives

201a3f4a

chore: revert #7703 (#7710)

This reverts commit 26eb2b0a.

f3695eb2

Diff

@@ -69,9 +69,7 @@ instance moduleCat_enoughProjectives : EnoughProjectives (ModuleCat.{max u v} R)
               -- Porting note: simp [Finsupp.total_single] fails but rw succeeds
               dsimp [Basis.constr]
               simp only [Finsupp.lmapDomain_id, comp_id]
-              -- This used to be `rw`, but we need `erw` after leanprover/lean4#2644
-              erw [Finsupp.total_single]
-              rw [one_smul]
+              rw [Finsupp.total_single, one_smul]
               rfl ⟩) }⟩
 set_option linter.uppercaseLean3 false in
 #align Module.Module_enough_projectives ModuleCat.moduleCat_enoughProjectives

201a3f4a

chore: bump toolchain to v4.2.0-rc2 (#7703)

This includes all the changes from #7606.

Co-authored-by: Scott Morrison <scott.morrison@gmail.com>

26eb2b0a

Diff

@@ -69,7 +69,9 @@ instance moduleCat_enoughProjectives : EnoughProjectives (ModuleCat.{max u v} R)
               -- Porting note: simp [Finsupp.total_single] fails but rw succeeds
               dsimp [Basis.constr]
               simp only [Finsupp.lmapDomain_id, comp_id]
-              rw [Finsupp.total_single, one_smul]
+              -- This used to be `rw`, but we need `erw` after leanprover/lean4#2644
+              erw [Finsupp.total_single]
+              rw [one_smul]
               rfl ⟩) }⟩
 set_option linter.uppercaseLean3 false in
 #align Module.Module_enough_projectives ModuleCat.moduleCat_enoughProjectives

201a3f4a

fix: disable autoImplicit globally (#6528)

Autoimplicits are highly controversial and also defeat the performance-improving work in #6474.

The intent of this PR is to make autoImplicit opt-in on a per-file basis, by disabling it in the lakefile and enabling it again with set_option autoImplicit true in the few files that rely on it.

That also keeps this PR small, as opposed to attempting to "fix" files to not need it any more.

I claim that many of the uses of autoImplicit in these files are accidental; situations such as:

Assuming variables are in scope, but pasting the lemma in the wrong section
Pasting in a lemma from a scratch file without checking to see if the variable names are consistent with the rest of the file
Making a copy-paste error between lemmas and forgetting to add an explicit arguments.

Having set_option autoImplicit false as the default prevents these types of mistake being made in the 90% of files where autoImplicits are not used at all, and causes them to be caught by CI during review.

I think there were various points during the port where we encouraged porters to delete the universes u v lines; I think having autoparams for universe variables only would cover a lot of the cases we actually use them, while avoiding any real shortcomings.

A Zulip poll (after combining overlapping votes accordingly) was in favor of this change with 5:5:18 as the no:dontcare:yes vote ratio.

While this PR was being reviewed, a handful of files gained some more likely-accidental autoImplicits. In these places, set_option autoImplicit true has been placed locally within a section, rather than at the top of the file.

0c24f831

Diff

@@ -15,6 +15,8 @@ import Mathlib.Data.Finsupp.Basic
 # The category of `R`-modules has enough projectives.
 -/
 
+set_option autoImplicit true
+
 universe v u
 
 open CategoryTheory

201a3f4a

chore: script to replace headers with #align_import statements (#5979)

depends on: #5966

Co-authored-by: Eric Wieser <wieser.eric@gmail.com> Co-authored-by: Scott Morrison <scott.morrison@gmail.com>

89aa3a3b

Diff

@@ -2,11 +2,6 @@
 Copyright (c) 2020 Markus Himmel. All rights reserved.
 Released under Apache 2.0 license as described in the file LICENSE.
 Authors: Markus Himmel, Scott Morrison
-
-! This file was ported from Lean 3 source module algebra.category.Module.projective
-! leanprover-community/mathlib commit 201a3f4a0e59b5f836fe8a6c1a462ee674327211
-! Please do not edit these lines, except to modify the commit id
-! if you have ported upstream changes.
 -/
 import Mathlib.Algebra.Category.ModuleCat.EpiMono
 import Mathlib.Algebra.Module.Projective
@@ -14,6 +9,8 @@ import Mathlib.CategoryTheory.Preadditive.Projective
 import Mathlib.LinearAlgebra.FinsuppVectorSpace
 import Mathlib.Data.Finsupp.Basic
 
+#align_import algebra.category.Module.projective from "leanprover-community/mathlib"@"201a3f4a0e59b5f836fe8a6c1a462ee674327211"
+
 /-!
 # The category of `R`-modules has enough projectives.
 -/

201a3f4a

feat: port Algebra.Category.ModuleCat.Projective (#3964)

This is stuck at a universe issue. Lean is having trouble merging Type (max (max v u) u v) with Type (max u u v)

See comment below.

Co-authored-by: Matthew Ballard <matt@mrb.email>

b58077e6

`algebra.category.Module.projective` ⟷ `Mathlib.Algebra.Category.ModuleCat.Projective`

Changes since the initial port

Changes in mathlib3

Changes in mathlib3port

Changes in mathlib4

Dependencies 8 + 560

algebra.category.Module.projective ⟷ Mathlib.Algebra.Category.ModuleCat.Projective

Changes since the initial port

Changes in mathlib3

Changes in mathlib3port

Changes in mathlib4

Dependencies 8 + 560

`algebra.category.Module.projective` ⟷ `Mathlib.Algebra.Category.ModuleCat.Projective`