algebra.category.Ring.adjunctions | Mathlib porting status

Changes since the initial port

The following section lists changes to this file in mathlib3 and mathlib4 that occured after the initial port. Most recent changes are shown first. Hovering over a commit will show all commits associated with the same mathlib3 commit.

Changes in mathlib3

79ffb556

(last sync)

Changes in mathlib3port

mathlib3

mathlib3port

f60c6087

bump to nightly-2024-04-07-08

mathlib commit https://github.com/leanprover-community/mathlib/commit/65a1391a0106c9204fe45bc73a039f056558cb83

b03b8656

Diff

@@ -4,7 +4,7 @@ Released under Apache 2.0 license as described in the file LICENSE.
 Authors: Scott Morrison, Johannes Hölzl
 -/
 import Algebra.Category.Ring.Basic
-import Data.MvPolynomial.CommRing
+import Algebra.MvPolynomial.CommRing
 
 #align_import algebra.category.Ring.adjunctions from "leanprover-community/mathlib"@"f60c6087a7275b72d5db3c5a1d0e19e35a429c0a"

f60c6087

bump to nightly-2023-09-24-06

mathlib commit https://github.com/leanprover-community/mathlib/commit/ce64cd319bb6b3e82f31c2d38e79080d377be451

5655435f

Diff

@@ -3,8 +3,8 @@ Copyright (c) 2019 Scott Morrison. All rights reserved.
 Released under Apache 2.0 license as described in the file LICENSE.
 Authors: Scott Morrison, Johannes Hölzl
 -/
-import Mathbin.Algebra.Category.Ring.Basic
-import Mathbin.Data.MvPolynomial.CommRing
+import Algebra.Category.Ring.Basic
+import Data.MvPolynomial.CommRing
 
 #align_import algebra.category.Ring.adjunctions from "leanprover-community/mathlib"@"f60c6087a7275b72d5db3c5a1d0e19e35a429c0a"

f60c6087

bump to nightly-2023-07-20-09

mathlib commit https://github.com/leanprover-community/mathlib/commit/8ea5598db6caeddde6cb734aa179cc2408dbd345

9c56d0dd

Diff

@@ -2,15 +2,12 @@
 Copyright (c) 2019 Scott Morrison. All rights reserved.
 Released under Apache 2.0 license as described in the file LICENSE.
 Authors: Scott Morrison, Johannes Hölzl
-
-! This file was ported from Lean 3 source module algebra.category.Ring.adjunctions
-! leanprover-community/mathlib commit f60c6087a7275b72d5db3c5a1d0e19e35a429c0a
-! Please do not edit these lines, except to modify the commit id
-! if you have ported upstream changes.
 -/
 import Mathbin.Algebra.Category.Ring.Basic
 import Mathbin.Data.MvPolynomial.CommRing
 
+#align_import algebra.category.Ring.adjunctions from "leanprover-community/mathlib"@"f60c6087a7275b72d5db3c5a1d0e19e35a429c0a"
+
 /-!
 > THIS FILE IS SYNCHRONIZED WITH MATHLIB4.
 > Any changes to this file require a corresponding PR to mathlib4.

f60c6087

bump to nightly-2023-06-13-21

mathlib commit https://github.com/leanprover-community/mathlib/commit/9fb8964792b4237dac6200193a0d533f1b3f7423

829520ac

Diff

@@ -47,15 +47,19 @@ def free : Type u ⥤ CommRingCat.{u}
 #align CommRing.free CommRingCat.free
 -/
 
+#print CommRingCat.free_obj_coe /-
 @[simp]
 theorem free_obj_coe {α : Type u} : (free.obj α : Type u) = MvPolynomial α ℤ :=
   rfl
 #align CommRing.free_obj_coe CommRingCat.free_obj_coe
+-/
 
+#print CommRingCat.free_map_coe /-
 @[simp]
 theorem free_map_coe {α β : Type u} {f : α → β} : ⇑(free.map f) = rename f :=
   rfl
 #align CommRing.free_map_coe CommRingCat.free_map_coe
+-/
 
 #print CommRingCat.adj /-
 /-- The free-forgetful adjunction for commutative rings.

f60c6087

bump to nightly-2023-06-01-04

mathlib commit https://github.com/leanprover-community/mathlib/commit/cca40788df1b8755d5baf17ab2f27dacc2e17acb

4d9eaa85

Diff

@@ -4,7 +4,7 @@ Released under Apache 2.0 license as described in the file LICENSE.
 Authors: Scott Morrison, Johannes Hölzl
 
 ! This file was ported from Lean 3 source module algebra.category.Ring.adjunctions
-! leanprover-community/mathlib commit 79ffb5563b56fefdea3d60b5736dad168a9494ab
+! leanprover-community/mathlib commit f60c6087a7275b72d5db3c5a1d0e19e35a429c0a
 ! Please do not edit these lines, except to modify the commit id
 ! if you have ported upstream changes.
 -/
@@ -12,6 +12,9 @@ import Mathbin.Algebra.Category.Ring.Basic
 import Mathbin.Data.MvPolynomial.CommRing
 
 /-!
+> THIS FILE IS SYNCHRONIZED WITH MATHLIB4.
+> Any changes to this file require a corresponding PR to mathlib4.
+
 Multivariable polynomials on a type is the left adjoint of the
 forgetful functor from commutative rings to types.
 -/

79ffb556

bump to nightly-2023-05-28-18

mathlib commit https://github.com/leanprover-community/mathlib/commit/917c3c072e487b3cccdbfeff17e75b40e45f66cb

8d353152

Diff

@@ -27,7 +27,7 @@ open CategoryTheory
 
 namespace CommRingCat
 
-open Classical
+open scoped Classical
 
 #print CommRingCat.free /-
 /-- The free functor `Type u ⥤ CommRing` sending a type `X` to the multivariable (commutative)

79ffb556

bump to nightly-2023-05-28-06

mathlib commit https://github.com/leanprover-community/mathlib/commit/917c3c072e487b3cccdbfeff17e75b40e45f66cb

ba5d8b97

Diff

@@ -44,20 +44,11 @@ def free : Type u ⥤ CommRingCat.{u}
 #align CommRing.free CommRingCat.free
 -/
 
-/- warning: CommRing.free_obj_coe -> CommRingCat.free_obj_coe is a dubious translation:
-lean 3 declaration is
-  forall {α : Type.{u1}}, Eq.{succ (succ u1)} Type.{u1} (coeSort.{succ (succ u1), succ (succ u1)} CommRingCat.{u1} Type.{u1} CommRingCat.hasCoeToSort.{u1} (CategoryTheory.Functor.obj.{u1, u1, succ u1, succ u1} Type.{u1} CategoryTheory.types.{u1} CommRingCat.{u1} CommRingCat.largeCategory.{u1} CommRingCat.free.{u1} α)) (MvPolynomial.{u1, 0} α Int Int.commSemiring)
-but is expected to have type
-  forall {α : Type.{u1}}, Eq.{succ (succ u1)} Type.{u1} (CategoryTheory.Bundled.α.{u1, u1} CommRing.{u1} (Prefunctor.obj.{succ u1, succ u1, succ u1, succ u1} Type.{u1} (CategoryTheory.CategoryStruct.toQuiver.{u1, succ u1} Type.{u1} (CategoryTheory.Category.toCategoryStruct.{u1, succ u1} Type.{u1} CategoryTheory.types.{u1})) CommRingCat.{u1} (CategoryTheory.CategoryStruct.toQuiver.{u1, succ u1} CommRingCat.{u1} (CategoryTheory.Category.toCategoryStruct.{u1, succ u1} CommRingCat.{u1} instCommRingCatLargeCategory.{u1})) (CategoryTheory.Functor.toPrefunctor.{u1, u1, succ u1, succ u1} Type.{u1} CategoryTheory.types.{u1} CommRingCat.{u1} instCommRingCatLargeCategory.{u1} CommRingCat.free.{u1}) α)) (MvPolynomial.{u1, 0} α Int Int.instCommSemiringInt)
-Case conversion may be inaccurate. Consider using '#align CommRing.free_obj_coe CommRingCat.free_obj_coeₓ'. -/
 @[simp]
 theorem free_obj_coe {α : Type u} : (free.obj α : Type u) = MvPolynomial α ℤ :=
   rfl
 #align CommRing.free_obj_coe CommRingCat.free_obj_coe
 
-/- warning: CommRing.free_map_coe -> CommRingCat.free_map_coe is a dubious translation:
-<too large>
-Case conversion may be inaccurate. Consider using '#align CommRing.free_map_coe CommRingCat.free_map_coeₓ'. -/
 @[simp]
 theorem free_map_coe {α β : Type u} {f : α → β} : ⇑(free.map f) = rename f :=
   rfl

79ffb556

bump to nightly-2023-05-28-03

mathlib commit https://github.com/leanprover-community/mathlib/commit/917c3c072e487b3cccdbfeff17e75b40e45f66cb

6c6011cf

Diff

@@ -29,6 +29,7 @@ namespace CommRingCat
 
 open Classical
 
+#print CommRingCat.free /-
 /-- The free functor `Type u ⥤ CommRing` sending a type `X` to the multivariable (commutative)
 polynomials with variables `x : X`.
 -/
@@ -41,17 +42,28 @@ def free : Type u ⥤ CommRingCat.{u}
   map_id' X := RingHom.ext <| rename_id
   map_comp' X Y Z f g := RingHom.ext fun p => (rename_rename f g p).symm
 #align CommRing.free CommRingCat.free
+-/
 
+/- warning: CommRing.free_obj_coe -> CommRingCat.free_obj_coe is a dubious translation:
+lean 3 declaration is
+  forall {α : Type.{u1}}, Eq.{succ (succ u1)} Type.{u1} (coeSort.{succ (succ u1), succ (succ u1)} CommRingCat.{u1} Type.{u1} CommRingCat.hasCoeToSort.{u1} (CategoryTheory.Functor.obj.{u1, u1, succ u1, succ u1} Type.{u1} CategoryTheory.types.{u1} CommRingCat.{u1} CommRingCat.largeCategory.{u1} CommRingCat.free.{u1} α)) (MvPolynomial.{u1, 0} α Int Int.commSemiring)
+but is expected to have type
+  forall {α : Type.{u1}}, Eq.{succ (succ u1)} Type.{u1} (CategoryTheory.Bundled.α.{u1, u1} CommRing.{u1} (Prefunctor.obj.{succ u1, succ u1, succ u1, succ u1} Type.{u1} (CategoryTheory.CategoryStruct.toQuiver.{u1, succ u1} Type.{u1} (CategoryTheory.Category.toCategoryStruct.{u1, succ u1} Type.{u1} CategoryTheory.types.{u1})) CommRingCat.{u1} (CategoryTheory.CategoryStruct.toQuiver.{u1, succ u1} CommRingCat.{u1} (CategoryTheory.Category.toCategoryStruct.{u1, succ u1} CommRingCat.{u1} instCommRingCatLargeCategory.{u1})) (CategoryTheory.Functor.toPrefunctor.{u1, u1, succ u1, succ u1} Type.{u1} CategoryTheory.types.{u1} CommRingCat.{u1} instCommRingCatLargeCategory.{u1} CommRingCat.free.{u1}) α)) (MvPolynomial.{u1, 0} α Int Int.instCommSemiringInt)
+Case conversion may be inaccurate. Consider using '#align CommRing.free_obj_coe CommRingCat.free_obj_coeₓ'. -/
 @[simp]
 theorem free_obj_coe {α : Type u} : (free.obj α : Type u) = MvPolynomial α ℤ :=
   rfl
 #align CommRing.free_obj_coe CommRingCat.free_obj_coe
 
+/- warning: CommRing.free_map_coe -> CommRingCat.free_map_coe is a dubious translation:
+<too large>
+Case conversion may be inaccurate. Consider using '#align CommRing.free_map_coe CommRingCat.free_map_coeₓ'. -/
 @[simp]
 theorem free_map_coe {α β : Type u} {f : α → β} : ⇑(free.map f) = rename f :=
   rfl
 #align CommRing.free_map_coe CommRingCat.free_map_coe
 
+#print CommRingCat.adj /-
 /-- The free-forgetful adjunction for commutative rings.
 -/
 def adj : free ⊣ forget CommRingCat.{u} :=
@@ -60,6 +72,7 @@ def adj : free ⊣ forget CommRingCat.{u} :=
       homEquiv_naturality_left_symm := fun _ _ Y f g =>
         RingHom.ext fun x => eval₂_cast_comp f (Int.castRingHom Y) g x }
 #align CommRing.adj CommRingCat.adj
+-/
 
 instance : IsRightAdjoint (forget CommRingCat.{u}) :=
   ⟨_, adj⟩

79ffb556

bump to nightly-2023-02-21-16

mathlib commit https://github.com/leanprover-community/mathlib/commit/bd9851ca476957ea4549eb19b40e7b5ade9428cc

1107b979

Changes in mathlib4

mathlib3

mathlib4

79ffb556

move(Polynomial): Move out of Data (#11751)

Polynomial and MvPolynomial are algebraic objects, hence should be under Algebra (or at least not under Data)

56e439ec

Diff

@@ -4,7 +4,7 @@ Released under Apache 2.0 license as described in the file LICENSE.
 Authors: Scott Morrison, Johannes Hölzl
 -/
 import Mathlib.Algebra.Category.Ring.Basic
-import Mathlib.Data.MvPolynomial.CommRing
+import Mathlib.Algebra.MvPolynomial.CommRing
 
 #align_import algebra.category.Ring.adjunctions from "leanprover-community/mathlib"@"79ffb5563b56fefdea3d60b5736dad168a9494ab"

79ffb556

chore: scope open Classical (#11199)

We remove all but one open Classicals, instead preferring to use open scoped Classical. The only real side-effect this led to is moving a couple declarations to use Exists.choose instead of Classical.choose.

The first few commits are explicitly labelled regex replaces for ease of review.

c747be0a

Diff

@@ -25,7 +25,7 @@ open CategoryTheory
 namespace CommRingCat
 set_option linter.uppercaseLean3 false -- `CommRing`
 
-open Classical
+open scoped Classical
 
 /-- The free functor `Type u ⥤ CommRingCat` sending a type `X` to the multivariable (commutative)
 polynomials with variables `x : X`.

79ffb556

chore: update links to issue #5081 to std4#86 (#6392)

Co-authored-by: Scott Morrison <scott.morrison@gmail.com>

3e439955

Diff

@@ -45,7 +45,7 @@ theorem free_obj_coe {α : Type u} : (free.obj α : Type u) = MvPolynomial α 
 #align CommRing.free_obj_coe CommRingCat.free_obj_coe
 
 -- Porting note: `simpNF` should not trigger on `rfl` lemmas.
--- see https://github.com/leanprover-community/mathlib4/issues/5081
+-- see https://github.com/leanprover/std4/issues/86
 @[simp, nolint simpNF]
 theorem free_map_coe {α β : Type u} {f : α → β} : ⇑(free.map f) = ⇑(rename f) :=
   rfl

79ffb556

chore: script to replace headers with #align_import statements (#5979)

depends on: #5966

Co-authored-by: Eric Wieser <wieser.eric@gmail.com> Co-authored-by: Scott Morrison <scott.morrison@gmail.com>

89aa3a3b

Diff

@@ -2,15 +2,12 @@
 Copyright (c) 2019 Scott Morrison. All rights reserved.
 Released under Apache 2.0 license as described in the file LICENSE.
 Authors: Scott Morrison, Johannes Hölzl
-
-! This file was ported from Lean 3 source module algebra.category.Ring.adjunctions
-! leanprover-community/mathlib commit 79ffb5563b56fefdea3d60b5736dad168a9494ab
-! Please do not edit these lines, except to modify the commit id
-! if you have ported upstream changes.
 -/
 import Mathlib.Algebra.Category.Ring.Basic
 import Mathlib.Data.MvPolynomial.CommRing
 
+#align_import algebra.category.Ring.adjunctions from "leanprover-community/mathlib"@"79ffb5563b56fefdea3d60b5736dad168a9494ab"
+
 /-!
 Multivariable polynomials on a type is the left adjoint of the
 forgetful functor from commutative rings to types.

79ffb556

feat: port Topology.Sheaves.Operations (#4731)

Co-authored-by: Jujian Zhang <jujian.zhang1998@outlook.com> Co-authored-by: Scott Morrison <scott.morrison@anu.edu.au> Co-authored-by: Parcly Taxel <reddeloostw@gmail.com>

32a2d94b

Diff

@@ -47,7 +47,9 @@ theorem free_obj_coe {α : Type u} : (free.obj α : Type u) = MvPolynomial α 
   rfl
 #align CommRing.free_obj_coe CommRingCat.free_obj_coe
 
-@[simp]
+-- Porting note: `simpNF` should not trigger on `rfl` lemmas.
+-- see https://github.com/leanprover-community/mathlib4/issues/5081
+@[simp, nolint simpNF]
 theorem free_map_coe {α β : Type u} {f : α → β} : ⇑(free.map f) = ⇑(rename f) :=
   rfl
 #align CommRing.free_map_coe CommRingCat.free_map_coe

79ffb556

feat: port Algebra.Category.Ring.Adjunctions (#4413)

aabb3054

`algebra.category.Ring.adjunctions` ⟷ `Mathlib.Algebra.Category.Ring.Adjunctions`

Changes since the initial port

Changes in mathlib3

Changes in mathlib3port

Changes in mathlib4

Dependencies 8 + 540

algebra.category.Ring.adjunctions ⟷ Mathlib.Algebra.Category.Ring.Adjunctions

Changes since the initial port

Changes in mathlib3

Changes in mathlib3port

Changes in mathlib4

Dependencies 8 + 540

`algebra.category.Ring.adjunctions` ⟷ `Mathlib.Algebra.Category.Ring.Adjunctions`