algebra.group_ring_action.subobjects | Mathlib porting status

Changes since the initial port

The following section lists changes to this file in mathlib3 and mathlib4 that occured after the initial port. Most recent changes are shown first. Hovering over a commit will show all commits associated with the same mathlib3 commit.

Changes in mathlib3

f93c1193

(last sync)

Changes in mathlib3port

mathlib3

mathlib3port

a11f9106

bump to nightly-2023-09-24-06

mathlib commit https://github.com/leanprover-community/mathlib/commit/ce64cd319bb6b3e82f31c2d38e79080d377be451

5655435f

Diff

@@ -3,8 +3,8 @@ Copyright (c) 2021 Eric Wieser. All rights reserved.
 Released under Apache 2.0 license as described in the file LICENSE.
 Authors: Eric Wieser
 -/
-import Mathbin.Algebra.GroupRingAction.Basic
-import Mathbin.GroupTheory.Subgroup.Basic
+import Algebra.GroupRingAction.Basic
+import GroupTheory.Subgroup.Basic
 
 #align_import algebra.group_ring_action.subobjects from "leanprover-community/mathlib"@"a11f9106a169dd302a285019e5165f8ab32ff433"

a11f9106

bump to nightly-2023-07-20-09

mathlib commit https://github.com/leanprover-community/mathlib/commit/8ea5598db6caeddde6cb734aa179cc2408dbd345

9c56d0dd

Diff

@@ -2,15 +2,12 @@
 Copyright (c) 2021 Eric Wieser. All rights reserved.
 Released under Apache 2.0 license as described in the file LICENSE.
 Authors: Eric Wieser
-
-! This file was ported from Lean 3 source module algebra.group_ring_action.subobjects
-! leanprover-community/mathlib commit a11f9106a169dd302a285019e5165f8ab32ff433
-! Please do not edit these lines, except to modify the commit id
-! if you have ported upstream changes.
 -/
 import Mathbin.Algebra.GroupRingAction.Basic
 import Mathbin.GroupTheory.Subgroup.Basic
 
+#align_import algebra.group_ring_action.subobjects from "leanprover-community/mathlib"@"a11f9106a169dd302a285019e5165f8ab32ff433"
+
 /-!
 # Instances of `mul_semiring_action` for subobjects

a11f9106

bump to nightly-2023-06-13-21

mathlib commit https://github.com/leanprover-community/mathlib/commit/9fb8964792b4237dac6200193a0d533f1b3f7423

829520ac

Diff

@@ -30,15 +30,19 @@ variable {M G R : Type _}
 
 variable [Monoid M] [Group G] [Semiring R]
 
+#print Submonoid.mulSemiringAction /-
 /-- A stronger version of `submonoid.distrib_mul_action`. -/
 instance Submonoid.mulSemiringAction [MulSemiringAction M R] (H : Submonoid M) :
     MulSemiringAction H R :=
   { H.MulDistribMulAction, H.DistribMulAction with smul := (· • ·) }
 #align submonoid.mul_semiring_action Submonoid.mulSemiringAction
+-/
 
+#print Subgroup.mulSemiringAction /-
 /-- A stronger version of `subgroup.distrib_mul_action`. -/
 instance Subgroup.mulSemiringAction [MulSemiringAction G R] (H : Subgroup G) :
     MulSemiringAction H R :=
   H.toSubmonoid.MulSemiringAction
 #align subgroup.mul_semiring_action Subgroup.mulSemiringAction
+-/

a11f9106

bump to nightly-2023-05-28-06

mathlib commit https://github.com/leanprover-community/mathlib/commit/917c3c072e487b3cccdbfeff17e75b40e45f66cb

ba5d8b97

Diff

@@ -30,24 +30,12 @@ variable {M G R : Type _}
 
 variable [Monoid M] [Group G] [Semiring R]
 
-/- warning: submonoid.mul_semiring_action -> Submonoid.mulSemiringAction is a dubious translation:
-lean 3 declaration is
-  forall {M : Type.{u1}} {R : Type.{u2}} [_inst_1 : Monoid.{u1} M] [_inst_3 : Semiring.{u2} R] [_inst_4 : MulSemiringAction.{u1, u2} M R _inst_1 _inst_3] (H : Submonoid.{u1} M (Monoid.toMulOneClass.{u1} M _inst_1)), MulSemiringAction.{u1, u2} (coeSort.{succ u1, succ (succ u1)} (Submonoid.{u1} M (Monoid.toMulOneClass.{u1} M _inst_1)) Type.{u1} (SetLike.hasCoeToSort.{u1, u1} (Submonoid.{u1} M (Monoid.toMulOneClass.{u1} M _inst_1)) M (Submonoid.setLike.{u1} M (Monoid.toMulOneClass.{u1} M _inst_1))) H) R (Submonoid.toMonoid.{u1} M _inst_1 H) _inst_3
-but is expected to have type
-  forall {M : Type.{u1}} {R : Type.{u2}} [_inst_1 : Monoid.{u1} M] [_inst_3 : Semiring.{u2} R] [_inst_4 : MulSemiringAction.{u1, u2} M R _inst_1 _inst_3] (H : Submonoid.{u1} M (Monoid.toMulOneClass.{u1} M _inst_1)), MulSemiringAction.{u1, u2} (Subtype.{succ u1} M (fun (x : M) => Membership.mem.{u1, u1} M (Submonoid.{u1} M (Monoid.toMulOneClass.{u1} M _inst_1)) (SetLike.instMembership.{u1, u1} (Submonoid.{u1} M (Monoid.toMulOneClass.{u1} M _inst_1)) M (Submonoid.instSetLikeSubmonoid.{u1} M (Monoid.toMulOneClass.{u1} M _inst_1))) x H)) R (Submonoid.toMonoid.{u1} M _inst_1 H) _inst_3
-Case conversion may be inaccurate. Consider using '#align submonoid.mul_semiring_action Submonoid.mulSemiringActionₓ'. -/
 /-- A stronger version of `submonoid.distrib_mul_action`. -/
 instance Submonoid.mulSemiringAction [MulSemiringAction M R] (H : Submonoid M) :
     MulSemiringAction H R :=
   { H.MulDistribMulAction, H.DistribMulAction with smul := (· • ·) }
 #align submonoid.mul_semiring_action Submonoid.mulSemiringAction
 
-/- warning: subgroup.mul_semiring_action -> Subgroup.mulSemiringAction is a dubious translation:
-lean 3 declaration is
-  forall {G : Type.{u1}} {R : Type.{u2}} [_inst_2 : Group.{u1} G] [_inst_3 : Semiring.{u2} R] [_inst_4 : MulSemiringAction.{u1, u2} G R (DivInvMonoid.toMonoid.{u1} G (Group.toDivInvMonoid.{u1} G _inst_2)) _inst_3] (H : Subgroup.{u1} G _inst_2), MulSemiringAction.{u1, u2} (coeSort.{succ u1, succ (succ u1)} (Subgroup.{u1} G _inst_2) Type.{u1} (SetLike.hasCoeToSort.{u1, u1} (Subgroup.{u1} G _inst_2) G (Subgroup.setLike.{u1} G _inst_2)) H) R (DivInvMonoid.toMonoid.{u1} (coeSort.{succ u1, succ (succ u1)} (Subgroup.{u1} G _inst_2) Type.{u1} (SetLike.hasCoeToSort.{u1, u1} (Subgroup.{u1} G _inst_2) G (Subgroup.setLike.{u1} G _inst_2)) H) (Group.toDivInvMonoid.{u1} (coeSort.{succ u1, succ (succ u1)} (Subgroup.{u1} G _inst_2) Type.{u1} (SetLike.hasCoeToSort.{u1, u1} (Subgroup.{u1} G _inst_2) G (Subgroup.setLike.{u1} G _inst_2)) H) (Subgroup.toGroup.{u1} G _inst_2 H))) _inst_3
-but is expected to have type
-  forall {G : Type.{u1}} {R : Type.{u2}} [_inst_2 : Group.{u1} G] [_inst_3 : Semiring.{u2} R] [_inst_4 : MulSemiringAction.{u1, u2} G R (DivInvMonoid.toMonoid.{u1} G (Group.toDivInvMonoid.{u1} G _inst_2)) _inst_3] (H : Subgroup.{u1} G _inst_2), MulSemiringAction.{u1, u2} (Subtype.{succ u1} G (fun (x : G) => Membership.mem.{u1, u1} G (Subgroup.{u1} G _inst_2) (SetLike.instMembership.{u1, u1} (Subgroup.{u1} G _inst_2) G (Subgroup.instSetLikeSubgroup.{u1} G _inst_2)) x H)) R (Submonoid.toMonoid.{u1} G (DivInvMonoid.toMonoid.{u1} G (Group.toDivInvMonoid.{u1} G _inst_2)) (Subgroup.toSubmonoid.{u1} G _inst_2 H)) _inst_3
-Case conversion may be inaccurate. Consider using '#align subgroup.mul_semiring_action Subgroup.mulSemiringActionₓ'. -/
 /-- A stronger version of `subgroup.distrib_mul_action`. -/
 instance Subgroup.mulSemiringAction [MulSemiringAction G R] (H : Subgroup G) :
     MulSemiringAction H R :=

a11f9106

bump to nightly-2023-02-21-16

mathlib commit https://github.com/leanprover-community/mathlib/commit/bd9851ca476957ea4549eb19b40e7b5ade9428cc

1107b979

Changes in mathlib4

mathlib3

mathlib4

f93c1193

chore(*): remove empty lines between variable statements (#11418)

Empty lines were removed by executing the following Python script twice

import os
import re


# Loop through each file in the repository
for dir_path, dirs, files in os.walk('.'):
  for filename in files:
    if filename.endswith('.lean'):
      file_path = os.path.join(dir_path, filename)

      # Open the file and read its contents
      with open(file_path, 'r') as file:
        content = file.read()

      # Use a regular expression to replace sequences of "variable" lines separated by empty lines
      # with sequences without empty lines
      modified_content = re.sub(r'(variable.*\n)\n(variable(?! .* in))', r'\1\2', content)

      # Write the modified content back to the file
      with open(file_path, 'w') as file:
        file.write(modified_content)

75c86f04

Diff

@@ -21,7 +21,6 @@ for those subobjects.
 
 
 variable {M G R : Type*}
-
 variable [Monoid M] [Group G] [Semiring R]
 
 /-- A stronger version of `Submonoid.distribMulAction`. -/

f93c1193

perf: remove overspecified fields (#6965)

This removes redundant field values of the form add := add for smaller terms and less unfolding during unification.

A list of all files containing a structure instance of the form { a1, ... with x1 := val, ... } where some xi is a field of some aj was generated by modifying the structure instance elaboration algorithm to print such overlaps to stdout in a custom toolchain.

Using that toolchain, I went through each file on the list and attempted to remove algebraic fields that overlapped and were redundant, eg add := add and not toFun (though some other ones did creep in). If things broke (which was the case in a couple of cases), I did not push further and reverted.

It is possible that pushing harder and trying to remove all redundant overlaps will yield further improvements.

12150475

Diff

@@ -27,8 +27,7 @@ variable [Monoid M] [Group G] [Semiring R]
 /-- A stronger version of `Submonoid.distribMulAction`. -/
 instance Submonoid.mulSemiringAction [MulSemiringAction M R] (H : Submonoid M) :
     MulSemiringAction H R :=
-  { inferInstanceAs (DistribMulAction H R), inferInstanceAs (MulDistribMulAction H R)
-    with smul := (· • ·) }
+  { inferInstanceAs (DistribMulAction H R), inferInstanceAs (MulDistribMulAction H R) with }
 #align submonoid.mul_semiring_action Submonoid.mulSemiringAction
 
 /-- A stronger version of `Subgroup.distribMulAction`. -/

f93c1193

chore: banish Type _ and Sort _ (#6499)

We remove all possible occurences of Type _ and Sort _ in favor of Type* and Sort*.

This has nice performance benefits.

32de3f67

Diff

@@ -20,7 +20,7 @@ for those subobjects.
 -/
 
 
-variable {M G R : Type _}
+variable {M G R : Type*}
 
 variable [Monoid M] [Group G] [Semiring R]

f93c1193

chore: script to replace headers with #align_import statements (#5979)

depends on: #5966

Co-authored-by: Eric Wieser <wieser.eric@gmail.com> Co-authored-by: Scott Morrison <scott.morrison@gmail.com>

89aa3a3b

Diff

@@ -2,15 +2,12 @@
 Copyright (c) 2021 Eric Wieser. All rights reserved.
 Released under Apache 2.0 license as described in the file LICENSE.
 Authors: Eric Wieser
-
-! This file was ported from Lean 3 source module algebra.group_ring_action.subobjects
-! leanprover-community/mathlib commit f93c11933efbc3c2f0299e47b8ff83e9b539cbf6
-! Please do not edit these lines, except to modify the commit id
-! if you have ported upstream changes.
 -/
 import Mathlib.Algebra.GroupRingAction.Basic
 import Mathlib.GroupTheory.Subgroup.Basic
 
+#align_import algebra.group_ring_action.subobjects from "leanprover-community/mathlib"@"f93c11933efbc3c2f0299e47b8ff83e9b539cbf6"
+
 /-!
 # Instances of `MulSemiringAction` for subobjects

f93c1193

chore: use inferInstanceAs (#2074)

Drop

by delta mydef; infer_instance. This generates id _ in the proof.
show _, by infer_instance. This generates let in let; not sure if it's bad for defeq but a reducible inferInstanceAs should not be worse.

f9f9320a

Diff

@@ -30,8 +30,7 @@ variable [Monoid M] [Group G] [Semiring R]
 /-- A stronger version of `Submonoid.distribMulAction`. -/
 instance Submonoid.mulSemiringAction [MulSemiringAction M R] (H : Submonoid M) :
     MulSemiringAction H R :=
-  { show MulDistribMulAction H R by infer_instance,
-    show DistribMulAction H R by infer_instance
+  { inferInstanceAs (DistribMulAction H R), inferInstanceAs (MulDistribMulAction H R)
     with smul := (· • ·) }
 #align submonoid.mul_semiring_action Submonoid.mulSemiringAction

f93c1193

feat: port Algebra.GroupRingAction.Subobjects (#1849)

142b06b9

`algebra.group_ring_action.subobjects` ⟷ `Mathlib.Algebra.GroupRingAction.Subobjects`

Changes since the initial port

Changes in mathlib3

Changes in mathlib3port

Changes in mathlib4

Dependencies 4 + 206

algebra.group_ring_action.subobjects ⟷ Mathlib.Algebra.GroupRingAction.Subobjects

Changes since the initial port

Changes in mathlib3

Changes in mathlib3port

Changes in mathlib4

Dependencies 4 + 206

`algebra.group_ring_action.subobjects` ⟷ `Mathlib.Algebra.GroupRingAction.Subobjects`