algebra.order.group.instances | Mathlib porting status

Changes since the initial port

The following section lists changes to this file in mathlib3 and mathlib4 that occured after the initial port. Most recent changes are shown first. Hovering over a commit will show all commits associated with the same mathlib3 commit.

Changes in mathlib3

55bbb807

(last sync)

chore(algebra/order/group): Restore basic instances (#17810)

Moving the inheritance instances results in unexpected and confusing errors when importing algebra.order.group.defs but not algebra.order.group.instances. This puts the inheritance instances back into algebra.order.group.defs.

Diff

@@ -17,21 +17,9 @@ import algebra.order.monoid.order_dual
 
 variables {α : Type*}
 
-@[priority 100, to_additive]    -- see Note [lower instance priority]
-instance ordered_comm_group.to_ordered_cancel_comm_monoid [s : ordered_comm_group α] :
-  ordered_cancel_comm_monoid α :=
-{ le_of_mul_le_mul_left := λ a b c, (mul_le_mul_iff_left a).mp,
-  ..s }
-
 @[to_additive] instance [ordered_comm_group α] : ordered_comm_group αᵒᵈ :=
 { .. order_dual.ordered_comm_monoid, .. order_dual.group }
 
 @[to_additive] instance [linear_ordered_comm_group α] :
   linear_ordered_comm_group αᵒᵈ :=
 { .. order_dual.ordered_comm_group, .. order_dual.linear_order α }
-
-@[priority 100, to_additive] -- see Note [lower instance priority]
-instance linear_ordered_comm_group.to_linear_ordered_cancel_comm_monoid
-  [linear_ordered_comm_group α] : linear_ordered_cancel_comm_monoid α :=
-{ le_of_mul_le_mul_left := λ x y z, le_of_mul_le_mul_left',
-  ..‹linear_ordered_comm_group α› }

a95b16cb

(first ported)

Changes in mathlib3port

mathlib3

mathlib3port

448144f7

bump to nightly-2023-09-24-06

mathlib commit https://github.com/leanprover-community/mathlib/commit/ce64cd319bb6b3e82f31c2d38e79080d377be451

5655435f

Diff

@@ -3,8 +3,8 @@ Copyright (c) 2016 Jeremy Avigad. All rights reserved.
 Released under Apache 2.0 license as described in the file LICENSE.
 Authors: Jeremy Avigad, Leonardo de Moura, Mario Carneiro, Johannes Hölzl
 -/
-import Mathbin.Algebra.Order.Group.Defs
-import Mathbin.Algebra.Order.Monoid.OrderDual
+import Algebra.Order.Group.Defs
+import Algebra.Order.Monoid.OrderDual
 
 #align_import algebra.order.group.instances from "leanprover-community/mathlib"@"448144f7ae193a8990cb7473c9e9a01990f64ac7"

448144f7

bump to nightly-2023-09-10-06

mathlib commit https://github.com/leanprover-community/mathlib/commit/442a83d738cb208d3600056c489be16900ba701d

783dcb10

Diff

@@ -21,7 +21,7 @@ variable {α : Type _}
 
 @[to_additive]
 instance [OrderedCommGroup α] : OrderedCommGroup αᵒᵈ :=
-  { OrderDual.orderedCommMonoid, instGroupOrderDual with }
+  { OrderDual.orderedCommMonoid, OrderDual.instGroup with }
 
 @[to_additive]
 instance [LinearOrderedCommGroup α] : LinearOrderedCommGroup αᵒᵈ :=

448144f7

bump to nightly-2023-08-11-09

mathlib commit https://github.com/leanprover-community/mathlib/commit/32a7e535287f9c73f2e4d2aef306a39190f0b504

0d5a6584

Diff

@@ -25,5 +25,5 @@ instance [OrderedCommGroup α] : OrderedCommGroup αᵒᵈ :=
 
 @[to_additive]
 instance [LinearOrderedCommGroup α] : LinearOrderedCommGroup αᵒᵈ :=
-  { OrderDual.orderedCommGroup, OrderDual.linearOrder α with }
+  { OrderDual.orderedCommGroup, OrderDual.instLinearOrder α with }

448144f7

bump to nightly-2023-07-20-09

mathlib commit https://github.com/leanprover-community/mathlib/commit/8ea5598db6caeddde6cb734aa179cc2408dbd345

9c56d0dd

Diff

@@ -2,15 +2,12 @@
 Copyright (c) 2016 Jeremy Avigad. All rights reserved.
 Released under Apache 2.0 license as described in the file LICENSE.
 Authors: Jeremy Avigad, Leonardo de Moura, Mario Carneiro, Johannes Hölzl
-
-! This file was ported from Lean 3 source module algebra.order.group.instances
-! leanprover-community/mathlib commit 448144f7ae193a8990cb7473c9e9a01990f64ac7
-! Please do not edit these lines, except to modify the commit id
-! if you have ported upstream changes.
 -/
 import Mathbin.Algebra.Order.Group.Defs
 import Mathbin.Algebra.Order.Monoid.OrderDual
 
+#align_import algebra.order.group.instances from "leanprover-community/mathlib"@"448144f7ae193a8990cb7473c9e9a01990f64ac7"
+
 /-!
 # Additional instances for ordered commutative groups.

448144f7

bump to nightly-2023-02-21-16

mathlib commit https://github.com/leanprover-community/mathlib/commit/bd9851ca476957ea4549eb19b40e7b5ade9428cc

1107b979

Changes in mathlib4

mathlib3

mathlib4

55bbb807

chore: tidy various files (#7035)

d04897a6

Diff

@@ -18,7 +18,7 @@ variable {α : Type*}
 
 @[to_additive]
 instance OrderDual.orderedCommGroup [OrderedCommGroup α] : OrderedCommGroup αᵒᵈ :=
-  { OrderDual.orderedCommMonoid, instGroupOrderDual with }
+  { OrderDual.orderedCommMonoid, OrderDual.instGroup with }
 #align order_dual.ordered_comm_group OrderDual.orderedCommGroup
 #align order_dual.ordered_add_comm_group OrderDual.orderedAddCommGroup

55bbb807

chore: banish Type _ and Sort _ (#6499)

We remove all possible occurences of Type _ and Sort _ in favor of Type* and Sort*.

This has nice performance benefits.

32de3f67

Diff

@@ -14,7 +14,7 @@ import Mathlib.Algebra.Order.Monoid.OrderDual
 -/
 
 
-variable {α : Type _}
+variable {α : Type*}
 
 @[to_additive]
 instance OrderDual.orderedCommGroup [OrderedCommGroup α] : OrderedCommGroup αᵒᵈ :=

55bbb807

chore: ensure all instances referred to directly have explicit names (#6423)

Per https://github.com/leanprover/lean4/issues/2343, we are going to need to change the automatic generation of instance names, as they become too long.

This PR ensures that everywhere in Mathlib that refers to an instance by name, that name is given explicitly, rather than being automatically generated.

There are four exceptions, which are now commented, with links to https://github.com/leanprover/lean4/issues/2343.

This was implemented by running Mathlib against a modified Lean that appended _ᾰ to all automatically generated names, and fixing everything.

Co-authored-by: Scott Morrison <scott.morrison@gmail.com>

65a35f78

Diff

@@ -24,4 +24,4 @@ instance OrderDual.orderedCommGroup [OrderedCommGroup α] : OrderedCommGroup α
 
 @[to_additive]
 instance OrderDual.linearOrderedCommGroup [LinearOrderedCommGroup α] : LinearOrderedCommGroup αᵒᵈ :=
-  { OrderDual.orderedCommGroup, OrderDual.linearOrder α with }
+  { OrderDual.orderedCommGroup, OrderDual.instLinearOrder α with }

55bbb807

chore: script to replace headers with #align_import statements (#5979)

depends on: #5966

Co-authored-by: Eric Wieser <wieser.eric@gmail.com> Co-authored-by: Scott Morrison <scott.morrison@gmail.com>

89aa3a3b

Diff

@@ -2,15 +2,12 @@
 Copyright (c) 2016 Jeremy Avigad. All rights reserved.
 Released under Apache 2.0 license as described in the file LICENSE.
 Authors: Jeremy Avigad, Leonardo de Moura, Mario Carneiro, Johannes Hölzl
-
-! This file was ported from Lean 3 source module algebra.order.group.instances
-! leanprover-community/mathlib commit 55bbb8076236154a4f53939a62ad1e4fddbc14c8
-! Please do not edit these lines, except to modify the commit id
-! if you have ported upstream changes.
 -/
 import Mathlib.Algebra.Order.Group.Defs
 import Mathlib.Algebra.Order.Monoid.OrderDual
 
+#align_import algebra.order.group.instances from "leanprover-community/mathlib"@"55bbb8076236154a4f53939a62ad1e4fddbc14c8"
+
 /-!
 # Additional instances for ordered commutative groups.

55bbb807

chore: update SHA (#2555)

This change was forward-ported in #913, but this was before we were recording SHAs properly

3277f79b

Diff

@@ -4,7 +4,7 @@ Released under Apache 2.0 license as described in the file LICENSE.
 Authors: Jeremy Avigad, Leonardo de Moura, Mario Carneiro, Johannes Hölzl
 
 ! This file was ported from Lean 3 source module algebra.order.group.instances
-! leanprover-community/mathlib commit a95b16cbade0f938fc24abd05412bde1e84bab9b
+! leanprover-community/mathlib commit 55bbb8076236154a4f53939a62ad1e4fddbc14c8
 ! Please do not edit these lines, except to modify the commit id
 ! if you have ported upstream changes.
 -/

a95b16cb

chore: add source headers to ported theory files (#1094)

The script used to do this is included. The yaml file was obtained from https://raw.githubusercontent.com/wiki/leanprover-community/mathlib/mathlib4-port-status.md

f168625e

Diff

@@ -2,6 +2,11 @@
 Copyright (c) 2016 Jeremy Avigad. All rights reserved.
 Released under Apache 2.0 license as described in the file LICENSE.
 Authors: Jeremy Avigad, Leonardo de Moura, Mario Carneiro, Johannes Hölzl
+
+! This file was ported from Lean 3 source module algebra.order.group.instances
+! leanprover-community/mathlib commit a95b16cbade0f938fc24abd05412bde1e84bab9b
+! Please do not edit these lines, except to modify the commit id
+! if you have ported upstream changes.
 -/
 import Mathlib.Algebra.Order.Group.Defs
 import Mathlib.Algebra.Order.Monoid.OrderDual

`algebra.order.group.instances` ⟷ `Mathlib.Algebra.Order.Group.Instances`

Changes since the initial port

Changes in mathlib3

Changes in mathlib3port

Changes in mathlib4

Dependencies 1 + 44

algebra.order.group.instances ⟷ Mathlib.Algebra.Order.Group.Instances

Changes since the initial port

Changes in mathlib3

Changes in mathlib3port

Changes in mathlib4

Dependencies 1 + 44

`algebra.order.group.instances` ⟷ `Mathlib.Algebra.Order.Group.Instances`