algebra.order.monoid.units | Mathlib porting status

Changes since the initial port

The following section lists changes to this file in mathlib3 and mathlib4 that occured after the initial port. Most recent changes are shown first. Hovering over a commit will show all commits associated with the same mathlib3 commit.

Changes in mathlib3

f1a2caaf

(last sync)

Changes in mathlib3port

mathlib3

mathlib3port

448144f7

bump to nightly-2023-09-24-06

mathlib commit https://github.com/leanprover-community/mathlib/commit/ce64cd319bb6b3e82f31c2d38e79080d377be451

5655435f

Diff

@@ -3,9 +3,9 @@ Copyright (c) 2016 Jeremy Avigad. All rights reserved.
 Released under Apache 2.0 license as described in the file LICENSE.
 Authors: Jeremy Avigad, Leonardo de Moura, Mario Carneiro, Johannes Hölzl
 -/
-import Mathbin.Order.Hom.Basic
-import Mathbin.Order.MinMax
-import Mathbin.Algebra.Group.Units
+import Order.Hom.Basic
+import Order.MinMax
+import Algebra.Group.Units
 
 #align_import algebra.order.monoid.units from "leanprover-community/mathlib"@"448144f7ae193a8990cb7473c9e9a01990f64ac7"

448144f7

bump to nightly-2023-07-20-09

mathlib commit https://github.com/leanprover-community/mathlib/commit/8ea5598db6caeddde6cb734aa179cc2408dbd345

9c56d0dd

Diff

@@ -2,16 +2,13 @@
 Copyright (c) 2016 Jeremy Avigad. All rights reserved.
 Released under Apache 2.0 license as described in the file LICENSE.
 Authors: Jeremy Avigad, Leonardo de Moura, Mario Carneiro, Johannes Hölzl
-
-! This file was ported from Lean 3 source module algebra.order.monoid.units
-! leanprover-community/mathlib commit 448144f7ae193a8990cb7473c9e9a01990f64ac7
-! Please do not edit these lines, except to modify the commit id
-! if you have ported upstream changes.
 -/
 import Mathbin.Order.Hom.Basic
 import Mathbin.Order.MinMax
 import Mathbin.Algebra.Group.Units
 
+#align_import algebra.order.monoid.units from "leanprover-community/mathlib"@"448144f7ae193a8990cb7473c9e9a01990f64ac7"
+
 /-!
 # Units in ordered monoids

448144f7

bump to nightly-2023-06-13-21

mathlib commit https://github.com/leanprover-community/mathlib/commit/9fb8964792b4237dac6200193a0d533f1b3f7423

829520ac

Diff

@@ -62,17 +62,21 @@ def orderEmbeddingVal [Monoid α] [LinearOrder α] : αˣ ↪o α :=
 #align add_units.order_embedding_coe AddUnits.orderEmbeddingVal
 -/
 
+#print Units.max_val /-
 @[simp, norm_cast, to_additive]
 theorem max_val [Monoid α] [LinearOrder α] {a b : αˣ} : (↑(max a b) : α) = max a b :=
   Monotone.map_max orderEmbeddingVal.Monotone
 #align units.max_coe Units.max_val
 #align add_units.max_coe AddUnits.max_val
+-/
 
+#print Units.min_val /-
 @[simp, norm_cast, to_additive]
 theorem min_val [Monoid α] [LinearOrder α] {a b : αˣ} : (↑(min a b) : α) = min a b :=
   Monotone.map_min orderEmbeddingVal.Monotone
 #align units.min_coe Units.min_val
 #align add_units.min_coe AddUnits.min_val
+-/
 
 end Units

448144f7

bump to nightly-2023-05-28-18

mathlib commit https://github.com/leanprover-community/mathlib/commit/917c3c072e487b3cccdbfeff17e75b40e45f66cb

8d353152

Diff

@@ -28,17 +28,21 @@ namespace Units
 instance [Monoid α] [Preorder α] : Preorder αˣ :=
   Preorder.lift (coe : αˣ → α)
 
+#print Units.val_le_val /-
 @[simp, norm_cast, to_additive]
 theorem val_le_val [Monoid α] [Preorder α] {a b : αˣ} : (a : α) ≤ b ↔ a ≤ b :=
   Iff.rfl
 #align units.coe_le_coe Units.val_le_val
 #align add_units.coe_le_coe AddUnits.val_le_val
+-/
 
+#print Units.val_lt_val /-
 @[simp, norm_cast, to_additive]
 theorem val_lt_val [Monoid α] [Preorder α] {a b : αˣ} : (a : α) < b ↔ a < b :=
   Iff.rfl
 #align units.coe_lt_coe Units.val_lt_val
 #align add_units.coe_lt_coe AddUnits.val_lt_val
+-/
 
 @[to_additive]
 instance [Monoid α] [PartialOrder α] : PartialOrder αˣ :=
@@ -48,6 +52,7 @@ instance [Monoid α] [PartialOrder α] : PartialOrder αˣ :=
 instance [Monoid α] [LinearOrder α] : LinearOrder αˣ :=
   LinearOrder.lift' coe Units.ext
 
+#print Units.orderEmbeddingVal /-
 /-- `coe : αˣ → α` as an order embedding. -/
 @[to_additive "`coe : add_units α → α` as an order embedding.",
   simps (config := { fullyApplied := false })]
@@ -55,6 +60,7 @@ def orderEmbeddingVal [Monoid α] [LinearOrder α] : αˣ ↪o α :=
   ⟨⟨coe, ext⟩, fun _ _ => Iff.rfl⟩
 #align units.order_embedding_coe Units.orderEmbeddingVal
 #align add_units.order_embedding_coe AddUnits.orderEmbeddingVal
+-/
 
 @[simp, norm_cast, to_additive]
 theorem max_val [Monoid α] [LinearOrder α] {a b : αˣ} : (↑(max a b) : α) = max a b :=

448144f7

bump to nightly-2023-05-28-06

mathlib commit https://github.com/leanprover-community/mathlib/commit/917c3c072e487b3cccdbfeff17e75b40e45f66cb

ba5d8b97

Diff

@@ -28,24 +28,12 @@ namespace Units
 instance [Monoid α] [Preorder α] : Preorder αˣ :=
   Preorder.lift (coe : αˣ → α)
 
-/- warning: units.coe_le_coe -> Units.val_le_val is a dubious translation:
-lean 3 declaration is
-  forall {α : Type.{u1}} [_inst_1 : Monoid.{u1} α] [_inst_2 : Preorder.{u1} α] {a : Units.{u1} α _inst_1} {b : Units.{u1} α _inst_1}, Iff (LE.le.{u1} α (Preorder.toHasLe.{u1} α _inst_2) ((fun (a : Type.{u1}) (b : Type.{u1}) [self : HasLiftT.{succ u1, succ u1} a b] => self.0) (Units.{u1} α _inst_1) α (HasLiftT.mk.{succ u1, succ u1} (Units.{u1} α _inst_1) α (CoeTCₓ.coe.{succ u1, succ u1} (Units.{u1} α _inst_1) α (coeBase.{succ u1, succ u1} (Units.{u1} α _inst_1) α (Units.hasCoe.{u1} α _inst_1)))) a) ((fun (a : Type.{u1}) (b : Type.{u1}) [self : HasLiftT.{succ u1, succ u1} a b] => self.0) (Units.{u1} α _inst_1) α (HasLiftT.mk.{succ u1, succ u1} (Units.{u1} α _inst_1) α (CoeTCₓ.coe.{succ u1, succ u1} (Units.{u1} α _inst_1) α (coeBase.{succ u1, succ u1} (Units.{u1} α _inst_1) α (Units.hasCoe.{u1} α _inst_1)))) b)) (LE.le.{u1} (Units.{u1} α _inst_1) (Preorder.toHasLe.{u1} (Units.{u1} α _inst_1) (Units.preorder.{u1} α _inst_1 _inst_2)) a b)
-but is expected to have type
-  forall {α : Type.{u1}} [_inst_1 : Monoid.{u1} α] [_inst_2 : Preorder.{u1} α] {a : Units.{u1} α _inst_1} {b : Units.{u1} α _inst_1}, Iff (LE.le.{u1} α (Preorder.toLE.{u1} α _inst_2) (Units.val.{u1} α _inst_1 a) (Units.val.{u1} α _inst_1 b)) (LE.le.{u1} (Units.{u1} α _inst_1) (Preorder.toLE.{u1} (Units.{u1} α _inst_1) (Units.instPreorderUnits.{u1} α _inst_1 _inst_2)) a b)
-Case conversion may be inaccurate. Consider using '#align units.coe_le_coe Units.val_le_valₓ'. -/
 @[simp, norm_cast, to_additive]
 theorem val_le_val [Monoid α] [Preorder α] {a b : αˣ} : (a : α) ≤ b ↔ a ≤ b :=
   Iff.rfl
 #align units.coe_le_coe Units.val_le_val
 #align add_units.coe_le_coe AddUnits.val_le_val
 
-/- warning: units.coe_lt_coe -> Units.val_lt_val is a dubious translation:
-lean 3 declaration is
-  forall {α : Type.{u1}} [_inst_1 : Monoid.{u1} α] [_inst_2 : Preorder.{u1} α] {a : Units.{u1} α _inst_1} {b : Units.{u1} α _inst_1}, Iff (LT.lt.{u1} α (Preorder.toHasLt.{u1} α _inst_2) ((fun (a : Type.{u1}) (b : Type.{u1}) [self : HasLiftT.{succ u1, succ u1} a b] => self.0) (Units.{u1} α _inst_1) α (HasLiftT.mk.{succ u1, succ u1} (Units.{u1} α _inst_1) α (CoeTCₓ.coe.{succ u1, succ u1} (Units.{u1} α _inst_1) α (coeBase.{succ u1, succ u1} (Units.{u1} α _inst_1) α (Units.hasCoe.{u1} α _inst_1)))) a) ((fun (a : Type.{u1}) (b : Type.{u1}) [self : HasLiftT.{succ u1, succ u1} a b] => self.0) (Units.{u1} α _inst_1) α (HasLiftT.mk.{succ u1, succ u1} (Units.{u1} α _inst_1) α (CoeTCₓ.coe.{succ u1, succ u1} (Units.{u1} α _inst_1) α (coeBase.{succ u1, succ u1} (Units.{u1} α _inst_1) α (Units.hasCoe.{u1} α _inst_1)))) b)) (LT.lt.{u1} (Units.{u1} α _inst_1) (Preorder.toHasLt.{u1} (Units.{u1} α _inst_1) (Units.preorder.{u1} α _inst_1 _inst_2)) a b)
-but is expected to have type
-  forall {α : Type.{u1}} [_inst_1 : Monoid.{u1} α] [_inst_2 : Preorder.{u1} α] {a : Units.{u1} α _inst_1} {b : Units.{u1} α _inst_1}, Iff (LT.lt.{u1} α (Preorder.toLT.{u1} α _inst_2) (Units.val.{u1} α _inst_1 a) (Units.val.{u1} α _inst_1 b)) (LT.lt.{u1} (Units.{u1} α _inst_1) (Preorder.toLT.{u1} (Units.{u1} α _inst_1) (Units.instPreorderUnits.{u1} α _inst_1 _inst_2)) a b)
-Case conversion may be inaccurate. Consider using '#align units.coe_lt_coe Units.val_lt_valₓ'. -/
 @[simp, norm_cast, to_additive]
 theorem val_lt_val [Monoid α] [Preorder α] {a b : αˣ} : (a : α) < b ↔ a < b :=
   Iff.rfl
@@ -60,12 +48,6 @@ instance [Monoid α] [PartialOrder α] : PartialOrder αˣ :=
 instance [Monoid α] [LinearOrder α] : LinearOrder αˣ :=
   LinearOrder.lift' coe Units.ext
 
-/- warning: units.order_embedding_coe -> Units.orderEmbeddingVal is a dubious translation:
-lean 3 declaration is
-  forall {α : Type.{u1}} [_inst_1 : Monoid.{u1} α] [_inst_2 : LinearOrder.{u1} α], OrderEmbedding.{u1, u1} (Units.{u1} α _inst_1) α (Preorder.toHasLe.{u1} (Units.{u1} α _inst_1) (Units.preorder.{u1} α _inst_1 (PartialOrder.toPreorder.{u1} α (SemilatticeInf.toPartialOrder.{u1} α (Lattice.toSemilatticeInf.{u1} α (LinearOrder.toLattice.{u1} α _inst_2)))))) (Preorder.toHasLe.{u1} α (PartialOrder.toPreorder.{u1} α (SemilatticeInf.toPartialOrder.{u1} α (Lattice.toSemilatticeInf.{u1} α (LinearOrder.toLattice.{u1} α _inst_2)))))
-but is expected to have type
-  forall {α : Type.{u1}} [_inst_1 : Monoid.{u1} α] [_inst_2 : LinearOrder.{u1} α], OrderEmbedding.{u1, u1} (Units.{u1} α _inst_1) α (Preorder.toLE.{u1} (Units.{u1} α _inst_1) (Units.instPreorderUnits.{u1} α _inst_1 (PartialOrder.toPreorder.{u1} α (SemilatticeInf.toPartialOrder.{u1} α (Lattice.toSemilatticeInf.{u1} α (DistribLattice.toLattice.{u1} α (instDistribLattice.{u1} α _inst_2))))))) (Preorder.toLE.{u1} α (PartialOrder.toPreorder.{u1} α (SemilatticeInf.toPartialOrder.{u1} α (Lattice.toSemilatticeInf.{u1} α (DistribLattice.toLattice.{u1} α (instDistribLattice.{u1} α _inst_2))))))
-Case conversion may be inaccurate. Consider using '#align units.order_embedding_coe Units.orderEmbeddingValₓ'. -/
 /-- `coe : αˣ → α` as an order embedding. -/
 @[to_additive "`coe : add_units α → α` as an order embedding.",
   simps (config := { fullyApplied := false })]
@@ -74,24 +56,12 @@ def orderEmbeddingVal [Monoid α] [LinearOrder α] : αˣ ↪o α :=
 #align units.order_embedding_coe Units.orderEmbeddingVal
 #align add_units.order_embedding_coe AddUnits.orderEmbeddingVal
 
-/- warning: units.max_coe -> Units.max_val is a dubious translation:
-lean 3 declaration is
-  forall {α : Type.{u1}} [_inst_1 : Monoid.{u1} α] [_inst_2 : LinearOrder.{u1} α] {a : Units.{u1} α _inst_1} {b : Units.{u1} α _inst_1}, Eq.{succ u1} α ((fun (a : Type.{u1}) (b : Type.{u1}) [self : HasLiftT.{succ u1, succ u1} a b] => self.0) (Units.{u1} α _inst_1) α (HasLiftT.mk.{succ u1, succ u1} (Units.{u1} α _inst_1) α (CoeTCₓ.coe.{succ u1, succ u1} (Units.{u1} α _inst_1) α (coeBase.{succ u1, succ u1} (Units.{u1} α _inst_1) α (Units.hasCoe.{u1} α _inst_1)))) (LinearOrder.max.{u1} (Units.{u1} α _inst_1) (Units.linearOrder.{u1} α _inst_1 _inst_2) a b)) (LinearOrder.max.{u1} α _inst_2 ((fun (a : Type.{u1}) (b : Type.{u1}) [self : HasLiftT.{succ u1, succ u1} a b] => self.0) (Units.{u1} α _inst_1) α (HasLiftT.mk.{succ u1, succ u1} (Units.{u1} α _inst_1) α (CoeTCₓ.coe.{succ u1, succ u1} (Units.{u1} α _inst_1) α (coeBase.{succ u1, succ u1} (Units.{u1} α _inst_1) α (Units.hasCoe.{u1} α _inst_1)))) a) ((fun (a : Type.{u1}) (b : Type.{u1}) [self : HasLiftT.{succ u1, succ u1} a b] => self.0) (Units.{u1} α _inst_1) α (HasLiftT.mk.{succ u1, succ u1} (Units.{u1} α _inst_1) α (CoeTCₓ.coe.{succ u1, succ u1} (Units.{u1} α _inst_1) α (coeBase.{succ u1, succ u1} (Units.{u1} α _inst_1) α (Units.hasCoe.{u1} α _inst_1)))) b))
-but is expected to have type
-  forall {α : Type.{u1}} [_inst_1 : Monoid.{u1} α] [_inst_2 : LinearOrder.{u1} α] {a : Units.{u1} α _inst_1} {b : Units.{u1} α _inst_1}, Eq.{succ u1} α (Units.val.{u1} α _inst_1 (Max.max.{u1} (Units.{u1} α _inst_1) (LinearOrder.toMax.{u1} (Units.{u1} α _inst_1) (Units.instLinearOrderUnits.{u1} α _inst_1 _inst_2)) a b)) (Max.max.{u1} α (LinearOrder.toMax.{u1} α _inst_2) (Units.val.{u1} α _inst_1 a) (Units.val.{u1} α _inst_1 b))
-Case conversion may be inaccurate. Consider using '#align units.max_coe Units.max_valₓ'. -/
 @[simp, norm_cast, to_additive]
 theorem max_val [Monoid α] [LinearOrder α] {a b : αˣ} : (↑(max a b) : α) = max a b :=
   Monotone.map_max orderEmbeddingVal.Monotone
 #align units.max_coe Units.max_val
 #align add_units.max_coe AddUnits.max_val
 
-/- warning: units.min_coe -> Units.min_val is a dubious translation:
-lean 3 declaration is
-  forall {α : Type.{u1}} [_inst_1 : Monoid.{u1} α] [_inst_2 : LinearOrder.{u1} α] {a : Units.{u1} α _inst_1} {b : Units.{u1} α _inst_1}, Eq.{succ u1} α ((fun (a : Type.{u1}) (b : Type.{u1}) [self : HasLiftT.{succ u1, succ u1} a b] => self.0) (Units.{u1} α _inst_1) α (HasLiftT.mk.{succ u1, succ u1} (Units.{u1} α _inst_1) α (CoeTCₓ.coe.{succ u1, succ u1} (Units.{u1} α _inst_1) α (coeBase.{succ u1, succ u1} (Units.{u1} α _inst_1) α (Units.hasCoe.{u1} α _inst_1)))) (LinearOrder.min.{u1} (Units.{u1} α _inst_1) (Units.linearOrder.{u1} α _inst_1 _inst_2) a b)) (LinearOrder.min.{u1} α _inst_2 ((fun (a : Type.{u1}) (b : Type.{u1}) [self : HasLiftT.{succ u1, succ u1} a b] => self.0) (Units.{u1} α _inst_1) α (HasLiftT.mk.{succ u1, succ u1} (Units.{u1} α _inst_1) α (CoeTCₓ.coe.{succ u1, succ u1} (Units.{u1} α _inst_1) α (coeBase.{succ u1, succ u1} (Units.{u1} α _inst_1) α (Units.hasCoe.{u1} α _inst_1)))) a) ((fun (a : Type.{u1}) (b : Type.{u1}) [self : HasLiftT.{succ u1, succ u1} a b] => self.0) (Units.{u1} α _inst_1) α (HasLiftT.mk.{succ u1, succ u1} (Units.{u1} α _inst_1) α (CoeTCₓ.coe.{succ u1, succ u1} (Units.{u1} α _inst_1) α (coeBase.{succ u1, succ u1} (Units.{u1} α _inst_1) α (Units.hasCoe.{u1} α _inst_1)))) b))
-but is expected to have type
-  forall {α : Type.{u1}} [_inst_1 : Monoid.{u1} α] [_inst_2 : LinearOrder.{u1} α] {a : Units.{u1} α _inst_1} {b : Units.{u1} α _inst_1}, Eq.{succ u1} α (Units.val.{u1} α _inst_1 (Min.min.{u1} (Units.{u1} α _inst_1) (LinearOrder.toMin.{u1} (Units.{u1} α _inst_1) (Units.instLinearOrderUnits.{u1} α _inst_1 _inst_2)) a b)) (Min.min.{u1} α (LinearOrder.toMin.{u1} α _inst_2) (Units.val.{u1} α _inst_1 a) (Units.val.{u1} α _inst_1 b))
-Case conversion may be inaccurate. Consider using '#align units.min_coe Units.min_valₓ'. -/
 @[simp, norm_cast, to_additive]
 theorem min_val [Monoid α] [LinearOrder α] {a b : αˣ} : (↑(min a b) : α) = min a b :=
   Monotone.map_min orderEmbeddingVal.Monotone

448144f7

bump to nightly-2023-05-16-16

mathlib commit https://github.com/leanprover-community/mathlib/commit/0b9eaaa7686280fad8cce467f5c3c57ee6ce77f8

9cb92e8c

Diff

@@ -28,21 +28,29 @@ namespace Units
 instance [Monoid α] [Preorder α] : Preorder αˣ :=
   Preorder.lift (coe : αˣ → α)
 
-#print Units.val_le_val /-
+/- warning: units.coe_le_coe -> Units.val_le_val is a dubious translation:
+lean 3 declaration is
+  forall {α : Type.{u1}} [_inst_1 : Monoid.{u1} α] [_inst_2 : Preorder.{u1} α] {a : Units.{u1} α _inst_1} {b : Units.{u1} α _inst_1}, Iff (LE.le.{u1} α (Preorder.toHasLe.{u1} α _inst_2) ((fun (a : Type.{u1}) (b : Type.{u1}) [self : HasLiftT.{succ u1, succ u1} a b] => self.0) (Units.{u1} α _inst_1) α (HasLiftT.mk.{succ u1, succ u1} (Units.{u1} α _inst_1) α (CoeTCₓ.coe.{succ u1, succ u1} (Units.{u1} α _inst_1) α (coeBase.{succ u1, succ u1} (Units.{u1} α _inst_1) α (Units.hasCoe.{u1} α _inst_1)))) a) ((fun (a : Type.{u1}) (b : Type.{u1}) [self : HasLiftT.{succ u1, succ u1} a b] => self.0) (Units.{u1} α _inst_1) α (HasLiftT.mk.{succ u1, succ u1} (Units.{u1} α _inst_1) α (CoeTCₓ.coe.{succ u1, succ u1} (Units.{u1} α _inst_1) α (coeBase.{succ u1, succ u1} (Units.{u1} α _inst_1) α (Units.hasCoe.{u1} α _inst_1)))) b)) (LE.le.{u1} (Units.{u1} α _inst_1) (Preorder.toHasLe.{u1} (Units.{u1} α _inst_1) (Units.preorder.{u1} α _inst_1 _inst_2)) a b)
+but is expected to have type
+  forall {α : Type.{u1}} [_inst_1 : Monoid.{u1} α] [_inst_2 : Preorder.{u1} α] {a : Units.{u1} α _inst_1} {b : Units.{u1} α _inst_1}, Iff (LE.le.{u1} α (Preorder.toLE.{u1} α _inst_2) (Units.val.{u1} α _inst_1 a) (Units.val.{u1} α _inst_1 b)) (LE.le.{u1} (Units.{u1} α _inst_1) (Preorder.toLE.{u1} (Units.{u1} α _inst_1) (Units.instPreorderUnits.{u1} α _inst_1 _inst_2)) a b)
+Case conversion may be inaccurate. Consider using '#align units.coe_le_coe Units.val_le_valₓ'. -/
 @[simp, norm_cast, to_additive]
 theorem val_le_val [Monoid α] [Preorder α] {a b : αˣ} : (a : α) ≤ b ↔ a ≤ b :=
   Iff.rfl
 #align units.coe_le_coe Units.val_le_val
 #align add_units.coe_le_coe AddUnits.val_le_val
--/
 
-#print Units.val_lt_val /-
+/- warning: units.coe_lt_coe -> Units.val_lt_val is a dubious translation:
+lean 3 declaration is
+  forall {α : Type.{u1}} [_inst_1 : Monoid.{u1} α] [_inst_2 : Preorder.{u1} α] {a : Units.{u1} α _inst_1} {b : Units.{u1} α _inst_1}, Iff (LT.lt.{u1} α (Preorder.toHasLt.{u1} α _inst_2) ((fun (a : Type.{u1}) (b : Type.{u1}) [self : HasLiftT.{succ u1, succ u1} a b] => self.0) (Units.{u1} α _inst_1) α (HasLiftT.mk.{succ u1, succ u1} (Units.{u1} α _inst_1) α (CoeTCₓ.coe.{succ u1, succ u1} (Units.{u1} α _inst_1) α (coeBase.{succ u1, succ u1} (Units.{u1} α _inst_1) α (Units.hasCoe.{u1} α _inst_1)))) a) ((fun (a : Type.{u1}) (b : Type.{u1}) [self : HasLiftT.{succ u1, succ u1} a b] => self.0) (Units.{u1} α _inst_1) α (HasLiftT.mk.{succ u1, succ u1} (Units.{u1} α _inst_1) α (CoeTCₓ.coe.{succ u1, succ u1} (Units.{u1} α _inst_1) α (coeBase.{succ u1, succ u1} (Units.{u1} α _inst_1) α (Units.hasCoe.{u1} α _inst_1)))) b)) (LT.lt.{u1} (Units.{u1} α _inst_1) (Preorder.toHasLt.{u1} (Units.{u1} α _inst_1) (Units.preorder.{u1} α _inst_1 _inst_2)) a b)
+but is expected to have type
+  forall {α : Type.{u1}} [_inst_1 : Monoid.{u1} α] [_inst_2 : Preorder.{u1} α] {a : Units.{u1} α _inst_1} {b : Units.{u1} α _inst_1}, Iff (LT.lt.{u1} α (Preorder.toLT.{u1} α _inst_2) (Units.val.{u1} α _inst_1 a) (Units.val.{u1} α _inst_1 b)) (LT.lt.{u1} (Units.{u1} α _inst_1) (Preorder.toLT.{u1} (Units.{u1} α _inst_1) (Units.instPreorderUnits.{u1} α _inst_1 _inst_2)) a b)
+Case conversion may be inaccurate. Consider using '#align units.coe_lt_coe Units.val_lt_valₓ'. -/
 @[simp, norm_cast, to_additive]
 theorem val_lt_val [Monoid α] [Preorder α] {a b : αˣ} : (a : α) < b ↔ a < b :=
   Iff.rfl
 #align units.coe_lt_coe Units.val_lt_val
 #align add_units.coe_lt_coe AddUnits.val_lt_val
--/
 
 @[to_additive]
 instance [Monoid α] [PartialOrder α] : PartialOrder αˣ :=
@@ -52,7 +60,12 @@ instance [Monoid α] [PartialOrder α] : PartialOrder αˣ :=
 instance [Monoid α] [LinearOrder α] : LinearOrder αˣ :=
   LinearOrder.lift' coe Units.ext
 
-#print Units.orderEmbeddingVal /-
+/- warning: units.order_embedding_coe -> Units.orderEmbeddingVal is a dubious translation:
+lean 3 declaration is
+  forall {α : Type.{u1}} [_inst_1 : Monoid.{u1} α] [_inst_2 : LinearOrder.{u1} α], OrderEmbedding.{u1, u1} (Units.{u1} α _inst_1) α (Preorder.toHasLe.{u1} (Units.{u1} α _inst_1) (Units.preorder.{u1} α _inst_1 (PartialOrder.toPreorder.{u1} α (SemilatticeInf.toPartialOrder.{u1} α (Lattice.toSemilatticeInf.{u1} α (LinearOrder.toLattice.{u1} α _inst_2)))))) (Preorder.toHasLe.{u1} α (PartialOrder.toPreorder.{u1} α (SemilatticeInf.toPartialOrder.{u1} α (Lattice.toSemilatticeInf.{u1} α (LinearOrder.toLattice.{u1} α _inst_2)))))
+but is expected to have type
+  forall {α : Type.{u1}} [_inst_1 : Monoid.{u1} α] [_inst_2 : LinearOrder.{u1} α], OrderEmbedding.{u1, u1} (Units.{u1} α _inst_1) α (Preorder.toLE.{u1} (Units.{u1} α _inst_1) (Units.instPreorderUnits.{u1} α _inst_1 (PartialOrder.toPreorder.{u1} α (SemilatticeInf.toPartialOrder.{u1} α (Lattice.toSemilatticeInf.{u1} α (DistribLattice.toLattice.{u1} α (instDistribLattice.{u1} α _inst_2))))))) (Preorder.toLE.{u1} α (PartialOrder.toPreorder.{u1} α (SemilatticeInf.toPartialOrder.{u1} α (Lattice.toSemilatticeInf.{u1} α (DistribLattice.toLattice.{u1} α (instDistribLattice.{u1} α _inst_2))))))
+Case conversion may be inaccurate. Consider using '#align units.order_embedding_coe Units.orderEmbeddingValₓ'. -/
 /-- `coe : αˣ → α` as an order embedding. -/
 @[to_additive "`coe : add_units α → α` as an order embedding.",
   simps (config := { fullyApplied := false })]
@@ -60,7 +73,6 @@ def orderEmbeddingVal [Monoid α] [LinearOrder α] : αˣ ↪o α :=
   ⟨⟨coe, ext⟩, fun _ _ => Iff.rfl⟩
 #align units.order_embedding_coe Units.orderEmbeddingVal
 #align add_units.order_embedding_coe AddUnits.orderEmbeddingVal
--/
 
 /- warning: units.max_coe -> Units.max_val is a dubious translation:
 lean 3 declaration is

448144f7

bump to nightly-2023-02-21-16

mathlib commit https://github.com/leanprover-community/mathlib/commit/bd9851ca476957ea4549eb19b40e7b5ade9428cc

1107b979

Changes in mathlib4

mathlib3

mathlib4

f1a2caaf

chore: remove more autoImplicit (#11336)

... or reduce its scope (the full removal is not as obvious).

59f72a90

Diff

@@ -13,10 +13,10 @@ import Mathlib.Algebra.Group.Units
 # Units in ordered monoids
 -/
 
-set_option autoImplicit true
-
 namespace Units
 
+variable {α : Type*}
+
 @[to_additive]
 instance [Monoid α] [Preorder α] : Preorder αˣ :=
   Preorder.lift val

f1a2caaf

style: shorten simps configurations (#8296)

Use .asFn and .lemmasOnly as simps configuration options.

For reference, these are defined here:

https://github.com/leanprover-community/mathlib4/blob/4055c8b471380825f07416b12cb0cf266da44d84/Mathlib/Tactic/Simps/Basic.lean#L843-L851

e0637173

Diff

@@ -44,7 +44,7 @@ instance [Monoid α] [LinearOrder α] : LinearOrder αˣ :=
   LinearOrder.lift' val Units.ext
 
 /-- `val : αˣ → α` as an order embedding. -/
-@[to_additive (attr := simps (config := { fullyApplied := false }))
+@[to_additive (attr := simps (config := .asFn))
   "`val : add_units α → α` as an order embedding."]
 def orderEmbeddingVal [Monoid α] [LinearOrder α] : αˣ ↪o α :=
   ⟨⟨val, ext⟩, Iff.rfl⟩

f1a2caaf

fix: disable autoImplicit globally (#6528)

Autoimplicits are highly controversial and also defeat the performance-improving work in #6474.

The intent of this PR is to make autoImplicit opt-in on a per-file basis, by disabling it in the lakefile and enabling it again with set_option autoImplicit true in the few files that rely on it.

That also keeps this PR small, as opposed to attempting to "fix" files to not need it any more.

I claim that many of the uses of autoImplicit in these files are accidental; situations such as:

Assuming variables are in scope, but pasting the lemma in the wrong section
Pasting in a lemma from a scratch file without checking to see if the variable names are consistent with the rest of the file
Making a copy-paste error between lemmas and forgetting to add an explicit arguments.

Having set_option autoImplicit false as the default prevents these types of mistake being made in the 90% of files where autoImplicits are not used at all, and causes them to be caught by CI during review.

I think there were various points during the port where we encouraged porters to delete the universes u v lines; I think having autoparams for universe variables only would cover a lot of the cases we actually use them, while avoiding any real shortcomings.

A Zulip poll (after combining overlapping votes accordingly) was in favor of this change with 5:5:18 as the no:dontcare:yes vote ratio.

While this PR was being reviewed, a handful of files gained some more likely-accidental autoImplicits. In these places, set_option autoImplicit true has been placed locally within a section, rather than at the top of the file.

0c24f831

Diff

@@ -13,6 +13,7 @@ import Mathlib.Algebra.Group.Units
 # Units in ordered monoids
 -/
 
+set_option autoImplicit true
 
 namespace Units

f1a2caaf

chore: ensure all instances referred to directly have explicit names (#6423)

Per https://github.com/leanprover/lean4/issues/2343, we are going to need to change the automatic generation of instance names, as they become too long.

This PR ensures that everywhere in Mathlib that refers to an instance by name, that name is given explicitly, rather than being automatically generated.

There are four exceptions, which are now commented, with links to https://github.com/leanprover/lean4/issues/2343.

This was implemented by running Mathlib against a modified Lean that appended _ᾰ to all automatically generated names, and fixing everything.

Co-authored-by: Scott Morrison <scott.morrison@gmail.com>

65a35f78

Diff

@@ -33,7 +33,7 @@ theorem val_lt_val [Monoid α] [Preorder α] {a b : αˣ} : (a : α) < b ↔ a <
 #align add_units.coe_lt_coe AddUnits.val_lt_val
 
 @[to_additive]
-instance [Monoid α] [PartialOrder α] : PartialOrder αˣ :=
+instance instPartialOrderUnits [Monoid α] [PartialOrder α] : PartialOrder αˣ :=
   PartialOrder.lift val Units.ext
 #align units.partial_order Units.instPartialOrderUnits
 #align add_units.partial_order AddUnits.instPartialOrderAddUnits

f1a2caaf

chore: script to replace headers with #align_import statements (#5979)

depends on: #5966

Co-authored-by: Eric Wieser <wieser.eric@gmail.com> Co-authored-by: Scott Morrison <scott.morrison@gmail.com>

89aa3a3b

Diff

@@ -2,16 +2,13 @@
 Copyright (c) 2016 Jeremy Avigad. All rights reserved.
 Released under Apache 2.0 license as described in the file LICENSE.
 Authors: Jeremy Avigad, Leonardo de Moura, Mario Carneiro, Johannes Hölzl
-
-! This file was ported from Lean 3 source module algebra.order.monoid.units
-! leanprover-community/mathlib commit f1a2caaf51ef593799107fe9a8d5e411599f3996
-! Please do not edit these lines, except to modify the commit id
-! if you have ported upstream changes.
 -/
 import Mathlib.Order.Hom.Basic
 import Mathlib.Order.MinMax
 import Mathlib.Algebra.Group.Units
 
+#align_import algebra.order.monoid.units from "leanprover-community/mathlib"@"f1a2caaf51ef593799107fe9a8d5e411599f3996"
+
 /-!
 # Units in ordered monoids
 -/

f1a2caaf

fix: use to_additive (attr := _) here and there (#2073)

adaaf293

Diff

@@ -46,8 +46,8 @@ instance [Monoid α] [LinearOrder α] : LinearOrder αˣ :=
   LinearOrder.lift' val Units.ext
 
 /-- `val : αˣ → α` as an order embedding. -/
-@[to_additive "`val : add_units α → α` as an order embedding.",
-  simps (config := { fullyApplied := false })]
+@[to_additive (attr := simps (config := { fullyApplied := false }))
+  "`val : add_units α → α` as an order embedding."]
 def orderEmbeddingVal [Monoid α] [LinearOrder α] : αˣ ↪o α :=
   ⟨⟨val, ext⟩, Iff.rfl⟩
 #align units.order_embedding_coe Units.orderEmbeddingVal

f1a2caaf

chore: add #align statements for to_additive decls (#1816)

Co-authored-by: Floris van Doorn <fpvdoorn@gmail.com>

ed378238

Diff

@@ -27,11 +27,13 @@ instance [Monoid α] [Preorder α] : Preorder αˣ :=
 theorem val_le_val [Monoid α] [Preorder α] {a b : αˣ} : (a : α) ≤ b ↔ a ≤ b :=
   Iff.rfl
 #align units.coe_le_coe Units.val_le_val
+#align add_units.coe_le_coe AddUnits.val_le_val
 
 @[to_additive (attr := simp, norm_cast)]
 theorem val_lt_val [Monoid α] [Preorder α] {a b : αˣ} : (a : α) < b ↔ a < b :=
   Iff.rfl
 #align units.coe_lt_coe Units.val_lt_val
+#align add_units.coe_lt_coe AddUnits.val_lt_val
 
 @[to_additive]
 instance [Monoid α] [PartialOrder α] : PartialOrder αˣ :=
@@ -55,10 +57,12 @@ def orderEmbeddingVal [Monoid α] [LinearOrder α] : αˣ ↪o α :=
 theorem max_val [Monoid α] [LinearOrder α] {a b : αˣ} : (max a b).val = max a.val b.val :=
   Monotone.map_max orderEmbeddingVal.monotone
 #align units.max_coe Units.max_val
+#align add_units.max_coe AddUnits.max_val
 
 @[to_additive (attr := simp, norm_cast)]
 theorem min_val [Monoid α] [LinearOrder α] {a b : αˣ} : (min a b).val = min a.val b.val :=
   Monotone.map_min orderEmbeddingVal.monotone
 #align units.min_coe Units.min_val
+#align add_units.min_coe AddUnits.min_val
 
 end Units

f1a2caaf

feat: improve the way to_additive deals with attributes (#1314)

The new syntax for any attributes that need to be copied by to_additive is @[to_additive (attrs := simp, ext, simps)]
Adds the auxiliary declarations generated by the simp and simps attributes to the to_additive-dictionary.
Future issue: Does not yet translate auxiliary declarations for other attributes (including custom simp-attributes). In particular it's possible that norm_cast might generate some auxiliary declarations.
Fixes #950
Fixes #953
Fixes #1149
This moves the interaction between to_additive and simps from the Simps file to the toAdditive file for uniformity.
Make the same changes to @[reassoc]

Co-authored-by: Johan Commelin <johan@commelin.net> Co-authored-by: Scott Morrison <scott.morrison@gmail.com>

56bf4cd6

Diff

@@ -23,12 +23,12 @@ namespace Units
 instance [Monoid α] [Preorder α] : Preorder αˣ :=
   Preorder.lift val
 
-@[simp, norm_cast, to_additive]
+@[to_additive (attr := simp, norm_cast)]
 theorem val_le_val [Monoid α] [Preorder α] {a b : αˣ} : (a : α) ≤ b ↔ a ≤ b :=
   Iff.rfl
 #align units.coe_le_coe Units.val_le_val
 
-@[simp, norm_cast, to_additive]
+@[to_additive (attr := simp, norm_cast)]
 theorem val_lt_val [Monoid α] [Preorder α] {a b : αˣ} : (a : α) < b ↔ a < b :=
   Iff.rfl
 #align units.coe_lt_coe Units.val_lt_val
@@ -51,12 +51,12 @@ def orderEmbeddingVal [Monoid α] [LinearOrder α] : αˣ ↪o α :=
 #align units.order_embedding_coe Units.orderEmbeddingVal
 #align add_units.order_embedding_coe AddUnits.orderEmbeddingVal
 
-@[simp, norm_cast, to_additive]
+@[to_additive (attr := simp, norm_cast)]
 theorem max_val [Monoid α] [LinearOrder α] {a b : αˣ} : (max a b).val = max a.val b.val :=
   Monotone.map_max orderEmbeddingVal.monotone
 #align units.max_coe Units.max_val
 
-@[simp, norm_cast, to_additive]
+@[to_additive (attr := simp, norm_cast)]
 theorem min_val [Monoid α] [LinearOrder α] {a b : αˣ} : (min a b).val = min a.val b.val :=
   Monotone.map_min orderEmbeddingVal.monotone
 #align units.min_coe Units.min_val

f1a2caaf

chore: add source headers to ported theory files (#1094)

The script used to do this is included. The yaml file was obtained from https://raw.githubusercontent.com/wiki/leanprover-community/mathlib/mathlib4-port-status.md

f168625e

Diff

@@ -2,6 +2,11 @@
 Copyright (c) 2016 Jeremy Avigad. All rights reserved.
 Released under Apache 2.0 license as described in the file LICENSE.
 Authors: Jeremy Avigad, Leonardo de Moura, Mario Carneiro, Johannes Hölzl
+
+! This file was ported from Lean 3 source module algebra.order.monoid.units
+! leanprover-community/mathlib commit f1a2caaf51ef593799107fe9a8d5e411599f3996
+! Please do not edit these lines, except to modify the commit id
+! if you have ported upstream changes.
 -/
 import Mathlib.Order.Hom.Basic
 import Mathlib.Order.MinMax

`algebra.order.monoid.units` ⟷ `Mathlib.Algebra.Order.Monoid.Units`

Changes since the initial port

Changes in mathlib3

Changes in mathlib3port

Changes in mathlib4

Dependencies 38

algebra.order.monoid.units ⟷ Mathlib.Algebra.Order.Monoid.Units

Changes since the initial port

Changes in mathlib3

Changes in mathlib3port

Changes in mathlib4

Dependencies 38

`algebra.order.monoid.units` ⟷ `Mathlib.Algebra.Order.Monoid.Units`