analysis.normed.group.SemiNormedGroup | Mathlib porting status

Changes since the initial port

The following section lists changes to this file in mathlib3 and mathlib4 that occured after the initial port. Most recent changes are shown first. Hovering over a commit will show all commits associated with the same mathlib3 commit.

Changes in mathlib3

17ef379e

(last sync)

Changes in mathlib3port

mathlib3

mathlib3port

cff8231f

bump to nightly-2023-09-24-06

mathlib commit https://github.com/leanprover-community/mathlib/commit/ce64cd319bb6b3e82f31c2d38e79080d377be451

5655435f

Diff

@@ -3,10 +3,10 @@ Copyright (c) 2021 Johan Commelin. All rights reserved.
 Released under Apache 2.0 license as described in the file LICENSE.
 Authors: Johan Commelin, Riccardo Brasca
 -/
-import Mathbin.Analysis.Normed.Group.Hom
-import Mathbin.CategoryTheory.Limits.Shapes.ZeroMorphisms
-import Mathbin.CategoryTheory.ConcreteCategory.BundledHom
-import Mathbin.CategoryTheory.Elementwise
+import Analysis.Normed.Group.Hom
+import CategoryTheory.Limits.Shapes.ZeroMorphisms
+import CategoryTheory.ConcreteCategory.BundledHom
+import CategoryTheory.Elementwise
 
 #align_import analysis.normed.group.SemiNormedGroup from "leanprover-community/mathlib"@"cff8231f04dfa33fd8f2f45792eebd862ef30cad"

cff8231f

bump to nightly-2023-07-20-09

mathlib commit https://github.com/leanprover-community/mathlib/commit/8ea5598db6caeddde6cb734aa179cc2408dbd345

9c56d0dd

Diff

@@ -2,17 +2,14 @@
 Copyright (c) 2021 Johan Commelin. All rights reserved.
 Released under Apache 2.0 license as described in the file LICENSE.
 Authors: Johan Commelin, Riccardo Brasca
-
-! This file was ported from Lean 3 source module analysis.normed.group.SemiNormedGroup
-! leanprover-community/mathlib commit cff8231f04dfa33fd8f2f45792eebd862ef30cad
-! Please do not edit these lines, except to modify the commit id
-! if you have ported upstream changes.
 -/
 import Mathbin.Analysis.Normed.Group.Hom
 import Mathbin.CategoryTheory.Limits.Shapes.ZeroMorphisms
 import Mathbin.CategoryTheory.ConcreteCategory.BundledHom
 import Mathbin.CategoryTheory.Elementwise
 
+#align_import analysis.normed.group.SemiNormedGroup from "leanprover-community/mathlib"@"cff8231f04dfa33fd8f2f45792eebd862ef30cad"
+
 /-!
 # The category of seminormed groups

cff8231f

bump to nightly-2023-06-18-23

mathlib commit https://github.com/leanprover-community/mathlib/commit/2a0ce625dbb0ffbc7d1316597de0b25c1ec75303

3b5e23dc

Diff

@@ -30,73 +30,96 @@ universe u
 
 open CategoryTheory
 
+#print SemiNormedGroupCat /-
 /-- The category of seminormed abelian groups and bounded group homomorphisms. -/
-def SemiNormedGroup : Type (u + 1) :=
+def SemiNormedGroupCat : Type (u + 1) :=
   Bundled SeminormedAddCommGroup
-#align SemiNormedGroup SemiNormedGroup
+#align SemiNormedGroup SemiNormedGroupCat
+-/
 
-namespace SemiNormedGroup
+namespace SemiNormedGroupCat
 
+#print SemiNormedGroupCat.bundledHom /-
 instance bundledHom : BundledHom @NormedAddGroupHom :=
   ⟨@NormedAddGroupHom.toFun, @NormedAddGroupHom.id, @NormedAddGroupHom.comp,
     @NormedAddGroupHom.coe_inj⟩
-#align SemiNormedGroup.bundled_hom SemiNormedGroup.bundledHom
+#align SemiNormedGroup.bundled_hom SemiNormedGroupCat.bundledHom
+-/
 
-deriving instance LargeCategory, ConcreteCategory for SemiNormedGroup
+deriving instance LargeCategory, ConcreteCategory for SemiNormedGroupCat
 
-instance : CoeSort SemiNormedGroup (Type u) :=
+instance : CoeSort SemiNormedGroupCat (Type u) :=
   Bundled.hasCoeToSort
 
+/- warning: SemiNormedGroup.of clashes with SemiNormedGroupCat.of -> SemiNormedGroupCat.of
+Case conversion may be inaccurate. Consider using '#align SemiNormedGroup.of SemiNormedGroupCat.ofₓ'. -/
+#print SemiNormedGroupCat.of /-
 /-- Construct a bundled `SemiNormedGroup` from the underlying type and typeclass. -/
-def of (M : Type u) [SeminormedAddCommGroup M] : SemiNormedGroup :=
+def of (M : Type u) [SeminormedAddCommGroup M] : SemiNormedGroupCat :=
   Bundled.of M
-#align SemiNormedGroup.of SemiNormedGroup.of
+#align SemiNormedGroup.of SemiNormedGroupCat.of
+-/
 
-instance (M : SemiNormedGroup) : SeminormedAddCommGroup M :=
+instance (M : SemiNormedGroupCat) : SeminormedAddCommGroup M :=
   M.str
 
+#print SemiNormedGroupCat.coe_of /-
 @[simp]
-theorem coe_of (V : Type u) [SeminormedAddCommGroup V] : (SemiNormedGroup.of V : Type u) = V :=
+theorem coe_of (V : Type u) [SeminormedAddCommGroup V] : (SemiNormedGroupCat.of V : Type u) = V :=
   rfl
-#align SemiNormedGroup.coe_of SemiNormedGroup.coe_of
+#align SemiNormedGroup.coe_of SemiNormedGroupCat.coe_of
+-/
 
+#print SemiNormedGroupCat.coe_id /-
 @[simp]
-theorem coe_id (V : SemiNormedGroup) : ⇑(𝟙 V) = id :=
+theorem coe_id (V : SemiNormedGroupCat) : ⇑(𝟙 V) = id :=
   rfl
-#align SemiNormedGroup.coe_id SemiNormedGroup.coe_id
+#align SemiNormedGroup.coe_id SemiNormedGroupCat.coe_id
+-/
 
+#print SemiNormedGroupCat.coe_comp /-
 @[simp]
-theorem coe_comp {M N K : SemiNormedGroup} (f : M ⟶ N) (g : N ⟶ K) : (f ≫ g : M → K) = g ∘ f :=
+theorem coe_comp {M N K : SemiNormedGroupCat} (f : M ⟶ N) (g : N ⟶ K) : (f ≫ g : M → K) = g ∘ f :=
   rfl
-#align SemiNormedGroup.coe_comp SemiNormedGroup.coe_comp
+#align SemiNormedGroup.coe_comp SemiNormedGroupCat.coe_comp
+-/
 
-instance : Inhabited SemiNormedGroup :=
+instance : Inhabited SemiNormedGroupCat :=
   ⟨of PUnit⟩
 
+#print SemiNormedGroupCat.ofUnique /-
 instance ofUnique (V : Type u) [SeminormedAddCommGroup V] [i : Unique V] :
-    Unique (SemiNormedGroup.of V) :=
+    Unique (SemiNormedGroupCat.of V) :=
   i
-#align SemiNormedGroup.of_unique SemiNormedGroup.ofUnique
+#align SemiNormedGroup.of_unique SemiNormedGroupCat.ofUnique
+-/
 
-instance : Limits.HasZeroMorphisms.{u, u + 1} SemiNormedGroup where
+instance : Limits.HasZeroMorphisms.{u, u + 1} SemiNormedGroupCat where
 
+#print SemiNormedGroupCat.zero_apply /-
 @[simp]
-theorem zero_apply {V W : SemiNormedGroup} (x : V) : (0 : V ⟶ W) x = 0 :=
+theorem zero_apply {V W : SemiNormedGroupCat} (x : V) : (0 : V ⟶ W) x = 0 :=
   rfl
-#align SemiNormedGroup.zero_apply SemiNormedGroup.zero_apply
+#align SemiNormedGroup.zero_apply SemiNormedGroupCat.zero_apply
+-/
 
-theorem isZero_of_subsingleton (V : SemiNormedGroup) [Subsingleton V] : Limits.IsZero V :=
+#print SemiNormedGroupCat.isZero_of_subsingleton /-
+theorem isZero_of_subsingleton (V : SemiNormedGroupCat) [Subsingleton V] : Limits.IsZero V :=
   by
   refine' ⟨fun X => ⟨⟨⟨0⟩, fun f => _⟩⟩, fun X => ⟨⟨⟨0⟩, fun f => _⟩⟩⟩
   · ext; have : x = 0 := Subsingleton.elim _ _; simp only [this, map_zero]
   · ext; apply Subsingleton.elim
-#align SemiNormedGroup.is_zero_of_subsingleton SemiNormedGroup.isZero_of_subsingleton
+#align SemiNormedGroup.is_zero_of_subsingleton SemiNormedGroupCat.isZero_of_subsingleton
+-/
 
-instance hasZeroObject : Limits.HasZeroObject SemiNormedGroup.{u} :=
+#print SemiNormedGroupCat.hasZeroObject /-
+instance hasZeroObject : Limits.HasZeroObject SemiNormedGroupCat.{u} :=
   ⟨⟨of PUnit, isZero_of_subsingleton _⟩⟩
-#align SemiNormedGroup.has_zero_object SemiNormedGroup.hasZeroObject
+#align SemiNormedGroup.has_zero_object SemiNormedGroupCat.hasZeroObject
+-/
 
-theorem iso_isometry_of_normNoninc {V W : SemiNormedGroup} (i : V ≅ W) (h1 : i.hom.NormNoninc)
+#print SemiNormedGroupCat.iso_isometry_of_normNoninc /-
+theorem iso_isometry_of_normNoninc {V W : SemiNormedGroupCat} (i : V ≅ W) (h1 : i.hom.NormNoninc)
     (h2 : i.inv.NormNoninc) : Isometry i.hom :=
   by
   apply AddMonoidHomClass.isometry_of_norm
@@ -105,130 +128,158 @@ theorem iso_isometry_of_normNoninc {V W : SemiNormedGroup} (i : V ≅ W) (h1 : i
   calc
     ‖v‖ = ‖i.inv (i.hom v)‖ := by rw [iso.hom_inv_id_apply]
     _ ≤ ‖i.hom v‖ := h2 _
-#align SemiNormedGroup.iso_isometry_of_norm_noninc SemiNormedGroup.iso_isometry_of_normNoninc
+#align SemiNormedGroup.iso_isometry_of_norm_noninc SemiNormedGroupCat.iso_isometry_of_normNoninc
+-/
 
-end SemiNormedGroup
+end SemiNormedGroupCat
 
+#print SemiNormedGroupCat₁ /-
 /-- `SemiNormedGroup₁` is a type synonym for `SemiNormedGroup`,
 which we shall equip with the category structure consisting only of the norm non-increasing maps.
 -/
-def SemiNormedGroup₁ : Type (u + 1) :=
+def SemiNormedGroupCat₁ : Type (u + 1) :=
   Bundled SeminormedAddCommGroup
-#align SemiNormedGroup₁ SemiNormedGroup₁
+#align SemiNormedGroup₁ SemiNormedGroupCat₁
+-/
 
-namespace SemiNormedGroup₁
+namespace SemiNormedGroupCat₁
 
-instance : CoeSort SemiNormedGroup₁ (Type u) :=
+instance : CoeSort SemiNormedGroupCat₁ (Type u) :=
   Bundled.hasCoeToSort
 
-instance : LargeCategory.{u} SemiNormedGroup₁
+instance : LargeCategory.{u} SemiNormedGroupCat₁
     where
   hom X Y := { f : NormedAddGroupHom X Y // f.NormNoninc }
   id X := ⟨NormedAddGroupHom.id X, NormedAddGroupHom.NormNoninc.id⟩
   comp X Y Z f g := ⟨(g : NormedAddGroupHom Y Z).comp (f : NormedAddGroupHom X Y), g.2.comp f.2⟩
 
+#print SemiNormedGroupCat₁.hom_ext /-
 @[ext]
-theorem hom_ext {M N : SemiNormedGroup₁} (f g : M ⟶ N) (w : (f : M → N) = (g : M → N)) : f = g :=
+theorem hom_ext {M N : SemiNormedGroupCat₁} (f g : M ⟶ N) (w : (f : M → N) = (g : M → N)) : f = g :=
   Subtype.eq (NormedAddGroupHom.ext (congr_fun w))
-#align SemiNormedGroup₁.hom_ext SemiNormedGroup₁.hom_ext
+#align SemiNormedGroup₁.hom_ext SemiNormedGroupCat₁.hom_ext
+-/
 
-instance : ConcreteCategory.{u} SemiNormedGroup₁
+instance : ConcreteCategory.{u} SemiNormedGroupCat₁
     where
   forget :=
     { obj := fun X => X
       map := fun X Y f => f }
   forget_faithful := { }
 
+#print SemiNormedGroupCat₁.of /-
 /-- Construct a bundled `SemiNormedGroup₁` from the underlying type and typeclass. -/
-def of (M : Type u) [SeminormedAddCommGroup M] : SemiNormedGroup₁ :=
+def of (M : Type u) [SeminormedAddCommGroup M] : SemiNormedGroupCat₁ :=
   Bundled.of M
-#align SemiNormedGroup₁.of SemiNormedGroup₁.of
+#align SemiNormedGroup₁.of SemiNormedGroupCat₁.of
+-/
 
-instance (M : SemiNormedGroup₁) : SeminormedAddCommGroup M :=
+instance (M : SemiNormedGroupCat₁) : SeminormedAddCommGroup M :=
   M.str
 
+#print SemiNormedGroupCat₁.mkHom /-
 /-- Promote a morphism in `SemiNormedGroup` to a morphism in `SemiNormedGroup₁`. -/
-def mkHom {M N : SemiNormedGroup} (f : M ⟶ N) (i : f.NormNoninc) :
-    SemiNormedGroup₁.of M ⟶ SemiNormedGroup₁.of N :=
+def mkHom {M N : SemiNormedGroupCat} (f : M ⟶ N) (i : f.NormNoninc) :
+    SemiNormedGroupCat₁.of M ⟶ SemiNormedGroupCat₁.of N :=
   ⟨f, i⟩
-#align SemiNormedGroup₁.mk_hom SemiNormedGroup₁.mkHom
+#align SemiNormedGroup₁.mk_hom SemiNormedGroupCat₁.mkHom
+-/
 
+#print SemiNormedGroupCat₁.mkHom_apply /-
 @[simp]
-theorem mkHom_apply {M N : SemiNormedGroup} (f : M ⟶ N) (i : f.NormNoninc) (x) :
+theorem mkHom_apply {M N : SemiNormedGroupCat} (f : M ⟶ N) (i : f.NormNoninc) (x) :
     mkHom f i x = f x :=
   rfl
-#align SemiNormedGroup₁.mk_hom_apply SemiNormedGroup₁.mkHom_apply
+#align SemiNormedGroup₁.mk_hom_apply SemiNormedGroupCat₁.mkHom_apply
+-/
 
+#print SemiNormedGroupCat₁.mkIso /-
 /-- Promote an isomorphism in `SemiNormedGroup` to an isomorphism in `SemiNormedGroup₁`. -/
 @[simps]
-def mkIso {M N : SemiNormedGroup} (f : M ≅ N) (i : f.hom.NormNoninc) (i' : f.inv.NormNoninc) :
-    SemiNormedGroup₁.of M ≅ SemiNormedGroup₁.of N
+def mkIso {M N : SemiNormedGroupCat} (f : M ≅ N) (i : f.hom.NormNoninc) (i' : f.inv.NormNoninc) :
+    SemiNormedGroupCat₁.of M ≅ SemiNormedGroupCat₁.of N
     where
   hom := mkHom f.hom i
   inv := mkHom f.inv i'
   hom_inv_id' := by apply Subtype.eq; exact f.hom_inv_id
   inv_hom_id' := by apply Subtype.eq; exact f.inv_hom_id
-#align SemiNormedGroup₁.mk_iso SemiNormedGroup₁.mkIso
+#align SemiNormedGroup₁.mk_iso SemiNormedGroupCat₁.mkIso
+-/
 
-instance : HasForget₂ SemiNormedGroup₁ SemiNormedGroup
+instance : HasForget₂ SemiNormedGroupCat₁ SemiNormedGroupCat
     where forget₂ :=
     { obj := fun X => X
       map := fun X Y f => f.1 }
 
+#print SemiNormedGroupCat₁.coe_of /-
 @[simp]
-theorem coe_of (V : Type u) [SeminormedAddCommGroup V] : (SemiNormedGroup₁.of V : Type u) = V :=
+theorem coe_of (V : Type u) [SeminormedAddCommGroup V] : (SemiNormedGroupCat₁.of V : Type u) = V :=
   rfl
-#align SemiNormedGroup₁.coe_of SemiNormedGroup₁.coe_of
+#align SemiNormedGroup₁.coe_of SemiNormedGroupCat₁.coe_of
+-/
 
+#print SemiNormedGroupCat₁.coe_id /-
 @[simp]
-theorem coe_id (V : SemiNormedGroup₁) : ⇑(𝟙 V) = id :=
+theorem coe_id (V : SemiNormedGroupCat₁) : ⇑(𝟙 V) = id :=
   rfl
-#align SemiNormedGroup₁.coe_id SemiNormedGroup₁.coe_id
+#align SemiNormedGroup₁.coe_id SemiNormedGroupCat₁.coe_id
+-/
 
+#print SemiNormedGroupCat₁.coe_comp /-
 @[simp]
-theorem coe_comp {M N K : SemiNormedGroup₁} (f : M ⟶ N) (g : N ⟶ K) : (f ≫ g : M → K) = g ∘ f :=
+theorem coe_comp {M N K : SemiNormedGroupCat₁} (f : M ⟶ N) (g : N ⟶ K) : (f ≫ g : M → K) = g ∘ f :=
   rfl
-#align SemiNormedGroup₁.coe_comp SemiNormedGroup₁.coe_comp
+#align SemiNormedGroup₁.coe_comp SemiNormedGroupCat₁.coe_comp
+-/
 
 -- If `coe_fn_coe_base` fires before `coe_comp`, `coe_comp'` puts us back in normal form.
 @[simp]
-theorem coe_comp' {M N K : SemiNormedGroup₁} (f : M ⟶ N) (g : N ⟶ K) :
+theorem coe_comp' {M N K : SemiNormedGroupCat₁} (f : M ⟶ N) (g : N ⟶ K) :
     (f ≫ g : NormedAddGroupHom M K) = (↑g : NormedAddGroupHom N K).comp ↑f :=
   rfl
-#align SemiNormedGroup₁.coe_comp' SemiNormedGroup₁.coe_comp'
+#align SemiNormedGroup₁.coe_comp' SemiNormedGroupCat₁.coe_comp'
 
-instance : Inhabited SemiNormedGroup₁ :=
+instance : Inhabited SemiNormedGroupCat₁ :=
   ⟨of PUnit⟩
 
+#print SemiNormedGroupCat₁.ofUnique /-
 instance ofUnique (V : Type u) [SeminormedAddCommGroup V] [i : Unique V] :
-    Unique (SemiNormedGroup₁.of V) :=
+    Unique (SemiNormedGroupCat₁.of V) :=
   i
-#align SemiNormedGroup₁.of_unique SemiNormedGroup₁.ofUnique
+#align SemiNormedGroup₁.of_unique SemiNormedGroupCat₁.ofUnique
+-/
 
-instance : Limits.HasZeroMorphisms.{u, u + 1} SemiNormedGroup₁
+instance : Limits.HasZeroMorphisms.{u, u + 1} SemiNormedGroupCat₁
     where
   Zero X Y := { zero := ⟨0, NormedAddGroupHom.NormNoninc.zero⟩ }
   comp_zero X Y f Z := by ext; rfl
   zero_comp X Y Z f := by ext; simp [coeFn_coe_base']
 
+#print SemiNormedGroupCat₁.zero_apply /-
 @[simp]
-theorem zero_apply {V W : SemiNormedGroup₁} (x : V) : (0 : V ⟶ W) x = 0 :=
+theorem zero_apply {V W : SemiNormedGroupCat₁} (x : V) : (0 : V ⟶ W) x = 0 :=
   rfl
-#align SemiNormedGroup₁.zero_apply SemiNormedGroup₁.zero_apply
+#align SemiNormedGroup₁.zero_apply SemiNormedGroupCat₁.zero_apply
+-/
 
-theorem isZero_of_subsingleton (V : SemiNormedGroup₁) [Subsingleton V] : Limits.IsZero V :=
+#print SemiNormedGroupCat₁.isZero_of_subsingleton /-
+theorem isZero_of_subsingleton (V : SemiNormedGroupCat₁) [Subsingleton V] : Limits.IsZero V :=
   by
   refine' ⟨fun X => ⟨⟨⟨0⟩, fun f => _⟩⟩, fun X => ⟨⟨⟨0⟩, fun f => _⟩⟩⟩
   · ext; have : x = 0 := Subsingleton.elim _ _; simp only [this, map_zero]
     exact map_zero f.1
   · ext; apply Subsingleton.elim
-#align SemiNormedGroup₁.is_zero_of_subsingleton SemiNormedGroup₁.isZero_of_subsingleton
+#align SemiNormedGroup₁.is_zero_of_subsingleton SemiNormedGroupCat₁.isZero_of_subsingleton
+-/
 
-instance hasZeroObject : Limits.HasZeroObject SemiNormedGroup₁.{u} :=
+#print SemiNormedGroupCat₁.hasZeroObject /-
+instance hasZeroObject : Limits.HasZeroObject SemiNormedGroupCat₁.{u} :=
   ⟨⟨of PUnit, isZero_of_subsingleton _⟩⟩
-#align SemiNormedGroup₁.has_zero_object SemiNormedGroup₁.hasZeroObject
+#align SemiNormedGroup₁.has_zero_object SemiNormedGroupCat₁.hasZeroObject
+-/
 
-theorem iso_isometry {V W : SemiNormedGroup₁} (i : V ≅ W) : Isometry i.hom :=
+#print SemiNormedGroupCat₁.iso_isometry /-
+theorem iso_isometry {V W : SemiNormedGroupCat₁} (i : V ≅ W) : Isometry i.hom :=
   by
   change Isometry (i.hom : V →+ W)
   refine' AddMonoidHomClass.isometry_of_norm i.hom _
@@ -237,7 +288,8 @@ theorem iso_isometry {V W : SemiNormedGroup₁} (i : V ≅ W) : Isometry i.hom :
   calc
     ‖v‖ = ‖i.inv (i.hom v)‖ := by rw [iso.hom_inv_id_apply]
     _ ≤ ‖i.hom v‖ := i.inv.2 _
-#align SemiNormedGroup₁.iso_isometry SemiNormedGroup₁.iso_isometry
+#align SemiNormedGroup₁.iso_isometry SemiNormedGroupCat₁.iso_isometry
+-/
 
-end SemiNormedGroup₁
+end SemiNormedGroupCat₁

cff8231f

bump to nightly-2023-06-17-03

mathlib commit https://github.com/leanprover-community/mathlib/commit/893964fc28cefbcffc7cb784ed00a2895b4e65cf

253178d1

Diff

@@ -4,7 +4,7 @@ Released under Apache 2.0 license as described in the file LICENSE.
 Authors: Johan Commelin, Riccardo Brasca
 
 ! This file was ported from Lean 3 source module analysis.normed.group.SemiNormedGroup
-! leanprover-community/mathlib commit 17ef379e997badd73e5eabb4d38f11919ab3c4b3
+! leanprover-community/mathlib commit cff8231f04dfa33fd8f2f45792eebd862ef30cad
 ! Please do not edit these lines, except to modify the commit id
 ! if you have ported upstream changes.
 -/
@@ -16,6 +16,9 @@ import Mathbin.CategoryTheory.Elementwise
 /-!
 # The category of seminormed groups
 
+> THIS FILE IS SYNCHRONIZED WITH MATHLIB4.
+> Any changes to this file require a corresponding PR to mathlib4.
+
 We define `SemiNormedGroup`, the category of seminormed groups and normed group homs between them,
 as well as `SemiNormedGroup₁`, the subcategory of norm non-increasing morphisms.
 -/

17ef379e

bump to nightly-2023-06-09-07

mathlib commit https://github.com/leanprover-community/mathlib/commit/7e5137f579de09a059a5ce98f364a04e221aabf0

16afdc39

Diff

@@ -102,7 +102,6 @@ theorem iso_isometry_of_normNoninc {V W : SemiNormedGroup} (i : V ≅ W) (h1 : i
   calc
     ‖v‖ = ‖i.inv (i.hom v)‖ := by rw [iso.hom_inv_id_apply]
     _ ≤ ‖i.hom v‖ := h2 _
-    
 #align SemiNormedGroup.iso_isometry_of_norm_noninc SemiNormedGroup.iso_isometry_of_normNoninc
 
 end SemiNormedGroup
@@ -235,7 +234,6 @@ theorem iso_isometry {V W : SemiNormedGroup₁} (i : V ≅ W) : Isometry i.hom :
   calc
     ‖v‖ = ‖i.inv (i.hom v)‖ := by rw [iso.hom_inv_id_apply]
     _ ≤ ‖i.hom v‖ := i.inv.2 _
-    
 #align SemiNormedGroup₁.iso_isometry SemiNormedGroup₁.iso_isometry
 
 end SemiNormedGroup₁

17ef379e

bump to nightly-2023-05-28-04

mathlib commit https://github.com/leanprover-community/mathlib/commit/917c3c072e487b3cccdbfeff17e75b40e45f66cb

6797a637

Diff

@@ -85,11 +85,8 @@ theorem zero_apply {V W : SemiNormedGroup} (x : V) : (0 : V ⟶ W) x = 0 :=
 theorem isZero_of_subsingleton (V : SemiNormedGroup) [Subsingleton V] : Limits.IsZero V :=
   by
   refine' ⟨fun X => ⟨⟨⟨0⟩, fun f => _⟩⟩, fun X => ⟨⟨⟨0⟩, fun f => _⟩⟩⟩
-  · ext
-    have : x = 0 := Subsingleton.elim _ _
-    simp only [this, map_zero]
-  · ext
-    apply Subsingleton.elim
+  · ext; have : x = 0 := Subsingleton.elim _ _; simp only [this, map_zero]
+  · ext; apply Subsingleton.elim
 #align SemiNormedGroup.is_zero_of_subsingleton SemiNormedGroup.isZero_of_subsingleton
 
 instance hasZeroObject : Limits.HasZeroObject SemiNormedGroup.{u} :=
@@ -167,12 +164,8 @@ def mkIso {M N : SemiNormedGroup} (f : M ≅ N) (i : f.hom.NormNoninc) (i' : f.i
     where
   hom := mkHom f.hom i
   inv := mkHom f.inv i'
-  hom_inv_id' := by
-    apply Subtype.eq
-    exact f.hom_inv_id
-  inv_hom_id' := by
-    apply Subtype.eq
-    exact f.inv_hom_id
+  hom_inv_id' := by apply Subtype.eq; exact f.hom_inv_id
+  inv_hom_id' := by apply Subtype.eq; exact f.inv_hom_id
 #align SemiNormedGroup₁.mk_iso SemiNormedGroup₁.mkIso
 
 instance : HasForget₂ SemiNormedGroup₁ SemiNormedGroup
@@ -213,12 +206,8 @@ instance ofUnique (V : Type u) [SeminormedAddCommGroup V] [i : Unique V] :
 instance : Limits.HasZeroMorphisms.{u, u + 1} SemiNormedGroup₁
     where
   Zero X Y := { zero := ⟨0, NormedAddGroupHom.NormNoninc.zero⟩ }
-  comp_zero X Y f Z := by
-    ext
-    rfl
-  zero_comp X Y Z f := by
-    ext
-    simp [coeFn_coe_base']
+  comp_zero X Y f Z := by ext; rfl
+  zero_comp X Y Z f := by ext; simp [coeFn_coe_base']
 
 @[simp]
 theorem zero_apply {V W : SemiNormedGroup₁} (x : V) : (0 : V ⟶ W) x = 0 :=
@@ -228,12 +217,9 @@ theorem zero_apply {V W : SemiNormedGroup₁} (x : V) : (0 : V ⟶ W) x = 0 :=
 theorem isZero_of_subsingleton (V : SemiNormedGroup₁) [Subsingleton V] : Limits.IsZero V :=
   by
   refine' ⟨fun X => ⟨⟨⟨0⟩, fun f => _⟩⟩, fun X => ⟨⟨⟨0⟩, fun f => _⟩⟩⟩
-  · ext
-    have : x = 0 := Subsingleton.elim _ _
-    simp only [this, map_zero]
+  · ext; have : x = 0 := Subsingleton.elim _ _; simp only [this, map_zero]
     exact map_zero f.1
-  · ext
-    apply Subsingleton.elim
+  · ext; apply Subsingleton.elim
 #align SemiNormedGroup₁.is_zero_of_subsingleton SemiNormedGroup₁.isZero_of_subsingleton
 
 instance hasZeroObject : Limits.HasZeroObject SemiNormedGroup₁.{u} :=

17ef379e

bump to nightly-2023-03-08-08

mathlib commit https://github.com/leanprover-community/mathlib/commit/38f16f960f5006c6c0c2bac7b0aba5273188f4e5

fc92a682

Diff

@@ -213,10 +213,10 @@ instance ofUnique (V : Type u) [SeminormedAddCommGroup V] [i : Unique V] :
 instance : Limits.HasZeroMorphisms.{u, u + 1} SemiNormedGroup₁
     where
   Zero X Y := { zero := ⟨0, NormedAddGroupHom.NormNoninc.zero⟩ }
-  comp_zero' X Y f Z := by
+  comp_zero X Y f Z := by
     ext
     rfl
-  zero_comp' X Y Z f := by
+  zero_comp X Y Z f := by
     ext
     simp [coeFn_coe_base']

17ef379e

bump to nightly-2023-02-21-16

mathlib commit https://github.com/leanprover-community/mathlib/commit/bd9851ca476957ea4549eb19b40e7b5ade9428cc

1107b979

Changes in mathlib4

mathlib3

mathlib4

17ef379e

style: reduce spacing variation in "porting note" comments (#10886)

In this pull request, I have systematically eliminated the leading whitespace preceding the colon (:) within all unlabelled or unclassified porting notes. This adjustment facilitates a more efficient review process for the remaining notes by ensuring no entries are overlooked due to formatting inconsistencies.

86b84c52

Diff

@@ -77,13 +77,13 @@ theorem coe_of (V : Type u) [SeminormedAddCommGroup V] : (SemiNormedGroupCat.of
   rfl
 #align SemiNormedGroup.coe_of SemiNormedGroupCat.coe_of
 
--- Porting note : marked with high priority to short circuit simplifier's path
+-- Porting note: marked with high priority to short circuit simplifier's path
 @[simp (high)]
 theorem coe_id (V : SemiNormedGroupCat) : (𝟙 V : V → V) = id :=
   rfl
 #align SemiNormedGroup.coe_id SemiNormedGroupCat.coe_id
 
--- Porting note : marked with high priority to short circuit simplifier's path
+-- Porting note: marked with high priority to short circuit simplifier's path
 @[simp (high)]
 theorem coe_comp {M N K : SemiNormedGroupCat} (f : M ⟶ N) (g : N ⟶ K) :
     (f ≫ g : M → K) = g ∘ f :=
@@ -210,13 +210,13 @@ theorem coe_of (V : Type u) [SeminormedAddCommGroup V] : (SemiNormedGroupCat₁.
   rfl
 #align SemiNormedGroup₁.coe_of SemiNormedGroupCat₁.coe_of
 
--- Porting note : marked with high priority to short circuit simplifier's path
+-- Porting note: marked with high priority to short circuit simplifier's path
 @[simp (high)]
 theorem coe_id (V : SemiNormedGroupCat₁) : ⇑(𝟙 V) = id :=
   rfl
 #align SemiNormedGroup₁.coe_id SemiNormedGroupCat₁.coe_id
 
--- Porting note : marked with high priority to short circuit simplifier's path
+-- Porting note: marked with high priority to short circuit simplifier's path
 @[simp (high)]
 theorem coe_comp {M N K : SemiNormedGroupCat₁} (f : M ⟶ N) (g : N ⟶ K) :
     (f ≫ g : M → K) = g ∘ f :=

17ef379e

chore: classify added to ease automation porting notes (#10689)

Classifies by adding issue number (#10688) to porting notes claiming anything semantically equivalent to added to ease automation.
Enforce singular convention converting "porting notes" to "porting note".

b06068c3

Diff

@@ -67,7 +67,7 @@ instance toAddMonoidHomClass {V W : SemiNormedGroupCat} : AddMonoidHomClass (V 
   map_add f := f.map_add'
   map_zero f := (AddMonoidHom.mk' f.toFun f.map_add').map_zero
 
--- Porting note: added to ease automation
+-- Porting note (#10688): added to ease automation
 @[ext]
 lemma ext {M N : SemiNormedGroupCat} {f₁ f₂ : M ⟶ N} (h : ∀ (x : M), f₁ x = f₂ x) : f₁ = f₂ :=
   DFunLike.ext _ _ h

17ef379e

chore: classify added instance porting notes (#10755)

Classifies by adding issue number (#10754) to porting notes claiming added instance.

283cf08e

Diff

@@ -58,7 +58,7 @@ def of (M : Type u) [SeminormedAddCommGroup M] : SemiNormedGroupCat :=
 instance (M : SemiNormedGroupCat) : SeminormedAddCommGroup M :=
   M.str
 
--- Porting Note: added
+-- Porting note (#10754): added instance
 instance funLike {V W : SemiNormedGroupCat} : FunLike (V ⟶ W) V W where
   coe := (forget SemiNormedGroupCat).map
   coe_injective' := fun f g h => by cases f; cases g; congr
@@ -148,7 +148,7 @@ instance : LargeCategory.{u} SemiNormedGroupCat₁ where
   id X := ⟨NormedAddGroupHom.id X, NormedAddGroupHom.NormNoninc.id⟩
   comp {X Y Z} f g := ⟨g.1.comp f.1, g.2.comp f.2⟩
 
--- Porting Note: Added
+-- Porting note (#10754): added instance
 instance instFunLike (X Y : SemiNormedGroupCat₁) : FunLike (X ⟶ Y) X Y where
   coe f := f.1.toFun
   coe_injective' _ _ h := Subtype.val_inj.mp (NormedAddGroupHom.coe_injective h)
@@ -165,7 +165,7 @@ instance : ConcreteCategory.{u} SemiNormedGroupCat₁ where
       map := fun f => f }
   forget_faithful := { }
 
--- Porting note: added
+-- Porting note (#10754): added instance
 instance toAddMonoidHomClass {V W : SemiNormedGroupCat₁} : AddMonoidHomClass (V ⟶ W) V W where
   map_add f := f.1.map_add'
   map_zero f := (AddMonoidHom.mk' f.1 f.1.map_add').map_zero

17ef379e

refactor(Data/FunLike): use unbundled inheritance from FunLike (#8386)

The FunLike hierarchy is very big and gets scanned through each time we need a coercion (via the CoeFun instance). It looks like unbundled inheritance suits Lean 4 better here. The only class that still extends FunLike is EquivLike, since that has a custom coe_injective' field that is easier to implement. All other classes should take FunLike or EquivLike as a parameter.

Zulip thread

Important changes

Previously, morphism classes would be Type-valued and extend FunLike:

/-- `MyHomClass F A B` states that `F` is a type of `MyClass.op`-preserving morphisms.
You should extend this class when you extend `MyHom`. -/
class MyHomClass (F : Type*) (A B : outParam <| Type*) [MyClass A] [MyClass B]
  extends FunLike F A B :=
(map_op : ∀ (f : F) (x y : A), f (MyClass.op x y) = MyClass.op (f x) (f y))

After this PR, they should be Prop-valued and take FunLike as a parameter:

/-- `MyHomClass F A B` states that `F` is a type of `MyClass.op`-preserving morphisms.
You should extend this class when you extend `MyHom`. -/
class MyHomClass (F : Type*) (A B : outParam <| Type*) [MyClass A] [MyClass B]
  [FunLike F A B] : Prop :=
(map_op : ∀ (f : F) (x y : A), f (MyClass.op x y) = MyClass.op (f x) (f y))

(Note that A B stay marked as outParam even though they are not purely required to be so due to the FunLike parameter already filling them in. This is required to see through type synonyms, which is important in the category theory library. Also, I think keeping them as outParam is slightly faster.)

Similarly, MyEquivClass should take EquivLike as a parameter.

As a result, every mention of [MyHomClass F A B] should become [FunLike F A B] [MyHomClass F A B].

Remaining issues

Slower (failing) search

While overall this gives some great speedups, there are some cases that are noticeably slower. In particular, a failing application of a lemma such as map_mul is more expensive. This is due to suboptimal processing of arguments. For example:

variable [FunLike F M N] [Mul M] [Mul N] (f : F) (x : M) (y : M)

theorem map_mul [MulHomClass F M N] : f (x * y) = f x * f y

example [AddHomClass F A B] : f (x * y) = f x * f y := map_mul f _ _

Before this PR, applying map_mul f gives the goals [Mul ?M] [Mul ?N] [MulHomClass F ?M ?N]. Since M and N are out_params, [MulHomClass F ?M ?N] is synthesized first, supplies values for ?M and ?N and then the Mul M and Mul N instances can be found.

After this PR, the goals become [FunLike F ?M ?N] [Mul ?M] [Mul ?N] [MulHomClass F ?M ?N]. Now [FunLike F ?M ?N] is synthesized first, supplies values for ?M and ?N and then the Mul M and Mul N instances can be found, before trying MulHomClass F M N which fails. Since the Mul hierarchy is very big, this can be slow to fail, especially when there is no such Mul instance.

A long-term but harder to achieve solution would be to specify the order in which instance goals get solved. For example, we'd like to change the arguments to map_mul to look like [FunLike F M N] [Mul M] [Mul N] [highPriority <| MulHomClass F M N] because MulHomClass fails or succeeds much faster than the others.

As a consequence, the simpNF linter is much slower since by design it tries and fails to apply many map_ lemmas. The same issue occurs a few times in existing calls to simp [map_mul], where map_mul is tried "too soon" and fails. Thanks to the speedup of leanprover/lean4#2478 the impact is very limited, only in files that already were close to the timeout.

`simp` not firing sometimes

This affects map_smulₛₗ and related definitions. For simp lemmas Lean apparently uses a slightly different mechanism to find instances, so that rw can find every argument to map_smulₛₗ successfully but simp can't: leanprover/lean4#3701.

Missing instances due to unification failing

Especially in the category theory library, we might sometimes have a type A which is also accessible as a synonym (Bundled A hA).1. Instance synthesis doesn't always work if we have f : A →* B but x * y : (Bundled A hA).1 or vice versa. This seems to be mostly fixed by keeping A B as outParams in MulHomClass F A B. (Presumably because Lean will do a definitional check A =?= (Bundled A hA).1 instead of using the syntax in the discrimination tree.)

Workaround for issues

The timeouts can be worked around for now by specifying which map_mul we mean, either as map_mul f for some explicit f, or as e.g. MonoidHomClass.map_mul.

map_smulₛₗ not firing as simp lemma can be worked around by going back to the pre-FunLike situation and making LinearMap.map_smulₛₗ a simp lemma instead of the generic map_smulₛₗ. Writing simp [map_smulₛₗ _] also works.

Co-authored-by: Matthew Ballard <matt@mrb.email> Co-authored-by: Scott Morrison <scott.morrison@gmail.com> Co-authored-by: Scott Morrison <scott@tqft.net> Co-authored-by: Anne Baanen <Vierkantor@users.noreply.github.com>

c6a73d4f

Diff

@@ -59,9 +59,11 @@ instance (M : SemiNormedGroupCat) : SeminormedAddCommGroup M :=
   M.str
 
 -- Porting Note: added
-instance toAddMonoidHomClass {V W : SemiNormedGroupCat} : AddMonoidHomClass (V ⟶ W) V W where
+instance funLike {V W : SemiNormedGroupCat} : FunLike (V ⟶ W) V W where
   coe := (forget SemiNormedGroupCat).map
   coe_injective' := fun f g h => by cases f; cases g; congr
+
+instance toAddMonoidHomClass {V W : SemiNormedGroupCat} : AddMonoidHomClass (V ⟶ W) V W where
   map_add f := f.map_add'
   map_zero f := (AddMonoidHom.mk' f.toFun f.map_add').map_zero

17ef379e

refactor(*): abbreviation for non-dependent FunLike (#9833)

This follows up from #9785, which renamed FunLike to DFunLike, by introducing a new abbreviation FunLike F α β := DFunLike F α (fun _ => β), to make the non-dependent use of FunLike easier.

I searched for the pattern DFunLike.*fun and DFunLike.*λ in all files to replace expressions of the form DFunLike F α (fun _ => β) with FunLike F α β. I did this everywhere except for extends clauses for two reasons: it would conflict with #8386, and more importantly extends must directly refer to a structure with no unfolding of defs or abbrevs.

54792e9e

Diff

@@ -147,7 +147,7 @@ instance : LargeCategory.{u} SemiNormedGroupCat₁ where
   comp {X Y Z} f g := ⟨g.1.comp f.1, g.2.comp f.2⟩
 
 -- Porting Note: Added
-instance instDFunLike (X Y : SemiNormedGroupCat₁) : DFunLike (X ⟶ Y) X (fun _ => Y) where
+instance instFunLike (X Y : SemiNormedGroupCat₁) : FunLike (X ⟶ Y) X Y where
   coe f := f.1.toFun
   coe_injective' _ _ h := Subtype.val_inj.mp (NormedAddGroupHom.coe_injective h)

17ef379e

chore(*): rename FunLike to DFunLike (#9785)

This prepares for the introduction of a non-dependent synonym of FunLike, which helps a lot with keeping #8386 readable.

This is entirely search-and-replace in 680197f combined with manual fixes in 4145626, e900597 and b8428f8. The commands that generated this change:

sed -i 's/\bFunLike\b/DFunLike/g' {Archive,Counterexamples,Mathlib,test}/**/*.lean
sed -i 's/\btoFunLike\b/toDFunLike/g' {Archive,Counterexamples,Mathlib,test}/**/*.lean
sed -i 's/import Mathlib.Data.DFunLike/import Mathlib.Data.FunLike/g' {Archive,Counterexamples,Mathlib,test}/**/*.lean
sed -i 's/\bHom_FunLike\b/Hom_DFunLike/g' {Archive,Counterexamples,Mathlib,test}/**/*.lean     
sed -i 's/\binstFunLike\b/instDFunLike/g' {Archive,Counterexamples,Mathlib,test}/**/*.lean
sed -i 's/\bfunLike\b/instDFunLike/g' {Archive,Counterexamples,Mathlib,test}/**/*.lean
sed -i 's/\btoo many metavariables to apply `fun_like.has_coe_to_fun`/too many metavariables to apply `DFunLike.hasCoeToFun`/g' {Archive,Counterexamples,Mathlib,test}/**/*.lean

Co-authored-by: Anne Baanen <Vierkantor@users.noreply.github.com>

82656743

Diff

@@ -68,7 +68,7 @@ instance toAddMonoidHomClass {V W : SemiNormedGroupCat} : AddMonoidHomClass (V 
 -- Porting note: added to ease automation
 @[ext]
 lemma ext {M N : SemiNormedGroupCat} {f₁ f₂ : M ⟶ N} (h : ∀ (x : M), f₁ x = f₂ x) : f₁ = f₂ :=
-  FunLike.ext _ _ h
+  DFunLike.ext _ _ h
 
 @[simp]
 theorem coe_of (V : Type u) [SeminormedAddCommGroup V] : (SemiNormedGroupCat.of V : Type u) = V :=
@@ -147,7 +147,7 @@ instance : LargeCategory.{u} SemiNormedGroupCat₁ where
   comp {X Y Z} f g := ⟨g.1.comp f.1, g.2.comp f.2⟩
 
 -- Porting Note: Added
-instance instFunLike (X Y : SemiNormedGroupCat₁) : FunLike (X ⟶ Y) X (fun _ => Y) where
+instance instDFunLike (X Y : SemiNormedGroupCat₁) : DFunLike (X ⟶ Y) X (fun _ => Y) where
   coe f := f.1.toFun
   coe_injective' _ _ h := Subtype.val_inj.mp (NormedAddGroupHom.coe_injective h)

17ef379e

Revert "chore: revert #7703 (#7710)"

This reverts commit f3695eb2.

ab56fa28

Diff

@@ -122,7 +122,8 @@ theorem iso_isometry_of_normNoninc {V W : SemiNormedGroupCat} (i : V ≅ W) (h1
   intro v
   apply le_antisymm (h1 v)
   calc
-    ‖v‖ = ‖i.inv (i.hom v)‖ := by rw [Iso.hom_inv_id_apply]
+    -- This used to be `rw`, but we need `erw` after leanprover/lean4#2644
+    ‖v‖ = ‖i.inv (i.hom v)‖ := by erw [Iso.hom_inv_id_apply]
     _ ≤ ‖i.hom v‖ := h2 _
 #align SemiNormedGroup.iso_isometry_of_norm_noninc SemiNormedGroupCat.iso_isometry_of_normNoninc
 
@@ -258,7 +259,8 @@ theorem iso_isometry {V W : SemiNormedGroupCat₁} (i : V ≅ W) : Isometry i.ho
   intro v
   apply le_antisymm (i.hom.2 v)
   calc
-    ‖v‖ = ‖i.inv (i.hom v)‖ := by rw [Iso.hom_inv_id_apply]
+    -- This used to be `rw`, but we need `erw` after leanprover/lean4#2644
+    ‖v‖ = ‖i.inv (i.hom v)‖ := by erw [Iso.hom_inv_id_apply]
     _ ≤ ‖i.hom v‖ := i.inv.2 _
 #align SemiNormedGroup₁.iso_isometry SemiNormedGroupCat₁.iso_isometry

17ef379e

chore: revert #7703 (#7710)

This reverts commit 26eb2b0a.

f3695eb2

Diff

@@ -122,8 +122,7 @@ theorem iso_isometry_of_normNoninc {V W : SemiNormedGroupCat} (i : V ≅ W) (h1
   intro v
   apply le_antisymm (h1 v)
   calc
-    -- This used to be `rw`, but we need `erw` after leanprover/lean4#2644
-    ‖v‖ = ‖i.inv (i.hom v)‖ := by erw [Iso.hom_inv_id_apply]
+    ‖v‖ = ‖i.inv (i.hom v)‖ := by rw [Iso.hom_inv_id_apply]
     _ ≤ ‖i.hom v‖ := h2 _
 #align SemiNormedGroup.iso_isometry_of_norm_noninc SemiNormedGroupCat.iso_isometry_of_normNoninc
 
@@ -259,8 +258,7 @@ theorem iso_isometry {V W : SemiNormedGroupCat₁} (i : V ≅ W) : Isometry i.ho
   intro v
   apply le_antisymm (i.hom.2 v)
   calc
-    -- This used to be `rw`, but we need `erw` after leanprover/lean4#2644
-    ‖v‖ = ‖i.inv (i.hom v)‖ := by erw [Iso.hom_inv_id_apply]
+    ‖v‖ = ‖i.inv (i.hom v)‖ := by rw [Iso.hom_inv_id_apply]
     _ ≤ ‖i.hom v‖ := i.inv.2 _
 #align SemiNormedGroup₁.iso_isometry SemiNormedGroupCat₁.iso_isometry

17ef379e

chore: bump toolchain to v4.2.0-rc2 (#7703)

This includes all the changes from #7606.

Co-authored-by: Scott Morrison <scott.morrison@gmail.com>

26eb2b0a

Diff

@@ -122,7 +122,8 @@ theorem iso_isometry_of_normNoninc {V W : SemiNormedGroupCat} (i : V ≅ W) (h1
   intro v
   apply le_antisymm (h1 v)
   calc
-    ‖v‖ = ‖i.inv (i.hom v)‖ := by rw [Iso.hom_inv_id_apply]
+    -- This used to be `rw`, but we need `erw` after leanprover/lean4#2644
+    ‖v‖ = ‖i.inv (i.hom v)‖ := by erw [Iso.hom_inv_id_apply]
     _ ≤ ‖i.hom v‖ := h2 _
 #align SemiNormedGroup.iso_isometry_of_norm_noninc SemiNormedGroupCat.iso_isometry_of_normNoninc
 
@@ -258,7 +259,8 @@ theorem iso_isometry {V W : SemiNormedGroupCat₁} (i : V ≅ W) : Isometry i.ho
   intro v
   apply le_antisymm (i.hom.2 v)
   calc
-    ‖v‖ = ‖i.inv (i.hom v)‖ := by rw [Iso.hom_inv_id_apply]
+    -- This used to be `rw`, but we need `erw` after leanprover/lean4#2644
+    ‖v‖ = ‖i.inv (i.hom v)‖ := by erw [Iso.hom_inv_id_apply]
     _ ≤ ‖i.hom v‖ := i.inv.2 _
 #align SemiNormedGroup₁.iso_isometry SemiNormedGroupCat₁.iso_isometry

17ef379e

chore: banish Type _ and Sort _ (#6499)

We remove all possible occurences of Type _ and Sort _ in favor of Type* and Sort*.

This has nice performance benefits.

32de3f67

Diff

@@ -47,7 +47,7 @@ instance : ConcreteCategory SemiNormedGroupCat := by
   dsimp [SemiNormedGroupCat]
   infer_instance
 
-instance : CoeSort SemiNormedGroupCat (Type _) where
+instance : CoeSort SemiNormedGroupCat (Type*) where
   coe X := X.α
 
 /-- Construct a bundled `SemiNormedGroupCat` from the underlying type and typeclass. -/
@@ -137,7 +137,7 @@ def SemiNormedGroupCat₁ : Type (u + 1) :=
 
 namespace SemiNormedGroupCat₁
 
-instance : CoeSort SemiNormedGroupCat₁ (Type _) where
+instance : CoeSort SemiNormedGroupCat₁ (Type*) where
   coe X := X.α
 
 instance : LargeCategory.{u} SemiNormedGroupCat₁ where

17ef379e

chore: script to replace headers with #align_import statements (#5979)

depends on: #5966

Co-authored-by: Eric Wieser <wieser.eric@gmail.com> Co-authored-by: Scott Morrison <scott.morrison@gmail.com>

89aa3a3b

Diff

@@ -2,17 +2,14 @@
 Copyright (c) 2021 Johan Commelin. All rights reserved.
 Released under Apache 2.0 license as described in the file LICENSE.
 Authors: Johan Commelin, Riccardo Brasca
-
-! This file was ported from Lean 3 source module analysis.normed.group.SemiNormedGroup
-! leanprover-community/mathlib commit 17ef379e997badd73e5eabb4d38f11919ab3c4b3
-! Please do not edit these lines, except to modify the commit id
-! if you have ported upstream changes.
 -/
 import Mathlib.Analysis.Normed.Group.Hom
 import Mathlib.CategoryTheory.Limits.Shapes.ZeroMorphisms
 import Mathlib.CategoryTheory.ConcreteCategory.BundledHom
 import Mathlib.CategoryTheory.Elementwise
 
+#align_import analysis.normed.group.SemiNormedGroup from "leanprover-community/mathlib"@"17ef379e997badd73e5eabb4d38f11919ab3c4b3"
+
 /-!
 # The category of seminormed groups

17ef379e

feat: port Analysis.Normed.Group.SemiNormedGroupCat (#4047)

Co-authored-by: Scott Morrison <scott.morrison@anu.edu.au> Co-authored-by: Jeremy Tan Jie Rui <reddeloostw@gmail.com> Co-authored-by: nick-kuhn <nikolaskuhn@gmx.de> Co-authored-by: Jujian Zhang <jujian.zhang1998@outlook.com> Co-authored-by: nick-kuhn <46423253+nick-kuhn@users.noreply.github.com>

0fc56964

`analysis.normed.group.SemiNormedGroup` ⟷ `Mathlib.Analysis.Normed.Group.SemiNormedGroupCat`

Changes since the initial port

Changes in mathlib3

Changes in mathlib3port

Changes in mathlib4

Important changes

Remaining issues

Slower (failing) search

`simp` not firing sometimes

Missing instances due to unification failing

Workaround for issues

Dependencies 10 + 599

analysis.normed.group.SemiNormedGroup ⟷ Mathlib.Analysis.Normed.Group.SemiNormedGroupCat

Changes since the initial port

Changes in mathlib3

Changes in mathlib3port

Changes in mathlib4

Important changes

Remaining issues

Slower (failing) search

simp not firing sometimes

Missing instances due to unification failing

Workaround for issues

Dependencies 10 + 599

`analysis.normed.group.SemiNormedGroup` ⟷ `Mathlib.Analysis.Normed.Group.SemiNormedGroupCat`

`simp` not firing sometimes