category_theory.concrete_category.bundled

Changes since the initial port

The following section lists changes to this file in mathlib3 and mathlib4 that occured after the initial port. Most recent changes are shown first. Hovering over a commit will show all commits associated with the same mathlib3 commit.

Changes in mathlib3

a148d797

(last sync)

Changes in mathlib3port

mathlib3

mathlib3port

448144f7

bump to nightly-2023-07-20-09

mathlib commit https://github.com/leanprover-community/mathlib/commit/8ea5598db6caeddde6cb734aa179cc2408dbd345

9c56d0dd

Diff

@@ -2,14 +2,11 @@
 Copyright (c) 2018 Scott Morrison. All rights reserved.
 Released under Apache 2.0 license as described in the file LICENSE.
 Authors: Scott Morrison, Johannes Hölzl, Reid Barton, Sean Leather
-
-! This file was ported from Lean 3 source module category_theory.concrete_category.bundled
-! leanprover-community/mathlib commit 448144f7ae193a8990cb7473c9e9a01990f64ac7
-! Please do not edit these lines, except to modify the commit id
-! if you have ported upstream changes.
 -/
 import Mathbin.Tactic.Lint.Default
 
+#align_import category_theory.concrete_category.bundled from "leanprover-community/mathlib"@"448144f7ae193a8990cb7473c9e9a01990f64ac7"
+
 /-!
 # Bundled types

448144f7

bump to nightly-2023-02-21-16

mathlib commit https://github.com/leanprover-community/mathlib/commit/bd9851ca476957ea4549eb19b40e7b5ade9428cc

1107b979

Changes in mathlib4

mathlib3

mathlib4

a148d797

chore: move Mathlib to v4.7.0-rc1 (#11162)

This is a very large PR, but it has been reviewed piecemeal already in PRs to the bump/v4.7.0 branch as we update to intermediate nightlies.

Co-authored-by: Scott Morrison <scott.morrison@gmail.com> Co-authored-by: Kyle Miller <kmill31415@gmail.com> Co-authored-by: damiano <adomani@gmail.com>

fa48894a

Diff

@@ -4,7 +4,6 @@ Released under Apache 2.0 license as described in the file LICENSE.
 Authors: Scott Morrison, Johannes Hölzl, Reid Barton, Sean Leather
 -/
 import Std.Tactic.Lint.Misc
-import Std.Tactic.CoeExt
 import Mathlib.Mathport.Rename
 
 #align_import category_theory.concrete_category.bundled from "leanprover-community/mathlib"@"a148d797a1094ab554ad4183a4ad6f130358ef64"

a148d797

chore: tidy various files (#10453)

678a9b1b

Diff

@@ -14,9 +14,10 @@ import Mathlib.Mathport.Rename
 
 `Bundled c` provides a uniform structure for bundling a type equipped with a type class.
 
-We provide `Category` instances for these in `CategoryTheory/ConcreteCategory/UnbundledHom.lean`
+We provide `Category` instances for these in
+`Mathlib/CategoryTheory/ConcreteCategory/UnbundledHom.lean`
 (for categories with unbundled homs, e.g. topological spaces)
-and in `CategoryTheory/ConcreteCategory/BundledHom.lean`
+and in `Mathlib/CategoryTheory/ConcreteCategory/BundledHom.lean`
 (for categories with bundled homs, e.g. monoids).
 -/

a148d797

chore: reduce imports (#9830)

This uses the improved shake script from #9772 to reduce imports across mathlib. The corresponding noshake.json file has been added to #9772.

Co-authored-by: Mario Carneiro <di.gama@gmail.com>

f4c4ca61

Diff

@@ -3,7 +3,6 @@ Copyright (c) 2018 Scott Morrison. All rights reserved.
 Released under Apache 2.0 license as described in the file LICENSE.
 Authors: Scott Morrison, Johannes Hölzl, Reid Barton, Sean Leather
 -/
-import Std.Tactic.Lint.Frontend
 import Std.Tactic.Lint.Misc
 import Std.Tactic.CoeExt
 import Mathlib.Mathport.Rename

a148d797

fix: wrong links to (un)bundledHom (#9198)

4d1c265d

Diff

@@ -15,9 +15,10 @@ import Mathlib.Mathport.Rename
 
 `Bundled c` provides a uniform structure for bundling a type equipped with a type class.
 
-We provide `Category` instances for these in `CategoryTheory/UnbundledHom.lean`
+We provide `Category` instances for these in `CategoryTheory/ConcreteCategory/UnbundledHom.lean`
 (for categories with unbundled homs, e.g. topological spaces)
-and in `CategoryTheory/BundledHom.lean` (for categories with bundled homs, e.g. monoids).
+and in `CategoryTheory/ConcreteCategory/BundledHom.lean`
+(for categories with bundled homs, e.g. monoids).
 -/
 
 universe u v

a148d797

chore: script to replace headers with #align_import statements (#5979)

depends on: #5966

Co-authored-by: Eric Wieser <wieser.eric@gmail.com> Co-authored-by: Scott Morrison <scott.morrison@gmail.com>

89aa3a3b

Diff

@@ -2,17 +2,14 @@
 Copyright (c) 2018 Scott Morrison. All rights reserved.
 Released under Apache 2.0 license as described in the file LICENSE.
 Authors: Scott Morrison, Johannes Hölzl, Reid Barton, Sean Leather
-
-! This file was ported from Lean 3 source module category_theory.concrete_category.bundled
-! leanprover-community/mathlib commit a148d797a1094ab554ad4183a4ad6f130358ef64
-! Please do not edit these lines, except to modify the commit id
-! if you have ported upstream changes.
 -/
 import Std.Tactic.Lint.Frontend
 import Std.Tactic.Lint.Misc
 import Std.Tactic.CoeExt
 import Mathlib.Mathport.Rename
 
+#align_import category_theory.concrete_category.bundled from "leanprover-community/mathlib"@"a148d797a1094ab554ad4183a4ad6f130358ef64"
+
 /-!
 # Bundled types

a148d797

chore: fix upper/lowercase in comments (#4360)

Run a non-interactive version of fix-comments.py on all files.
Go through the diff and manually add/discard/edit chunks.

27d257fc

Diff

@@ -46,7 +46,8 @@ attribute [coe] α
 -- that `c α` is a typeclass.
 set_option checkBinderAnnotations false in
 
--- Usually explicit instances will provide their own version of this, e.g. `Mon.of` and `Top.of`.
+-- Usually explicit instances will provide their own version of this, e.g. `MonCat.of` and
+-- `TopCat.of`.
 /-- A generic function for lifting a type equipped with an instance to a bundled object. -/
 def of {c : Type u → Type v} (α : Type u) [str : c α] : Bundled c :=
   ⟨α, str⟩

a148d797

chore: refactor of concrete categories (#3900)

I think the ports

https://github.com/leanprover-community/mathlib4/pull/2902 (MonCat)
https://github.com/leanprover-community/mathlib4/pull/3036 (GroupCat)
https://github.com/leanprover-community/mathlib4/pull/3260 (ModuleCat)

didn't quite get things right, and also have some variation between them. This PR tries to straighten things out.

Major changes:

Have the coercion to type be via X.\a, and put attribute @[coe] on this.

Make sure the coercion from morphisms to functions means that simp lemmas about the underlying bundled morphisms apply directly.

This means we drop lemmas like

lemma Hom.map_mul {X Y : MonCat} (f : X ⟶ Y) (x y : X) : ((forget MonCat).map f) (x * y) = f x * f y

But at the expense of adding lemmas like

lemma coe_comp {X Y Z : MonCat} {f : X ⟶ Y} {g : Y ⟶ Z} : (f ≫ g : X → Z) = g ∘ f := rfl

Overall I'm pretty happy, and it allows me to unstick the long stuck https://github.com/leanprover-community/mathlib4/pull/3105.

This is not everything I want to do to refactor these files, but once I was satisfied that I can move forward with RingCat, I want to get this merged so we can unblock porting progress. I'll promise to come back to this soon! :-)

Co-authored-by: Scott Morrison <scott.morrison@gmail.com> Co-authored-by: Scott Morrison <scott.morrison@anu.edu.au>

237c33e0

Diff

@@ -10,6 +10,7 @@ Authors: Scott Morrison, Johannes Hölzl, Reid Barton, Sean Leather
 -/
 import Std.Tactic.Lint.Frontend
 import Std.Tactic.Lint.Misc
+import Std.Tactic.CoeExt
 import Mathlib.Mathport.Rename
 
 /-!
@@ -39,6 +40,8 @@ structure Bundled (c : Type u → Type v) : Type max (u + 1) v where
 
 namespace Bundled
 
+attribute [coe] α
+
 -- This is needed so that we can ask for an instance of `c α` below even though Lean doesn't know
 -- that `c α` is a typeclass.
 set_option checkBinderAnnotations false in

a148d797

feat: port Topology.Category.Born (#2973)

Co-authored-by: Parcly Taxel <reddeloostw@gmail.com>

d01ce5bd

Diff

@@ -49,7 +49,7 @@ def of {c : Type u → Type v} (α : Type u) [str : c α] : Bundled c :=
   ⟨α, str⟩
 #align category_theory.bundled.of CategoryTheory.Bundled.of
 
-instance : CoeSort (Bundled c) (Type u) :=
+instance coeSort : CoeSort (Bundled c) (Type u) :=
   ⟨Bundled.α⟩
 
 theorem coe_mk (α) (str) : (@Bundled.mk c α str : Type u) = α :=

a148d797

chore: add missing #align statements (#1902)

This PR is the result of a slight variant on the following "algorithm"

take all mathlib 3 names, remove _ and make all uppercase letters into lowercase
take all mathlib 4 names, remove _ and make all uppercase letters into lowercase
look for matches, and create pairs (original_lean3_name, OriginalLean4Name)
for pairs that do not have an align statement:
- use Lean 4 to lookup the file + position of the Lean 4 name
- add an #align statement just before the next empty line
manually fix some tiny mistakes (e.g., empty lines in proofs might cause the #align statement to have been inserted too early)

b72bb858

Diff

@@ -10,6 +10,7 @@ Authors: Scott Morrison, Johannes Hölzl, Reid Barton, Sean Leather
 -/
 import Std.Tactic.Lint.Frontend
 import Std.Tactic.Lint.Misc
+import Mathlib.Mathport.Rename
 
 /-!
 # Bundled types
@@ -34,6 +35,7 @@ structure Bundled (c : Type u → Type v) : Type max (u + 1) v where
   α : Type u
   /-- The corresponding instance of the bundled type class -/
   str : c α := by infer_instance
+#align category_theory.bundled CategoryTheory.Bundled
 
 namespace Bundled
 
@@ -45,12 +47,14 @@ set_option checkBinderAnnotations false in
 /-- A generic function for lifting a type equipped with an instance to a bundled object. -/
 def of {c : Type u → Type v} (α : Type u) [str : c α] : Bundled c :=
   ⟨α, str⟩
+#align category_theory.bundled.of CategoryTheory.Bundled.of
 
 instance : CoeSort (Bundled c) (Type u) :=
   ⟨Bundled.α⟩
 
 theorem coe_mk (α) (str) : (@Bundled.mk c α str : Type u) = α :=
   rfl
+#align category_theory.bundled.coe_mk CategoryTheory.Bundled.coe_mk
 
 /-
 `Bundled.map` is reducible so that, if we define a category
@@ -67,6 +71,7 @@ Lean 4.
 /-- Map over the bundled structure -/
 def map (f : ∀ {α}, c α → d α) (b : Bundled c) : Bundled d :=
   ⟨b, f b.str⟩
+#align category_theory.bundled.map CategoryTheory.Bundled.map
 
 end Bundled

a148d797

chore: fix more casing errors per naming scheme (#1232)

I've avoided anything under Tactic or test.

In correcting the names, I found Option.isNone_iff_eq_none duplicated between Std and Mathlib, so the Mathlib one has been removed.

Co-authored-by: Reid Barton <rwbarton@gmail.com>

31a56f75

Diff

@@ -59,7 +59,7 @@ theorem coe_mk (α) (str) : (@Bundled.mk c α str : Type u) = α :=
 
 instance search is able to "see" that a morphism R ⟶ S in Ring is really
 a (semi)ring homomorphism from R.α to S.α, and not merely from
-`(Bundled.map @ring.to_semiring R).α` to `(Bundled.map @ring.to_semiring S).α`.
+`(Bundled.map @Ring.toSemiring R).α` to `(Bundled.map @Ring.toSemiring S).α`.
 
 TODO: Once at least one use of this has been ported, check if this still needs to be reducible in
 Lean 4.

a148d797

chore: add source headers to ported theory files (#1094)

The script used to do this is included. The yaml file was obtained from https://raw.githubusercontent.com/wiki/leanprover-community/mathlib/mathlib4-port-status.md

f168625e

Diff

@@ -2,6 +2,11 @@
 Copyright (c) 2018 Scott Morrison. All rights reserved.
 Released under Apache 2.0 license as described in the file LICENSE.
 Authors: Scott Morrison, Johannes Hölzl, Reid Barton, Sean Leather
+
+! This file was ported from Lean 3 source module category_theory.concrete_category.bundled
+! leanprover-community/mathlib commit a148d797a1094ab554ad4183a4ad6f130358ef64
+! Please do not edit these lines, except to modify the commit id
+! if you have ported upstream changes.
 -/
 import Std.Tactic.Lint.Frontend
 import Std.Tactic.Lint.Misc

`category_theory.concrete_category.bundled` ⟷ `Mathlib.CategoryTheory.ConcreteCategory.Bundled`

Changes since the initial port

Changes in mathlib3

Changes in mathlib3port

Changes in mathlib4

Dependencies

category_theory.concrete_category.bundled ⟷ Mathlib.CategoryTheory.ConcreteCategory.Bundled

Changes since the initial port

Changes in mathlib3

Changes in mathlib3port

Changes in mathlib4

Dependencies

`category_theory.concrete_category.bundled` ⟷ `Mathlib.CategoryTheory.ConcreteCategory.Bundled`