category_theory.concrete_category.bundled_hom

Changes since the initial port

The following section lists changes to this file in mathlib3 and mathlib4 that occured after the initial port. Most recent changes are shown first. Hovering over a commit will show all commits associated with the same mathlib3 commit.

Changes in mathlib3

77ca1ed3

(last sync)

Changes in mathlib3port

mathlib3

mathlib3port

93287238

bump to nightly-2024-04-29-08

mathlib commit https://github.com/leanprover-community/mathlib/commit/65a1391a0106c9204fe45bc73a039f056558cb83

6607d135

Diff

@@ -168,10 +168,10 @@ instance forget₂ (F : ∀ {α}, d α → c α) [ParentProjection @F] : HasForg
 #align category_theory.bundled_hom.forget₂ CategoryTheory.BundledHom.forget₂
 -/
 
-#print CategoryTheory.BundledHom.forget₂Full /-
-instance forget₂Full (F : ∀ {α}, d α → c α) [ParentProjection @F] :
+#print CategoryTheory.BundledHom.forget₂_full /-
+instance forget₂_full (F : ∀ {α}, d α → c α) [ParentProjection @F] :
     CategoryTheory.Functor.Full (forget₂ (Bundled d) (Bundled c)) where preimage X Y f := f
-#align category_theory.bundled_hom.forget₂_full CategoryTheory.BundledHom.forget₂Full
+#align category_theory.bundled_hom.forget₂_full CategoryTheory.BundledHom.forget₂_full
 -/
 
 end BundledHom

93287238

bump to nightly-2024-04-14-09

mathlib commit https://github.com/leanprover-community/mathlib/commit/65a1391a0106c9204fe45bc73a039f056558cb83

f736ea6b

Diff

@@ -170,7 +170,7 @@ instance forget₂ (F : ∀ {α}, d α → c α) [ParentProjection @F] : HasForg
 
 #print CategoryTheory.BundledHom.forget₂Full /-
 instance forget₂Full (F : ∀ {α}, d α → c α) [ParentProjection @F] :
-    Full (forget₂ (Bundled d) (Bundled c)) where preimage X Y f := f
+    CategoryTheory.Functor.Full (forget₂ (Bundled d) (Bundled c)) where preimage X Y f := f
 #align category_theory.bundled_hom.forget₂_full CategoryTheory.BundledHom.forget₂Full
 -/

93287238

bump to nightly-2024-01-17-06

mathlib commit https://github.com/leanprover-community/mathlib/commit/65a1391a0106c9204fe45bc73a039f056558cb83

8ba88f37

Diff

@@ -66,7 +66,7 @@ instance category : Category (Bundled c) := by
             comp_id' := _
             id_comp' := _
             assoc' := _ } <;> intros <;> apply 𝒞.hom_ext <;>
-    simp only [𝒞.id_to_fun, 𝒞.comp_to_fun, Function.left_id, Function.right_id]
+    simp only [𝒞.id_to_fun, 𝒞.comp_to_fun, Function.id_comp, Function.comp_id]
 #align category_theory.bundled_hom.category CategoryTheory.BundledHom.category
 -/

93287238

bump to nightly-2023-09-24-06

mathlib commit https://github.com/leanprover-community/mathlib/commit/ce64cd319bb6b3e82f31c2d38e79080d377be451

5655435f

Diff

@@ -3,8 +3,8 @@ Copyright (c) 2019 Scott Morrison. All rights reserved.
 Released under Apache 2.0 license as described in the file LICENSE.
 Authors: Scott Morrison, Yury Kudryashov
 -/
-import Mathbin.CategoryTheory.ConcreteCategory.Basic
-import Mathbin.CategoryTheory.ConcreteCategory.Bundled
+import CategoryTheory.ConcreteCategory.Basic
+import CategoryTheory.ConcreteCategory.Bundled
 
 #align_import category_theory.concrete_category.bundled_hom from "leanprover-community/mathlib"@"932872382355f00112641d305ba0619305dc8642"

93287238

bump to nightly-2023-07-20-09

mathlib commit https://github.com/leanprover-community/mathlib/commit/8ea5598db6caeddde6cb734aa179cc2408dbd345

9c56d0dd

Diff

@@ -2,15 +2,12 @@
 Copyright (c) 2019 Scott Morrison. All rights reserved.
 Released under Apache 2.0 license as described in the file LICENSE.
 Authors: Scott Morrison, Yury Kudryashov
-
-! This file was ported from Lean 3 source module category_theory.concrete_category.bundled_hom
-! leanprover-community/mathlib commit 932872382355f00112641d305ba0619305dc8642
-! Please do not edit these lines, except to modify the commit id
-! if you have ported upstream changes.
 -/
 import Mathbin.CategoryTheory.ConcreteCategory.Basic
 import Mathbin.CategoryTheory.ConcreteCategory.Bundled
 
+#align_import category_theory.concrete_category.bundled_hom from "leanprover-community/mathlib"@"932872382355f00112641d305ba0619305dc8642"
+
 /-!
 # Category instances for algebraic structures that use bundled homs.

93287238

bump to nightly-2023-06-13-21

mathlib commit https://github.com/leanprover-community/mathlib/commit/9fb8964792b4237dac6200193a0d533f1b3f7423

829520ac

Diff

@@ -56,8 +56,6 @@ namespace BundledHom
 
 variable [𝒞 : BundledHom hom]
 
-include 𝒞
-
 #print CategoryTheory.BundledHom.category /-
 /-- Every `@bundled_hom c _` defines a category with objects in `bundled c`.
 
@@ -96,6 +94,7 @@ variable {hom}
 
 attribute [local instance] concrete_category.has_coe_to_fun
 
+#print CategoryTheory.BundledHom.mkHasForget₂ /-
 /-- A version of `has_forget₂.mk'` for categories defined using `@bundled_hom`. -/
 def mkHasForget₂ {d : Type u → Type u} {hom_d : ∀ ⦃α β : Type u⦄ (Iα : d α) (Iβ : d β), Type u}
     [BundledHom hom_d] (obj : ∀ ⦃α⦄, c α → d α)
@@ -105,6 +104,7 @@ def mkHasForget₂ {d : Type u → Type u} {hom_d : ∀ ⦃α β : Type u⦄ (I
   HasForget₂.mk' (Bundled.map @obj) (fun _ => rfl) (@map)
     (by intros <;> apply hEq_of_eq <;> apply h_map)
 #align category_theory.bundled_hom.mk_has_forget₂ CategoryTheory.BundledHom.mkHasForget₂
+-/
 
 variable {d : Type u → Type u}
 
@@ -112,8 +112,6 @@ variable (hom)
 
 section
 
-omit 𝒞
-
 #print CategoryTheory.BundledHom.MapHom /-
 /-- The `hom` corresponding to first forgetting along `F`, then taking the `hom` associated to `c`.
 
@@ -142,8 +140,6 @@ def map (F : ∀ {α}, d α → c α) : BundledHom (MapHom hom @F)
 
 section
 
-omit 𝒞
-
 #print CategoryTheory.BundledHom.ParentProjection /-
 /-- We use the empty `parent_projection` class to label functions like `comm_monoid.to_monoid`,
 which we would like to use to automatically construct `bundled_hom` instances from.
@@ -167,11 +163,13 @@ instance bundledHomOfParentProjection (F : ∀ {α}, d α → c α) [ParentProje
 #align category_theory.bundled_hom.bundled_hom_of_parent_projection CategoryTheory.BundledHom.bundledHomOfParentProjection
 -/
 
+#print CategoryTheory.BundledHom.forget₂ /-
 instance forget₂ (F : ∀ {α}, d α → c α) [ParentProjection @F] : HasForget₂ (Bundled d) (Bundled c)
     where forget₂ :=
     { obj := fun X => ⟨X, F X.2⟩
       map := fun X Y f => f }
 #align category_theory.bundled_hom.forget₂ CategoryTheory.BundledHom.forget₂
+-/
 
 #print CategoryTheory.BundledHom.forget₂Full /-
 instance forget₂Full (F : ∀ {α}, d α → c α) [ParentProjection @F] :

93287238

bump to nightly-2023-06-11-17

mathlib commit https://github.com/leanprover-community/mathlib/commit/c471da714c044131b90c133701e51b877c246677

e85a8bfe

Diff

@@ -96,7 +96,6 @@ variable {hom}
 
 attribute [local instance] concrete_category.has_coe_to_fun
 
-#print CategoryTheory.BundledHom.mkHasForget₂ /-
 /-- A version of `has_forget₂.mk'` for categories defined using `@bundled_hom`. -/
 def mkHasForget₂ {d : Type u → Type u} {hom_d : ∀ ⦃α β : Type u⦄ (Iα : d α) (Iβ : d β), Type u}
     [BundledHom hom_d] (obj : ∀ ⦃α⦄, c α → d α)
@@ -106,7 +105,6 @@ def mkHasForget₂ {d : Type u → Type u} {hom_d : ∀ ⦃α β : Type u⦄ (I
   HasForget₂.mk' (Bundled.map @obj) (fun _ => rfl) (@map)
     (by intros <;> apply hEq_of_eq <;> apply h_map)
 #align category_theory.bundled_hom.mk_has_forget₂ CategoryTheory.BundledHom.mkHasForget₂
--/
 
 variable {d : Type u → Type u}
 
@@ -169,13 +167,11 @@ instance bundledHomOfParentProjection (F : ∀ {α}, d α → c α) [ParentProje
 #align category_theory.bundled_hom.bundled_hom_of_parent_projection CategoryTheory.BundledHom.bundledHomOfParentProjection
 -/
 
-#print CategoryTheory.BundledHom.forget₂ /-
 instance forget₂ (F : ∀ {α}, d α → c α) [ParentProjection @F] : HasForget₂ (Bundled d) (Bundled c)
     where forget₂ :=
     { obj := fun X => ⟨X, F X.2⟩
       map := fun X Y f => f }
 #align category_theory.bundled_hom.forget₂ CategoryTheory.BundledHom.forget₂
--/
 
 #print CategoryTheory.BundledHom.forget₂Full /-
 instance forget₂Full (F : ∀ {α}, d α → c α) [ParentProjection @F] :

93287238

bump to nightly-2023-03-19-03

mathlib commit https://github.com/leanprover-community/mathlib/commit/1f4705ccdfe1e557fc54a0ce081a05e33d2e6240

b19efad4

Diff

@@ -4,7 +4,7 @@ Released under Apache 2.0 license as described in the file LICENSE.
 Authors: Scott Morrison, Yury Kudryashov
 
 ! This file was ported from Lean 3 source module category_theory.concrete_category.bundled_hom
-! leanprover-community/mathlib commit 77ca1ed347337ecbafa9d9f4a55e330e44e9f9f8
+! leanprover-community/mathlib commit 932872382355f00112641d305ba0619305dc8642
 ! Please do not edit these lines, except to modify the commit id
 ! if you have ported upstream changes.
 -/
@@ -14,6 +14,9 @@ import Mathbin.CategoryTheory.ConcreteCategory.Bundled
 /-!
 # Category instances for algebraic structures that use bundled homs.
 
+> THIS FILE IS SYNCHRONIZED WITH MATHLIB4.
+> Any changes to this file require a corresponding PR to mathlib4.
+
 Many algebraic structures in Lean initially used unbundled homs (e.g. a bare function between types,
 along with an `is_monoid_hom` typeclass), but the general trend is towards using bundled homs.

77ca1ed3

bump to nightly-2023-03-17-20

mathlib commit https://github.com/leanprover-community/mathlib/commit/da3fc4a33ff6bc75f077f691dc94c217b8d41559

4420e8a1

Diff

@@ -28,6 +28,7 @@ namespace CategoryTheory
 
 variable {c : Type u → Type u} (hom : ∀ ⦃α β : Type u⦄ (Iα : c α) (Iβ : c β), Type u)
 
+#print CategoryTheory.BundledHom /-
 /-- Class for bundled homs. Note that the arguments order follows that of lemmas for `monoid_hom`.
 This way we can use `⟨@monoid_hom.to_fun, @monoid_hom.id ...⟩` in an instance. -/
 structure BundledHom where
@@ -42,6 +43,7 @@ structure BundledHom where
       to_fun Iα Iγ (comp Iα Iβ Iγ g f) = to_fun Iβ Iγ g ∘ to_fun Iα Iβ f := by
     obviously
 #align category_theory.bundled_hom CategoryTheory.BundledHom
+-/
 
 attribute [class] bundled_hom
 
@@ -53,6 +55,7 @@ variable [𝒞 : BundledHom hom]
 
 include 𝒞
 
+#print CategoryTheory.BundledHom.category /-
 /-- Every `@bundled_hom c _` defines a category with objects in `bundled c`.
 
 This instance generates the type-class problem `bundled_hom ?m` (which is why this is marked as
@@ -67,7 +70,9 @@ instance category : Category (Bundled c) := by
             assoc' := _ } <;> intros <;> apply 𝒞.hom_ext <;>
     simp only [𝒞.id_to_fun, 𝒞.comp_to_fun, Function.left_id, Function.right_id]
 #align category_theory.bundled_hom.category CategoryTheory.BundledHom.category
+-/
 
+#print CategoryTheory.BundledHom.concreteCategory /-
 /-- A category given by `bundled_hom` is a concrete category.
 
 This instance generates the type-class problem `bundled_hom ?m` (which is why this is marked as
@@ -82,11 +87,13 @@ instance concreteCategory : ConcreteCategory.{u} (Bundled c)
       map_comp' := by intros <;> erw [𝒞.comp_to_fun] <;> rfl }
   forget_faithful := { map_injective' := by intros <;> apply 𝒞.hom_ext }
 #align category_theory.bundled_hom.concrete_category CategoryTheory.BundledHom.concreteCategory
+-/
 
 variable {hom}
 
 attribute [local instance] concrete_category.has_coe_to_fun
 
+#print CategoryTheory.BundledHom.mkHasForget₂ /-
 /-- A version of `has_forget₂.mk'` for categories defined using `@bundled_hom`. -/
 def mkHasForget₂ {d : Type u → Type u} {hom_d : ∀ ⦃α β : Type u⦄ (Iα : d α) (Iβ : d β), Type u}
     [BundledHom hom_d] (obj : ∀ ⦃α⦄, c α → d α)
@@ -96,6 +103,7 @@ def mkHasForget₂ {d : Type u → Type u} {hom_d : ∀ ⦃α β : Type u⦄ (I
   HasForget₂.mk' (Bundled.map @obj) (fun _ => rfl) (@map)
     (by intros <;> apply hEq_of_eq <;> apply h_map)
 #align category_theory.bundled_hom.mk_has_forget₂ CategoryTheory.BundledHom.mkHasForget₂
+-/
 
 variable {d : Type u → Type u}
 
@@ -105,6 +113,7 @@ section
 
 omit 𝒞
 
+#print CategoryTheory.BundledHom.MapHom /-
 /-- The `hom` corresponding to first forgetting along `F`, then taking the `hom` associated to `c`.
 
 For typical usage, see the construction of `CommMon` from `Mon`.
@@ -113,9 +122,11 @@ For typical usage, see the construction of `CommMon` from `Mon`.
 def MapHom (F : ∀ {α}, d α → c α) : ∀ ⦃α β : Type u⦄ (Iα : d α) (Iβ : d β), Type u :=
   fun α β iα iβ => hom (F iα) (F iβ)
 #align category_theory.bundled_hom.map_hom CategoryTheory.BundledHom.MapHom
+-/
 
 end
 
+#print CategoryTheory.BundledHom.map /-
 /-- Construct the `bundled_hom` induced by a map between type classes.
 This is useful for building categories such as `CommMon` from `Mon`.
 -/
@@ -126,11 +137,13 @@ def map (F : ∀ {α}, d α → c α) : BundledHom (MapHom hom @F)
   comp α β γ iα iβ iγ f g := 𝒞.comp (F iα) (F iβ) (F iγ) f g
   hom_ext α β iα iβ f g h := 𝒞.hom_ext (F iα) (F iβ) h
 #align category_theory.bundled_hom.map CategoryTheory.BundledHom.map
+-/
 
 section
 
 omit 𝒞
 
+#print CategoryTheory.BundledHom.ParentProjection /-
 /-- We use the empty `parent_projection` class to label functions like `comm_monoid.to_monoid`,
 which we would like to use to automatically construct `bundled_hom` instances from.
 
@@ -140,25 +153,32 @@ this allows us to set up `CommMon` by defining an instance
 -/
 class ParentProjection (F : ∀ {α}, d α → c α)
 #align category_theory.bundled_hom.parent_projection CategoryTheory.BundledHom.ParentProjection
+-/
 
 end
 
+#print CategoryTheory.BundledHom.bundledHomOfParentProjection /-
 -- The `parent_projection` typeclass is just a marker, so won't be used.
 @[nolint unused_arguments]
 instance bundledHomOfParentProjection (F : ∀ {α}, d α → c α) [ParentProjection @F] :
     BundledHom (MapHom hom @F) :=
   map hom @F
 #align category_theory.bundled_hom.bundled_hom_of_parent_projection CategoryTheory.BundledHom.bundledHomOfParentProjection
+-/
 
+#print CategoryTheory.BundledHom.forget₂ /-
 instance forget₂ (F : ∀ {α}, d α → c α) [ParentProjection @F] : HasForget₂ (Bundled d) (Bundled c)
     where forget₂ :=
     { obj := fun X => ⟨X, F X.2⟩
       map := fun X Y f => f }
 #align category_theory.bundled_hom.forget₂ CategoryTheory.BundledHom.forget₂
+-/
 
+#print CategoryTheory.BundledHom.forget₂Full /-
 instance forget₂Full (F : ∀ {α}, d α → c α) [ParentProjection @F] :
     Full (forget₂ (Bundled d) (Bundled c)) where preimage X Y f := f
 #align category_theory.bundled_hom.forget₂_full CategoryTheory.BundledHom.forget₂Full
+-/
 
 end BundledHom

77ca1ed3

bump to nightly-2023-02-21-16

mathlib commit https://github.com/leanprover-community/mathlib/commit/bd9851ca476957ea4549eb19b40e7b5ade9428cc

1107b979

Changes in mathlib4

mathlib3

mathlib4

77ca1ed3

chore(CategoryTheory): make Functor.Full a Prop (#12449)

Before this PR, Functor.Full contained the data of the preimage of maps by a full functor F. This PR makes Functor.Full a proposition. This is to prevent any diamond to appear.

The lemma Functor.image_preimage is also renamed Functor.map_preimage.

Co-authored-by: Joël Riou <37772949+joelriou@users.noreply.github.com>

ce289a0e

Diff

@@ -151,9 +151,10 @@ instance forget₂ (F : ∀ {α}, d α → c α) [ParentProjection @F] :
       map := @fun X Y f => f }
 #align category_theory.bundled_hom.forget₂ CategoryTheory.BundledHom.forget₂
 
-instance forget₂Full (F : ∀ {α}, d α → c α) [ParentProjection @F] :
-    Functor.Full (CategoryTheory.forget₂ (Bundled d) (Bundled c)) where preimage X Y {f} := f
-#align category_theory.bundled_hom.forget₂_full CategoryTheory.BundledHom.forget₂Full
+instance forget₂_full (F : ∀ {α}, d α → c α) [ParentProjection @F] :
+    Functor.Full (CategoryTheory.forget₂ (Bundled d) (Bundled c)) where
+  map_surjective f := ⟨f, rfl⟩
+#align category_theory.bundled_hom.forget₂_full CategoryTheory.BundledHom.forget₂_full
 
 end BundledHom

77ca1ed3

chore(CategoryTheory): move Full, Faithful, EssSurj, IsEquivalence and ReflectsIsomorphisms to the Functor namespace (#11985)

These notions on functors are now Functor.Full, Functor.Faithful, Functor.EssSurj, Functor.IsEquivalence, Functor.ReflectsIsomorphisms. Deprecated aliases are introduced for the previous names.

65b7affc

Diff

@@ -152,7 +152,7 @@ instance forget₂ (F : ∀ {α}, d α → c α) [ParentProjection @F] :
 #align category_theory.bundled_hom.forget₂ CategoryTheory.BundledHom.forget₂
 
 instance forget₂Full (F : ∀ {α}, d α → c α) [ParentProjection @F] :
-    Full (CategoryTheory.forget₂ (Bundled d) (Bundled c)) where preimage X Y {f} := f
+    Functor.Full (CategoryTheory.forget₂ (Bundled d) (Bundled c)) where preimage X Y {f} := f
 #align category_theory.bundled_hom.forget₂_full CategoryTheory.BundledHom.forget₂Full
 
 end BundledHom

77ca1ed3

chore(*): remove empty lines between variable statements (#11418)

Empty lines were removed by executing the following Python script twice

import os
import re


# Loop through each file in the repository
for dir_path, dirs, files in os.walk('.'):
  for filename in files:
    if filename.endswith('.lean'):
      file_path = os.path.join(dir_path, filename)

      # Open the file and read its contents
      with open(file_path, 'r') as file:
        content = file.read()

      # Use a regular expression to replace sequences of "variable" lines separated by empty lines
      # with sequences without empty lines
      modified_content = re.sub(r'(variable.*\n)\n(variable(?! .* in))', r'\1\2', content)

      # Write the modified content back to the file
      with open(file_path, 'w') as file:
        file.write(modified_content)

75c86f04

Diff

@@ -97,7 +97,6 @@ def mkHasForget₂ {d : Type u → Type u} {hom_d : ∀ ⦃α β : Type u⦄ (_
 #align category_theory.bundled_hom.mk_has_forget₂ CategoryTheory.BundledHom.mkHasForget₂
 
 variable {d : Type u → Type u}
-
 variable (hom)
 
 section

77ca1ed3

chore: remove useless include and omit porting notes (#10503)

625e2ac8

Diff

@@ -54,9 +54,6 @@ namespace BundledHom
 
 variable [𝒞 : BundledHom hom]
 
--- porting note: include not needed
--- include 𝒞
-
 set_option synthInstance.checkSynthOrder false in
 /-- Every `@BundledHom c _` defines a category with objects in `Bundled c`.
 
@@ -105,9 +102,6 @@ variable (hom)
 
 section
 
--- porting note: commented out
--- omit 𝒞
-
 /-- The `hom` corresponding to first forgetting along `F`, then taking the `hom` associated to `c`.
 
 For typical usage, see the construction of `CommMonCat` from `MonCat`.
@@ -132,9 +126,6 @@ def map (F : ∀ {α}, d α → c α) : BundledHom (MapHom hom @F)
 
 section
 
--- porting note: commented out
---omit 𝒞
-
 /-- We use the empty `ParentProjection` class to label functions like `CommMonoid.toMonoid`,
 which we would like to use to automatically construct `BundledHom` instances from.

77ca1ed3

refactor(*): abbreviation for non-dependent FunLike (#9833)

This follows up from #9785, which renamed FunLike to DFunLike, by introducing a new abbreviation FunLike F α β := DFunLike F α (fun _ => β), to make the non-dependent use of FunLike easier.

I searched for the pattern DFunLike.*fun and DFunLike.*λ in all files to replace expressions of the form DFunLike F α (fun _ => β) with FunLike F α β. I did this everywhere except for extends clauses for two reasons: it would conflict with #8386, and more importantly extends must directly refer to a structure with no unfolding of defs or abbrevs.

54792e9e

Diff

@@ -86,7 +86,7 @@ instance concreteCategory : ConcreteCategory.{u} (Bundled c)
 
 variable {hom}
 
-attribute [local instance] ConcreteCategory.instDFunLike
+attribute [local instance] ConcreteCategory.instFunLike
 
 /-- A version of `HasForget₂.mk'` for categories defined using `@BundledHom`. -/
 def mkHasForget₂ {d : Type u → Type u} {hom_d : ∀ ⦃α β : Type u⦄ (_ : d α) (_ : d β), Type u}

77ca1ed3

chore(*): rename FunLike to DFunLike (#9785)

This prepares for the introduction of a non-dependent synonym of FunLike, which helps a lot with keeping #8386 readable.

This is entirely search-and-replace in 680197f combined with manual fixes in 4145626, e900597 and b8428f8. The commands that generated this change:

sed -i 's/\bFunLike\b/DFunLike/g' {Archive,Counterexamples,Mathlib,test}/**/*.lean
sed -i 's/\btoFunLike\b/toDFunLike/g' {Archive,Counterexamples,Mathlib,test}/**/*.lean
sed -i 's/import Mathlib.Data.DFunLike/import Mathlib.Data.FunLike/g' {Archive,Counterexamples,Mathlib,test}/**/*.lean
sed -i 's/\bHom_FunLike\b/Hom_DFunLike/g' {Archive,Counterexamples,Mathlib,test}/**/*.lean     
sed -i 's/\binstFunLike\b/instDFunLike/g' {Archive,Counterexamples,Mathlib,test}/**/*.lean
sed -i 's/\bfunLike\b/instDFunLike/g' {Archive,Counterexamples,Mathlib,test}/**/*.lean
sed -i 's/\btoo many metavariables to apply `fun_like.has_coe_to_fun`/too many metavariables to apply `DFunLike.hasCoeToFun`/g' {Archive,Counterexamples,Mathlib,test}/**/*.lean

Co-authored-by: Anne Baanen <Vierkantor@users.noreply.github.com>

82656743

Diff

@@ -86,7 +86,7 @@ instance concreteCategory : ConcreteCategory.{u} (Bundled c)
 
 variable {hom}
 
-attribute [local instance] ConcreteCategory.funLike
+attribute [local instance] ConcreteCategory.instDFunLike
 
 /-- A version of `HasForget₂.mk'` for categories defined using `@BundledHom`. -/
 def mkHasForget₂ {d : Type u → Type u} {hom_d : ∀ ⦃α β : Type u⦄ (_ : d α) (_ : d β), Type u}

77ca1ed3

fix: correct precedence for coercion arrows (#8297)

The new precedences match coeNotation in core:

syntax:1024 (name := coeNotation) "↑" term:1024 : term

They also match the precedence in Lean 3.

332340d8

Diff

@@ -92,7 +92,7 @@ attribute [local instance] ConcreteCategory.funLike
 def mkHasForget₂ {d : Type u → Type u} {hom_d : ∀ ⦃α β : Type u⦄ (_ : d α) (_ : d β), Type u}
     [BundledHom hom_d] (obj : ∀ ⦃α⦄, c α → d α)
     (map : ∀ {X Y : Bundled c}, (X ⟶ Y) → (Bundled.map @obj X ⟶ (Bundled.map @obj Y)))
-    (h_map : ∀ {X Y : Bundled c} (f : X ⟶ Y), ⇑map f = ⇑f) :
+    (h_map : ∀ {X Y : Bundled c} (f : X ⟶ Y), ⇑(map f) = ⇑f) :
     HasForget₂ (Bundled c) (Bundled d) :=
   HasForget₂.mk' (Bundled.map @obj) (fun _ => rfl) map (by
     intros X Y f

77ca1ed3

style: fix wrapping of where (#7149)

084cfb35

Diff

@@ -154,8 +154,9 @@ instance bundledHomOfParentProjection (F : ∀ {α}, d α → c α) [ParentProje
   map hom @F
 #align category_theory.bundled_hom.bundled_hom_of_parent_projection CategoryTheory.BundledHom.bundledHomOfParentProjection
 
-instance forget₂ (F : ∀ {α}, d α → c α) [ParentProjection @F] : HasForget₂ (Bundled d) (Bundled c)
-    where forget₂ :=
+instance forget₂ (F : ∀ {α}, d α → c α) [ParentProjection @F] :
+    HasForget₂ (Bundled d) (Bundled c) where
+  forget₂ :=
     { obj := fun X => ⟨X, F X.2⟩
       map := @fun X Y f => f }
 #align category_theory.bundled_hom.forget₂ CategoryTheory.BundledHom.forget₂

77ca1ed3

feat: Linter that checks that Prop classes are Props (#6148)

930dd29d

Diff

@@ -142,7 +142,7 @@ Once we've set up `MonCat` as the category of bundled monoids,
 this allows us to set up `CommMonCat` by defining an instance
 ```instance : ParentProjection (CommMonoid.toMonoid) := ⟨⟩```
 -/
-class ParentProjection (F : ∀ {α}, d α → c α)
+class ParentProjection (F : ∀ {α}, d α → c α) : Prop
 #align category_theory.bundled_hom.parent_projection CategoryTheory.BundledHom.ParentProjection
 
 end

77ca1ed3

chore: script to replace headers with #align_import statements (#5979)

depends on: #5966

Co-authored-by: Eric Wieser <wieser.eric@gmail.com> Co-authored-by: Scott Morrison <scott.morrison@gmail.com>

89aa3a3b

Diff

@@ -2,15 +2,12 @@
 Copyright (c) 2019 Scott Morrison. All rights reserved.
 Released under Apache 2.0 license as described in the file LICENSE.
 Authors: Scott Morrison, Yury Kudryashov
-
-! This file was ported from Lean 3 source module category_theory.concrete_category.bundled_hom
-! leanprover-community/mathlib commit 77ca1ed347337ecbafa9d9f4a55e330e44e9f9f8
-! Please do not edit these lines, except to modify the commit id
-! if you have ported upstream changes.
 -/
 import Mathlib.CategoryTheory.ConcreteCategory.Basic
 import Mathlib.CategoryTheory.ConcreteCategory.Bundled
 
+#align_import category_theory.concrete_category.bundled_hom from "leanprover-community/mathlib"@"77ca1ed347337ecbafa9d9f4a55e330e44e9f9f8"
+
 /-!
 # Category instances for algebraic structures that use bundled homs.

77ca1ed3

feat: change ConcreteCategory.hasCoeToFun to FunLike (#4693)

b7cba33a

Diff

@@ -89,7 +89,7 @@ instance concreteCategory : ConcreteCategory.{u} (Bundled c)
 
 variable {hom}
 
-attribute [local instance] ConcreteCategory.hasCoeToFun
+attribute [local instance] ConcreteCategory.funLike
 
 /-- A version of `HasForget₂.mk'` for categories defined using `@BundledHom`. -/
 def mkHasForget₂ {d : Type u → Type u} {hom_d : ∀ ⦃α β : Type u⦄ (_ : d α) (_ : d β), Type u}
@@ -99,7 +99,7 @@ def mkHasForget₂ {d : Type u → Type u} {hom_d : ∀ ⦃α β : Type u⦄ (_
     HasForget₂ (Bundled c) (Bundled d) :=
   HasForget₂.mk' (Bundled.map @obj) (fun _ => rfl) map (by
     intros X Y f
-    rw [heq_eq_eq, h_map])
+    rw [heq_eq_eq, forget_map_eq_coe, forget_map_eq_coe, h_map f])
 #align category_theory.bundled_hom.mk_has_forget₂ CategoryTheory.BundledHom.mkHasForget₂
 
 variable {d : Type u → Type u}

77ca1ed3

chore: fix upper/lowercase in comments (#4360)

Run a non-interactive version of fix-comments.py on all files.
Go through the diff and manually add/discard/edit chunks.

27d257fc

Diff

@@ -113,7 +113,7 @@ section
 
 /-- The `hom` corresponding to first forgetting along `F`, then taking the `hom` associated to `c`.
 
-For typical usage, see the construction of `CommMon` from `Mon`.
+For typical usage, see the construction of `CommMonCat` from `MonCat`.
 -/
 @[reducible]
 def MapHom (F : ∀ {α}, d α → c α) : ∀ ⦃α β : Type u⦄ (_ : d α) (_ : d β), Type u :=
@@ -123,7 +123,7 @@ def MapHom (F : ∀ {α}, d α → c α) : ∀ ⦃α β : Type u⦄ (_ : d α) (
 end
 
 /-- Construct the `CategoryTheory.BundledHom` induced by a map between type classes.
-This is useful for building categories such as `CommMon` from `Mon`.
+This is useful for building categories such as `CommMonCat` from `MonCat`.
 -/
 def map (F : ∀ {α}, d α → c α) : BundledHom (MapHom hom @F)
     where
@@ -141,8 +141,8 @@ section
 /-- We use the empty `ParentProjection` class to label functions like `CommMonoid.toMonoid`,
 which we would like to use to automatically construct `BundledHom` instances from.
 
-Once we've set up `Mon` as the category of bundled monoids,
-this allows us to set up `CommMon` by defining an instance
+Once we've set up `MonCat` as the category of bundled monoids,
+this allows us to set up `CommMonCat` by defining an instance
 ```instance : ParentProjection (CommMonoid.toMonoid) := ⟨⟩```
 -/
 class ParentProjection (F : ∀ {α}, d α → c α)

77ca1ed3

chore: refactor of concrete categories (#3900)

I think the ports

https://github.com/leanprover-community/mathlib4/pull/2902 (MonCat)
https://github.com/leanprover-community/mathlib4/pull/3036 (GroupCat)
https://github.com/leanprover-community/mathlib4/pull/3260 (ModuleCat)

didn't quite get things right, and also have some variation between them. This PR tries to straighten things out.

Major changes:

Have the coercion to type be via X.\a, and put attribute @[coe] on this.

Make sure the coercion from morphisms to functions means that simp lemmas about the underlying bundled morphisms apply directly.

This means we drop lemmas like

lemma Hom.map_mul {X Y : MonCat} (f : X ⟶ Y) (x y : X) : ((forget MonCat).map f) (x * y) = f x * f y

But at the expense of adding lemmas like

lemma coe_comp {X Y Z : MonCat} {f : X ⟶ Y} {g : Y ⟶ Z} : (f ≫ g : X → Z) = g ∘ f := rfl

Overall I'm pretty happy, and it allows me to unstick the long stuck https://github.com/leanprover-community/mathlib4/pull/3105.

This is not everything I want to do to refactor these files, but once I was satisfied that I can move forward with RingCat, I want to get this merged so we can unblock porting progress. I'll promise to come back to this soon! :-)

Co-authored-by: Scott Morrison <scott.morrison@gmail.com> Co-authored-by: Scott Morrison <scott.morrison@anu.edu.au>

237c33e0

Diff

@@ -79,7 +79,7 @@ instance category : Category (Bundled c) := by
 /-- A category given by `BundledHom` is a concrete category. -/
 instance concreteCategory : ConcreteCategory.{u} (Bundled c)
     where
-  Forget :=
+  forget :=
     { obj := fun X => X
       map := @fun X Y f => 𝒞.toFun X.str Y.str f
       map_id := fun X => 𝒞.id_toFun X.str

77ca1ed3

chore: bump to nightly-2023-04-11 (#3139)

1cd8b316

Diff

@@ -60,11 +60,12 @@ variable [𝒞 : BundledHom hom]
 -- porting note: include not needed
 -- include 𝒞
 
+set_option synthInstance.checkSynthOrder false in
 /-- Every `@BundledHom c _` defines a category with objects in `Bundled c`.
 
-This instance generates the type-class problem `BundledHom ?m` (which is why this is marked as
-`[nolint]`). Currently that is not a problem, as there are almost no instances of `BundledHom`. -/
-@[nolint dangerousInstance]
+This instance generates the type-class problem `BundledHom ?m`.
+Currently that is not a problem, as there are almost no instances of `BundledHom`.
+-/
 instance category : Category (Bundled c) := by
   refine' { Hom := fun X Y => @hom X Y X.str Y.str
             id := fun X => @BundledHom.id c hom 𝒞 X X.str
@@ -75,11 +76,7 @@ instance category : Category (Bundled c) := by
     aesop_cat
 #align category_theory.bundled_hom.category CategoryTheory.BundledHom.category
 
-/-- A category given by `BundledHom` is a concrete category.
-
-This instance generates the type-class problem `BundledHom ?m` (which is why this is marked as
-`[nolint]`). Currently that is not a problem, as there are almost no instances of `BundledHom`. -/
-@[nolint dangerousInstance]
+/-- A category given by `BundledHom` is a concrete category. -/
 instance concreteCategory : ConcreteCategory.{u} (Bundled c)
     where
   Forget :=

77ca1ed3

feat: port CategoryTheory.ConcreteCategory.BundledHom (#2740)

Co-authored-by: Moritz Firsching <firsching@google.com> Co-authored-by: Joël Riou <joel.riou@universite-paris-saclay.fr>

530cf1f3

`category_theory.concrete_category.bundled_hom` ⟷ `Mathlib.CategoryTheory.ConcreteCategory.BundledHom`

Changes since the initial port

Changes in mathlib3

Changes in mathlib3port

Changes in mathlib4

Dependencies 114

category_theory.concrete_category.bundled_hom ⟷ Mathlib.CategoryTheory.ConcreteCategory.BundledHom

Changes since the initial port

Changes in mathlib3

Changes in mathlib3port

Changes in mathlib4

Dependencies 114

`category_theory.concrete_category.bundled_hom` ⟷ `Mathlib.CategoryTheory.ConcreteCategory.BundledHom`