control.bifunctor | Mathlib porting status

Changes since the initial port

The following section lists changes to this file in mathlib3 and mathlib4 that occured after the initial port. Most recent changes are shown first. Hovering over a commit will show all commits associated with the same mathlib3 commit.

Changes in mathlib3

dc1525fb

(last sync)

Changes in mathlib3port

mathlib3

mathlib3port

69c6a5a1

bump to nightly-2023-09-24-06

mathlib commit https://github.com/leanprover-community/mathlib/commit/ce64cd319bb6b3e82f31c2d38e79080d377be451

5655435f

Diff

@@ -3,8 +3,8 @@ Copyright (c) 2018 Simon Hudon. All rights reserved.
 Released under Apache 2.0 license as described in the file LICENSE.
 Authors: Simon Hudon
 -/
-import Mathbin.Control.Functor
-import Mathbin.Data.Sum.Basic
+import Control.Functor
+import Data.Sum.Basic
 
 #align_import control.bifunctor from "leanprover-community/mathlib"@"69c6a5a12d8a2b159f20933e60115a4f2de62b58"

69c6a5a1

bump to nightly-2023-07-20-09

mathlib commit https://github.com/leanprover-community/mathlib/commit/8ea5598db6caeddde6cb734aa179cc2408dbd345

9c56d0dd

Diff

@@ -2,15 +2,12 @@
 Copyright (c) 2018 Simon Hudon. All rights reserved.
 Released under Apache 2.0 license as described in the file LICENSE.
 Authors: Simon Hudon
-
-! This file was ported from Lean 3 source module control.bifunctor
-! leanprover-community/mathlib commit 69c6a5a12d8a2b159f20933e60115a4f2de62b58
-! Please do not edit these lines, except to modify the commit id
-! if you have ported upstream changes.
 -/
 import Mathbin.Control.Functor
 import Mathbin.Data.Sum.Basic
 
+#align_import control.bifunctor from "leanprover-community/mathlib"@"69c6a5a12d8a2b159f20933e60115a4f2de62b58"
+
 /-!
 # Functors with two arguments

69c6a5a1

bump to nightly-2023-06-01-16

mathlib commit https://github.com/leanprover-community/mathlib/commit/cca40788df1b8755d5baf17ab2f27dacc2e17acb

b9c87c70

Diff

@@ -126,8 +126,8 @@ theorem comp_snd {α β₀ β₁ β₂} (g : β₀ → β₁) (g' : β₁ → β
 #align bifunctor.comp_snd Bifunctor.comp_snd
 -/
 
-attribute [functor_norm]
-  bimap_bimap comp_snd comp_fst snd_comp_snd snd_comp_fst fst_comp_snd fst_comp_fst bimap_comp_bimap bimap_id_id fst_id snd_id
+attribute [functor_norm] bimap_bimap comp_snd comp_fst snd_comp_snd snd_comp_fst fst_comp_snd
+  fst_comp_fst bimap_comp_bimap bimap_id_id fst_id snd_id
 
 end Bifunctor

69c6a5a1

bump to nightly-2023-05-19-16

mathlib commit https://github.com/leanprover-community/mathlib/commit/95a87616d63b3cb49d3fe678d416fbe9c4217bf4

a31df521

Diff

@@ -56,9 +56,9 @@ class LawfulBifunctor (F : Type u₀ → Type u₁ → Type u₂) [Bifunctor F]
 
 export LawfulBifunctor (id_bimap bimap_bimap)
 
-attribute [higher_order.1bimap_id_id] id_bimap
+attribute [higher_order bimap_id_id] id_bimap
 
-attribute [higher_order.1bimap_comp_bimap] bimap_bimap
+attribute [higher_order bimap_comp_bimap] bimap_bimap
 
 export LawfulBifunctor (bimap_id_id bimap_comp_bimap)
 
@@ -85,42 +85,42 @@ def snd {α β β'} (f : β → β') : F α β → F α β' :=
 variable [LawfulBifunctor F]
 
 #print Bifunctor.id_fst /-
-@[higher_order.1fst_id]
+@[higher_order fst_id]
 theorem id_fst : ∀ {α β} (x : F α β), fst id x = x :=
   @id_bimap _ _ _
 #align bifunctor.id_fst Bifunctor.id_fst
 -/
 
 #print Bifunctor.id_snd /-
-@[higher_order.1snd_id]
+@[higher_order snd_id]
 theorem id_snd : ∀ {α β} (x : F α β), snd id x = x :=
   @id_bimap _ _ _
 #align bifunctor.id_snd Bifunctor.id_snd
 -/
 
 #print Bifunctor.comp_fst /-
-@[higher_order.1fst_comp_fst]
+@[higher_order fst_comp_fst]
 theorem comp_fst {α₀ α₁ α₂ β} (f : α₀ → α₁) (f' : α₁ → α₂) (x : F α₀ β) :
     fst f' (fst f x) = fst (f' ∘ f) x := by simp [fst, bimap_bimap]
 #align bifunctor.comp_fst Bifunctor.comp_fst
 -/
 
 #print Bifunctor.fst_snd /-
-@[higher_order.1fst_comp_snd]
+@[higher_order fst_comp_snd]
 theorem fst_snd {α₀ α₁ β₀ β₁} (f : α₀ → α₁) (f' : β₀ → β₁) (x : F α₀ β₀) :
     fst f (snd f' x) = bimap f f' x := by simp [fst, bimap_bimap]
 #align bifunctor.fst_snd Bifunctor.fst_snd
 -/
 
 #print Bifunctor.snd_fst /-
-@[higher_order.1snd_comp_fst]
+@[higher_order snd_comp_fst]
 theorem snd_fst {α₀ α₁ β₀ β₁} (f : α₀ → α₁) (f' : β₀ → β₁) (x : F α₀ β₀) :
     snd f' (fst f x) = bimap f f' x := by simp [snd, bimap_bimap]
 #align bifunctor.snd_fst Bifunctor.snd_fst
 -/
 
 #print Bifunctor.comp_snd /-
-@[higher_order.1snd_comp_snd]
+@[higher_order snd_comp_snd]
 theorem comp_snd {α β₀ β₁ β₂} (g : β₀ → β₁) (g' : β₁ → β₂) (x : F α β₀) :
     snd g' (snd g x) = snd (g' ∘ g) x := by simp [snd, bimap_bimap]
 #align bifunctor.comp_snd Bifunctor.comp_snd

69c6a5a1

bump to nightly-2023-03-14-02

mathlib commit https://github.com/leanprover-community/mathlib/commit/2196ab363eb097c008d4497125e0dde23fb36db2

d4b38a42

Diff

@@ -4,7 +4,7 @@ Released under Apache 2.0 license as described in the file LICENSE.
 Authors: Simon Hudon
 
 ! This file was ported from Lean 3 source module control.bifunctor
-! leanprover-community/mathlib commit dc1525fb3ef6eb4348fb1749c302d8abc303d34a
+! leanprover-community/mathlib commit 69c6a5a12d8a2b159f20933e60115a4f2de62b58
 ! Please do not edit these lines, except to modify the commit id
 ! if you have ported upstream changes.
 -/
@@ -14,6 +14,9 @@ import Mathbin.Data.Sum.Basic
 /-!
 # Functors with two arguments
 
+> THIS FILE IS SYNCHRONIZED WITH MATHLIB4.
+> Any changes to this file require a corresponding PR to mathlib4.
+
 This file defines bifunctors.
 
 A bifunctor is a function `F : Type* → Type* → Type*` along with a bimap which turns `F α β` into

dc1525fb

bump to nightly-2023-03-13-18

mathlib commit https://github.com/leanprover-community/mathlib/commit/2af0836443b4cfb5feda0df0051acdb398304931

66e1e587

Diff

@@ -53,9 +53,9 @@ class LawfulBifunctor (F : Type u₀ → Type u₁ → Type u₂) [Bifunctor F]
 
 export LawfulBifunctor (id_bimap bimap_bimap)
 
-attribute [higher_order bimap_id_id] id_bimap
+attribute [higher_order.1bimap_id_id] id_bimap
 
-attribute [higher_order bimap_comp_bimap] bimap_bimap
+attribute [higher_order.1bimap_comp_bimap] bimap_bimap
 
 export LawfulBifunctor (bimap_id_id bimap_comp_bimap)
 
@@ -82,42 +82,42 @@ def snd {α β β'} (f : β → β') : F α β → F α β' :=
 variable [LawfulBifunctor F]
 
 #print Bifunctor.id_fst /-
-@[higher_order fst_id]
+@[higher_order.1fst_id]
 theorem id_fst : ∀ {α β} (x : F α β), fst id x = x :=
   @id_bimap _ _ _
 #align bifunctor.id_fst Bifunctor.id_fst
 -/
 
 #print Bifunctor.id_snd /-
-@[higher_order snd_id]
+@[higher_order.1snd_id]
 theorem id_snd : ∀ {α β} (x : F α β), snd id x = x :=
   @id_bimap _ _ _
 #align bifunctor.id_snd Bifunctor.id_snd
 -/
 
 #print Bifunctor.comp_fst /-
-@[higher_order fst_comp_fst]
+@[higher_order.1fst_comp_fst]
 theorem comp_fst {α₀ α₁ α₂ β} (f : α₀ → α₁) (f' : α₁ → α₂) (x : F α₀ β) :
     fst f' (fst f x) = fst (f' ∘ f) x := by simp [fst, bimap_bimap]
 #align bifunctor.comp_fst Bifunctor.comp_fst
 -/
 
 #print Bifunctor.fst_snd /-
-@[higher_order fst_comp_snd]
+@[higher_order.1fst_comp_snd]
 theorem fst_snd {α₀ α₁ β₀ β₁} (f : α₀ → α₁) (f' : β₀ → β₁) (x : F α₀ β₀) :
     fst f (snd f' x) = bimap f f' x := by simp [fst, bimap_bimap]
 #align bifunctor.fst_snd Bifunctor.fst_snd
 -/
 
 #print Bifunctor.snd_fst /-
-@[higher_order snd_comp_fst]
+@[higher_order.1snd_comp_fst]
 theorem snd_fst {α₀ α₁ β₀ β₁} (f : α₀ → α₁) (f' : β₀ → β₁) (x : F α₀ β₀) :
     snd f' (fst f x) = bimap f f' x := by simp [snd, bimap_bimap]
 #align bifunctor.snd_fst Bifunctor.snd_fst
 -/
 
 #print Bifunctor.comp_snd /-
-@[higher_order snd_comp_snd]
+@[higher_order.1snd_comp_snd]
 theorem comp_snd {α β₀ β₁ β₂} (g : β₀ → β₁) (g' : β₁ → β₂) (x : F α β₀) :
     snd g' (snd g x) = snd (g' ∘ g) x := by simp [snd, bimap_bimap]
 #align bifunctor.comp_snd Bifunctor.comp_snd

dc1525fb

bump to nightly-2023-03-08-14

mathlib commit https://github.com/leanprover-community/mathlib/commit/38f16f960f5006c6c0c2bac7b0aba5273188f4e5

f7af4b63

Diff

@@ -32,76 +32,96 @@ universe u₀ u₁ u₂ v₀ v₁ v₂
 
 open Function
 
+#print Bifunctor /-
 /-- Lawless bifunctor. This typeclass only holds the data for the bimap. -/
 class Bifunctor (F : Type u₀ → Type u₁ → Type u₂) where
   bimap : ∀ {α α' β β'}, (α → α') → (β → β') → F α β → F α' β'
 #align bifunctor Bifunctor
+-/
 
 export Bifunctor (bimap)
 
+#print LawfulBifunctor /-
 /-- Bifunctor. This typeclass asserts that a lawless `bifunctor` is lawful. -/
-class IsLawfulBifunctor (F : Type u₀ → Type u₁ → Type u₂) [Bifunctor F] where
+class LawfulBifunctor (F : Type u₀ → Type u₁ → Type u₂) [Bifunctor F] where
   id_bimap : ∀ {α β} (x : F α β), bimap id id x = x
   bimap_bimap :
     ∀ {α₀ α₁ α₂ β₀ β₁ β₂} (f : α₀ → α₁) (f' : α₁ → α₂) (g : β₀ → β₁) (g' : β₁ → β₂) (x : F α₀ β₀),
       bimap f' g' (bimap f g x) = bimap (f' ∘ f) (g' ∘ g) x
-#align is_lawful_bifunctor IsLawfulBifunctor
+#align is_lawful_bifunctor LawfulBifunctor
+-/
 
-export IsLawfulBifunctor (id_bimap bimap_bimap)
+export LawfulBifunctor (id_bimap bimap_bimap)
 
 attribute [higher_order bimap_id_id] id_bimap
 
 attribute [higher_order bimap_comp_bimap] bimap_bimap
 
-export IsLawfulBifunctor (bimap_id_id bimap_comp_bimap)
+export LawfulBifunctor (bimap_id_id bimap_comp_bimap)
 
 variable {F : Type u₀ → Type u₁ → Type u₂} [Bifunctor F]
 
 namespace Bifunctor
 
+#print Bifunctor.fst /-
 /-- Left map of a bifunctor. -/
 @[reducible]
 def fst {α α' β} (f : α → α') : F α β → F α' β :=
   bimap f id
 #align bifunctor.fst Bifunctor.fst
+-/
 
+#print Bifunctor.snd /-
 /-- Right map of a bifunctor. -/
 @[reducible]
 def snd {α β β'} (f : β → β') : F α β → F α β' :=
   bimap id f
 #align bifunctor.snd Bifunctor.snd
+-/
 
-variable [IsLawfulBifunctor F]
+variable [LawfulBifunctor F]
 
+#print Bifunctor.id_fst /-
 @[higher_order fst_id]
 theorem id_fst : ∀ {α β} (x : F α β), fst id x = x :=
   @id_bimap _ _ _
 #align bifunctor.id_fst Bifunctor.id_fst
+-/
 
+#print Bifunctor.id_snd /-
 @[higher_order snd_id]
 theorem id_snd : ∀ {α β} (x : F α β), snd id x = x :=
   @id_bimap _ _ _
 #align bifunctor.id_snd Bifunctor.id_snd
+-/
 
+#print Bifunctor.comp_fst /-
 @[higher_order fst_comp_fst]
 theorem comp_fst {α₀ α₁ α₂ β} (f : α₀ → α₁) (f' : α₁ → α₂) (x : F α₀ β) :
     fst f' (fst f x) = fst (f' ∘ f) x := by simp [fst, bimap_bimap]
 #align bifunctor.comp_fst Bifunctor.comp_fst
+-/
 
+#print Bifunctor.fst_snd /-
 @[higher_order fst_comp_snd]
 theorem fst_snd {α₀ α₁ β₀ β₁} (f : α₀ → α₁) (f' : β₀ → β₁) (x : F α₀ β₀) :
     fst f (snd f' x) = bimap f f' x := by simp [fst, bimap_bimap]
 #align bifunctor.fst_snd Bifunctor.fst_snd
+-/
 
+#print Bifunctor.snd_fst /-
 @[higher_order snd_comp_fst]
 theorem snd_fst {α₀ α₁ β₀ β₁} (f : α₀ → α₁) (f' : β₀ → β₁) (x : F α₀ β₀) :
     snd f' (fst f x) = bimap f f' x := by simp [snd, bimap_bimap]
 #align bifunctor.snd_fst Bifunctor.snd_fst
+-/
 
+#print Bifunctor.comp_snd /-
 @[higher_order snd_comp_snd]
 theorem comp_snd {α β₀ β₁ β₂} (g : β₀ → β₁) (g' : β₁ → β₂) (x : F α β₀) :
     snd g' (snd g x) = snd (g' ∘ g) x := by simp [snd, bimap_bimap]
 #align bifunctor.comp_snd Bifunctor.comp_snd
+-/
 
 attribute [functor_norm]
   bimap_bimap comp_snd comp_fst snd_comp_snd snd_comp_fst fst_comp_snd fst_comp_fst bimap_comp_bimap bimap_id_id fst_id snd_id
@@ -112,34 +132,46 @@ open Functor
 
 instance : Bifunctor Prod where bimap := @Prod.map
 
-instance : IsLawfulBifunctor Prod := by refine' { .. } <;> intros <;> cases x <;> rfl
+instance : LawfulBifunctor Prod := by refine' { .. } <;> intros <;> cases x <;> rfl
 
+#print Bifunctor.const /-
 instance Bifunctor.const : Bifunctor Const where bimap α α' β β f _ := f
 #align bifunctor.const Bifunctor.const
+-/
 
-instance IsLawfulBifunctor.const : IsLawfulBifunctor Const := by refine' { .. } <;> intros <;> rfl
-#align is_lawful_bifunctor.const IsLawfulBifunctor.const
+#print LawfulBifunctor.const /-
+instance LawfulBifunctor.const : LawfulBifunctor Const := by refine' { .. } <;> intros <;> rfl
+#align is_lawful_bifunctor.const LawfulBifunctor.const
+-/
 
+#print Bifunctor.flip /-
 instance Bifunctor.flip : Bifunctor (flip F)
     where bimap α α' β β' f f' x := (bimap f' f x : F β' α')
 #align bifunctor.flip Bifunctor.flip
+-/
 
-instance IsLawfulBifunctor.flip [IsLawfulBifunctor F] : IsLawfulBifunctor (flip F) := by
+#print LawfulBifunctor.flip /-
+instance LawfulBifunctor.flip [LawfulBifunctor F] : LawfulBifunctor (flip F) := by
   refine' { .. } <;> intros <;> simp [bimap, functor_norm]
-#align is_lawful_bifunctor.flip IsLawfulBifunctor.flip
+#align is_lawful_bifunctor.flip LawfulBifunctor.flip
+-/
 
 instance : Bifunctor Sum where bimap := @Sum.map
 
-instance : IsLawfulBifunctor Sum := by refine' { .. } <;> intros <;> cases x <;> rfl
+instance : LawfulBifunctor Sum := by refine' { .. } <;> intros <;> cases x <;> rfl
 
 open Bifunctor Functor
 
+#print Bifunctor.functor /-
 instance (priority := 10) Bifunctor.functor {α} : Functor (F α) where map _ _ := snd
 #align bifunctor.functor Bifunctor.functor
+-/
 
-instance (priority := 10) Bifunctor.lawfulFunctor [IsLawfulBifunctor F] {α} : LawfulFunctor (F α) :=
+#print Bifunctor.lawfulFunctor /-
+instance (priority := 10) Bifunctor.lawfulFunctor [LawfulBifunctor F] {α} : LawfulFunctor (F α) :=
   by refine' { .. } <;> intros <;> simp [Functor.map, functor_norm]
 #align bifunctor.is_lawful_functor Bifunctor.lawfulFunctor
+-/
 
 section Bicompl
 
@@ -148,8 +180,8 @@ variable (G : Type _ → Type u₀) (H : Type _ → Type u₁) [Functor G] [Func
 instance : Bifunctor (bicompl F G H)
     where bimap α α' β β' f f' x := (bimap (map f) (map f') x : F (G α') (H β'))
 
-instance [LawfulFunctor G] [LawfulFunctor H] [IsLawfulBifunctor F] :
-    IsLawfulBifunctor (bicompl F G H) := by
+instance [LawfulFunctor G] [LawfulFunctor H] [LawfulBifunctor F] :
+    LawfulBifunctor (bicompl F G H) := by
   constructor <;> intros <;> simp [bimap, map_id, map_comp_map, functor_norm]
 
 end Bicompl
@@ -161,7 +193,7 @@ variable (G : Type u₂ → Type _) [Functor G]
 instance : Bifunctor (bicompr G F)
     where bimap α α' β β' f f' x := (map (bimap f f') x : G (F α' β'))
 
-instance [LawfulFunctor G] [IsLawfulBifunctor F] : IsLawfulBifunctor (bicompr G F) := by
+instance [LawfulFunctor G] [LawfulBifunctor F] : LawfulBifunctor (bicompr G F) := by
   constructor <;> intros <;> simp [bimap, functor_norm]
 
 end Bicompr

dc1525fb

bump to nightly-2023-02-21-16

mathlib commit https://github.com/leanprover-community/mathlib/commit/bd9851ca476957ea4549eb19b40e7b5ade9428cc

1107b979

Changes in mathlib4

mathlib3

mathlib4

dc1525fb

chore: reduce imports (#9830)

This uses the improved shake script from #9772 to reduce imports across mathlib. The corresponding noshake.json file has been added to #9772.

Co-authored-by: Mario Carneiro <di.gama@gmail.com>

f4c4ca61

Diff

@@ -4,7 +4,6 @@ Released under Apache 2.0 license as described in the file LICENSE.
 Authors: Simon Hudon
 -/
 import Mathlib.Control.Functor
-import Mathlib.Data.Sum.Basic
 import Mathlib.Tactic.Common
 
 #align_import control.bifunctor from "leanprover-community/mathlib"@"dc1525fb3ef6eb4348fb1749c302d8abc303d34a"

dc1525fb

style: fix wrapping of where (#7149)

084cfb35

Diff

@@ -130,8 +130,8 @@ instance Bifunctor.const : Bifunctor Const where bimap f _ := f
 instance LawfulBifunctor.const : LawfulBifunctor Const := by refine' { .. } <;> intros <;> rfl
 #align is_lawful_bifunctor.const LawfulBifunctor.const
 
-instance Bifunctor.flip : Bifunctor (flip F)
-    where bimap {_α α' _β β'} f f' x := (bimap f' f x : F β' α')
+instance Bifunctor.flip : Bifunctor (flip F) where
+  bimap {_α α' _β β'} f f' x := (bimap f' f x : F β' α')
 #align bifunctor.flip Bifunctor.flip
 
 instance LawfulBifunctor.flip [LawfulBifunctor F] : LawfulBifunctor (flip F) := by
@@ -159,8 +159,8 @@ section Bicompl
 
 variable (G : Type* → Type u₀) (H : Type* → Type u₁) [Functor G] [Functor H]
 
-instance Function.bicompl.bifunctor : Bifunctor (bicompl F G H)
-    where bimap {_α α' _β β'} f f' x := (bimap (map f) (map f') x : F (G α') (H β'))
+instance Function.bicompl.bifunctor : Bifunctor (bicompl F G H) where
+  bimap {_α α' _β β'} f f' x := (bimap (map f) (map f') x : F (G α') (H β'))
 #align function.bicompl.bifunctor Function.bicompl.bifunctor
 
 instance Function.bicompl.lawfulBifunctor [LawfulFunctor G] [LawfulFunctor H] [LawfulBifunctor F] :
@@ -174,8 +174,8 @@ section Bicompr
 
 variable (G : Type u₂ → Type*) [Functor G]
 
-instance Function.bicompr.bifunctor : Bifunctor (bicompr G F)
-    where bimap {_α α' _β β'} f f' x := (map (bimap f f') x : G (F α' β'))
+instance Function.bicompr.bifunctor : Bifunctor (bicompr G F) where
+  bimap {_α α' _β β'} f f' x := (map (bimap f f') x : G (F α' β'))
 #align function.bicompr.bifunctor Function.bicompr.bifunctor
 
 instance Function.bicompr.lawfulBifunctor [LawfulFunctor G] [LawfulBifunctor F] :

dc1525fb

chore: banish Type _ and Sort _ (#6499)

We remove all possible occurences of Type _ and Sort _ in favor of Type* and Sort*.

This has nice performance benefits.

32de3f67

Diff

@@ -14,7 +14,7 @@ import Mathlib.Tactic.Common
 
 This file defines bifunctors.
 
-A bifunctor is a function `F : Type _ → Type _ → Type _` along with a bimap which turns `F α β`into
+A bifunctor is a function `F : Type* → Type* → Type*` along with a bimap which turns `F α β`into
 `F α' β'` given two functions `α → α'` and `β → β'`. It further
 * respects the identity: `bimap id id = id`
 * composes in the obvious way: `(bimap f' g') ∘ (bimap f g) = bimap (f' ∘ f) (g' ∘ g)`
@@ -157,7 +157,7 @@ instance (priority := 10) Bifunctor.lawfulFunctor [LawfulBifunctor F] {α} : Law
 
 section Bicompl
 
-variable (G : Type _ → Type u₀) (H : Type _ → Type u₁) [Functor G] [Functor H]
+variable (G : Type* → Type u₀) (H : Type* → Type u₁) [Functor G] [Functor H]
 
 instance Function.bicompl.bifunctor : Bifunctor (bicompl F G H)
     where bimap {_α α' _β β'} f f' x := (bimap (map f) (map f') x : F (G α') (H β'))
@@ -172,7 +172,7 @@ end Bicompl
 
 section Bicompr
 
-variable (G : Type u₂ → Type _) [Functor G]
+variable (G : Type u₂ → Type*) [Functor G]
 
 instance Function.bicompr.bifunctor : Bifunctor (bicompr G F)
     where bimap {_α α' _β β'} f f' x := (map (bimap f f') x : G (F α' β'))

dc1525fb

feat: Linter that checks that Prop classes are Props (#6148)

930dd29d

Diff

@@ -38,7 +38,7 @@ class Bifunctor (F : Type u₀ → Type u₁ → Type u₂) where
 export Bifunctor (bimap)
 
 /-- Bifunctor. This typeclass asserts that a lawless `Bifunctor` is lawful. -/
-class LawfulBifunctor (F : Type u₀ → Type u₁ → Type u₂) [Bifunctor F] where
+class LawfulBifunctor (F : Type u₀ → Type u₁ → Type u₂) [Bifunctor F] : Prop where
   id_bimap : ∀ {α β} (x : F α β), bimap id id x = x
   bimap_bimap :
     ∀ {α₀ α₁ α₂ β₀ β₁ β₂} (f : α₀ → α₁) (f' : α₁ → α₂) (g : β₀ → β₁) (g' : β₁ → β₂) (x : F α₀ β₀),

dc1525fb

chore: script to replace headers with #align_import statements (#5979)

depends on: #5966

Co-authored-by: Eric Wieser <wieser.eric@gmail.com> Co-authored-by: Scott Morrison <scott.morrison@gmail.com>

89aa3a3b

Diff

@@ -2,16 +2,13 @@
 Copyright (c) 2018 Simon Hudon. All rights reserved.
 Released under Apache 2.0 license as described in the file LICENSE.
 Authors: Simon Hudon
-
-! This file was ported from Lean 3 source module control.bifunctor
-! leanprover-community/mathlib commit dc1525fb3ef6eb4348fb1749c302d8abc303d34a
-! Please do not edit these lines, except to modify the commit id
-! if you have ported upstream changes.
 -/
 import Mathlib.Control.Functor
 import Mathlib.Data.Sum.Basic
 import Mathlib.Tactic.Common
 
+#align_import control.bifunctor from "leanprover-community/mathlib"@"dc1525fb3ef6eb4348fb1749c302d8abc303d34a"
+
 /-!
 # Functors with two arguments

dc1525fb

feat: add Mathlib.Tactic.Common, and import (#4056)

This makes a mathlib4 version of mathlib3's tactic.basic, now called Mathlib.Tactic.Common, which imports all tactics which do not have significant theory requirements, and then is imported all across the base of the hierarchy.

This ensures that all common tactics are available nearly everywhere in the library, rather than having to be imported one-by-one as you need them.

Co-authored-by: Scott Morrison <scott.morrison@gmail.com>

a4eaf1c4

Diff

@@ -8,10 +8,9 @@ Authors: Simon Hudon
 ! Please do not edit these lines, except to modify the commit id
 ! if you have ported upstream changes.
 -/
-import Aesop
 import Mathlib.Control.Functor
 import Mathlib.Data.Sum.Basic
-import Mathlib.Tactic.HigherOrder
+import Mathlib.Tactic.Common
 
 /-!
 # Functors with two arguments

dc1525fb

fix: Tactic/HigherOrder should not import Mathport/Syntax (#2837)

Co-authored-by: Scott Morrison <scott.morrison@gmail.com> Co-authored-by: Komyyy <pol_tta@outlook.jp>

36766e1e

Diff

@@ -8,6 +8,7 @@ Authors: Simon Hudon
 ! Please do not edit these lines, except to modify the commit id
 ! if you have ported upstream changes.
 -/
+import Aesop
 import Mathlib.Control.Functor
 import Mathlib.Data.Sum.Basic
 import Mathlib.Tactic.HigherOrder

dc1525fb

feat: port Control.Bifunctor (#2439)

Co-authored-by: ChrisHughes24 <chrishughes24@gmail.com>

87fe67eb

`control.bifunctor` ⟷ `Mathlib.Control.Bifunctor`

Changes since the initial port

Changes in mathlib3

Changes in mathlib3port

Changes in mathlib4

Dependencies 1

control.bifunctor ⟷ Mathlib.Control.Bifunctor

Changes since the initial port

Changes in mathlib3

Changes in mathlib3port

Changes in mathlib4

Dependencies 1

`control.bifunctor` ⟷ `Mathlib.Control.Bifunctor`