control.bitraversable.instances | Mathlib porting status

Changes since the initial port

The following section lists changes to this file in mathlib3 and mathlib4 that occured after the initial port. Most recent changes are shown first. Hovering over a commit will show all commits associated with the same mathlib3 commit.

Changes in mathlib3

1e7f6b9a

(last sync)

Changes in mathlib3port

mathlib3

mathlib3port

1b089e3b

bump to nightly-2023-09-24-06

mathlib commit https://github.com/leanprover-community/mathlib/commit/ce64cd319bb6b3e82f31c2d38e79080d377be451

5655435f

Diff

@@ -3,8 +3,8 @@ Copyright (c) 2019 Simon Hudon. All rights reserved.
 Released under Apache 2.0 license as described in the file LICENSE.
 Authors: Simon Hudon
 -/
-import Mathbin.Control.Bitraversable.Lemmas
-import Mathbin.Control.Traversable.Lemmas
+import Control.Bitraversable.Lemmas
+import Control.Traversable.Lemmas
 
 #align_import control.bitraversable.instances from "leanprover-community/mathlib"@"1b089e3bdc3ce6b39cd472543474a0a137128c6c"

1b089e3b

bump to nightly-2023-07-20-09

mathlib commit https://github.com/leanprover-community/mathlib/commit/8ea5598db6caeddde6cb734aa179cc2408dbd345

9c56d0dd

Diff

@@ -2,15 +2,12 @@
 Copyright (c) 2019 Simon Hudon. All rights reserved.
 Released under Apache 2.0 license as described in the file LICENSE.
 Authors: Simon Hudon
-
-! This file was ported from Lean 3 source module control.bitraversable.instances
-! leanprover-community/mathlib commit 1b089e3bdc3ce6b39cd472543474a0a137128c6c
-! Please do not edit these lines, except to modify the commit id
-! if you have ported upstream changes.
 -/
 import Mathbin.Control.Bitraversable.Lemmas
 import Mathbin.Control.Traversable.Lemmas
 
+#align_import control.bitraversable.instances from "leanprover-community/mathlib"@"1b089e3bdc3ce6b39cd472543474a0a137128c6c"
+
 /-!
 # Bitraversable instances

1b089e3b

bump to nightly-2023-07-06-21

mathlib commit https://github.com/leanprover-community/mathlib/commit/5dc6092d09e5e489106865241986f7f2ad28d4c8

8b3166c8

Diff

@@ -122,7 +122,7 @@ instance (priority := 10) Bitraversable.traversable {α} : Traversable (t α)
 
 #print Bitraversable.isLawfulTraversable /-
 instance (priority := 10) Bitraversable.isLawfulTraversable [LawfulBitraversable t] {α} :
-    IsLawfulTraversable (t α) :=
+    LawfulTraversable (t α) :=
   by
   constructor <;> intros <;> simp [traverse, comp_tsnd, functor_norm]
   · rfl
@@ -133,7 +133,7 @@ instance (priority := 10) Bitraversable.isLawfulTraversable [LawfulBitraversable
 
 end
 
-open Bifunctor Traversable IsLawfulTraversable LawfulBitraversable
+open Bifunctor Traversable LawfulTraversable LawfulBitraversable
 
 open Function (bicompl bicompr)
 
@@ -151,7 +151,7 @@ def Bicompl.bitraverse {m} [Applicative m] {α β α' β'} (f : α → m β) (f'
 
 instance : Bitraversable (bicompl t F G) where bitraverse := @Bicompl.bitraverse t _ F G _ _
 
-instance [IsLawfulTraversable F] [IsLawfulTraversable G] [LawfulBitraversable t] :
+instance [LawfulTraversable F] [LawfulTraversable G] [LawfulBitraversable t] :
     LawfulBitraversable (bicompl t F G) :=
   by
   constructor <;> intros <;>
@@ -177,7 +177,7 @@ def Bicompr.bitraverse {m} [Applicative m] {α β α' β'} (f : α → m β) (f'
 
 instance : Bitraversable (bicompr F t) where bitraverse := @Bicompr.bitraverse t _ F _
 
-instance [IsLawfulTraversable F] [LawfulBitraversable t] : LawfulBitraversable (bicompr F t) :=
+instance [LawfulTraversable F] [LawfulBitraversable t] : LawfulBitraversable (bicompr F t) :=
   by
   constructor <;> intros <;> simp [bitraverse, Bicompr.bitraverse, bitraverse_id_id, functor_norm]
   · simp [bitraverse_eq_bimap_id', traverse_eq_map_id']; rfl

1b089e3b

bump to nightly-2023-06-23-03

mathlib commit https://github.com/leanprover-community/mathlib/commit/d30d31261cdb4d2f5e612eabc3c4bf45556350d5

2dc54ce1

Diff

@@ -4,7 +4,7 @@ Released under Apache 2.0 license as described in the file LICENSE.
 Authors: Simon Hudon
 
 ! This file was ported from Lean 3 source module control.bitraversable.instances
-! leanprover-community/mathlib commit 1e7f6b9a746d445350890f3ad5236f3fc686c103
+! leanprover-community/mathlib commit 1b089e3bdc3ce6b39cd472543474a0a137128c6c
 ! Please do not edit these lines, except to modify the commit id
 ! if you have ported upstream changes.
 -/
@@ -14,6 +14,9 @@ import Mathbin.Control.Traversable.Lemmas
 /-!
 # Bitraversable instances
 
+> THIS FILE IS SYNCHRONIZED WITH MATHLIB4.
+> Any changes to this file require a corresponding PR to mathlib4.
+
 This file provides `bitraversable` instances for concrete bifunctors:
 * `prod`
 * `sum`

1e7f6b9a

bump to nightly-2023-06-21-09

mathlib commit https://github.com/leanprover-community/mathlib/commit/f2ad3645af9effcdb587637dc28a6074edc813f9

7d4d846c

Diff

@@ -40,66 +40,85 @@ section
 
 variable {F : Type u → Type u} [Applicative F]
 
+#print Prod.bitraverse /-
 /-- The bitraverse function for `α × β`. -/
 def Prod.bitraverse {α α' β β'} (f : α → F α') (f' : β → F β') : α × β → F (α' × β')
   | (x, y) => Prod.mk <$> f x <*> f' y
 #align prod.bitraverse Prod.bitraverse
+-/
 
 instance : Bitraversable Prod where bitraverse := @Prod.bitraverse
 
-instance : IsLawfulBitraversable Prod := by
+instance : LawfulBitraversable Prod := by
   constructor <;> intros <;> cases x <;> simp [bitraverse, Prod.bitraverse, functor_norm] <;> rfl
 
 open Functor
 
+#print Sum.bitraverse /-
 /-- The bitraverse function for `α ⊕ β`. -/
 def Sum.bitraverse {α α' β β'} (f : α → F α') (f' : β → F β') : Sum α β → F (Sum α' β')
   | Sum.inl x => Sum.inl <$> f x
   | Sum.inr x => Sum.inr <$> f' x
 #align sum.bitraverse Sum.bitraverse
+-/
 
 instance : Bitraversable Sum where bitraverse := @Sum.bitraverse
 
-instance : IsLawfulBitraversable Sum := by
+instance : LawfulBitraversable Sum := by
   constructor <;> intros <;> cases x <;> simp [bitraverse, Sum.bitraverse, functor_norm] <;> rfl
 
+#print Const.bitraverse /-
 /-- The bitraverse function for `const`. It throws away the second map. -/
 @[nolint unused_arguments]
 def Const.bitraverse {α α' β β'} (f : α → F α') (f' : β → F β') : Const α β → F (Const α' β') :=
   f
 #align const.bitraverse Const.bitraverse
+-/
 
+#print Bitraversable.const /-
 instance Bitraversable.const : Bitraversable Const where bitraverse := @Const.bitraverse
 #align bitraversable.const Bitraversable.const
+-/
 
-instance IsLawfulBitraversable.const : IsLawfulBitraversable Const := by
+#print LawfulBitraversable.const /-
+instance LawfulBitraversable.const : LawfulBitraversable Const := by
   constructor <;> intros <;> simp [bitraverse, Const.bitraverse, functor_norm] <;> rfl
-#align is_lawful_bitraversable.const IsLawfulBitraversable.const
+#align is_lawful_bitraversable.const LawfulBitraversable.const
+-/
 
+#print flip.bitraverse /-
 /-- The bitraverse function for `flip`. -/
 def flip.bitraverse {α α' β β'} (f : α → F α') (f' : β → F β') : flip t α β → F (flip t α' β') :=
   (bitraverse f' f : t β α → F (t β' α'))
 #align flip.bitraverse flip.bitraverse
+-/
 
+#print Bitraversable.flip /-
 instance Bitraversable.flip : Bitraversable (flip t) where bitraverse := @flip.bitraverse t _
 #align bitraversable.flip Bitraversable.flip
+-/
 
-open IsLawfulBitraversable
+open LawfulBitraversable
 
 /- ./././Mathport/Syntax/Translate/Tactic/Builtin.lean:69:18: unsupported non-interactive tactic tactic.apply_assumption -/
-instance IsLawfulBitraversable.flip [IsLawfulBitraversable t] : IsLawfulBitraversable (flip t) := by
-  constructor <;> intros <;> casesm IsLawfulBitraversable t <;>
+#print LawfulBitraversable.flip /-
+instance LawfulBitraversable.flip [LawfulBitraversable t] : LawfulBitraversable (flip t) := by
+  constructor <;> intros <;> casesm LawfulBitraversable t <;>
     run_tac
       tactic.apply_assumption
-#align is_lawful_bitraversable.flip IsLawfulBitraversable.flip
+#align is_lawful_bitraversable.flip LawfulBitraversable.flip
+-/
 
 open Bitraversable Functor
 
+#print Bitraversable.traversable /-
 instance (priority := 10) Bitraversable.traversable {α} : Traversable (t α)
     where traverse := @tsnd t _ _
 #align bitraversable.traversable Bitraversable.traversable
+-/
 
-instance (priority := 10) Bitraversable.isLawfulTraversable [IsLawfulBitraversable t] {α} :
+#print Bitraversable.isLawfulTraversable /-
+instance (priority := 10) Bitraversable.isLawfulTraversable [LawfulBitraversable t] {α} :
     IsLawfulTraversable (t α) :=
   by
   constructor <;> intros <;> simp [traverse, comp_tsnd, functor_norm]
@@ -107,10 +126,11 @@ instance (priority := 10) Bitraversable.isLawfulTraversable [IsLawfulBitraversab
   · simp [tsnd_eq_snd_id]; rfl
   · simp [tsnd, binaturality, Function.comp, functor_norm]
 #align bitraversable.is_lawful_traversable Bitraversable.isLawfulTraversable
+-/
 
 end
 
-open Bifunctor Traversable IsLawfulTraversable IsLawfulBitraversable
+open Bifunctor Traversable IsLawfulTraversable LawfulBitraversable
 
 open Function (bicompl bicompr)
 
@@ -118,16 +138,18 @@ section Bicompl
 
 variable (F G : Type u → Type u) [Traversable F] [Traversable G]
 
+#print Bicompl.bitraverse /-
 /-- The bitraverse function for `bicompl`. -/
 def Bicompl.bitraverse {m} [Applicative m] {α β α' β'} (f : α → m β) (f' : α' → m β') :
     bicompl t F G α α' → m (bicompl t F G β β') :=
   (bitraverse (traverse f) (traverse f') : t (F α) (G α') → m _)
 #align bicompl.bitraverse Bicompl.bitraverse
+-/
 
 instance : Bitraversable (bicompl t F G) where bitraverse := @Bicompl.bitraverse t _ F G _ _
 
-instance [IsLawfulTraversable F] [IsLawfulTraversable G] [IsLawfulBitraversable t] :
-    IsLawfulBitraversable (bicompl t F G) :=
+instance [IsLawfulTraversable F] [IsLawfulTraversable G] [LawfulBitraversable t] :
+    LawfulBitraversable (bicompl t F G) :=
   by
   constructor <;> intros <;>
     simp [bitraverse, Bicompl.bitraverse, bimap, traverse_id, bitraverse_id_id, comp_bitraverse,
@@ -142,15 +164,17 @@ section Bicompr
 
 variable (F : Type u → Type u) [Traversable F]
 
+#print Bicompr.bitraverse /-
 /-- The bitraverse function for `bicompr`. -/
 def Bicompr.bitraverse {m} [Applicative m] {α β α' β'} (f : α → m β) (f' : α' → m β') :
     bicompr F t α α' → m (bicompr F t β β') :=
   (traverse (bitraverse f f') : F (t α α') → m _)
 #align bicompr.bitraverse Bicompr.bitraverse
+-/
 
 instance : Bitraversable (bicompr F t) where bitraverse := @Bicompr.bitraverse t _ F _
 
-instance [IsLawfulTraversable F] [IsLawfulBitraversable t] : IsLawfulBitraversable (bicompr F t) :=
+instance [IsLawfulTraversable F] [LawfulBitraversable t] : LawfulBitraversable (bicompr F t) :=
   by
   constructor <;> intros <;> simp [bitraverse, Bicompr.bitraverse, bitraverse_id_id, functor_norm]
   · simp [bitraverse_eq_bimap_id', traverse_eq_map_id']; rfl

1e7f6b9a

bump to nightly-2023-05-28-06

mathlib commit https://github.com/leanprover-community/mathlib/commit/917c3c072e487b3cccdbfeff17e75b40e45f66cb

ba5d8b97

Diff

@@ -40,12 +40,6 @@ section
 
 variable {F : Type u → Type u} [Applicative F]
 
-/- warning: prod.bitraverse -> Prod.bitraverse is a dubious translation:
-lean 3 declaration is
-  forall {F : Type.{u1} -> Type.{u1}} [_inst_2 : Applicative.{u1, u1} F] {α : Type.{u2}} {α' : Type.{u1}} {β : Type.{u3}} {β' : Type.{u1}}, (α -> (F α')) -> (β -> (F β')) -> (Prod.{u2, u3} α β) -> (F (Prod.{u1, u1} α' β'))
-but is expected to have type
-  forall {F : Type.{u3} -> Type.{u3}} [_inst_2 : Applicative.{u3, u3} F] {α : Type.{u1}} {α' : Type.{u3}} {β : Type.{u2}} {β' : Type.{u3}}, (α -> (F α')) -> (β -> (F β')) -> (Prod.{u1, u2} α β) -> (F (Prod.{u3, u3} α' β'))
-Case conversion may be inaccurate. Consider using '#align prod.bitraverse Prod.bitraverseₓ'. -/
 /-- The bitraverse function for `α × β`. -/
 def Prod.bitraverse {α α' β β'} (f : α → F α') (f' : β → F β') : α × β → F (α' × β')
   | (x, y) => Prod.mk <$> f x <*> f' y
@@ -58,12 +52,6 @@ instance : IsLawfulBitraversable Prod := by
 
 open Functor
 
-/- warning: sum.bitraverse -> Sum.bitraverse is a dubious translation:
-lean 3 declaration is
-  forall {F : Type.{u1} -> Type.{u1}} [_inst_2 : Applicative.{u1, u1} F] {α : Type.{u2}} {α' : Type.{u1}} {β : Type.{u3}} {β' : Type.{u1}}, (α -> (F α')) -> (β -> (F β')) -> (Sum.{u2, u3} α β) -> (F (Sum.{u1, u1} α' β'))
-but is expected to have type
-  forall {F : Type.{u3} -> Type.{u3}} [_inst_2 : Applicative.{u3, u3} F] {α : Type.{u1}} {α' : Type.{u3}} {β : Type.{u2}} {β' : Type.{u3}}, (α -> (F α')) -> (β -> (F β')) -> (Sum.{u1, u2} α β) -> (F (Sum.{u3, u3} α' β'))
-Case conversion may be inaccurate. Consider using '#align sum.bitraverse Sum.bitraverseₓ'. -/
 /-- The bitraverse function for `α ⊕ β`. -/
 def Sum.bitraverse {α α' β β'} (f : α → F α') (f' : β → F β') : Sum α β → F (Sum α' β')
   | Sum.inl x => Sum.inl <$> f x

1e7f6b9a

bump to nightly-2023-05-28-04

mathlib commit https://github.com/leanprover-community/mathlib/commit/917c3c072e487b3cccdbfeff17e75b40e45f66cb

6797a637

Diff

@@ -116,8 +116,7 @@ instance (priority := 10) Bitraversable.isLawfulTraversable [IsLawfulBitraversab
   by
   constructor <;> intros <;> simp [traverse, comp_tsnd, functor_norm]
   · rfl
-  · simp [tsnd_eq_snd_id]
-    rfl
+  · simp [tsnd_eq_snd_id]; rfl
   · simp [tsnd, binaturality, Function.comp, functor_norm]
 #align bitraversable.is_lawful_traversable Bitraversable.isLawfulTraversable
 
@@ -146,8 +145,7 @@ instance [IsLawfulTraversable F] [IsLawfulTraversable G] [IsLawfulBitraversable
     simp [bitraverse, Bicompl.bitraverse, bimap, traverse_id, bitraverse_id_id, comp_bitraverse,
       functor_norm]
   · simp [traverse_eq_map_id', bitraverse_eq_bimap_id]
-  · revert x
-    dsimp only [bicompl]
+  · revert x; dsimp only [bicompl]
     simp [binaturality, naturality_pf]
 
 end Bicompl
@@ -167,11 +165,8 @@ instance : Bitraversable (bicompr F t) where bitraverse := @Bicompr.bitraverse t
 instance [IsLawfulTraversable F] [IsLawfulBitraversable t] : IsLawfulBitraversable (bicompr F t) :=
   by
   constructor <;> intros <;> simp [bitraverse, Bicompr.bitraverse, bitraverse_id_id, functor_norm]
-  · simp [bitraverse_eq_bimap_id', traverse_eq_map_id']
-    rfl
-  · revert x
-    dsimp only [bicompr]
-    intro
+  · simp [bitraverse_eq_bimap_id', traverse_eq_map_id']; rfl
+  · revert x; dsimp only [bicompr]; intro
     simp [naturality, binaturality']
 
 end Bicompr

1e7f6b9a

bump to nightly-2023-03-01-20

mathlib commit https://github.com/leanprover-community/mathlib/commit/4c586d291f189eecb9d00581aeb3dd998ac34442

20cadee0

Diff

@@ -98,7 +98,7 @@ instance Bitraversable.flip : Bitraversable (flip t) where bitraverse := @flip.b
 
 open IsLawfulBitraversable
 
-/- ./././Mathport/Syntax/Translate/Tactic/Builtin.lean:72:18: unsupported non-interactive tactic tactic.apply_assumption -/
+/- ./././Mathport/Syntax/Translate/Tactic/Builtin.lean:69:18: unsupported non-interactive tactic tactic.apply_assumption -/
 instance IsLawfulBitraversable.flip [IsLawfulBitraversable t] : IsLawfulBitraversable (flip t) := by
   constructor <;> intros <;> casesm IsLawfulBitraversable t <;>
     run_tac

1e7f6b9a

bump to nightly-2023-02-21-16

mathlib commit https://github.com/leanprover-community/mathlib/commit/bd9851ca476957ea4549eb19b40e7b5ade9428cc

1107b979

Changes in mathlib4

mathlib3

mathlib4

1e7f6b9a

chore: squeeze some non-terminal simps (#11247)

This PR accompanies #11246, squeezing some non-terminal simps highlighted by the linter until I decided to stop!

1ad8c3fe

Diff

@@ -103,7 +103,7 @@ instance (priority := 10) Bitraversable.isLawfulTraversable [LawfulBitraversable
     LawfulTraversable (t α) := by
   constructor <;> intros <;>
     simp [traverse, comp_tsnd, functor_norm]
-  · simp [tsnd_eq_snd_id]; rfl
+  · simp only [tsnd_eq_snd_id, Id.pure_eq]; rfl
   · simp [tsnd, binaturality, Function.comp, functor_norm]
 #align bitraversable.is_lawful_traversable Bitraversable.isLawfulTraversable
 
@@ -151,7 +151,7 @@ instance : Bitraversable (bicompr F t) where bitraverse := @Bicompr.bitraverse t
 instance [LawfulTraversable F] [LawfulBitraversable t] : LawfulBitraversable (bicompr F t) := by
   constructor <;> intros <;>
     simp [bitraverse, Bicompr.bitraverse, bitraverse_id_id, functor_norm]
-  · simp [bitraverse_eq_bimap_id', traverse_eq_map_id']; rfl
+  · simp only [bitraverse_eq_bimap_id', traverse_eq_map_id', Function.comp_apply, Id.pure_eq]; rfl
   · dsimp only [bicompr]
     simp [naturality, binaturality']

1e7f6b9a

chore: remove a bad @[simp] in Control/Traversable (#9538)

This @[simp] attribute was bad all along, and with a change to the simp algorithm in leanprover/lean4#3124, finally starting breaking things.

Co-authored-by: Scott Morrison <scott.morrison@gmail.com>

f8a022db

Diff

@@ -46,7 +46,7 @@ instance : Bitraversable Prod where bitraverse := @Prod.bitraverse
 
 instance : LawfulBitraversable Prod := by
   constructor <;> intros <;> casesm _ × _ <;>
-    simp [bitraverse, Prod.bitraverse, functor_norm, -ApplicativeTransformation.app_eq_coe] <;> rfl
+    simp [bitraverse, Prod.bitraverse, functor_norm] <;> rfl
 
 open Functor
 
@@ -60,7 +60,7 @@ instance : Bitraversable Sum where bitraverse := @Sum.bitraverse
 
 instance : LawfulBitraversable Sum := by
   constructor <;> intros <;> casesm _ ⊕ _ <;>
-    simp [bitraverse, Sum.bitraverse, functor_norm, -ApplicativeTransformation.app_eq_coe] <;> rfl
+    simp [bitraverse, Sum.bitraverse, functor_norm] <;> rfl
 
 
 set_option linter.unusedVariables false in
@@ -102,9 +102,9 @@ instance (priority := 10) Bitraversable.traversable {α} : Traversable (t α) wh
 instance (priority := 10) Bitraversable.isLawfulTraversable [LawfulBitraversable t] {α} :
     LawfulTraversable (t α) := by
   constructor <;> intros <;>
-    simp [traverse, comp_tsnd, functor_norm, -ApplicativeTransformation.app_eq_coe]
+    simp [traverse, comp_tsnd, functor_norm]
   · simp [tsnd_eq_snd_id]; rfl
-  · simp [tsnd, binaturality, Function.comp, functor_norm, -ApplicativeTransformation.app_eq_coe]
+  · simp [tsnd, binaturality, Function.comp, functor_norm]
 #align bitraversable.is_lawful_traversable Bitraversable.isLawfulTraversable
 
 end
@@ -129,7 +129,7 @@ instance [LawfulTraversable F] [LawfulTraversable G] [LawfulBitraversable t] :
     LawfulBitraversable (bicompl t F G) := by
   constructor <;> intros <;>
     simp [bitraverse, Bicompl.bitraverse, bimap, traverse_id, bitraverse_id_id, comp_bitraverse,
-      functor_norm, -ApplicativeTransformation.app_eq_coe]
+      functor_norm]
   · simp [traverse_eq_map_id', bitraverse_eq_bimap_id]
   · dsimp only [bicompl]
     simp [binaturality, naturality_pf]
@@ -150,8 +150,7 @@ instance : Bitraversable (bicompr F t) where bitraverse := @Bicompr.bitraverse t
 
 instance [LawfulTraversable F] [LawfulBitraversable t] : LawfulBitraversable (bicompr F t) := by
   constructor <;> intros <;>
-    simp [bitraverse, Bicompr.bitraverse, bitraverse_id_id, functor_norm,
-      -ApplicativeTransformation.app_eq_coe]
+    simp [bitraverse, Bicompr.bitraverse, bitraverse_id_id, functor_norm]
   · simp [bitraverse_eq_bimap_id', traverse_eq_map_id']; rfl
   · dsimp only [bicompr]
     simp [naturality, binaturality']

1e7f6b9a

chore: script to replace headers with #align_import statements (#5979)

depends on: #5966

Co-authored-by: Eric Wieser <wieser.eric@gmail.com> Co-authored-by: Scott Morrison <scott.morrison@gmail.com>

89aa3a3b

Diff

@@ -2,15 +2,12 @@
 Copyright (c) 2019 Simon Hudon. All rights reserved.
 Released under Apache 2.0 license as described in the file LICENSE.
 Authors: Simon Hudon
-
-! This file was ported from Lean 3 source module control.bitraversable.instances
-! leanprover-community/mathlib commit 1e7f6b9a746d445350890f3ad5236f3fc686c103
-! Please do not edit these lines, except to modify the commit id
-! if you have ported upstream changes.
 -/
 import Mathlib.Control.Bitraversable.Lemmas
 import Mathlib.Control.Traversable.Lemmas
 
+#align_import control.bitraversable.instances from "leanprover-community/mathlib"@"1e7f6b9a746d445350890f3ad5236f3fc686c103"
+
 /-!
 # Bitraversable instances

1e7f6b9a

style: IsLawfulTraversable -> LawfulTraversable (#5737)

0c08a8fa

Diff

@@ -103,7 +103,7 @@ instance (priority := 10) Bitraversable.traversable {α} : Traversable (t α) wh
 #align bitraversable.traversable Bitraversable.traversable
 
 instance (priority := 10) Bitraversable.isLawfulTraversable [LawfulBitraversable t] {α} :
-    IsLawfulTraversable (t α) := by
+    LawfulTraversable (t α) := by
   constructor <;> intros <;>
     simp [traverse, comp_tsnd, functor_norm, -ApplicativeTransformation.app_eq_coe]
   · simp [tsnd_eq_snd_id]; rfl
@@ -112,7 +112,7 @@ instance (priority := 10) Bitraversable.isLawfulTraversable [LawfulBitraversable
 
 end
 
-open Bifunctor Traversable IsLawfulTraversable LawfulBitraversable
+open Bifunctor Traversable LawfulTraversable LawfulBitraversable
 
 open Function (bicompl bicompr)
 
@@ -128,7 +128,7 @@ nonrec def Bicompl.bitraverse {m} [Applicative m] {α β α' β'} (f : α → m
 
 instance : Bitraversable (bicompl t F G) where bitraverse := @Bicompl.bitraverse t _ F G _ _
 
-instance [IsLawfulTraversable F] [IsLawfulTraversable G] [LawfulBitraversable t] :
+instance [LawfulTraversable F] [LawfulTraversable G] [LawfulBitraversable t] :
     LawfulBitraversable (bicompl t F G) := by
   constructor <;> intros <;>
     simp [bitraverse, Bicompl.bitraverse, bimap, traverse_id, bitraverse_id_id, comp_bitraverse,
@@ -151,7 +151,7 @@ nonrec def Bicompr.bitraverse {m} [Applicative m] {α β α' β'} (f : α → m
 
 instance : Bitraversable (bicompr F t) where bitraverse := @Bicompr.bitraverse t _ F _
 
-instance [IsLawfulTraversable F] [LawfulBitraversable t] : LawfulBitraversable (bicompr F t) := by
+instance [LawfulTraversable F] [LawfulBitraversable t] : LawfulBitraversable (bicompr F t) := by
   constructor <;> intros <;>
     simp [bitraverse, Bicompr.bitraverse, bitraverse_id_id, functor_norm,
       -ApplicativeTransformation.app_eq_coe]

1e7f6b9a

feat: port Control.Bitraversable.Instances (#5225)

98c34d9e

`control.bitraversable.instances` ⟷ `Mathlib.Control.Bitraversable.Instances`

Changes since the initial port

Changes in mathlib3

Changes in mathlib3port

Changes in mathlib4

Dependencies 7

control.bitraversable.instances ⟷ Mathlib.Control.Bitraversable.Instances

Changes since the initial port

Changes in mathlib3

Changes in mathlib3port

Changes in mathlib4

Dependencies 7

`control.bitraversable.instances` ⟷ `Mathlib.Control.Bitraversable.Instances`