control.equiv_functor.instances | Mathlib porting status

Changes since the initial port

The following section lists changes to this file in mathlib3 and mathlib4 that occured after the initial port. Most recent changes are shown first. Hovering over a commit will show all commits associated with the same mathlib3 commit.

Changes in mathlib3

9003f287

(last sync)

Changes in mathlib3port

mathlib3

mathlib3port

cc70d914

bump to nightly-2023-09-24-06

mathlib commit https://github.com/leanprover-community/mathlib/commit/ce64cd319bb6b3e82f31c2d38e79080d377be451

5655435f

Diff

@@ -3,8 +3,8 @@ Copyright (c) 2020 Scott Morrison. All rights reserved.
 Released under Apache 2.0 license as described in the file LICENSE.
 Authors: Scott Morrison
 -/
-import Mathbin.Data.Fintype.Basic
-import Mathbin.Control.EquivFunctor
+import Data.Fintype.Basic
+import Control.EquivFunctor
 
 #align_import control.equiv_functor.instances from "leanprover-community/mathlib"@"cc70d9141824ea8982d1562ce009952f2c3ece30"

cc70d914

bump to nightly-2023-07-20-09

mathlib commit https://github.com/leanprover-community/mathlib/commit/8ea5598db6caeddde6cb734aa179cc2408dbd345

9c56d0dd

Diff

@@ -2,15 +2,12 @@
 Copyright (c) 2020 Scott Morrison. All rights reserved.
 Released under Apache 2.0 license as described in the file LICENSE.
 Authors: Scott Morrison
-
-! This file was ported from Lean 3 source module control.equiv_functor.instances
-! leanprover-community/mathlib commit cc70d9141824ea8982d1562ce009952f2c3ece30
-! Please do not edit these lines, except to modify the commit id
-! if you have ported upstream changes.
 -/
 import Mathbin.Data.Fintype.Basic
 import Mathbin.Control.EquivFunctor
 
+#align_import control.equiv_functor.instances from "leanprover-community/mathlib"@"cc70d9141824ea8982d1562ce009952f2c3ece30"
+
 /-!
 # `equiv_functor` instances

cc70d914

bump to nightly-2023-02-21-16

mathlib commit https://github.com/leanprover-community/mathlib/commit/bd9851ca476957ea4549eb19b40e7b5ade9428cc

1107b979

Changes in mathlib4

mathlib3

mathlib4

9003f287

fix: attribute [simp] ... in -> attribute [local simp] ... in (#7678)

Mathlib.Logic.Unique contains the line attribute [simp] eq_iff_true_of_subsingleton in ...:

https://github.com/leanprover-community/mathlib4/blob/96a11c7aac574c00370c2b3dab483cb676405c5d/Mathlib/Logic/Unique.lean#L255-L256

Despite what the in part may imply, this adds the lemma to the simp set "globally", including for downstream files; it is likely that attribute [local simp] eq_iff_true_of_subsingleton in ... was meant instead (or maybe scoped simp, but I think "scoped" refers to the current namespace). Indeed, the relevant lemma is not marked with @[simp] for possible slowness: https://github.com/leanprover/std4/blob/846e9e1d6bb534774d1acd2dc430e70987da3c18/Std/Logic.lean#L749. Adding it to the simp set causes the example at https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/Regression.20in.20simp to slow down.

This PR changes this and fixes the relevant downstream simps. There was also one ocurrence of attribute [simp] FullSubcategory.comp_def FullSubcategory.id_def in in Mathlib.CategoryTheory.Monoidal.Subcategory but that was much easier to fix.

https://github.com/leanprover-community/mathlib4/blob/bc49eb9ba756a233370b4b68bcdedd60402f71ed/Mathlib/CategoryTheory/Monoidal/Subcategory.lean#L118-L119

1fe87718

Diff

@@ -19,8 +19,8 @@ open Equiv
 
 instance EquivFunctorUnique : EquivFunctor Unique where
   map e := Equiv.uniqueCongr e
-  map_refl' α := by simp
-  map_trans' := by simp
+  map_refl' α := by simp [eq_iff_true_of_subsingleton]
+  map_trans' := by simp [eq_iff_true_of_subsingleton]
 #align equiv_functor_unique EquivFunctorUnique
 
 instance EquivFunctorPerm : EquivFunctor Perm where
@@ -44,6 +44,6 @@ instance EquivFunctorFinset : EquivFunctor Finset where
 
 instance EquivFunctorFintype : EquivFunctor Fintype where
   map e s := Fintype.ofBijective e e.bijective
-  map_refl' α := by ext; simp
-  map_trans' := by simp
+  map_refl' α := by ext; simp [eq_iff_true_of_subsingleton]
+  map_trans' := by simp [eq_iff_true_of_subsingleton]
 #align equiv_functor_fintype EquivFunctorFintype

9003f287

chore: script to replace headers with #align_import statements (#5979)

depends on: #5966

Co-authored-by: Eric Wieser <wieser.eric@gmail.com> Co-authored-by: Scott Morrison <scott.morrison@gmail.com>

89aa3a3b

Diff

@@ -2,15 +2,12 @@
 Copyright (c) 2020 Scott Morrison. All rights reserved.
 Released under Apache 2.0 license as described in the file LICENSE.
 Authors: Scott Morrison
-
-! This file was ported from Lean 3 source module control.equiv_functor.instances
-! leanprover-community/mathlib commit 9003f28797c0664a49e4179487267c494477d853
-! Please do not edit these lines, except to modify the commit id
-! if you have ported upstream changes.
 -/
 import Mathlib.Data.Fintype.Basic
 import Mathlib.Control.EquivFunctor
 
+#align_import control.equiv_functor.instances from "leanprover-community/mathlib"@"9003f28797c0664a49e4179487267c494477d853"
+
 /-!
 # `EquivFunctor` instances

9003f287

chore: fix focusing dots (#5708)

This PR is the result of running

find . -type f -name "*.lean" -exec sed -i -E 's/^( +)\. /\1· /' {} \;
find . -type f -name "*.lean" -exec sed -i -E 'N;s/^( +·)\n +(.*)$/\1 \2/;P;D' {} \;

which firstly replaces . focusing dots with · and secondly removes isolated instances of such dots, unifying them with the following line. A new rule is placed in the style linter to verify this.

cb02d09e

Diff

@@ -39,9 +39,9 @@ instance EquivFunctorFinset : EquivFunctor Finset where
   map_refl' α := by ext; simp
   map_trans' k h := by
     ext _ a; simp; constructor <;> intro h'
-    . let ⟨a, ha₁, ha₂⟩ := h'
+    · let ⟨a, ha₁, ha₂⟩ := h'
       rw [← ha₂]; simp; apply ha₁
-    . exists (Equiv.symm k) ((Equiv.symm h) a)
+    · exists (Equiv.symm k) ((Equiv.symm h) a)
       simp [h']
 #align equiv_functor_finset EquivFunctorFinset

9003f287

feat: port Control.EquivFunctor.Instances (#1613)

c3d42c9a

`control.equiv_functor.instances` ⟷ `Mathlib.Control.EquivFunctor.Instances`

Changes since the initial port

Changes in mathlib3

Changes in mathlib3port

Changes in mathlib4

Dependencies 2 + 154

control.equiv_functor.instances ⟷ Mathlib.Control.EquivFunctor.Instances

Changes since the initial port

Changes in mathlib3

Changes in mathlib3port

Changes in mathlib4

Dependencies 2 + 154

`control.equiv_functor.instances` ⟷ `Mathlib.Control.EquivFunctor.Instances`