Changes since the initial port

The following section lists changes to this file in mathlib3 and mathlib4 that occured after the initial port. Most recent changes are shown first. Hovering over a commit will show all commits associated with the same mathlib3 commit.

Changes in mathlib3

008205aa

(last sync)

Changes in mathlib3port

mathlib3

mathlib3port

4d392a6c

bump to nightly-2024-04-06-08

mathlib commit https://github.com/leanprover-community/mathlib/commit/65a1391a0106c9204fe45bc73a039f056558cb83

e34029c9

Diff

@@ -4,7 +4,7 @@ Released under Apache 2.0 license as described in the file LICENSE.
 Authors: Jeremy Avigad, Mario Carneiro, Simon Hudon
 -/
 import Data.Fin.Fin2
-import Data.Typevec
+import Data.TypeVec
 
 #align_import control.functor.multivariate from "leanprover-community/mathlib"@"4d392a6c9c4539cbeca399b3ee0afea398fbd2eb"

4d392a6c

bump to nightly-2023-09-24-06

mathlib commit https://github.com/leanprover-community/mathlib/commit/ce64cd319bb6b3e82f31c2d38e79080d377be451

5655435f

Diff

@@ -3,8 +3,8 @@ Copyright (c) 2018 Jeremy Avigad. All rights reserved.
 Released under Apache 2.0 license as described in the file LICENSE.
 Authors: Jeremy Avigad, Mario Carneiro, Simon Hudon
 -/
-import Mathbin.Data.Fin.Fin2
-import Mathbin.Data.Typevec
+import Data.Fin.Fin2
+import Data.Typevec
 
 #align_import control.functor.multivariate from "leanprover-community/mathlib"@"4d392a6c9c4539cbeca399b3ee0afea398fbd2eb"

4d392a6c

bump to nightly-2023-07-20-09

mathlib commit https://github.com/leanprover-community/mathlib/commit/8ea5598db6caeddde6cb734aa179cc2408dbd345

9c56d0dd

Diff

@@ -2,15 +2,12 @@
 Copyright (c) 2018 Jeremy Avigad. All rights reserved.
 Released under Apache 2.0 license as described in the file LICENSE.
 Authors: Jeremy Avigad, Mario Carneiro, Simon Hudon
-
-! This file was ported from Lean 3 source module control.functor.multivariate
-! leanprover-community/mathlib commit 4d392a6c9c4539cbeca399b3ee0afea398fbd2eb
-! Please do not edit these lines, except to modify the commit id
-! if you have ported upstream changes.
 -/
 import Mathbin.Data.Fin.Fin2
 import Mathbin.Data.Typevec
 
+#align_import control.functor.multivariate from "leanprover-community/mathlib"@"4d392a6c9c4539cbeca399b3ee0afea398fbd2eb"
+
 /-!
 > THIS FILE IS SYNCHRONIZED WITH MATHLIB4.
 > Any changes to this file require a corresponding PR to mathlib4.

4d392a6c

bump to nightly-2023-06-20-01

mathlib commit https://github.com/leanprover-community/mathlib/commit/2a0ce625dbb0ffbc7d1316597de0b25c1ec75303

9b351f8c

Diff

@@ -218,9 +218,9 @@ theorem LiftP_PredLast_iff {β} (p : β → Prop) (x : F (α ::: β)) :
   by
   dsimp only [liftp, liftp']
   apply exists_iff_exists_of_mono F (f _ n α) (g _ n α)
-  · ext (i⟨x, _⟩); cases i <;> rfl
+  · ext i ⟨x, _⟩; cases i <;> rfl
   · intros; rw [MvFunctor.map_map, (· ⊚ ·)]
-    congr <;> ext (i⟨x, _⟩) <;> cases i <;> rfl
+    congr <;> ext i ⟨x, _⟩ <;> cases i <;> rfl
 #align mvfunctor.liftp_last_pred_iff MvFunctor.LiftP_PredLast_iff
 -/
 
@@ -255,9 +255,9 @@ theorem LiftR_RelLast_iff (x y : F (α ::: β)) :
   by
   dsimp only [liftr, liftr']
   apply exists_iff_exists_of_mono F (f rr _ _) (g rr _ _)
-  · ext (i⟨x, _⟩) : 2; cases i <;> rfl
+  · ext i ⟨x, _⟩ : 2; cases i <;> rfl
   · intros; rw [MvFunctor.map_map, MvFunctor.map_map, (· ⊚ ·), (· ⊚ ·)]
-    congr <;> ext (i⟨x, _⟩) <;> cases i <;> rfl
+    congr <;> ext i ⟨x, _⟩ <;> cases i <;> rfl
 #align mvfunctor.liftr_last_rel_iff MvFunctor.LiftR_RelLast_iff
 -/

4d392a6c

bump to nightly-2023-06-13-21

mathlib commit https://github.com/leanprover-community/mathlib/commit/9fb8964792b4237dac6200193a0d533f1b3f7423

829520ac

Diff

@@ -38,7 +38,6 @@ class MvFunctor {n : ℕ} (F : TypeVec n → Type _) where
 #align mvfunctor MvFunctor
 -/
 
--- mathport name: mvfunctor.map
 scoped[MvFunctor] infixr:100 " <$$> " => MvFunctor.map
 
 variable {n : ℕ}
@@ -213,6 +212,7 @@ private def g :
   | _, α, Fin2.fz, x => ⟨x.val, x.property⟩
 
 /- ./././Mathport/Syntax/Translate/Expr.lean:177:8: unsupported: ambiguous notation -/
+#print MvFunctor.LiftP_PredLast_iff /-
 theorem LiftP_PredLast_iff {β} (p : β → Prop) (x : F (α ::: β)) :
     LiftP' (PredLast' _ p) x ↔ LiftP (PredLast _ p) x :=
   by
@@ -222,6 +222,7 @@ theorem LiftP_PredLast_iff {β} (p : β → Prop) (x : F (α ::: β)) :
   · intros; rw [MvFunctor.map_map, (· ⊚ ·)]
     congr <;> ext (i⟨x, _⟩) <;> cases i <;> rfl
 #align mvfunctor.liftp_last_pred_iff MvFunctor.LiftP_PredLast_iff
+-/
 
 open Function
 
@@ -248,6 +249,7 @@ private def g :
   | _, α, Fin2.fz, x => ⟨x.val, x.property⟩
 
 /- ./././Mathport/Syntax/Translate/Expr.lean:177:8: unsupported: ambiguous notation -/
+#print MvFunctor.LiftR_RelLast_iff /-
 theorem LiftR_RelLast_iff (x y : F (α ::: β)) :
     LiftR' (RelLast' _ rr) x y ↔ LiftR (RelLast _ rr) x y :=
   by
@@ -257,6 +259,7 @@ theorem LiftR_RelLast_iff (x y : F (α ::: β)) :
   · intros; rw [MvFunctor.map_map, MvFunctor.map_map, (· ⊚ ·), (· ⊚ ·)]
     congr <;> ext (i⟨x, _⟩) <;> cases i <;> rfl
 #align mvfunctor.liftr_last_rel_iff MvFunctor.LiftR_RelLast_iff
+-/
 
 end LiftpLastPredIff

4d392a6c

bump to nightly-2023-06-04-18

mathlib commit https://github.com/leanprover-community/mathlib/commit/5f25c089cb34db4db112556f23c50d12da81b297

3fb4268b

Diff

@@ -67,7 +67,7 @@ def LiftR {α : TypeVec n} (r : ∀ {i}, α i → α i → Prop) (x y : F α) :
 /-- given `x : F α` and a projection `i` of type vector `α`, `supp x i` is the set
 of `α.i` contained in `x` -/
 def supp {α : TypeVec n} (x : F α) (i : Fin2 n) : Set (α i) :=
-  { y : α i | ∀ ⦃p⦄, LiftP p x → p i y }
+  {y : α i | ∀ ⦃p⦄, LiftP p x → p i y}
 #align mvfunctor.supp MvFunctor.supp
 -/

4d392a6c

bump to nightly-2023-06-01-16

mathlib commit https://github.com/leanprover-community/mathlib/commit/cca40788df1b8755d5baf17ab2f27dacc2e17acb

b9c87c70

Diff

@@ -146,7 +146,7 @@ variable (F)
 theorem exists_iff_exists_of_mono {p : F α → Prop} {q : F β → Prop} (f : α ⟹ β) (g : β ⟹ α)
     (h₀ : f ⊚ g = id) (h₁ : ∀ u : F α, p u ↔ q (f <$$> u)) : (∃ u : F α, p u) ↔ ∃ u : F β, q u :=
   by
-  constructor <;> rintro ⟨u, h₂⟩ <;> [use f <$$> u;use g <$$> u]
+  constructor <;> rintro ⟨u, h₂⟩ <;> [use f <$$> u; use g <$$> u]
   · apply (h₁ u).mp h₂
   · apply (h₁ _).mpr _
     simp only [MvFunctor.map_map, h₀, LawfulMvFunctor.id_map, h₂]
@@ -219,7 +219,7 @@ theorem LiftP_PredLast_iff {β} (p : β → Prop) (x : F (α ::: β)) :
   dsimp only [liftp, liftp']
   apply exists_iff_exists_of_mono F (f _ n α) (g _ n α)
   · ext (i⟨x, _⟩); cases i <;> rfl
-  · intros ; rw [MvFunctor.map_map, (· ⊚ ·)]
+  · intros; rw [MvFunctor.map_map, (· ⊚ ·)]
     congr <;> ext (i⟨x, _⟩) <;> cases i <;> rfl
 #align mvfunctor.liftp_last_pred_iff MvFunctor.LiftP_PredLast_iff
 
@@ -254,7 +254,7 @@ theorem LiftR_RelLast_iff (x y : F (α ::: β)) :
   dsimp only [liftr, liftr']
   apply exists_iff_exists_of_mono F (f rr _ _) (g rr _ _)
   · ext (i⟨x, _⟩) : 2; cases i <;> rfl
-  · intros ; rw [MvFunctor.map_map, MvFunctor.map_map, (· ⊚ ·), (· ⊚ ·)]
+  · intros; rw [MvFunctor.map_map, MvFunctor.map_map, (· ⊚ ·), (· ⊚ ·)]
     congr <;> ext (i⟨x, _⟩) <;> cases i <;> rfl
 #align mvfunctor.liftr_last_rel_iff MvFunctor.LiftR_RelLast_iff

4d392a6c

bump to nightly-2023-05-28-18

mathlib commit https://github.com/leanprover-community/mathlib/commit/917c3c072e487b3cccdbfeff17e75b40e45f66cb

8d353152

Diff

@@ -28,7 +28,7 @@ Features:
 
 universe u v w
 
-open MvFunctor
+open scoped MvFunctor
 
 #print MvFunctor /-
 /-- multivariate functors, i.e. functor between the category of type vectors

4d392a6c

bump to nightly-2023-05-28-06

mathlib commit https://github.com/leanprover-community/mathlib/commit/917c3c072e487b3cccdbfeff17e75b40e45f66cb

ba5d8b97

Diff

@@ -212,12 +212,6 @@ private def g :
     ⟨x.val, cast (by simp only [pred_last] <;> erw [const_iff_true]) x.property⟩
   | _, α, Fin2.fz, x => ⟨x.val, x.property⟩
 
-/- warning: mvfunctor.liftp_last_pred_iff -> MvFunctor.LiftP_PredLast_iff is a dubious translation:
-lean 3 declaration is
-  forall {n : Nat} {F : (TypeVec.{u1} (HAdd.hAdd.{0, 0, 0} Nat Nat Nat (instHAdd.{0} Nat Nat.hasAdd) n (OfNat.ofNat.{0} Nat 1 (OfNat.mk.{0} Nat 1 (One.one.{0} Nat Nat.hasOne))))) -> Type.{u2}} [_inst_1 : MvFunctor.{u1, u2} (HAdd.hAdd.{0, 0, 0} Nat Nat Nat (instHAdd.{0} Nat Nat.hasAdd) n (OfNat.ofNat.{0} Nat 1 (OfNat.mk.{0} Nat 1 (One.one.{0} Nat Nat.hasOne)))) F] [_inst_2 : LawfulMvFunctor.{u1, u2} (HAdd.hAdd.{0, 0, 0} Nat Nat Nat (instHAdd.{0} Nat Nat.hasAdd) n (OfNat.ofNat.{0} Nat 1 (OfNat.mk.{0} Nat 1 (One.one.{0} Nat Nat.hasOne)))) F _inst_1] {α : TypeVec.{u1} n} {β : Type.{u1}} (p : β -> Prop) (x : F (TypeVec.append1.{u1} n α β)), Iff (MvFunctor.LiftP'.{u1, u2} (HAdd.hAdd.{0, 0, 0} Nat Nat Nat (instHAdd.{0} Nat Nat.hasAdd) n (OfNat.ofNat.{0} Nat 1 (OfNat.mk.{0} Nat 1 (One.one.{0} Nat Nat.hasOne)))) (TypeVec.append1.{u1} n α β) F _inst_1 (TypeVec.PredLast'.{u1} n α β p) x) (MvFunctor.LiftP.{u1, u2} (HAdd.hAdd.{0, 0, 0} Nat Nat Nat (instHAdd.{0} Nat Nat.hasAdd) n (OfNat.ofNat.{0} Nat 1 (OfNat.mk.{0} Nat 1 (One.one.{0} Nat Nat.hasOne)))) F _inst_1 (fun (i : Fin2 (HAdd.hAdd.{0, 0, 0} Nat Nat Nat (instHAdd.{0} Nat Nat.hasAdd) n (OfNat.ofNat.{0} Nat 1 (OfNat.mk.{0} Nat 1 (One.one.{0} Nat Nat.hasOne))))) => TypeVec.append1.{u1} n α β i) (TypeVec.PredLast.{u1} n α β p) x)
-but is expected to have type
-  forall {n : Nat} {F : (TypeVec.{u2} (HAdd.hAdd.{0, 0, 0} Nat Nat Nat (instHAdd.{0} Nat instAddNat) n (OfNat.ofNat.{0} Nat 1 (instOfNatNat 1)))) -> Type.{u1}} [_inst_1 : MvFunctor.{u2, u1} (HAdd.hAdd.{0, 0, 0} Nat Nat Nat (instHAdd.{0} Nat instAddNat) n (OfNat.ofNat.{0} Nat 1 (instOfNatNat 1))) F] [_inst_2 : LawfulMvFunctor.{u2, u1} (HAdd.hAdd.{0, 0, 0} Nat Nat Nat (instHAdd.{0} Nat instAddNat) n (OfNat.ofNat.{0} Nat 1 (instOfNatNat 1))) F _inst_1] {α : TypeVec.{u2} n} {β : Type.{u2}} (p : β -> Prop) (x : F (TypeVec.append1.{u2} n α β)), Iff (MvFunctor.LiftP'.{u2, u1} (HAdd.hAdd.{0, 0, 0} Nat Nat Nat (instHAdd.{0} Nat instAddNat) n (OfNat.ofNat.{0} Nat 1 (instOfNatNat 1))) (TypeVec.append1.{u2} n α β) F _inst_1 (TypeVec.PredLast'.{u2} n α β p) x) (MvFunctor.LiftP.{u2, u1} (HAdd.hAdd.{0, 0, 0} Nat Nat Nat (instHAdd.{0} Nat instAddNat) n (OfNat.ofNat.{0} Nat 1 (instOfNatNat 1))) F _inst_1 (fun (i : Fin2 (HAdd.hAdd.{0, 0, 0} Nat Nat Nat (instHAdd.{0} Nat instAddNat) n (OfNat.ofNat.{0} Nat 1 (instOfNatNat 1)))) => TypeVec.append1.{u2} n α β i) (TypeVec.PredLast.{u2} n α β p) x)
-Case conversion may be inaccurate. Consider using '#align mvfunctor.liftp_last_pred_iff MvFunctor.LiftP_PredLast_iffₓ'. -/
 /- ./././Mathport/Syntax/Translate/Expr.lean:177:8: unsupported: ambiguous notation -/
 theorem LiftP_PredLast_iff {β} (p : β → Prop) (x : F (α ::: β)) :
     LiftP' (PredLast' _ p) x ↔ LiftP (PredLast _ p) x :=
@@ -253,12 +247,6 @@ private def g :
     ⟨x.val, cast (by simp only [rel_last] <;> erw [repeat_eq_iff_eq]) x.property⟩
   | _, α, Fin2.fz, x => ⟨x.val, x.property⟩
 
-/- warning: mvfunctor.liftr_last_rel_iff -> MvFunctor.LiftR_RelLast_iff is a dubious translation:
-lean 3 declaration is
-  forall {n : Nat} {F : (TypeVec.{u1} (HAdd.hAdd.{0, 0, 0} Nat Nat Nat (instHAdd.{0} Nat Nat.hasAdd) n (OfNat.ofNat.{0} Nat 1 (OfNat.mk.{0} Nat 1 (One.one.{0} Nat Nat.hasOne))))) -> Type.{u2}} [_inst_1 : MvFunctor.{u1, u2} (HAdd.hAdd.{0, 0, 0} Nat Nat Nat (instHAdd.{0} Nat Nat.hasAdd) n (OfNat.ofNat.{0} Nat 1 (OfNat.mk.{0} Nat 1 (One.one.{0} Nat Nat.hasOne)))) F] [_inst_2 : LawfulMvFunctor.{u1, u2} (HAdd.hAdd.{0, 0, 0} Nat Nat Nat (instHAdd.{0} Nat Nat.hasAdd) n (OfNat.ofNat.{0} Nat 1 (OfNat.mk.{0} Nat 1 (One.one.{0} Nat Nat.hasOne)))) F _inst_1] {α : TypeVec.{u1} n} {β : Type.{u1}} (rr : β -> β -> Prop) (x : F (TypeVec.append1.{u1} n α β)) (y : F (TypeVec.append1.{u1} n α β)), Iff (MvFunctor.LiftR'.{u1, u2} (HAdd.hAdd.{0, 0, 0} Nat Nat Nat (instHAdd.{0} Nat Nat.hasAdd) n (OfNat.ofNat.{0} Nat 1 (OfNat.mk.{0} Nat 1 (One.one.{0} Nat Nat.hasOne)))) (TypeVec.append1.{u1} n α β) F _inst_1 (TypeVec.RelLast'.{u1} n α β rr) x y) (MvFunctor.LiftR.{u1, u2} (HAdd.hAdd.{0, 0, 0} Nat Nat Nat (instHAdd.{0} Nat Nat.hasAdd) n (OfNat.ofNat.{0} Nat 1 (OfNat.mk.{0} Nat 1 (One.one.{0} Nat Nat.hasOne)))) F _inst_1 (fun (i : Fin2 (HAdd.hAdd.{0, 0, 0} Nat Nat Nat (instHAdd.{0} Nat Nat.hasAdd) n (OfNat.ofNat.{0} Nat 1 (OfNat.mk.{0} Nat 1 (One.one.{0} Nat Nat.hasOne))))) => TypeVec.append1.{u1} n α β i) (TypeVec.RelLast.{u1} n α β β rr) x y)
-but is expected to have type
-  forall {n : Nat} {F : (TypeVec.{u2} (HAdd.hAdd.{0, 0, 0} Nat Nat Nat (instHAdd.{0} Nat instAddNat) n (OfNat.ofNat.{0} Nat 1 (instOfNatNat 1)))) -> Type.{u1}} [_inst_1 : MvFunctor.{u2, u1} (HAdd.hAdd.{0, 0, 0} Nat Nat Nat (instHAdd.{0} Nat instAddNat) n (OfNat.ofNat.{0} Nat 1 (instOfNatNat 1))) F] [_inst_2 : LawfulMvFunctor.{u2, u1} (HAdd.hAdd.{0, 0, 0} Nat Nat Nat (instHAdd.{0} Nat instAddNat) n (OfNat.ofNat.{0} Nat 1 (instOfNatNat 1))) F _inst_1] {α : TypeVec.{u2} n} {β : Type.{u2}} (rr : β -> β -> Prop) (x : F (TypeVec.append1.{u2} n α β)) (y : F (TypeVec.append1.{u2} n α β)), Iff (MvFunctor.LiftR'.{u2, u1} (HAdd.hAdd.{0, 0, 0} Nat Nat Nat (instHAdd.{0} Nat instAddNat) n (OfNat.ofNat.{0} Nat 1 (instOfNatNat 1))) (TypeVec.append1.{u2} n α β) F _inst_1 (TypeVec.RelLast'.{u2} n α β rr) x y) (MvFunctor.LiftR.{u2, u1} (HAdd.hAdd.{0, 0, 0} Nat Nat Nat (instHAdd.{0} Nat instAddNat) n (OfNat.ofNat.{0} Nat 1 (instOfNatNat 1))) F _inst_1 (fun {i : Fin2 (HAdd.hAdd.{0, 0, 0} Nat Nat Nat (instHAdd.{0} Nat instAddNat) n (OfNat.ofNat.{0} Nat 1 (instOfNatNat 1)))} => TypeVec.append1.{u2} n α β i) (fun {i._@.Mathlib.Control.Functor.Multivariate._hyg.3428 : Fin2 (HAdd.hAdd.{0, 0, 0} Nat Nat Nat (instHAdd.{0} Nat instAddNat) n (OfNat.ofNat.{0} Nat 1 (instOfNatNat 1)))} => TypeVec.RelLast.{u2} n α β β rr i._@.Mathlib.Control.Functor.Multivariate._hyg.3428) x y)
-Case conversion may be inaccurate. Consider using '#align mvfunctor.liftr_last_rel_iff MvFunctor.LiftR_RelLast_iffₓ'. -/
 /- ./././Mathport/Syntax/Translate/Expr.lean:177:8: unsupported: ambiguous notation -/
 theorem LiftR_RelLast_iff (x y : F (α ::: β)) :
     LiftR' (RelLast' _ rr) x y ↔ LiftR (RelLast _ rr) x y :=

4d392a6c

bump to nightly-2023-05-28-04

mathlib commit https://github.com/leanprover-community/mathlib/commit/917c3c072e487b3cccdbfeff17e75b40e45f66cb

6797a637

Diff

@@ -224,10 +224,8 @@ theorem LiftP_PredLast_iff {β} (p : β → Prop) (x : F (α ::: β)) :
   by
   dsimp only [liftp, liftp']
   apply exists_iff_exists_of_mono F (f _ n α) (g _ n α)
-  · ext (i⟨x, _⟩)
-    cases i <;> rfl
-  · intros
-    rw [MvFunctor.map_map, (· ⊚ ·)]
+  · ext (i⟨x, _⟩); cases i <;> rfl
+  · intros ; rw [MvFunctor.map_map, (· ⊚ ·)]
     congr <;> ext (i⟨x, _⟩) <;> cases i <;> rfl
 #align mvfunctor.liftp_last_pred_iff MvFunctor.LiftP_PredLast_iff
 
@@ -267,10 +265,8 @@ theorem LiftR_RelLast_iff (x y : F (α ::: β)) :
   by
   dsimp only [liftr, liftr']
   apply exists_iff_exists_of_mono F (f rr _ _) (g rr _ _)
-  · ext (i⟨x, _⟩) : 2
-    cases i <;> rfl
-  · intros
-    rw [MvFunctor.map_map, MvFunctor.map_map, (· ⊚ ·), (· ⊚ ·)]
+  · ext (i⟨x, _⟩) : 2; cases i <;> rfl
+  · intros ; rw [MvFunctor.map_map, MvFunctor.map_map, (· ⊚ ·), (· ⊚ ·)]
     congr <;> ext (i⟨x, _⟩) <;> cases i <;> rfl
 #align mvfunctor.liftr_last_rel_iff MvFunctor.LiftR_RelLast_iff

4d392a6c

bump to nightly-2023-05-28-03

mathlib commit https://github.com/leanprover-community/mathlib/commit/917c3c072e487b3cccdbfeff17e75b40e45f66cb

6c6011cf

Diff

@@ -202,7 +202,6 @@ private def f :
   | _, α, Fin2.fs i, x =>
     ⟨x.val, cast (by simp only [pred_last] <;> erw [const_iff_true]) x.property⟩
   | _, α, Fin2.fz, x => ⟨x.val, x.property⟩
-#align mvfunctor.f mvfunctor.f
 
 /- ./././Mathport/Syntax/Translate/Expr.lean:177:8: unsupported: ambiguous notation -/
 private def g :
@@ -212,7 +211,6 @@ private def g :
   | _, α, Fin2.fs i, x =>
     ⟨x.val, cast (by simp only [pred_last] <;> erw [const_iff_true]) x.property⟩
   | _, α, Fin2.fz, x => ⟨x.val, x.property⟩
-#align mvfunctor.g mvfunctor.g
 
 /- warning: mvfunctor.liftp_last_pred_iff -> MvFunctor.LiftP_PredLast_iff is a dubious translation:
 lean 3 declaration is
@@ -246,7 +244,6 @@ private def f :
   | _, α, Fin2.fs i, x =>
     ⟨x.val, cast (by simp only [rel_last] <;> erw [repeat_eq_iff_eq]) x.property⟩
   | _, α, Fin2.fz, x => ⟨x.val, x.property⟩
-#align mvfunctor.f mvfunctor.f
 
 /- ./././Mathport/Syntax/Translate/Expr.lean:177:8: unsupported: ambiguous notation -/
 private def g :
@@ -257,7 +254,6 @@ private def g :
   | _, α, Fin2.fs i, x =>
     ⟨x.val, cast (by simp only [rel_last] <;> erw [repeat_eq_iff_eq]) x.property⟩
   | _, α, Fin2.fz, x => ⟨x.val, x.property⟩
-#align mvfunctor.g mvfunctor.g
 
 /- warning: mvfunctor.liftr_last_rel_iff -> MvFunctor.LiftR_RelLast_iff is a dubious translation:
 lean 3 declaration is

4d392a6c

bump to nightly-2023-05-24-06

mathlib commit https://github.com/leanprover-community/mathlib/commit/8d33f09cd7089ecf074b4791907588245aec5d1b

fbc7b476

Diff

@@ -146,7 +146,7 @@ variable (F)
 theorem exists_iff_exists_of_mono {p : F α → Prop} {q : F β → Prop} (f : α ⟹ β) (g : β ⟹ α)
     (h₀ : f ⊚ g = id) (h₁ : ∀ u : F α, p u ↔ q (f <$$> u)) : (∃ u : F α, p u) ↔ ∃ u : F β, q u :=
   by
-  constructor <;> rintro ⟨u, h₂⟩ <;> [use f <$$> u, use g <$$> u]
+  constructor <;> rintro ⟨u, h₂⟩ <;> [use f <$$> u;use g <$$> u]
   · apply (h₁ u).mp h₂
   · apply (h₁ _).mpr _
     simp only [MvFunctor.map_map, h₀, LawfulMvFunctor.id_map, h₂]

4d392a6c

bump to nightly-2023-05-19-16

mathlib commit https://github.com/leanprover-community/mathlib/commit/95a87616d63b3cb49d3fe678d416fbe9c4217bf4

a31df521

Diff

@@ -263,7 +263,7 @@ private def g :
 lean 3 declaration is
   forall {n : Nat} {F : (TypeVec.{u1} (HAdd.hAdd.{0, 0, 0} Nat Nat Nat (instHAdd.{0} Nat Nat.hasAdd) n (OfNat.ofNat.{0} Nat 1 (OfNat.mk.{0} Nat 1 (One.one.{0} Nat Nat.hasOne))))) -> Type.{u2}} [_inst_1 : MvFunctor.{u1, u2} (HAdd.hAdd.{0, 0, 0} Nat Nat Nat (instHAdd.{0} Nat Nat.hasAdd) n (OfNat.ofNat.{0} Nat 1 (OfNat.mk.{0} Nat 1 (One.one.{0} Nat Nat.hasOne)))) F] [_inst_2 : LawfulMvFunctor.{u1, u2} (HAdd.hAdd.{0, 0, 0} Nat Nat Nat (instHAdd.{0} Nat Nat.hasAdd) n (OfNat.ofNat.{0} Nat 1 (OfNat.mk.{0} Nat 1 (One.one.{0} Nat Nat.hasOne)))) F _inst_1] {α : TypeVec.{u1} n} {β : Type.{u1}} (rr : β -> β -> Prop) (x : F (TypeVec.append1.{u1} n α β)) (y : F (TypeVec.append1.{u1} n α β)), Iff (MvFunctor.LiftR'.{u1, u2} (HAdd.hAdd.{0, 0, 0} Nat Nat Nat (instHAdd.{0} Nat Nat.hasAdd) n (OfNat.ofNat.{0} Nat 1 (OfNat.mk.{0} Nat 1 (One.one.{0} Nat Nat.hasOne)))) (TypeVec.append1.{u1} n α β) F _inst_1 (TypeVec.RelLast'.{u1} n α β rr) x y) (MvFunctor.LiftR.{u1, u2} (HAdd.hAdd.{0, 0, 0} Nat Nat Nat (instHAdd.{0} Nat Nat.hasAdd) n (OfNat.ofNat.{0} Nat 1 (OfNat.mk.{0} Nat 1 (One.one.{0} Nat Nat.hasOne)))) F _inst_1 (fun (i : Fin2 (HAdd.hAdd.{0, 0, 0} Nat Nat Nat (instHAdd.{0} Nat Nat.hasAdd) n (OfNat.ofNat.{0} Nat 1 (OfNat.mk.{0} Nat 1 (One.one.{0} Nat Nat.hasOne))))) => TypeVec.append1.{u1} n α β i) (TypeVec.RelLast.{u1} n α β β rr) x y)
 but is expected to have type
-  forall {n : Nat} {F : (TypeVec.{u2} (HAdd.hAdd.{0, 0, 0} Nat Nat Nat (instHAdd.{0} Nat instAddNat) n (OfNat.ofNat.{0} Nat 1 (instOfNatNat 1)))) -> Type.{u1}} [_inst_1 : MvFunctor.{u2, u1} (HAdd.hAdd.{0, 0, 0} Nat Nat Nat (instHAdd.{0} Nat instAddNat) n (OfNat.ofNat.{0} Nat 1 (instOfNatNat 1))) F] [_inst_2 : LawfulMvFunctor.{u2, u1} (HAdd.hAdd.{0, 0, 0} Nat Nat Nat (instHAdd.{0} Nat instAddNat) n (OfNat.ofNat.{0} Nat 1 (instOfNatNat 1))) F _inst_1] {α : TypeVec.{u2} n} {β : Type.{u2}} (rr : β -> β -> Prop) (x : F (TypeVec.append1.{u2} n α β)) (y : F (TypeVec.append1.{u2} n α β)), Iff (MvFunctor.LiftR'.{u2, u1} (HAdd.hAdd.{0, 0, 0} Nat Nat Nat (instHAdd.{0} Nat instAddNat) n (OfNat.ofNat.{0} Nat 1 (instOfNatNat 1))) (TypeVec.append1.{u2} n α β) F _inst_1 (TypeVec.RelLast'.{u2} n α β rr) x y) (MvFunctor.LiftR.{u2, u1} (HAdd.hAdd.{0, 0, 0} Nat Nat Nat (instHAdd.{0} Nat instAddNat) n (OfNat.ofNat.{0} Nat 1 (instOfNatNat 1))) F _inst_1 (fun {i : Fin2 (HAdd.hAdd.{0, 0, 0} Nat Nat Nat (instHAdd.{0} Nat instAddNat) n (OfNat.ofNat.{0} Nat 1 (instOfNatNat 1)))} => TypeVec.append1.{u2} n α β i) (fun {i._@.Mathlib.Control.Functor.Multivariate._hyg.3418 : Fin2 (HAdd.hAdd.{0, 0, 0} Nat Nat Nat (instHAdd.{0} Nat instAddNat) n (OfNat.ofNat.{0} Nat 1 (instOfNatNat 1)))} => TypeVec.RelLast.{u2} n α β β rr i._@.Mathlib.Control.Functor.Multivariate._hyg.3418) x y)
+  forall {n : Nat} {F : (TypeVec.{u2} (HAdd.hAdd.{0, 0, 0} Nat Nat Nat (instHAdd.{0} Nat instAddNat) n (OfNat.ofNat.{0} Nat 1 (instOfNatNat 1)))) -> Type.{u1}} [_inst_1 : MvFunctor.{u2, u1} (HAdd.hAdd.{0, 0, 0} Nat Nat Nat (instHAdd.{0} Nat instAddNat) n (OfNat.ofNat.{0} Nat 1 (instOfNatNat 1))) F] [_inst_2 : LawfulMvFunctor.{u2, u1} (HAdd.hAdd.{0, 0, 0} Nat Nat Nat (instHAdd.{0} Nat instAddNat) n (OfNat.ofNat.{0} Nat 1 (instOfNatNat 1))) F _inst_1] {α : TypeVec.{u2} n} {β : Type.{u2}} (rr : β -> β -> Prop) (x : F (TypeVec.append1.{u2} n α β)) (y : F (TypeVec.append1.{u2} n α β)), Iff (MvFunctor.LiftR'.{u2, u1} (HAdd.hAdd.{0, 0, 0} Nat Nat Nat (instHAdd.{0} Nat instAddNat) n (OfNat.ofNat.{0} Nat 1 (instOfNatNat 1))) (TypeVec.append1.{u2} n α β) F _inst_1 (TypeVec.RelLast'.{u2} n α β rr) x y) (MvFunctor.LiftR.{u2, u1} (HAdd.hAdd.{0, 0, 0} Nat Nat Nat (instHAdd.{0} Nat instAddNat) n (OfNat.ofNat.{0} Nat 1 (instOfNatNat 1))) F _inst_1 (fun {i : Fin2 (HAdd.hAdd.{0, 0, 0} Nat Nat Nat (instHAdd.{0} Nat instAddNat) n (OfNat.ofNat.{0} Nat 1 (instOfNatNat 1)))} => TypeVec.append1.{u2} n α β i) (fun {i._@.Mathlib.Control.Functor.Multivariate._hyg.3428 : Fin2 (HAdd.hAdd.{0, 0, 0} Nat Nat Nat (instHAdd.{0} Nat instAddNat) n (OfNat.ofNat.{0} Nat 1 (instOfNatNat 1)))} => TypeVec.RelLast.{u2} n α β β rr i._@.Mathlib.Control.Functor.Multivariate._hyg.3428) x y)
 Case conversion may be inaccurate. Consider using '#align mvfunctor.liftr_last_rel_iff MvFunctor.LiftR_RelLast_iffₓ'. -/
 /- ./././Mathport/Syntax/Translate/Expr.lean:177:8: unsupported: ambiguous notation -/
 theorem LiftR_RelLast_iff (x y : F (α ::: β)) :

4d392a6c

bump to nightly-2023-03-11-22

mathlib commit https://github.com/leanprover-community/mathlib/commit/3180fab693e2cee3bff62675571264cb8778b212

a8ee822f

Diff

@@ -263,7 +263,7 @@ private def g :
 lean 3 declaration is
   forall {n : Nat} {F : (TypeVec.{u1} (HAdd.hAdd.{0, 0, 0} Nat Nat Nat (instHAdd.{0} Nat Nat.hasAdd) n (OfNat.ofNat.{0} Nat 1 (OfNat.mk.{0} Nat 1 (One.one.{0} Nat Nat.hasOne))))) -> Type.{u2}} [_inst_1 : MvFunctor.{u1, u2} (HAdd.hAdd.{0, 0, 0} Nat Nat Nat (instHAdd.{0} Nat Nat.hasAdd) n (OfNat.ofNat.{0} Nat 1 (OfNat.mk.{0} Nat 1 (One.one.{0} Nat Nat.hasOne)))) F] [_inst_2 : LawfulMvFunctor.{u1, u2} (HAdd.hAdd.{0, 0, 0} Nat Nat Nat (instHAdd.{0} Nat Nat.hasAdd) n (OfNat.ofNat.{0} Nat 1 (OfNat.mk.{0} Nat 1 (One.one.{0} Nat Nat.hasOne)))) F _inst_1] {α : TypeVec.{u1} n} {β : Type.{u1}} (rr : β -> β -> Prop) (x : F (TypeVec.append1.{u1} n α β)) (y : F (TypeVec.append1.{u1} n α β)), Iff (MvFunctor.LiftR'.{u1, u2} (HAdd.hAdd.{0, 0, 0} Nat Nat Nat (instHAdd.{0} Nat Nat.hasAdd) n (OfNat.ofNat.{0} Nat 1 (OfNat.mk.{0} Nat 1 (One.one.{0} Nat Nat.hasOne)))) (TypeVec.append1.{u1} n α β) F _inst_1 (TypeVec.RelLast'.{u1} n α β rr) x y) (MvFunctor.LiftR.{u1, u2} (HAdd.hAdd.{0, 0, 0} Nat Nat Nat (instHAdd.{0} Nat Nat.hasAdd) n (OfNat.ofNat.{0} Nat 1 (OfNat.mk.{0} Nat 1 (One.one.{0} Nat Nat.hasOne)))) F _inst_1 (fun (i : Fin2 (HAdd.hAdd.{0, 0, 0} Nat Nat Nat (instHAdd.{0} Nat Nat.hasAdd) n (OfNat.ofNat.{0} Nat 1 (OfNat.mk.{0} Nat 1 (One.one.{0} Nat Nat.hasOne))))) => TypeVec.append1.{u1} n α β i) (TypeVec.RelLast.{u1} n α β β rr) x y)
 but is expected to have type
-  forall {n : Nat} {F : (TypeVec.{u2} (HAdd.hAdd.{0, 0, 0} Nat Nat Nat (instHAdd.{0} Nat instAddNat) n (OfNat.ofNat.{0} Nat 1 (instOfNatNat 1)))) -> Type.{u1}} [_inst_1 : MvFunctor.{u2, u1} (HAdd.hAdd.{0, 0, 0} Nat Nat Nat (instHAdd.{0} Nat instAddNat) n (OfNat.ofNat.{0} Nat 1 (instOfNatNat 1))) F] [_inst_2 : LawfulMvFunctor.{u2, u1} (HAdd.hAdd.{0, 0, 0} Nat Nat Nat (instHAdd.{0} Nat instAddNat) n (OfNat.ofNat.{0} Nat 1 (instOfNatNat 1))) F _inst_1] {α : TypeVec.{u2} n} {β : Type.{u2}} (rr : β -> β -> Prop) (x : F (TypeVec.append1.{u2} n α β)) (y : F (TypeVec.append1.{u2} n α β)), Iff (MvFunctor.LiftR'.{u2, u1} (HAdd.hAdd.{0, 0, 0} Nat Nat Nat (instHAdd.{0} Nat instAddNat) n (OfNat.ofNat.{0} Nat 1 (instOfNatNat 1))) (TypeVec.append1.{u2} n α β) F _inst_1 (TypeVec.RelLast'.{u2} n α β rr) x y) (MvFunctor.LiftR.{u2, u1} (HAdd.hAdd.{0, 0, 0} Nat Nat Nat (instHAdd.{0} Nat instAddNat) n (OfNat.ofNat.{0} Nat 1 (instOfNatNat 1))) F _inst_1 (fun {i : Fin2 (HAdd.hAdd.{0, 0, 0} Nat Nat Nat (instHAdd.{0} Nat instAddNat) n (OfNat.ofNat.{0} Nat 1 (instOfNatNat 1)))} => TypeVec.append1.{u2} n α β i) (fun {i._@.Mathlib.Control.Functor.Multivariate._hyg.3392 : Fin2 (HAdd.hAdd.{0, 0, 0} Nat Nat Nat (instHAdd.{0} Nat instAddNat) n (OfNat.ofNat.{0} Nat 1 (instOfNatNat 1)))} => TypeVec.RelLast.{u2} n α β β rr i._@.Mathlib.Control.Functor.Multivariate._hyg.3392) x y)
+  forall {n : Nat} {F : (TypeVec.{u2} (HAdd.hAdd.{0, 0, 0} Nat Nat Nat (instHAdd.{0} Nat instAddNat) n (OfNat.ofNat.{0} Nat 1 (instOfNatNat 1)))) -> Type.{u1}} [_inst_1 : MvFunctor.{u2, u1} (HAdd.hAdd.{0, 0, 0} Nat Nat Nat (instHAdd.{0} Nat instAddNat) n (OfNat.ofNat.{0} Nat 1 (instOfNatNat 1))) F] [_inst_2 : LawfulMvFunctor.{u2, u1} (HAdd.hAdd.{0, 0, 0} Nat Nat Nat (instHAdd.{0} Nat instAddNat) n (OfNat.ofNat.{0} Nat 1 (instOfNatNat 1))) F _inst_1] {α : TypeVec.{u2} n} {β : Type.{u2}} (rr : β -> β -> Prop) (x : F (TypeVec.append1.{u2} n α β)) (y : F (TypeVec.append1.{u2} n α β)), Iff (MvFunctor.LiftR'.{u2, u1} (HAdd.hAdd.{0, 0, 0} Nat Nat Nat (instHAdd.{0} Nat instAddNat) n (OfNat.ofNat.{0} Nat 1 (instOfNatNat 1))) (TypeVec.append1.{u2} n α β) F _inst_1 (TypeVec.RelLast'.{u2} n α β rr) x y) (MvFunctor.LiftR.{u2, u1} (HAdd.hAdd.{0, 0, 0} Nat Nat Nat (instHAdd.{0} Nat instAddNat) n (OfNat.ofNat.{0} Nat 1 (instOfNatNat 1))) F _inst_1 (fun {i : Fin2 (HAdd.hAdd.{0, 0, 0} Nat Nat Nat (instHAdd.{0} Nat instAddNat) n (OfNat.ofNat.{0} Nat 1 (instOfNatNat 1)))} => TypeVec.append1.{u2} n α β i) (fun {i._@.Mathlib.Control.Functor.Multivariate._hyg.3418 : Fin2 (HAdd.hAdd.{0, 0, 0} Nat Nat Nat (instHAdd.{0} Nat instAddNat) n (OfNat.ofNat.{0} Nat 1 (instOfNatNat 1)))} => TypeVec.RelLast.{u2} n α β β rr i._@.Mathlib.Control.Functor.Multivariate._hyg.3418) x y)
 Case conversion may be inaccurate. Consider using '#align mvfunctor.liftr_last_rel_iff MvFunctor.LiftR_RelLast_iffₓ'. -/
 /- ./././Mathport/Syntax/Translate/Expr.lean:177:8: unsupported: ambiguous notation -/
 theorem LiftR_RelLast_iff (x y : F (α ::: β)) :

4d392a6c

bump to nightly-2023-02-21-16

mathlib commit https://github.com/leanprover-community/mathlib/commit/bd9851ca476957ea4549eb19b40e7b5ade9428cc

1107b979

Changes in mathlib4

mathlib3

mathlib4

008205aa

style: add missing spaces between a tactic name and its arguments (#11714)

After the (d)simp and rw tactics - hints to find further occurrences welcome.

zulip discussion

Co-authored-by: @sven-manthe

7151d90b

Diff

@@ -193,7 +193,7 @@ theorem LiftP_PredLast_iff {β} (P : β → Prop) (x : F (α ::: β)) :
     rw [MvFunctor.map_map]
     dsimp (config := { unfoldPartialApp := true }) [(· ⊚ ·)]
     suffices (fun i => Subtype.val) = (fun i x => (MvFunctor.f P n α i x).val)
-      by rw[this];
+      by rw [this];
     ext i ⟨x, _⟩
     cases i <;> rfl
 #align mvfunctor.liftp_last_pred_iff MvFunctor.LiftP_PredLast_iff
@@ -234,7 +234,7 @@ theorem LiftR_RelLast_iff (x y : F (α ::: β)) :
     suffices  (fun i t => t.val.fst) = ((fun i x => (MvFunctor.f' rr n α i x).val.fst))
             ∧ (fun i t => t.val.snd) = ((fun i x => (MvFunctor.f' rr n α i x).val.snd))
     by  rcases this with ⟨left, right⟩
-        rw[left, right];
+        rw [left, right];
     constructor <;> ext i ⟨x, _⟩ <;> cases i <;> rfl
 #align mvfunctor.liftr_last_rel_iff MvFunctor.LiftR_RelLast_iff

008205aa

golf: replace some apply foo.mpr by rw [foo] (#11515)

Sometimes, that line can be golfed into the next line. Inspired by a comment of @loefflerd; any decisions are my own.

fa3a2fdc

Diff

@@ -128,7 +128,7 @@ theorem exists_iff_exists_of_mono {P : F α → Prop} {q : F β → Prop}
   · refine ⟨f <$$> u, ?_⟩
     apply (h₁ u).mp h₂
   · refine ⟨g <$$> u, ?_⟩
-    apply (h₁ _).mpr _
+    rw [h₁]
     simp only [MvFunctor.map_map, h₀, LawfulMvFunctor.id_map, h₂]
 #align mvfunctor.exists_iff_exists_of_mono MvFunctor.exists_iff_exists_of_mono

008205aa

chore(*): remove empty lines between variable statements (#11418)

Empty lines were removed by executing the following Python script twice

import os
import re


# Loop through each file in the repository
for dir_path, dirs, files in os.walk('.'):
  for filename in files:
    if filename.endswith('.lean'):
      file_path = os.path.join(dir_path, filename)

      # Open the file and read its contents
      with open(file_path, 'r') as file:
        content = file.read()

      # Use a regular expression to replace sequences of "variable" lines separated by empty lines
      # with sequences without empty lines
      modified_content = re.sub(r'(variable.*\n)\n(variable(?! .* in))', r'\1\2', content)

      # Write the modified content back to the file
      with open(file_path, 'w') as file:
        file.write(modified_content)

75c86f04

Diff

@@ -85,9 +85,7 @@ export LawfulMvFunctor (comp_map)
 open LawfulMvFunctor
 
 variable {α β γ : TypeVec.{u} n}
-
 variable {F : TypeVec.{u} n → Type v} [MvFunctor F]
-
 variable (P : α ⟹ «repeat» n Prop) (R : α ⊗ α ⟹ «repeat» n Prop)
 
 /-- adapt `MvFunctor.LiftP` to accept predicates as arrows -/
@@ -167,7 +165,6 @@ variable {F : TypeVec.{u} (n + 1) → Type*} [MvFunctor F] [LawfulMvFunctor F] {
 open MvFunctor
 
 variable {β : Type u}
-
 variable (pp : β → Prop)
 
 private def f :

008205aa

style: homogenise porting notes (#11145)

Homogenises porting notes via capitalisation and addition of whitespace.

It makes the following changes:

converts "--porting note" into "-- Porting note";
converts "porting note" into "Porting note".

8be0b69c

Diff

@@ -231,7 +231,7 @@ theorem LiftR_RelLast_iff (x y : F (α ::: β)) :
     cases i <;> rfl
   · intros
     simp (config := { unfoldPartialApp := true }) [MvFunctor.map_map, (· ⊚ ·)]
-    -- porting note: proof was
+    -- Porting note: proof was
     -- rw [MvFunctor.map_map, MvFunctor.map_map, (· ⊚ ·), (· ⊚ ·)]
     -- congr <;> ext i ⟨x, _⟩ <;> cases i <;> rfl
     suffices  (fun i t => t.val.fst) = ((fun i x => (MvFunctor.f' rr n α i x).val.fst))

008205aa

feat: transport an MvQPF instance along an equivalence (#10806)

This is code ported from alexkeizer/QpfTypes. It's primary use is to show that existing type functions which are equivalent to polynomial functors but not defined as such (e.g., Sum, Prod, etc.) are QPFs.

c0d05dba

Diff

@@ -5,6 +5,7 @@ Authors: Jeremy Avigad, Mario Carneiro, Simon Hudon
 -/
 import Mathlib.Data.Fin.Fin2
 import Mathlib.Data.TypeVec
+import Mathlib.Logic.Equiv.Defs
 
 #align_import control.functor.multivariate from "leanprover-community/mathlib"@"008205aa645b3f194c1da47025c5f110c8406eab"
 
@@ -242,4 +243,9 @@ theorem LiftR_RelLast_iff (x y : F (α ::: β)) :
 
 end LiftPLastPredIff
 
+/-- Any type function that is (extensionally) equivalent to a functor, is itself a functor -/
+def ofEquiv {F F' : TypeVec.{u} n → Type*} [MvFunctor F'] (eqv : ∀ α, F α ≃ F' α) :
+    MvFunctor F where
+  map f x := (eqv _).symm <| f <$$> eqv _ x
+
 end MvFunctor

008205aa

chore: bump to v4.3.0-rc2 (#8366)

PR contents

This is the supremum of

#8284
#8056
#8023
#8332
#8226 (already approved)
#7834 (already approved)

along with some minor fixes from failures on nightly-testing as Mathlib master is merged into it.

Note that some PRs for changes that are already compatible with the current toolchain and will be necessary have already been split out: #8380.

I am hopeful that in future we will be able to progressively merge adaptation PRs into a bump/v4.X.0 branch, so we never end up with a "big merge" like this. However one of these adaptation PRs (#8056) predates my new scheme for combined CI, and it wasn't possible to keep that PR viable in the meantime.

Lean PRs involved in this bump

In particular this includes adjustments for the Lean PRs

leanprover/lean4#2778

We can get rid of all the

local macro_rules | `($x ^ $y) => `(HPow.hPow $x $y) -- Porting note: See issue [lean4#2220](https://github.com/leanprover/lean4/pull/2220)

macros across Mathlib (and in any projects that want to write natural number powers of reals).

leanprover/lean4#2722

Changes the default behaviour of simp to (config := {decide := false}). This makes simp (and consequentially norm_num) less powerful, but also more consistent, and less likely to blow up in long failures. This requires a variety of changes: changing some previously by simp or norm_num to decide or rfl, or adding (config := {decide := true}).

leanprover/lean4#2783

This changed the behaviour of simp so that simp [f] will only unfold "fully applied" occurrences of f. The old behaviour can be recovered with simp (config := { unfoldPartialApp := true }). We may in future add a syntax for this, e.g. simp [!f]; please provide feedback! In the meantime, we have made the following changes:

switching to using explicit lemmas that have the intended level of application
(config := { unfoldPartialApp := true }) in some places, to recover the old behaviour
Using @[eqns] to manually adjust the equation lemmas for a particular definition, recovering the old behaviour just for that definition. See #8371, where we do this for Function.comp and Function.flip.

This change in Lean may require further changes down the line (e.g. adding the !f syntax, and/or upstreaming the special treatment for Function.comp and Function.flip, and/or removing this special treatment). Please keep an open and skeptical mind about these changes!

Co-authored-by: leanprover-community-mathlib4-bot <leanprover-community-mathlib4-bot@users.noreply.github.com> Co-authored-by: Scott Morrison <scott.morrison@gmail.com> Co-authored-by: Eric Wieser <wieser.eric@gmail.com> Co-authored-by: Mauricio Collares <mauricio@collares.org>

40b64f79

Diff

@@ -144,8 +144,9 @@ theorem LiftR_def (x y : F α) :
       ∃ u : F (Subtype_ R),
         (TypeVec.prod.fst ⊚ subtypeVal R) <$$> u = x ∧
           (TypeVec.prod.snd ⊚ subtypeVal R) <$$> u = y :=
-  exists_iff_exists_of_mono _ _ _ (toSubtype'_of_subtype' R)
-    (by simp only [map_map, comp_assoc, subtypeVal_toSubtype']; simp [comp])
+  exists_iff_exists_of_mono _ _ _ (toSubtype'_of_subtype' R) (by
+    simp only [map_map, comp_assoc, subtypeVal_toSubtype']
+    simp (config := { unfoldPartialApp := true }) [comp])
 #align mvfunctor.liftr_def MvFunctor.LiftR_def
 
 end LiftP'
@@ -192,7 +193,7 @@ theorem LiftP_PredLast_iff {β} (P : β → Prop) (x : F (α ::: β)) :
     cases i <;> rfl
   · intros
     rw [MvFunctor.map_map]
-    dsimp [(· ⊚ ·)]
+    dsimp (config := { unfoldPartialApp := true }) [(· ⊚ ·)]
     suffices (fun i => Subtype.val) = (fun i x => (MvFunctor.f P n α i x).val)
       by rw[this];
     ext i ⟨x, _⟩
@@ -228,7 +229,7 @@ theorem LiftR_RelLast_iff (x y : F (α ::: β)) :
   · ext i ⟨x, _⟩ : 2
     cases i <;> rfl
   · intros
-    simp [MvFunctor.map_map, (· ⊚ ·)]
+    simp (config := { unfoldPartialApp := true }) [MvFunctor.map_map, (· ⊚ ·)]
     -- porting note: proof was
     -- rw [MvFunctor.map_map, MvFunctor.map_map, (· ⊚ ·), (· ⊚ ·)]
     -- congr <;> ext i ⟨x, _⟩ <;> cases i <;> rfl

008205aa

docs: prevent lists running onto a single line (#8122)

f17743c3

Diff

@@ -10,12 +10,12 @@ import Mathlib.Data.TypeVec
 
 /-!
 
-Functors between the category of tuples of types, and the category Type
+# Functors between the category of tuples of types, and the category Type
 
 Features:
 
-`MvFunctor n` : the type class of multivariate functors
-`f <$$> x`    : notation for map
+* `MvFunctor n` : the type class of multivariate functors
+* `f <$$> x`    : notation for map
 
 -/

008205aa

chore: exactly 4 spaces in theorems (#7328)

Co-authored-by: Moritz Firsching <firsching@google.com>

d3263b23

Diff

@@ -121,10 +121,10 @@ section LiftP'
 variable (F)
 
 theorem exists_iff_exists_of_mono {P : F α → Prop} {q : F β → Prop}
-                                  (f : α ⟹ β) (g : β ⟹ α)
-                                  (h₀ : f ⊚ g = TypeVec.id)
-                                  (h₁ : ∀ u : F α, P u ↔ q (f <$$> u)) :
-      (∃ u : F α, P u) ↔ ∃ u : F β, q u := by
+    (f : α ⟹ β) (g : β ⟹ α)
+    (h₀ : f ⊚ g = TypeVec.id)
+    (h₁ : ∀ u : F α, P u ↔ q (f <$$> u)) :
+    (∃ u : F α, P u) ↔ ∃ u : F β, q u := by
   constructor <;> rintro ⟨u, h₂⟩
   · refine ⟨f <$$> u, ?_⟩
     apply (h₁ u).mp h₂

008205aa

chore: banish Type _ and Sort _ (#6499)

We remove all possible occurences of Type _ and Sort _ in favor of Type* and Sort*.

This has nice performance benefits.

32de3f67

Diff

@@ -26,7 +26,7 @@ open MvFunctor
 
 /-- Multivariate functors, i.e. functor between the category of type vectors
 and the category of Type -/
-class MvFunctor {n : ℕ} (F : TypeVec n → Type _) where
+class MvFunctor {n : ℕ} (F : TypeVec n → Type*) where
   /-- Multivariate map, if `f : α ⟹ β` and `x : F α` then `f <$$> x : F β`. -/
   map : ∀ {α β : TypeVec n}, α ⟹ β → F α → F β
 #align mvfunctor MvFunctor
@@ -67,7 +67,7 @@ end MvFunctor
 
 
 /-- laws for `MvFunctor` -/
-class LawfulMvFunctor {n : ℕ} (F : TypeVec n → Type _) [MvFunctor F] : Prop where
+class LawfulMvFunctor {n : ℕ} (F : TypeVec n → Type*) [MvFunctor F] : Prop where
   /-- `map` preserved identities, i.e., maps identity on `α` to identity on `F α` -/
   id_map : ∀ {α : TypeVec n} (x : F α), TypeVec.id <$$> x = x
   /-- `map` preserves compositions -/
@@ -160,7 +160,7 @@ open TypeVec
 
 section LiftPLastPredIff
 
-variable {F : TypeVec.{u} (n + 1) → Type _} [MvFunctor F] [LawfulMvFunctor F] {α : TypeVec.{u} n}
+variable {F : TypeVec.{u} (n + 1) → Type*} [MvFunctor F] [LawfulMvFunctor F] {α : TypeVec.{u} n}
 
 open MvFunctor

008205aa

chore: script to replace headers with #align_import statements (#5979)

depends on: #5966

Co-authored-by: Eric Wieser <wieser.eric@gmail.com> Co-authored-by: Scott Morrison <scott.morrison@gmail.com>

89aa3a3b

Diff

@@ -2,15 +2,12 @@
 Copyright (c) 2018 Jeremy Avigad. All rights reserved.
 Released under Apache 2.0 license as described in the file LICENSE.
 Authors: Jeremy Avigad, Mario Carneiro, Simon Hudon
-
-! This file was ported from Lean 3 source module control.functor.multivariate
-! leanprover-community/mathlib commit 008205aa645b3f194c1da47025c5f110c8406eab
-! Please do not edit these lines, except to modify the commit id
-! if you have ported upstream changes.
 -/
 import Mathlib.Data.Fin.Fin2
 import Mathlib.Data.TypeVec
 
+#align_import control.functor.multivariate from "leanprover-community/mathlib"@"008205aa645b3f194c1da47025c5f110c8406eab"
+
 /-!
 
 Functors between the category of tuples of types, and the category Type

008205aa

chore: remove superfluous parentheses in calls to ext (#5258)

Co-authored-by: Xavier Roblot <46200072+xroblot@users.noreply.github.com> Co-authored-by: Joël Riou <joel.riou@universite-paris-saclay.fr> Co-authored-by: Riccardo Brasca <riccardo.brasca@gmail.com> Co-authored-by: Yury G. Kudryashov <urkud@urkud.name> Co-authored-by: Scott Morrison <scott.morrison@anu.edu.au> Co-authored-by: Scott Morrison <scott.morrison@gmail.com> Co-authored-by: Jeremy Tan Jie Rui <reddeloostw@gmail.com> Co-authored-by: Pol'tta / Miyahara Kō <pol_tta@outlook.jp> Co-authored-by: Jason Yuen <jason_yuen2007@hotmail.com> Co-authored-by: Mario Carneiro <di.gama@gmail.com> Co-authored-by: Jireh Loreaux <loreaujy@gmail.com> Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com> Co-authored-by: Kyle Miller <kmill31415@gmail.com> Co-authored-by: Heather Macbeth <25316162+hrmacbeth@users.noreply.github.com> Co-authored-by: Jujian Zhang <jujian.zhang1998@outlook.com> Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>

3d6731dc

Diff

@@ -191,14 +191,14 @@ theorem LiftP_PredLast_iff {β} (P : β → Prop) (x : F (α ::: β)) :
     LiftP' (PredLast' _ P) x ↔ LiftP (PredLast _ P) x := by
   dsimp only [LiftP, LiftP']
   apply exists_iff_exists_of_mono F (f _ n α) (g _ n α)
-  · ext (i⟨x, _⟩)
+  · ext i ⟨x, _⟩
     cases i <;> rfl
   · intros
     rw [MvFunctor.map_map]
     dsimp [(· ⊚ ·)]
     suffices (fun i => Subtype.val) = (fun i x => (MvFunctor.f P n α i x).val)
       by rw[this];
-    ext (i⟨x, _⟩)
+    ext i ⟨x, _⟩
     cases i <;> rfl
 #align mvfunctor.liftp_last_pred_iff MvFunctor.LiftP_PredLast_iff
 
@@ -228,18 +228,18 @@ theorem LiftR_RelLast_iff (x y : F (α ::: β)) :
     LiftR' (RelLast' _ rr) x y ↔ LiftR (RelLast (i := _) _ rr) x y := by
   dsimp only [LiftR, LiftR']
   apply exists_iff_exists_of_mono F (f' rr _ _) (g' rr _ _)
-  · ext (i⟨x, _⟩) : 2
+  · ext i ⟨x, _⟩ : 2
     cases i <;> rfl
   · intros
     simp [MvFunctor.map_map, (· ⊚ ·)]
     -- porting note: proof was
     -- rw [MvFunctor.map_map, MvFunctor.map_map, (· ⊚ ·), (· ⊚ ·)]
-    -- congr <;> ext (i⟨x, _⟩) <;> cases i <;> rfl
+    -- congr <;> ext i ⟨x, _⟩ <;> cases i <;> rfl
     suffices  (fun i t => t.val.fst) = ((fun i x => (MvFunctor.f' rr n α i x).val.fst))
             ∧ (fun i t => t.val.snd) = ((fun i x => (MvFunctor.f' rr n α i x).val.snd))
     by  rcases this with ⟨left, right⟩
         rw[left, right];
-    constructor <;> ext (i⟨x, _⟩) <;> cases i <;> rfl
+    constructor <;> ext i ⟨x, _⟩ <;> cases i <;> rfl
 #align mvfunctor.liftr_last_rel_iff MvFunctor.LiftR_RelLast_iff
 
 end LiftPLastPredIff

008205aa

chore: bye-bye, solo bys! (#3825)

This PR puts, with one exception, every single remaining by that lies all by itself on its own line to the previous line, thus matching the current behaviour of start-port.sh. The exception is when the by begins the second or later argument to a tuple or anonymous constructor; see https://github.com/leanprover-community/mathlib4/pull/3825#discussion_r1186702599.

Essentially this is s/\n *by$/ by/g, but with manual editing to satisfy the linter's max-100-char-line requirement. The Python style linter is also modified to catch these "isolated bys".

14167e48

Diff

@@ -127,8 +127,7 @@ theorem exists_iff_exists_of_mono {P : F α → Prop} {q : F β → Prop}
                                   (f : α ⟹ β) (g : β ⟹ α)
                                   (h₀ : f ⊚ g = TypeVec.id)
                                   (h₁ : ∀ u : F α, P u ↔ q (f <$$> u)) :
-      (∃ u : F α, P u) ↔ ∃ u : F β, q u :=
-by
+      (∃ u : F α, P u) ↔ ∃ u : F β, q u := by
   constructor <;> rintro ⟨u, h₂⟩
   · refine ⟨f <$$> u, ?_⟩
     apply (h₁ u).mp h₂
@@ -189,8 +188,7 @@ private def g :
   | _, α, Fin2.fz, x => ⟨x.val, x.property⟩
 
 theorem LiftP_PredLast_iff {β} (P : β → Prop) (x : F (α ::: β)) :
-    LiftP' (PredLast' _ P) x ↔ LiftP (PredLast _ P) x :=
-  by
+    LiftP' (PredLast' _ P) x ↔ LiftP (PredLast _ P) x := by
   dsimp only [LiftP, LiftP']
   apply exists_iff_exists_of_mono F (f _ n α) (g _ n α)
   · ext (i⟨x, _⟩)
@@ -227,8 +225,7 @@ private def g' :
   | _, α, Fin2.fz, x => ⟨x.val, x.property⟩
 
 theorem LiftR_RelLast_iff (x y : F (α ::: β)) :
-    LiftR' (RelLast' _ rr) x y ↔ LiftR (RelLast (i := _) _ rr) x y :=
-  by
+    LiftR' (RelLast' _ rr) x y ↔ LiftR (RelLast (i := _) _ rr) x y := by
   dsimp only [LiftR, LiftR']
   apply exists_iff_exists_of_mono F (f' rr _ _) (g' rr _ _)
   · ext (i⟨x, _⟩) : 2

008205aa

feat: port Control.Functor.Multivariate (#1638)

Co-authored-by: Reid Barton <rwbarton@gmail.com>

38c9db93

`control.functor.multivariate` ⟷ `Mathlib.Control.Functor.Multivariate`

Changes since the initial port

Changes in mathlib3

Changes in mathlib3port

Changes in mathlib4

PR contents

Lean PRs involved in this bump

leanprover/lean4#2778

leanprover/lean4#2722

leanprover/lean4#2783

Dependencies 2

control.functor.multivariate ⟷ Mathlib.Control.Functor.Multivariate

Changes since the initial port

Changes in mathlib3

Changes in mathlib3port

Changes in mathlib4

PR contents

Lean PRs involved in this bump

leanprover/lean4#2778

leanprover/lean4#2722

leanprover/lean4#2783

Dependencies 2

`control.functor.multivariate` ⟷ `Mathlib.Control.Functor.Multivariate`