data.dlist.basic | Mathlib porting status

Changes since the initial port

The following section lists changes to this file in mathlib3 and mathlib4 that occured after the initial port. Most recent changes are shown first. Hovering over a commit will show all commits associated with the same mathlib3 commit.

Changes in mathlib3

d6aae1bc

(last sync)

Changes in mathlib3port

mathlib3

mathlib3port

448144f7

bump to nightly-2024-04-06-08

mathlib commit https://github.com/leanprover-community/mathlib/commit/65a1391a0106c9204fe45bc73a039f056558cb83

e34029c9

Diff

@@ -3,7 +3,7 @@ Copyright (c) 2018 Simon Hudon. All rights reserved.
 Released under Apache 2.0 license as described in the file LICENSE.
 Authors: Simon Hudon
 -/
-import Data.Dlist
+import Data.DList.Defs
 
 #align_import data.dlist.basic from "leanprover-community/mathlib"@"448144f7ae193a8990cb7473c9e9a01990f64ac7"

448144f7

bump to nightly-2023-09-24-06

mathlib commit https://github.com/leanprover-community/mathlib/commit/ce64cd319bb6b3e82f31c2d38e79080d377be451

5655435f

Diff

@@ -3,7 +3,7 @@ Copyright (c) 2018 Simon Hudon. All rights reserved.
 Released under Apache 2.0 license as described in the file LICENSE.
 Authors: Simon Hudon
 -/
-import Leanbin.Data.Dlist
+import Data.Dlist
 
 #align_import data.dlist.basic from "leanprover-community/mathlib"@"448144f7ae193a8990cb7473c9e9a01990f64ac7"

448144f7

bump to nightly-2023-07-20-09

mathlib commit https://github.com/leanprover-community/mathlib/commit/8ea5598db6caeddde6cb734aa179cc2408dbd345

9c56d0dd

Diff

@@ -2,14 +2,11 @@
 Copyright (c) 2018 Simon Hudon. All rights reserved.
 Released under Apache 2.0 license as described in the file LICENSE.
 Authors: Simon Hudon
-
-! This file was ported from Lean 3 source module data.dlist.basic
-! leanprover-community/mathlib commit 448144f7ae193a8990cb7473c9e9a01990f64ac7
-! Please do not edit these lines, except to modify the commit id
-! if you have ported upstream changes.
 -/
 import Leanbin.Data.Dlist
 
+#align_import data.dlist.basic from "leanprover-community/mathlib"@"448144f7ae193a8990cb7473c9e9a01990f64ac7"
+
 /-!
 # Difference list

448144f7

bump to nightly-2023-06-18-23

mathlib commit https://github.com/leanprover-community/mathlib/commit/2a0ce625dbb0ffbc7d1316597de0b25c1ec75303

3b5e23dc

Diff

@@ -30,22 +30,23 @@ useful for append-heavy uses such as logging and pretty printing.
 #print Std.DList.join /-
 /-- Concatenates a list of difference lists to form a single difference list. Similar to
 `list.join`. -/
-def Std.DList.join {α : Type _} : List (Dlist α) → Dlist α
-  | [] => Dlist.empty
+def Std.DList.join {α : Type _} : List (Std.DList α) → Std.DList α
+  | [] => Std.DList.empty
   | x :: xs => x ++ Std.DList.join xs
 #align dlist.join Std.DList.join
 -/
 
 #print Std.DList_singleton /-
 @[simp]
-theorem Std.DList_singleton {α : Type _} {a : α} : Dlist.singleton a = Std.DList.lazy_ofList [a] :=
+theorem Std.DList_singleton {α : Type _} {a : α} :
+    Std.DList.singleton a = Std.DList.lazy_ofList [a] :=
   rfl
 #align dlist_singleton Std.DList_singleton
 -/
 
 #print Std.DList_lazy /-
 @[simp]
-theorem Std.DList_lazy {α : Type _} {l : List α} : Std.DList.lazy_ofList l = Dlist.ofList l :=
+theorem Std.DList_lazy {α : Type _} {l : List α} : Std.DList.lazy_ofList l = Std.DList.ofList l :=
   rfl
 #align dlist_lazy Std.DList_lazy
 -/

448144f7

bump to nightly-2023-06-13-21

mathlib commit https://github.com/leanprover-community/mathlib/commit/9fb8964792b4237dac6200193a0d533f1b3f7423

829520ac

Diff

@@ -27,20 +27,26 @@ useful for append-heavy uses such as logging and pretty printing.
 -/
 
 
+#print Std.DList.join /-
 /-- Concatenates a list of difference lists to form a single difference list. Similar to
 `list.join`. -/
 def Std.DList.join {α : Type _} : List (Dlist α) → Dlist α
   | [] => Dlist.empty
   | x :: xs => x ++ Std.DList.join xs
 #align dlist.join Std.DList.join
+-/
 
+#print Std.DList_singleton /-
 @[simp]
 theorem Std.DList_singleton {α : Type _} {a : α} : Dlist.singleton a = Std.DList.lazy_ofList [a] :=
   rfl
 #align dlist_singleton Std.DList_singleton
+-/
 
+#print Std.DList_lazy /-
 @[simp]
 theorem Std.DList_lazy {α : Type _} {l : List α} : Std.DList.lazy_ofList l = Dlist.ofList l :=
   rfl
 #align dlist_lazy Std.DList_lazy
+-/

448144f7

bump to nightly-2023-05-28-06

mathlib commit https://github.com/leanprover-community/mathlib/commit/917c3c072e487b3cccdbfeff17e75b40e45f66cb

ba5d8b97

Diff

@@ -27,12 +27,6 @@ useful for append-heavy uses such as logging and pretty printing.
 -/
 
 
-/- warning: dlist.join -> Std.DList.join is a dubious translation:
-lean 3 declaration is
-  forall {α : Type.{u1}}, (List.{u1} (Dlist.{u1} α)) -> (Dlist.{u1} α)
-but is expected to have type
-  forall {α : Type.{u1}}, (List.{u1} (Std.DList.{u1} α)) -> (Std.DList.{u1} α)
-Case conversion may be inaccurate. Consider using '#align dlist.join Std.DList.joinₓ'. -/
 /-- Concatenates a list of difference lists to form a single difference list. Similar to
 `list.join`. -/
 def Std.DList.join {α : Type _} : List (Dlist α) → Dlist α
@@ -40,23 +34,11 @@ def Std.DList.join {α : Type _} : List (Dlist α) → Dlist α
   | x :: xs => x ++ Std.DList.join xs
 #align dlist.join Std.DList.join
 
-/- warning: dlist_singleton -> Std.DList_singleton is a dubious translation:
-lean 3 declaration is
-  forall {α : Type.{u1}} {a : α}, Eq.{succ u1} (Dlist.{u1} α) (Dlist.singleton.{u1} α a) (Std.DList.lazy_ofList.{u1} α (fun (_ : Unit) => List.cons.{u1} α a (List.nil.{u1} α)))
-but is expected to have type
-  forall {α : Type.{u1}} {a : α}, Eq.{succ u1} (Std.DList.{u1} α) (Std.DList.singleton.{u1} α a) (Std.DList.lazy_ofList.{u1} α (Thunk.mk.{u1} (List.{u1} α) (fun (x._@.Init.Core._hyg.266 : Unit) => List.cons.{u1} α a (List.nil.{u1} α))))
-Case conversion may be inaccurate. Consider using '#align dlist_singleton Std.DList_singletonₓ'. -/
 @[simp]
 theorem Std.DList_singleton {α : Type _} {a : α} : Dlist.singleton a = Std.DList.lazy_ofList [a] :=
   rfl
 #align dlist_singleton Std.DList_singleton
 
-/- warning: dlist_lazy -> Std.DList_lazy is a dubious translation:
-lean 3 declaration is
-  forall {α : Type.{u1}} {l : List.{u1} α}, Eq.{succ u1} (Dlist.{u1} α) (Std.DList.lazy_ofList.{u1} α (fun (_ : Unit) => l)) (Dlist.ofList.{u1} α l)
-but is expected to have type
-  forall {α : Type.{u1}} {l : List.{u1} α}, Eq.{succ u1} (Std.DList.{u1} α) (Std.DList.lazy_ofList.{u1} α (Thunk.mk.{u1} (List.{u1} α) (fun (x._@.Init.Core._hyg.266 : Unit) => l))) (Std.DList.ofList.{u1} α l)
-Case conversion may be inaccurate. Consider using '#align dlist_lazy Std.DList_lazyₓ'. -/
 @[simp]
 theorem Std.DList_lazy {α : Type _} {l : List α} : Std.DList.lazy_ofList l = Dlist.ofList l :=
   rfl

448144f7

bump to nightly-2023-02-21-16

mathlib commit https://github.com/leanprover-community/mathlib/commit/bd9851ca476957ea4549eb19b40e7b5ade9428cc

1107b979

Changes in mathlib4

mathlib3

mathlib4

d6aae1bc

chore: refactor of Algebra/Group/Defs to reduce imports (#9606)

We are not that far from the point that Algebra/Group/Defs depends on nothing significant besides simps and to_additive.

This removes from Mathlib.Algebra.Group.Defs the dependencies on

Mathlib.Tactic.Basic (which is a grab-bag of random stuff)
Mathlib.Init.Algebra.Classes (which is ancient and half-baked)
Mathlib.Logic.Function.Basic (not particularly important, but it is barely used in this file)

The goal is to avoid all unnecessary imports to set up the definitions of basic algebraic structures.

We also separate out Mathlib.Tactic.TypeStar and Mathlib.Tactic.Lemma as prerequisites to Mathlib.Tactic.Basic, but which can be imported separately when the rest of Mathlib.Tactic.Basic is not needed.

Co-authored-by: Scott Morrison <scott.morrison@gmail.com> Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>

45df8238

Diff

@@ -4,7 +4,7 @@ Released under Apache 2.0 license as described in the file LICENSE.
 Authors: Simon Hudon
 -/
 import Mathlib.Data.DList.Defs
-import Mathlib.Tactic.Basic
+import Mathlib.Tactic.TypeStar
 
 #align_import data.dlist.basic from "leanprover-community/mathlib"@"d6aae1bcbd04b8de2022b9b83a5b5b10e10c777d"

d6aae1bc

chore: banish Type _ and Sort _ (#6499)

We remove all possible occurences of Type _ and Sort _ in favor of Type* and Sort*.

This has nice performance benefits.

32de3f67

Diff

@@ -4,6 +4,7 @@ Released under Apache 2.0 license as described in the file LICENSE.
 Authors: Simon Hudon
 -/
 import Mathlib.Data.DList.Defs
+import Mathlib.Tactic.Basic
 
 #align_import data.dlist.basic from "leanprover-community/mathlib"@"d6aae1bcbd04b8de2022b9b83a5b5b10e10c777d"
 
@@ -25,18 +26,18 @@ namespace Std
 
 /-- Concatenates a list of difference lists to form a single difference list. Similar to
 `List.join`. -/
-def DList.join {α : Type _} : List (DList α) → DList α
+def DList.join {α : Type*} : List (DList α) → DList α
   | [] => DList.empty
   | x :: xs => x ++ DList.join xs
 #align dlist.join Std.DList.join
 
 @[simp]
-theorem DList_singleton {α : Type _} {a : α} : DList.singleton a = DList.lazy_ofList [a] :=
+theorem DList_singleton {α : Type*} {a : α} : DList.singleton a = DList.lazy_ofList [a] :=
   rfl
 #align dlist_singleton Std.DList_singleton
 
 @[simp]
-theorem DList_lazy {α : Type _} {l : List α} : DList.lazy_ofList l = Std.DList.ofList l :=
+theorem DList_lazy {α : Type*} {l : List α} : DList.lazy_ofList l = Std.DList.ofList l :=
   rfl
 #align dlist_lazy Std.DList_lazy

d6aae1bc

chore: script to replace headers with #align_import statements (#5979)

depends on: #5966

Co-authored-by: Eric Wieser <wieser.eric@gmail.com> Co-authored-by: Scott Morrison <scott.morrison@gmail.com>

89aa3a3b

Diff

@@ -2,14 +2,11 @@
 Copyright (c) 2018 Simon Hudon. All rights reserved.
 Released under Apache 2.0 license as described in the file LICENSE.
 Authors: Simon Hudon
-
-! This file was ported from Lean 3 source module data.dlist.basic
-! leanprover-community/mathlib commit d6aae1bcbd04b8de2022b9b83a5b5b10e10c777d
-! Please do not edit these lines, except to modify the commit id
-! if you have ported upstream changes.
 -/
 import Mathlib.Data.DList.Defs
 
+#align_import data.dlist.basic from "leanprover-community/mathlib"@"d6aae1bcbd04b8de2022b9b83a5b5b10e10c777d"
+
 
 /-!
 # Difference list

d6aae1bc

feat: port Data.DList from Lean core (#1498)

Co-authored-by: Komyyy <pol_tta@outlook.jp>

a88976af

Diff

@@ -8,9 +8,7 @@ Authors: Simon Hudon
 ! Please do not edit these lines, except to modify the commit id
 ! if you have ported upstream changes.
 -/
-import Std.Data.DList
-import Mathlib.Mathport.Rename
-import Mathlib.Tactic.Cases
+import Mathlib.Data.DList.Defs
 
 
 /-!
@@ -22,7 +20,7 @@ A difference list is a function that, given a list, returns the original content
 difference list prepended to the given list. It is useful to represent elements of a given type
 as `a₁ + ... + aₙ` where `+ : α → α → α` is any operation, without actually computing.
 
-This structure supports `O(1)` `append` and `concat` operations on lists, making it
+This structure supports `O(1)` `append` and `push` operations on lists, making it
 useful for append-heavy uses such as logging and pretty printing.
 -/
 
@@ -35,12 +33,6 @@ def DList.join {α : Type _} : List (DList α) → DList α
   | x :: xs => x ++ DList.join xs
 #align dlist.join Std.DList.join
 
-/-- Convert a lazily-evaluated `List` to a `DList` -/
--- Ported from Lean 3 core
-def DList.lazy_ofList (l : Thunk (List α)) : DList α :=
-  ⟨fun xs => l.get ++ xs, fun t => by simp⟩
-#align dlist.lazy_of_list Std.DList.lazy_ofList
-
 @[simp]
 theorem DList_singleton {α : Type _} {a : α} : DList.singleton a = DList.lazy_ofList [a] :=
   rfl
@@ -51,17 +43,4 @@ theorem DList_lazy {α : Type _} {l : List α} : DList.lazy_ofList l = Std.DList
   rfl
 #align dlist_lazy Std.DList_lazy
 
--- Porting note: port from lean3
-theorem DList.toList_ofList (l : List α) : DList.toList (DList.ofList l) = l := by
-  cases l; rfl; simp only [DList.toList, DList.ofList, List.cons_append, List.append_nil]
-#align dlist.to_list_of_list Std.DList.toList_ofList
-
--- Porting note: port from lean3
-theorem DList.ofList_toList (l : DList α) : DList.ofList (DList.toList l) = l := by
-   cases' l with app inv
-   simp only [ofList, toList, mk.injEq]
-   funext x
-   rw [(inv x)]
-#align dlist.of_list_to_list Std.DList.ofList_toList
-
 end Std

d6aae1bc

chore: formatting issues (#4947)

Co-authored-by: Scott Morrison <scott.morrison@anu.edu.au> Co-authored-by: Parcly Taxel <reddeloostw@gmail.com>

5068808d

Diff

@@ -38,7 +38,7 @@ def DList.join {α : Type _} : List (DList α) → DList α
 /-- Convert a lazily-evaluated `List` to a `DList` -/
 -- Ported from Lean 3 core
 def DList.lazy_ofList (l : Thunk (List α)) : DList α :=
-⟨fun xs => l.get ++ xs, fun t => by simp⟩
+  ⟨fun xs => l.get ++ xs, fun t => by simp⟩
 #align dlist.lazy_of_list Std.DList.lazy_ofList
 
 @[simp]

d6aae1bc

feat: Port Data.DList.Instances (#1932)

42aaa1f2

Diff

@@ -10,6 +10,7 @@ Authors: Simon Hudon
 -/
 import Std.Data.DList
 import Mathlib.Mathport.Rename
+import Mathlib.Tactic.Cases
 
 
 /-!
@@ -50,4 +51,17 @@ theorem DList_lazy {α : Type _} {l : List α} : DList.lazy_ofList l = Std.DList
   rfl
 #align dlist_lazy Std.DList_lazy
 
+-- Porting note: port from lean3
+theorem DList.toList_ofList (l : List α) : DList.toList (DList.ofList l) = l := by
+  cases l; rfl; simp only [DList.toList, DList.ofList, List.cons_append, List.append_nil]
+#align dlist.to_list_of_list Std.DList.toList_ofList
+
+-- Porting note: port from lean3
+theorem DList.ofList_toList (l : DList α) : DList.ofList (DList.toList l) = l := by
+   cases' l with app inv
+   simp only [ofList, toList, mk.injEq]
+   funext x
+   rw [(inv x)]
+#align dlist.of_list_to_list Std.DList.ofList_toList
+
 end Std

d6aae1bc

chore: add source headers to ported theory files (#1094)

The script used to do this is included. The yaml file was obtained from https://raw.githubusercontent.com/wiki/leanprover-community/mathlib/mathlib4-port-status.md

f168625e

Diff

@@ -2,6 +2,11 @@
 Copyright (c) 2018 Simon Hudon. All rights reserved.
 Released under Apache 2.0 license as described in the file LICENSE.
 Authors: Simon Hudon
+
+! This file was ported from Lean 3 source module data.dlist.basic
+! leanprover-community/mathlib commit d6aae1bcbd04b8de2022b9b83a5b5b10e10c777d
+! Please do not edit these lines, except to modify the commit id
+! if you have ported upstream changes.
 -/
 import Std.Data.DList
 import Mathlib.Mathport.Rename

`data.dlist.basic` ⟷ `Mathlib.Data.DList.Basic`

Changes since the initial port

Changes in mathlib3

Changes in mathlib3port

Changes in mathlib4

Dependencies 1

data.dlist.basic ⟷ Mathlib.Data.DList.Basic

Changes since the initial port

Changes in mathlib3

Changes in mathlib3port

Changes in mathlib4

Dependencies 1

`data.dlist.basic` ⟷ `Mathlib.Data.DList.Basic`