data.fintype.units | Mathlib porting status

Changes since the initial port

The following section lists changes to this file in mathlib3 and mathlib4 that occured after the initial port. Most recent changes are shown first. Hovering over a commit will show all commits associated with the same mathlib3 commit.

Changes in mathlib3

509de852

(last sync)

Changes in mathlib3port

mathlib3

mathlib3port

327c3c0d

bump to nightly-2024-03-17-08

mathlib commit https://github.com/leanprover-community/mathlib/commit/65a1391a0106c9204fe45bc73a039f056558cb83

22f01ce4

Diff

@@ -52,7 +52,7 @@ theorem Fintype.card_units [GroupWithZero α] [Fintype α] [Fintype αˣ] :
   rw [eq_comm, Nat.sub_eq_iff_eq_add (Fintype.card_pos_iff.2 ⟨(0 : α)⟩),
     Fintype.card_congr (unitsEquivNeZero α)]
   have := Fintype.card_congr (Equiv.sumCompl (· = (0 : α))).symm
-  rwa [Fintype.card_sum, add_comm, Fintype.card_subtype_eq] at this 
+  rwa [Fintype.card_sum, add_comm, Fintype.card_subtype_eq] at this
 #align fintype.card_units Fintype.card_units
 -/

327c3c0d

bump to nightly-2024-02-01-06

mathlib commit https://github.com/leanprover-community/mathlib/commit/65a1391a0106c9204fe45bc73a039f056558cb83

5433bded

Diff

@@ -47,7 +47,12 @@ instance [Monoid α] [Finite α] : Finite αˣ :=
 
 #print Fintype.card_units /-
 theorem Fintype.card_units [GroupWithZero α] [Fintype α] [Fintype αˣ] :
-    Fintype.card αˣ = Fintype.card α - 1 := by classical
+    Fintype.card αˣ = Fintype.card α - 1 := by
+  classical
+  rw [eq_comm, Nat.sub_eq_iff_eq_add (Fintype.card_pos_iff.2 ⟨(0 : α)⟩),
+    Fintype.card_congr (unitsEquivNeZero α)]
+  have := Fintype.card_congr (Equiv.sumCompl (· = (0 : α))).symm
+  rwa [Fintype.card_sum, add_comm, Fintype.card_subtype_eq] at this 
 #align fintype.card_units Fintype.card_units
 -/

327c3c0d

bump to nightly-2024-01-31-06

mathlib commit https://github.com/leanprover-community/mathlib/commit/65a1391a0106c9204fe45bc73a039f056558cb83

61100fe9

Diff

@@ -47,12 +47,7 @@ instance [Monoid α] [Finite α] : Finite αˣ :=
 
 #print Fintype.card_units /-
 theorem Fintype.card_units [GroupWithZero α] [Fintype α] [Fintype αˣ] :
-    Fintype.card αˣ = Fintype.card α - 1 := by
-  classical
-  rw [eq_comm, Nat.sub_eq_iff_eq_add (Fintype.card_pos_iff.2 ⟨(0 : α)⟩),
-    Fintype.card_congr (unitsEquivNeZero α)]
-  have := Fintype.card_congr (Equiv.sumCompl (· = (0 : α))).symm
-  rwa [Fintype.card_sum, add_comm, Fintype.card_subtype_eq] at this 
+    Fintype.card αˣ = Fintype.card α - 1 := by classical
 #align fintype.card_units Fintype.card_units
 -/

327c3c0d

bump to nightly-2023-09-24-06

mathlib commit https://github.com/leanprover-community/mathlib/commit/ce64cd319bb6b3e82f31c2d38e79080d377be451

5655435f

Diff

@@ -3,9 +3,9 @@ Copyright (c) 2017 Mario Carneiro. All rights reserved.
 Released under Apache 2.0 license as described in the file LICENSE.
 Authors: Mario Carneiro
 -/
-import Mathbin.Data.Fintype.Prod
-import Mathbin.Data.Fintype.Sum
-import Mathbin.Data.Int.Units
+import Data.Fintype.Prod
+import Data.Fintype.Sum
+import Data.Int.Units
 
 #align_import data.fintype.units from "leanprover-community/mathlib"@"327c3c0d9232d80e250dc8f65e7835b82b266ea5"

327c3c0d

bump to nightly-2023-07-20-09

mathlib commit https://github.com/leanprover-community/mathlib/commit/8ea5598db6caeddde6cb734aa179cc2408dbd345

9c56d0dd

Diff

@@ -2,16 +2,13 @@
 Copyright (c) 2017 Mario Carneiro. All rights reserved.
 Released under Apache 2.0 license as described in the file LICENSE.
 Authors: Mario Carneiro
-
-! This file was ported from Lean 3 source module data.fintype.units
-! leanprover-community/mathlib commit 327c3c0d9232d80e250dc8f65e7835b82b266ea5
-! Please do not edit these lines, except to modify the commit id
-! if you have ported upstream changes.
 -/
 import Mathbin.Data.Fintype.Prod
 import Mathbin.Data.Fintype.Sum
 import Mathbin.Data.Int.Units
 
+#align_import data.fintype.units from "leanprover-community/mathlib"@"327c3c0d9232d80e250dc8f65e7835b82b266ea5"
+
 /-!
 # fintype instances relating to units

327c3c0d

bump to nightly-2023-06-13-21

mathlib commit https://github.com/leanprover-community/mathlib/commit/9fb8964792b4237dac6200193a0d533f1b3f7423

829520ac

Diff

@@ -22,14 +22,18 @@ import Mathbin.Data.Int.Units
 
 variable {α : Type _}
 
+#print UnitsInt.fintype /-
 instance UnitsInt.fintype : Fintype ℤˣ :=
   ⟨{1, -1}, fun x => by cases Int.units_eq_one_or x <;> simp [*]⟩
 #align units_int.fintype UnitsInt.fintype
+-/
 
+#print UnitsInt.univ /-
 @[simp]
 theorem UnitsInt.univ : (Finset.univ : Finset ℤˣ) = {1, -1} :=
   rfl
 #align units_int.univ UnitsInt.univ
+-/
 
 #print Fintype.card_units_int /-
 @[simp]

327c3c0d

bump to nightly-2023-06-04-18

mathlib commit https://github.com/leanprover-community/mathlib/commit/5f25c089cb34db4db112556f23c50d12da81b297

3fb4268b

Diff

@@ -48,10 +48,10 @@ instance [Monoid α] [Finite α] : Finite αˣ :=
 theorem Fintype.card_units [GroupWithZero α] [Fintype α] [Fintype αˣ] :
     Fintype.card αˣ = Fintype.card α - 1 := by
   classical
-    rw [eq_comm, Nat.sub_eq_iff_eq_add (Fintype.card_pos_iff.2 ⟨(0 : α)⟩),
-      Fintype.card_congr (unitsEquivNeZero α)]
-    have := Fintype.card_congr (Equiv.sumCompl (· = (0 : α))).symm
-    rwa [Fintype.card_sum, add_comm, Fintype.card_subtype_eq] at this 
+  rw [eq_comm, Nat.sub_eq_iff_eq_add (Fintype.card_pos_iff.2 ⟨(0 : α)⟩),
+    Fintype.card_congr (unitsEquivNeZero α)]
+  have := Fintype.card_congr (Equiv.sumCompl (· = (0 : α))).symm
+  rwa [Fintype.card_sum, add_comm, Fintype.card_subtype_eq] at this 
 #align fintype.card_units Fintype.card_units
 -/

327c3c0d

bump to nightly-2023-06-01-16

mathlib commit https://github.com/leanprover-community/mathlib/commit/cca40788df1b8755d5baf17ab2f27dacc2e17acb

b9c87c70

Diff

@@ -51,7 +51,7 @@ theorem Fintype.card_units [GroupWithZero α] [Fintype α] [Fintype αˣ] :
     rw [eq_comm, Nat.sub_eq_iff_eq_add (Fintype.card_pos_iff.2 ⟨(0 : α)⟩),
       Fintype.card_congr (unitsEquivNeZero α)]
     have := Fintype.card_congr (Equiv.sumCompl (· = (0 : α))).symm
-    rwa [Fintype.card_sum, add_comm, Fintype.card_subtype_eq] at this
+    rwa [Fintype.card_sum, add_comm, Fintype.card_subtype_eq] at this 
 #align fintype.card_units Fintype.card_units
 -/

327c3c0d

bump to nightly-2023-05-28-06

mathlib commit https://github.com/leanprover-community/mathlib/commit/917c3c072e487b3cccdbfeff17e75b40e45f66cb

ba5d8b97

Diff

@@ -22,22 +22,10 @@ import Mathbin.Data.Int.Units
 
 variable {α : Type _}
 
-/- warning: units_int.fintype -> UnitsInt.fintype is a dubious translation:
-lean 3 declaration is
-  Fintype.{0} (Units.{0} Int Int.monoid)
-but is expected to have type
-  Fintype.{0} (Units.{0} Int Int.instMonoidInt)
-Case conversion may be inaccurate. Consider using '#align units_int.fintype UnitsInt.fintypeₓ'. -/
 instance UnitsInt.fintype : Fintype ℤˣ :=
   ⟨{1, -1}, fun x => by cases Int.units_eq_one_or x <;> simp [*]⟩
 #align units_int.fintype UnitsInt.fintype
 
-/- warning: units_int.univ -> UnitsInt.univ is a dubious translation:
-lean 3 declaration is
-  Eq.{1} (Finset.{0} (Units.{0} Int Int.monoid)) (Finset.univ.{0} (Units.{0} Int Int.monoid) UnitsInt.fintype) (Insert.insert.{0, 0} (Units.{0} Int Int.monoid) (Finset.{0} (Units.{0} Int Int.monoid)) (Finset.hasInsert.{0} (Units.{0} Int Int.monoid) (fun (a : Units.{0} Int Int.monoid) (b : Units.{0} Int Int.monoid) => Units.decidableEq.{0} Int Int.monoid (fun (a : Int) (b : Int) => Int.decidableEq a b) a b)) (OfNat.ofNat.{0} (Units.{0} Int Int.monoid) 1 (OfNat.mk.{0} (Units.{0} Int Int.monoid) 1 (One.one.{0} (Units.{0} Int Int.monoid) (MulOneClass.toHasOne.{0} (Units.{0} Int Int.monoid) (Units.mulOneClass.{0} Int Int.monoid))))) (Singleton.singleton.{0, 0} (Units.{0} Int Int.monoid) (Finset.{0} (Units.{0} Int Int.monoid)) (Finset.hasSingleton.{0} (Units.{0} Int Int.monoid)) (Neg.neg.{0} (Units.{0} Int Int.monoid) (Units.hasNeg.{0} Int Int.monoid (NonUnitalNonAssocRing.toHasDistribNeg.{0} Int (NonAssocRing.toNonUnitalNonAssocRing.{0} Int (Ring.toNonAssocRing.{0} Int Int.ring)))) (OfNat.ofNat.{0} (Units.{0} Int Int.monoid) 1 (OfNat.mk.{0} (Units.{0} Int Int.monoid) 1 (One.one.{0} (Units.{0} Int Int.monoid) (MulOneClass.toHasOne.{0} (Units.{0} Int Int.monoid) (Units.mulOneClass.{0} Int Int.monoid))))))))
-but is expected to have type
-  Eq.{1} (Finset.{0} (Units.{0} Int Int.instMonoidInt)) (Finset.univ.{0} (Units.{0} Int Int.instMonoidInt) UnitsInt.fintype) (Insert.insert.{0, 0} (Units.{0} Int Int.instMonoidInt) (Finset.{0} (Units.{0} Int Int.instMonoidInt)) (Finset.instInsertFinset.{0} (Units.{0} Int Int.instMonoidInt) (fun (a : Units.{0} Int Int.instMonoidInt) (b : Units.{0} Int Int.instMonoidInt) => Units.instDecidableEqUnits.{0} Int Int.instMonoidInt (fun (a : Int) (b : Int) => Int.instDecidableEqInt a b) a b)) (OfNat.ofNat.{0} (Units.{0} Int Int.instMonoidInt) 1 (One.toOfNat1.{0} (Units.{0} Int Int.instMonoidInt) (InvOneClass.toOne.{0} (Units.{0} Int Int.instMonoidInt) (DivInvOneMonoid.toInvOneClass.{0} (Units.{0} Int Int.instMonoidInt) (DivisionMonoid.toDivInvOneMonoid.{0} (Units.{0} Int Int.instMonoidInt) (DivisionCommMonoid.toDivisionMonoid.{0} (Units.{0} Int Int.instMonoidInt) (CommGroup.toDivisionCommMonoid.{0} (Units.{0} Int Int.instMonoidInt) (Units.instCommGroupUnitsToMonoid.{0} Int Int.instCommMonoidInt)))))))) (Singleton.singleton.{0, 0} (Units.{0} Int Int.instMonoidInt) (Finset.{0} (Units.{0} Int Int.instMonoidInt)) (Finset.instSingletonFinset.{0} (Units.{0} Int Int.instMonoidInt)) (Neg.neg.{0} (Units.{0} Int Int.instMonoidInt) (Units.instNegUnits.{0} Int Int.instMonoidInt (NonUnitalNonAssocRing.toHasDistribNeg.{0} Int (NonAssocRing.toNonUnitalNonAssocRing.{0} Int (Ring.toNonAssocRing.{0} Int Int.instRingInt)))) (OfNat.ofNat.{0} (Units.{0} Int Int.instMonoidInt) 1 (One.toOfNat1.{0} (Units.{0} Int Int.instMonoidInt) (InvOneClass.toOne.{0} (Units.{0} Int Int.instMonoidInt) (DivInvOneMonoid.toInvOneClass.{0} (Units.{0} Int Int.instMonoidInt) (DivisionMonoid.toDivInvOneMonoid.{0} (Units.{0} Int Int.instMonoidInt) (DivisionCommMonoid.toDivisionMonoid.{0} (Units.{0} Int Int.instMonoidInt) (CommGroup.toDivisionCommMonoid.{0} (Units.{0} Int Int.instMonoidInt) (Units.instCommGroupUnitsToMonoid.{0} Int Int.instCommMonoidInt)))))))))))
-Case conversion may be inaccurate. Consider using '#align units_int.univ UnitsInt.univₓ'. -/
 @[simp]
 theorem UnitsInt.univ : (Finset.univ : Finset ℤˣ) = {1, -1} :=
   rfl

327c3c0d

bump to nightly-2023-02-21-16

mathlib commit https://github.com/leanprover-community/mathlib/commit/bd9851ca476957ea4549eb19b40e7b5ade9428cc

1107b979

Changes in mathlib4

mathlib3

mathlib4

509de852

chore: banish Type _ and Sort _ (#6499)

We remove all possible occurences of Type _ and Sort _ in favor of Type* and Sort*.

This has nice performance benefits.

32de3f67

Diff

@@ -15,7 +15,7 @@ import Mathlib.SetTheory.Cardinal.Finite
 -/
 
 
-variable {α : Type _}
+variable {α : Type*}
 
 instance UnitsInt.fintype : Fintype ℤˣ :=
   ⟨{1, -1}, fun x ↦ by cases Int.units_eq_one_or x <;> simp [*]⟩

509de852

feat: add card_units_add_one lemma (#5738)

A lemma to reexpress card_units without subtraction.

293041f7

Diff

@@ -6,6 +6,7 @@ Authors: Mario Carneiro
 import Mathlib.Data.Fintype.Prod
 import Mathlib.Data.Fintype.Sum
 import Mathlib.Data.Int.Units
+import Mathlib.SetTheory.Cardinal.Finite
 
 #align_import data.fintype.units from "leanprover-community/mathlib"@"509de852e1de55e1efa8eacfa11df0823f26f226"
 
@@ -33,11 +34,19 @@ instance [Monoid α] [Fintype α] [DecidableEq α] : Fintype αˣ :=
 
 instance [Monoid α] [Finite α] : Finite αˣ := Finite.of_injective _ Units.ext
 
-theorem Fintype.card_units [GroupWithZero α] [Fintype α] [Fintype αˣ] :
-    Fintype.card αˣ = Fintype.card α - 1 := by
+theorem Fintype.card_eq_card_units_add_one [GroupWithZero α] [Fintype α] [DecidableEq α] :
+    Fintype.card α = Fintype.card αˣ + 1 := by
+  rw [eq_comm, Fintype.card_congr (unitsEquivNeZero α)]
+  have := Fintype.card_congr (Equiv.sumCompl (· = (0 : α)))
+  rwa [Fintype.card_sum, add_comm, Fintype.card_subtype_eq] at this
+
+theorem Nat.card_eq_card_units_add_one [GroupWithZero α] [Finite α] :
+    Nat.card α = Nat.card αˣ + 1 := by
+  have : Fintype α := Fintype.ofFinite α
   classical
-    rw [eq_comm, Nat.sub_eq_iff_eq_add (Fintype.card_pos_iff.2 ⟨(0 : α)⟩),
-      Fintype.card_congr (unitsEquivNeZero α)]
-    have := Fintype.card_congr (Equiv.sumCompl (· = (0 : α))).symm
-    rwa [Fintype.card_sum, add_comm, Fintype.card_subtype_eq] at this
+    rw [Nat.card_eq_fintype_card, Nat.card_eq_fintype_card, Fintype.card_eq_card_units_add_one]
+
+theorem Fintype.card_units [GroupWithZero α] [Fintype α] [DecidableEq α] :
+    Fintype.card αˣ = Fintype.card α - 1 := by
+  rw [@Fintype.card_eq_card_units_add_one α, Nat.add_sub_cancel]
 #align fintype.card_units Fintype.card_units

509de852

chore: script to replace headers with #align_import statements (#5979)

depends on: #5966

Co-authored-by: Eric Wieser <wieser.eric@gmail.com> Co-authored-by: Scott Morrison <scott.morrison@gmail.com>

89aa3a3b

Diff

@@ -2,16 +2,13 @@
 Copyright (c) 2017 Mario Carneiro. All rights reserved.
 Released under Apache 2.0 license as described in the file LICENSE.
 Authors: Mario Carneiro
-
-! This file was ported from Lean 3 source module data.fintype.units
-! leanprover-community/mathlib commit 509de852e1de55e1efa8eacfa11df0823f26f226
-! Please do not edit these lines, except to modify the commit id
-! if you have ported upstream changes.
 -/
 import Mathlib.Data.Fintype.Prod
 import Mathlib.Data.Fintype.Sum
 import Mathlib.Data.Int.Units
 
+#align_import data.fintype.units from "leanprover-community/mathlib"@"509de852e1de55e1efa8eacfa11df0823f26f226"
+
 /-!
 # fintype instances relating to units
 -/

509de852

feat: port Data.Fintype.Units (#1696)

b163ce83

`data.fintype.units` ⟷ `Mathlib.Data.Fintype.Units`

Changes since the initial port

Changes in mathlib3

Changes in mathlib3port

Changes in mathlib4

Dependencies 2 + 173

data.fintype.units ⟷ Mathlib.Data.Fintype.Units

Changes since the initial port

Changes in mathlib3

Changes in mathlib3port

Changes in mathlib4

Dependencies 2 + 173

`data.fintype.units` ⟷ `Mathlib.Data.Fintype.Units`