data.int.cast.defs | Mathlib porting status

Changes since the initial port

The following section lists changes to this file in mathlib3 and mathlib4 that occured after the initial port. Most recent changes are shown first. Hovering over a commit will show all commits associated with the same mathlib3 commit.

Changes in mathlib3

acebd8d4

(last sync)

feat(algebra/*/opposite): Missing instances (#18602)

A few missing instances about nat.cast/int.cast/rat.cast and mul_opposite/add_opposite. Also add the (weirdly) missing add_comm_group_with_one → add_comm_monoid_with_one.

Finally, this changes the defeq of rat.cast on mul_opposite to be simpler.

Diff

@@ -52,8 +52,9 @@ class add_group_with_one (R : Type u)
 (int_cast_neg_succ_of_nat : ∀ n : ℕ, int_cast (-(n+1 : ℕ)) = -((n+1 : ℕ) : R) . control_laws_tac)
 
 /-- An `add_comm_group_with_one` is an `add_group_with_one` satisfying `a + b = b + a`. -/
-@[protect_proj, ancestor add_comm_group add_group_with_one]
-class add_comm_group_with_one (R : Type u) extends add_comm_group R, add_group_with_one R
+@[protect_proj, ancestor add_comm_group add_group_with_one add_comm_monoid_with_one]
+class add_comm_group_with_one (R : Type u)
+  extends add_comm_group R, add_group_with_one R, add_comm_monoid_with_one R
 
 /-- Canonical homomorphism from the integers to any ring(-like) structure `R` -/
 protected def int.cast {R : Type u} [has_int_cast R] (i : ℤ) : R := has_int_cast.int_cast i

99e8971d

(first ported)

Changes in mathlib3port

mathlib3

mathlib3port

acebd8d4

bump to nightly-2024-04-08-08

mathlib commit https://github.com/leanprover-community/mathlib/commit/65a1391a0106c9204fe45bc73a039f056558cb83

e7589225

Diff

@@ -85,12 +85,12 @@ instance (priority := 900) castCoe {R} [IntCast R] : CoeTC ℤ R :=
   ⟨Int.cast⟩
 #align int.cast_coe Int.castCoe
 
-/- warning: int.cast_of_nat clashes with int.cast_coe_nat -> Int.cast_ofNatₓ
-Case conversion may be inaccurate. Consider using '#align int.cast_of_nat Int.cast_ofNatₓₓ'. -/
-#print Int.cast_ofNatₓ /-
-theorem cast_ofNat (n : ℕ) : (ofNat n : R) = n :=
+/- warning: int.cast_of_nat clashes with int.cast_coe_nat -> Int.cast_natCastₓ
+Case conversion may be inaccurate. Consider using '#align int.cast_of_nat Int.cast_natCastₓₓ'. -/
+#print Int.cast_natCastₓ /-
+theorem cast_natCast (n : ℕ) : (ofNat n : R) = n :=
   AddGroupWithOne.intCast_ofNat n
-#align int.cast_of_nat Int.cast_ofNatₓ
+#align int.cast_of_nat Int.cast_natCastₓ
 -/
 
 end Int

acebd8d4

bump to nightly-2023-09-24-06

mathlib commit https://github.com/leanprover-community/mathlib/commit/ce64cd319bb6b3e82f31c2d38e79080d377be451

5655435f

Diff

@@ -3,7 +3,7 @@ Copyright (c) 2017 Mario Carneiro. All rights reserved.
 Released under Apache 2.0 license as described in the file LICENSE.
 Authors: Mario Carneiro, Gabriel Ebner
 -/
-import Mathbin.Data.Nat.Cast.Defs
+import Data.Nat.Cast.Defs
 
 #align_import data.int.cast.defs from "leanprover-community/mathlib"@"acebd8d49928f6ed8920e502a6c90674e75bd441"

acebd8d4

bump to nightly-2023-07-20-09

mathlib commit https://github.com/leanprover-community/mathlib/commit/8ea5598db6caeddde6cb734aa179cc2408dbd345

9c56d0dd

Diff

@@ -2,14 +2,11 @@
 Copyright (c) 2017 Mario Carneiro. All rights reserved.
 Released under Apache 2.0 license as described in the file LICENSE.
 Authors: Mario Carneiro, Gabriel Ebner
-
-! This file was ported from Lean 3 source module data.int.cast.defs
-! leanprover-community/mathlib commit acebd8d49928f6ed8920e502a6c90674e75bd441
-! Please do not edit these lines, except to modify the commit id
-! if you have ported upstream changes.
 -/
 import Mathbin.Data.Nat.Cast.Defs
 
+#align_import data.int.cast.defs from "leanprover-community/mathlib"@"acebd8d49928f6ed8920e502a6c90674e75bd441"
+
 /-!
 # Cast of integers

acebd8d4

bump to nightly-2023-06-01-16

mathlib commit https://github.com/leanprover-community/mathlib/commit/cca40788df1b8755d5baf17ab2f27dacc2e17acb

b9c87c70

Diff

@@ -57,8 +57,8 @@ It also contains data for the unique homomorphisms `ℕ → R` and `ℤ → R`.
 @[protect_proj]
 class AddGroupWithOne (R : Type u) extends IntCast R, AddGroup R, AddMonoidWithOne R where
   intCast := Int.castDef
-  intCast_ofNat : ∀ n : ℕ, int_cast n = (n : R) := by intros ; rfl
-  intCast_negSucc : ∀ n : ℕ, int_cast (-(n + 1 : ℕ)) = -((n + 1 : ℕ) : R) := by intros ; rfl
+  intCast_ofNat : ∀ n : ℕ, int_cast n = (n : R) := by intros; rfl
+  intCast_negSucc : ∀ n : ℕ, int_cast (-(n + 1 : ℕ)) = -((n + 1 : ℕ) : R) := by intros; rfl
 #align add_group_with_one AddGroupWithOne
 -/
 
@@ -66,7 +66,7 @@ class AddGroupWithOne (R : Type u) extends IntCast R, AddGroup R, AddMonoidWithO
 /-- An `add_comm_group_with_one` is an `add_group_with_one` satisfying `a + b = b + a`. -/
 @[protect_proj]
 class AddCommGroupWithOne (R : Type u) extends AddCommGroup R, AddGroupWithOne R,
-  AddCommMonoidWithOne R
+    AddCommMonoidWithOne R
 #align add_comm_group_with_one AddCommGroupWithOne
 -/

acebd8d4

bump to nightly-2023-05-28-04

mathlib commit https://github.com/leanprover-community/mathlib/commit/917c3c072e487b3cccdbfeff17e75b40e45f66cb

6797a637

Diff

@@ -57,15 +57,8 @@ It also contains data for the unique homomorphisms `ℕ → R` and `ℤ → R`.
 @[protect_proj]
 class AddGroupWithOne (R : Type u) extends IntCast R, AddGroup R, AddMonoidWithOne R where
   intCast := Int.castDef
-  intCast_ofNat :
-    ∀ n : ℕ, int_cast n = (n : R) := by
-    intros
-    rfl
-  intCast_negSucc :
-    ∀ n : ℕ, int_cast (-(n + 1 : ℕ)) =
-        -((n + 1 : ℕ) : R) := by
-    intros
-    rfl
+  intCast_ofNat : ∀ n : ℕ, int_cast n = (n : R) := by intros ; rfl
+  intCast_negSucc : ∀ n : ℕ, int_cast (-(n + 1 : ℕ)) = -((n + 1 : ℕ) : R) := by intros ; rfl
 #align add_group_with_one AddGroupWithOne
 -/

acebd8d4

bump to nightly-2023-03-19-03

mathlib commit https://github.com/leanprover-community/mathlib/commit/1f4705ccdfe1e557fc54a0ce081a05e33d2e6240

b19efad4

Diff

@@ -4,7 +4,7 @@ Released under Apache 2.0 license as described in the file LICENSE.
 Authors: Mario Carneiro, Gabriel Ebner
 
 ! This file was ported from Lean 3 source module data.int.cast.defs
-! leanprover-community/mathlib commit 448144f7ae193a8990cb7473c9e9a01990f64ac7
+! leanprover-community/mathlib commit acebd8d49928f6ed8920e502a6c90674e75bd441
 ! Please do not edit these lines, except to modify the commit id
 ! if you have ported upstream changes.
 -/
@@ -72,7 +72,8 @@ class AddGroupWithOne (R : Type u) extends IntCast R, AddGroup R, AddMonoidWithO
 #print AddCommGroupWithOne /-
 /-- An `add_comm_group_with_one` is an `add_group_with_one` satisfying `a + b = b + a`. -/
 @[protect_proj]
-class AddCommGroupWithOne (R : Type u) extends AddCommGroup R, AddGroupWithOne R
+class AddCommGroupWithOne (R : Type u) extends AddCommGroup R, AddGroupWithOne R,
+  AddCommMonoidWithOne R
 #align add_comm_group_with_one AddCommGroupWithOne
 -/

448144f7

bump to nightly-2023-02-21-16

mathlib commit https://github.com/leanprover-community/mathlib/commit/bd9851ca476957ea4549eb19b40e7b5ade9428cc

1107b979

Changes in mathlib4

mathlib3

mathlib4

Diff

@@ -40,11 +40,11 @@ protected def Int.castDef {R : Type u} [NatCast R] [Neg R] : ℤ → R
 /-- An `AddGroupWithOne` is an `AddGroup` with a 1. It also contains data for the unique
 homomorphisms `ℕ → R` and `ℤ → R`. -/
 class AddGroupWithOne (R : Type u) extends IntCast R, AddMonoidWithOne R, AddGroup R where
-  /-- The canonical homorphism `ℤ → R`. -/
+  /-- The canonical homomorphism `ℤ → R`. -/
   intCast := Int.castDef
-  /-- The canonical homorphism `ℤ → R` agrees with the one from `ℕ → R` on `ℕ`. -/
+  /-- The canonical homomorphism `ℤ → R` agrees with the one from `ℕ → R` on `ℕ`. -/
   intCast_ofNat : ∀ n : ℕ, intCast (n : ℕ) = Nat.cast n := by intros; rfl
-  /-- The canonical homorphism `ℤ → R` for negative values is just the negation of the values
+  /-- The canonical homomorphism `ℤ → R` for negative values is just the negation of the values
   of the canonical homomorphism `ℕ → R`. -/
   intCast_negSucc : ∀ n : ℕ, intCast (Int.negSucc n) = - Nat.cast (n + 1) := by intros; rfl
 #align add_group_with_one AddGroupWithOne

acebd8d4

chore: remove @[simp] attribute already in Std (#7687)

This attribute is already there at the point of definition in Std now.

Co-authored-by: Scott Morrison <scott.morrison@gmail.com>

a25db8ae

Diff

@@ -26,8 +26,6 @@ Preferentially, the homomorphism is written as a coercion.
 
 universe u
 
-attribute [simp] Int.ofNat_eq_coe
-
 /-- Default value for `IntCast.intCast` in an `AddGroupWithOne`. -/
 protected def Int.castDef {R : Type u} [NatCast R] [Neg R] : ℤ → R
   | (n : ℕ) => n
@@ -63,4 +61,3 @@ class AddCommGroupWithOne (R : Type u)
 #align add_comm_group_with_one.to_add_comm_group AddCommGroupWithOne.toAddCommGroup
 #align add_comm_group_with_one.to_add_group_with_one AddCommGroupWithOne.toAddGroupWithOne
 #align add_comm_group_with_one.to_add_comm_monoid_with_one AddCommGroupWithOne.toAddCommMonoidWithOne
-

acebd8d4

chore (Int.Cast.Defs): delete last line (#6710)

The last line is open Nat which came from an incomplete deletion of content from this fild. We delete the line.

a2e5641d

Diff

@@ -64,4 +64,3 @@ class AddCommGroupWithOne (R : Type u)
 #align add_comm_group_with_one.to_add_group_with_one AddCommGroupWithOne.toAddGroupWithOne
 #align add_comm_group_with_one.to_add_comm_monoid_with_one AddCommGroupWithOne.toAddCommMonoidWithOne
 
-open Nat

acebd8d4

chore: script to replace headers with #align_import statements (#5979)

depends on: #5966

Co-authored-by: Eric Wieser <wieser.eric@gmail.com> Co-authored-by: Scott Morrison <scott.morrison@gmail.com>

89aa3a3b

Diff

@@ -2,14 +2,11 @@
 Copyright (c) 2017 Mario Carneiro. All rights reserved.
 Released under Apache 2.0 license as described in the file LICENSE.
 Authors: Mario Carneiro, Gabriel Ebner
-
-! This file was ported from Lean 3 source module data.int.cast.defs
-! leanprover-community/mathlib commit acebd8d49928f6ed8920e502a6c90674e75bd441
-! Please do not edit these lines, except to modify the commit id
-! if you have ported upstream changes.
 -/
 import Mathlib.Data.Nat.Cast.Defs
 
+#align_import data.int.cast.defs from "leanprover-community/mathlib"@"acebd8d49928f6ed8920e502a6c90674e75bd441"
+
 /-!
 # Cast of integers

acebd8d4

feat: Missing opposite instances (#2940)

Match https://github.com/leanprover-community/mathlib/pull/18602

Co-authored-by: Eric Wieser <wieser.eric@gmail.com>

5c5703c2

Diff

@@ -4,7 +4,7 @@ Released under Apache 2.0 license as described in the file LICENSE.
 Authors: Mario Carneiro, Gabriel Ebner
 
 ! This file was ported from Lean 3 source module data.int.cast.defs
-! leanprover-community/mathlib commit 99e8971dc62f1f7ecf693d75e75fbbabd55849de
+! leanprover-community/mathlib commit acebd8d49928f6ed8920e502a6c90674e75bd441
 ! Please do not edit these lines, except to modify the commit id
 ! if you have ported upstream changes.
 -/
@@ -60,9 +60,11 @@ class AddGroupWithOne (R : Type u) extends IntCast R, AddMonoidWithOne R, AddGro
 #align add_group_with_one.int_cast_neg_succ_of_nat AddGroupWithOne.intCast_negSucc
 
 /-- An `AddCommGroupWithOne` is an `AddGroupWithOne` satisfying `a + b = b + a`. -/
-class AddCommGroupWithOne (R : Type u) extends AddCommGroup R, AddGroupWithOne R
+class AddCommGroupWithOne (R : Type u)
+  extends AddCommGroup R, AddGroupWithOne R, AddCommMonoidWithOne R
 #align add_comm_group_with_one AddCommGroupWithOne
 #align add_comm_group_with_one.to_add_comm_group AddCommGroupWithOne.toAddCommGroup
 #align add_comm_group_with_one.to_add_group_with_one AddCommGroupWithOne.toAddGroupWithOne
+#align add_comm_group_with_one.to_add_comm_monoid_with_one AddCommGroupWithOne.toAddCommMonoidWithOne
 
 open Nat

99e8971d

chore: update to 2023-01-10 nightly (#1447)

depends on: https://github.com/leanprover/std4/pull/83
depends on: https://github.com/JLimperg/aesop/pull/38

835b2b6b

Diff

@@ -37,11 +37,8 @@ protected def Int.castDef {R : Type u} [NatCast R] [Neg R] : ℤ → R
   | Int.negSucc n => -(n + 1 : ℕ)
 #align int.cast_def Int.castDef
 
-/-- Type class for the canonical homomorphism `ℤ → R`. -/
-class IntCast (R : Type u) where
-  /-- The canonical map `ℤ → R`. -/
-  intCast : ℤ → R
 #align has_int_cast IntCast
+#align int.cast Int.cast
 
 /-! ### Additive groups with one -/
 
@@ -62,17 +59,6 @@ class AddGroupWithOne (R : Type u) extends IntCast R, AddMonoidWithOne R, AddGro
 #align add_group_with_one.int_cast_of_nat AddGroupWithOne.intCast_ofNat
 #align add_group_with_one.int_cast_neg_succ_of_nat AddGroupWithOne.intCast_negSucc
 
-namespace Int
-
-/-- Canonical homomorphism from the integers to any ring(-like) structure `R` -/
-@[coe] def cast [IntCast R] : ℤ → R := IntCast.intCast
-#align int.cast Int.cast
-
-instance [IntCast R] : CoeTail ℤ R where coe := cast
-instance [IntCast R] : CoeHTCT ℤ R where coe := cast
-
-end Int
-
 /-- An `AddCommGroupWithOne` is an `AddGroupWithOne` satisfying `a + b = b + a`. -/
 class AddCommGroupWithOne (R : Type u) extends AddCommGroup R, AddGroupWithOne R
 #align add_comm_group_with_one AddCommGroupWithOne

99e8971d

fix: norm_cast for rationals (#1422)

65e242c0

Diff

@@ -69,6 +69,7 @@ namespace Int
 #align int.cast Int.cast
 
 instance [IntCast R] : CoeTail ℤ R where coe := cast
+instance [IntCast R] : CoeHTCT ℤ R where coe := cast
 
 end Int

99e8971d

chore: add source headers to ported theory files (#1094)

The script used to do this is included. The yaml file was obtained from https://raw.githubusercontent.com/wiki/leanprover-community/mathlib/mathlib4-port-status.md

f168625e

Diff

@@ -2,6 +2,11 @@
 Copyright (c) 2017 Mario Carneiro. All rights reserved.
 Released under Apache 2.0 license as described in the file LICENSE.
 Authors: Mario Carneiro, Gabriel Ebner
+
+! This file was ported from Lean 3 source module data.int.cast.defs
+! leanprover-community/mathlib commit 99e8971dc62f1f7ecf693d75e75fbbabd55849de
+! Please do not edit these lines, except to modify the commit id
+! if you have ported upstream changes.
 -/
 import Mathlib.Data.Nat.Cast.Defs

`data.int.cast.defs` ⟷ `Mathlib.Data.Int.Cast.Defs`

Changes since the initial port

Changes in mathlib3

Changes in mathlib3port

Changes in mathlib4

Dependencies 4

data.int.cast.defs ⟷ Mathlib.Data.Int.Cast.Defs

Changes since the initial port

Changes in mathlib3

Changes in mathlib3port

Changes in mathlib4

Dependencies 4

`data.int.cast.defs` ⟷ `Mathlib.Data.Int.Cast.Defs`