data.matrix.char_p | Mathlib porting status

Changes since the initial port

The following section lists changes to this file in mathlib3 and mathlib4 that occured after the initial port. Most recent changes are shown first. Hovering over a commit will show all commits associated with the same mathlib3 commit.

Changes in mathlib3

168ad7fc

(last sync)

Changes in mathlib3port

mathlib3

mathlib3port

d64d67d0

bump to nightly-2023-09-24-06

mathlib commit https://github.com/leanprover-community/mathlib/commit/ce64cd319bb6b3e82f31c2d38e79080d377be451

5655435f

Diff

@@ -3,8 +3,8 @@ Copyright (c) 2020 Aaron Anderson. All rights reserved.
 Released under Apache 2.0 license as described in the file LICENSE.
 Authors: Aaron Anderson
 -/
-import Mathbin.Data.Matrix.Basic
-import Mathbin.Algebra.CharP.Basic
+import Data.Matrix.Basic
+import Algebra.CharP.Basic
 
 #align_import data.matrix.char_p from "leanprover-community/mathlib"@"d64d67d000b974f0d86a2be7918cf800be6271c8"

d64d67d0

bump to nightly-2023-07-20-09

mathlib commit https://github.com/leanprover-community/mathlib/commit/8ea5598db6caeddde6cb734aa179cc2408dbd345

9c56d0dd

Diff

@@ -2,15 +2,12 @@
 Copyright (c) 2020 Aaron Anderson. All rights reserved.
 Released under Apache 2.0 license as described in the file LICENSE.
 Authors: Aaron Anderson
-
-! This file was ported from Lean 3 source module data.matrix.char_p
-! leanprover-community/mathlib commit d64d67d000b974f0d86a2be7918cf800be6271c8
-! Please do not edit these lines, except to modify the commit id
-! if you have ported upstream changes.
 -/
 import Mathbin.Data.Matrix.Basic
 import Mathbin.Algebra.CharP.Basic
 
+#align_import data.matrix.char_p from "leanprover-community/mathlib"@"d64d67d000b974f0d86a2be7918cf800be6271c8"
+
 /-!
 # Matrices in prime characteristic

d64d67d0

bump to nightly-2023-06-13-21

mathlib commit https://github.com/leanprover-community/mathlib/commit/9fb8964792b4237dac6200193a0d533f1b3f7423

829520ac

Diff

@@ -23,10 +23,12 @@ open Matrix
 
 variable {n : Type _} [Fintype n] {R : Type _} [Ring R]
 
+#print Matrix.charP /-
 instance Matrix.charP [DecidableEq n] [Nonempty n] (p : ℕ) [CharP R p] : CharP (Matrix n n R) p :=
   ⟨by
     intro k
     rw [← CharP.cast_eq_zero_iff R p k, ← Nat.cast_zero, ← map_natCast <| scalar n]
     convert scalar_inj; · simp; · assumption⟩
 #align matrix.char_p Matrix.charP
+-/

d64d67d0

bump to nightly-2023-05-28-06

mathlib commit https://github.com/leanprover-community/mathlib/commit/917c3c072e487b3cccdbfeff17e75b40e45f66cb

ba5d8b97

Diff

@@ -23,12 +23,6 @@ open Matrix
 
 variable {n : Type _} [Fintype n] {R : Type _} [Ring R]
 
-/- warning: matrix.char_p -> Matrix.charP is a dubious translation:
-lean 3 declaration is
-  forall {n : Type.{u1}} [_inst_1 : Fintype.{u1} n] {R : Type.{u2}} [_inst_2 : Ring.{u2} R] [_inst_3 : DecidableEq.{succ u1} n] [_inst_4 : Nonempty.{succ u1} n] (p : Nat) [_inst_5 : CharP.{u2} R (AddGroupWithOne.toAddMonoidWithOne.{u2} R (AddCommGroupWithOne.toAddGroupWithOne.{u2} R (Ring.toAddCommGroupWithOne.{u2} R _inst_2))) p], CharP.{max u1 u2} (Matrix.{u1, u1, u2} n n R) (AddGroupWithOne.toAddMonoidWithOne.{max u1 u2} (Matrix.{u1, u1, u2} n n R) (AddCommGroupWithOne.toAddGroupWithOne.{max u1 u2} (Matrix.{u1, u1, u2} n n R) (Ring.toAddCommGroupWithOne.{max u1 u2} (Matrix.{u1, u1, u2} n n R) (Matrix.ring.{u2, u1} n R _inst_1 (fun (a : n) (b : n) => _inst_3 a b) _inst_2)))) p
-but is expected to have type
-  forall {n : Type.{u1}} [_inst_1 : Fintype.{u1} n] {R : Type.{u2}} [_inst_2 : Ring.{u2} R] [_inst_3 : DecidableEq.{succ u1} n] [_inst_4 : Nonempty.{succ u1} n] (p : Nat) [_inst_5 : CharP.{u2} R (AddGroupWithOne.toAddMonoidWithOne.{u2} R (Ring.toAddGroupWithOne.{u2} R _inst_2)) p], CharP.{max u2 u1} (Matrix.{u1, u1, u2} n n R) (AddGroupWithOne.toAddMonoidWithOne.{max u1 u2} (Matrix.{u1, u1, u2} n n R) (Ring.toAddGroupWithOne.{max u1 u2} (Matrix.{u1, u1, u2} n n R) (Matrix.instRingMatrix.{u2, u1} n R _inst_1 (fun (a : n) (b : n) => _inst_3 a b) _inst_2))) p
-Case conversion may be inaccurate. Consider using '#align matrix.char_p Matrix.charPₓ'. -/
 instance Matrix.charP [DecidableEq n] [Nonempty n] (p : ℕ) [CharP R p] : CharP (Matrix n n R) p :=
   ⟨by
     intro k

d64d67d0

bump to nightly-2023-04-06-02

mathlib commit https://github.com/leanprover-community/mathlib/commit/06a655b5fcfbda03502f9158bbf6c0f1400886f9

89485060

Diff

@@ -4,7 +4,7 @@ Released under Apache 2.0 license as described in the file LICENSE.
 Authors: Aaron Anderson
 
 ! This file was ported from Lean 3 source module data.matrix.char_p
-! leanprover-community/mathlib commit 168ad7fc5d8173ad38be9767a22d50b8ecf1cd00
+! leanprover-community/mathlib commit d64d67d000b974f0d86a2be7918cf800be6271c8
 ! Please do not edit these lines, except to modify the commit id
 ! if you have ported upstream changes.
 -/
@@ -13,6 +13,9 @@ import Mathbin.Algebra.CharP.Basic
 
 /-!
 # Matrices in prime characteristic
+
+> THIS FILE IS SYNCHRONIZED WITH MATHLIB4.
+> Any changes to this file require a corresponding PR to mathlib4.
 -/

168ad7fc

bump to nightly-2023-04-04-14

mathlib commit https://github.com/leanprover-community/mathlib/commit/3cacc945118c8c637d89950af01da78307f59325

468d7cfa

Diff

@@ -20,6 +20,12 @@ open Matrix
 
 variable {n : Type _} [Fintype n] {R : Type _} [Ring R]
 
+/- warning: matrix.char_p -> Matrix.charP is a dubious translation:
+lean 3 declaration is
+  forall {n : Type.{u1}} [_inst_1 : Fintype.{u1} n] {R : Type.{u2}} [_inst_2 : Ring.{u2} R] [_inst_3 : DecidableEq.{succ u1} n] [_inst_4 : Nonempty.{succ u1} n] (p : Nat) [_inst_5 : CharP.{u2} R (AddGroupWithOne.toAddMonoidWithOne.{u2} R (AddCommGroupWithOne.toAddGroupWithOne.{u2} R (Ring.toAddCommGroupWithOne.{u2} R _inst_2))) p], CharP.{max u1 u2} (Matrix.{u1, u1, u2} n n R) (AddGroupWithOne.toAddMonoidWithOne.{max u1 u2} (Matrix.{u1, u1, u2} n n R) (AddCommGroupWithOne.toAddGroupWithOne.{max u1 u2} (Matrix.{u1, u1, u2} n n R) (Ring.toAddCommGroupWithOne.{max u1 u2} (Matrix.{u1, u1, u2} n n R) (Matrix.ring.{u2, u1} n R _inst_1 (fun (a : n) (b : n) => _inst_3 a b) _inst_2)))) p
+but is expected to have type
+  forall {n : Type.{u1}} [_inst_1 : Fintype.{u1} n] {R : Type.{u2}} [_inst_2 : Ring.{u2} R] [_inst_3 : DecidableEq.{succ u1} n] [_inst_4 : Nonempty.{succ u1} n] (p : Nat) [_inst_5 : CharP.{u2} R (AddGroupWithOne.toAddMonoidWithOne.{u2} R (Ring.toAddGroupWithOne.{u2} R _inst_2)) p], CharP.{max u2 u1} (Matrix.{u1, u1, u2} n n R) (AddGroupWithOne.toAddMonoidWithOne.{max u1 u2} (Matrix.{u1, u1, u2} n n R) (Ring.toAddGroupWithOne.{max u1 u2} (Matrix.{u1, u1, u2} n n R) (Matrix.instRingMatrix.{u2, u1} n R _inst_1 (fun (a : n) (b : n) => _inst_3 a b) _inst_2))) p
+Case conversion may be inaccurate. Consider using '#align matrix.char_p Matrix.charPₓ'. -/
 instance Matrix.charP [DecidableEq n] [Nonempty n] (p : ℕ) [CharP R p] : CharP (Matrix n n R) p :=
   ⟨by
     intro k

168ad7fc

bump to nightly-2023-02-21-16

mathlib commit https://github.com/leanprover-community/mathlib/commit/bd9851ca476957ea4549eb19b40e7b5ade9428cc

1107b979

Changes in mathlib4

mathlib3

mathlib4

168ad7fc

feat(Matrix/CharP): drop Fintype assumption (#10261)

Also generalize [Ring R] to [AddMonoidWithOne R].

8dd23a49

Diff

@@ -10,17 +10,18 @@ import Mathlib.Algebra.CharP.Basic
 
 /-!
 # Matrices in prime characteristic
+
+In this file we prove that matrices over a ring of characteristic `p`
+with nonempty index type have the same characteristic.
 -/
 
 
 open Matrix
 
-variable {n : Type*} [Fintype n] {R : Type*} [Ring R]
+variable {n : Type*} {R : Type*} [AddMonoidWithOne R]
 
-instance Matrix.charP [DecidableEq n] [Nonempty n] (p : ℕ) [CharP R p] : CharP (Matrix n n R) p :=
-  ⟨by
-    intro k
-    rw [← CharP.cast_eq_zero_iff R p k, ← Nat.cast_zero, ← map_natCast <| scalar n]
-    convert @scalar_inj n _ _ _ _ _ (@Nat.cast R NonAssocSemiring.toNatCast k) 0
-    simp⟩
+instance Matrix.charP [DecidableEq n] [Nonempty n] (p : ℕ) [CharP R p] :
+    CharP (Matrix n n R) p where
+  cast_eq_zero_iff' k := by simp_rw [← diagonal_natCast, ← diagonal_zero, diagonal_eq_diagonal_iff,
+    CharP.cast_eq_zero_iff R p k, forall_const]
 #align matrix.char_p Matrix.charP

168ad7fc

chore: banish Type _ and Sort _ (#6499)

We remove all possible occurences of Type _ and Sort _ in favor of Type* and Sort*.

This has nice performance benefits.

32de3f67

Diff

@@ -15,7 +15,7 @@ import Mathlib.Algebra.CharP.Basic
 
 open Matrix
 
-variable {n : Type _} [Fintype n] {R : Type _} [Ring R]
+variable {n : Type*} [Fintype n] {R : Type*} [Ring R]
 
 instance Matrix.charP [DecidableEq n] [Nonempty n] (p : ℕ) [CharP R p] : CharP (Matrix n n R) p :=
   ⟨by

168ad7fc

chore: script to replace headers with #align_import statements (#5979)

depends on: #5966

Co-authored-by: Eric Wieser <wieser.eric@gmail.com> Co-authored-by: Scott Morrison <scott.morrison@gmail.com>

89aa3a3b

Diff

@@ -2,15 +2,12 @@
 Copyright (c) 2020 Aaron Anderson. All rights reserved.
 Released under Apache 2.0 license as described in the file LICENSE.
 Authors: Aaron Anderson
-
-! This file was ported from Lean 3 source module data.matrix.char_p
-! leanprover-community/mathlib commit 168ad7fc5d8173ad38be9767a22d50b8ecf1cd00
-! Please do not edit these lines, except to modify the commit id
-! if you have ported upstream changes.
 -/
 import Mathlib.Data.Matrix.Basic
 import Mathlib.Algebra.CharP.Basic
 
+#align_import data.matrix.char_p from "leanprover-community/mathlib"@"168ad7fc5d8173ad38be9767a22d50b8ecf1cd00"
+
 /-!
 # Matrices in prime characteristic
 -/

168ad7fc

feat: port Data.Matrix.CharP (#3250)

Co-authored-by: Moritz Firsching <firsching@google.com>

dc86cdae

`data.matrix.char_p` ⟷ `Mathlib.Data.Matrix.CharP`

Changes since the initial port

Changes in mathlib3

Changes in mathlib3port

Changes in mathlib4

Dependencies 8 + 485

data.matrix.char_p ⟷ Mathlib.Data.Matrix.CharP

Changes since the initial port

Changes in mathlib3

Changes in mathlib3port

Changes in mathlib4

Dependencies 8 + 485

`data.matrix.char_p` ⟷ `Mathlib.Data.Matrix.CharP`