data.nat.cast.prod | Mathlib porting status

Changes since the initial port

The following section lists changes to this file in mathlib3 and mathlib4 that occured after the initial port. Most recent changes are shown first. Hovering over a commit will show all commits associated with the same mathlib3 commit.

Changes in mathlib3

ee0c179c

(last sync)

Changes in mathlib3port

mathlib3

mathlib3port

448144f7

bump to nightly-2023-09-24-06

mathlib commit https://github.com/leanprover-community/mathlib/commit/ce64cd319bb6b3e82f31c2d38e79080d377be451

5655435f

Diff

@@ -3,8 +3,8 @@ Copyright (c) 2014 Mario Carneiro. All rights reserved.
 Released under Apache 2.0 license as described in the file LICENSE.
 Authors: Mario Carneiro
 -/
-import Mathbin.Data.Nat.Cast.Basic
-import Mathbin.Algebra.Group.Prod
+import Data.Nat.Cast.Basic
+import Algebra.Group.Prod
 
 #align_import data.nat.cast.prod from "leanprover-community/mathlib"@"448144f7ae193a8990cb7473c9e9a01990f64ac7"

448144f7

bump to nightly-2023-07-20-09

mathlib commit https://github.com/leanprover-community/mathlib/commit/8ea5598db6caeddde6cb734aa179cc2408dbd345

9c56d0dd

Diff

@@ -2,15 +2,12 @@
 Copyright (c) 2014 Mario Carneiro. All rights reserved.
 Released under Apache 2.0 license as described in the file LICENSE.
 Authors: Mario Carneiro
-
-! This file was ported from Lean 3 source module data.nat.cast.prod
-! leanprover-community/mathlib commit 448144f7ae193a8990cb7473c9e9a01990f64ac7
-! Please do not edit these lines, except to modify the commit id
-! if you have ported upstream changes.
 -/
 import Mathbin.Data.Nat.Cast.Basic
 import Mathbin.Algebra.Group.Prod
 
+#align_import data.nat.cast.prod from "leanprover-community/mathlib"@"448144f7ae193a8990cb7473c9e9a01990f64ac7"
+
 /-!
 # The product of two `add_monoid_with_one`s.

448144f7

bump to nightly-2023-06-13-21

mathlib commit https://github.com/leanprover-community/mathlib/commit/9fb8964792b4237dac6200193a0d533f1b3f7423

829520ac

Diff

@@ -31,13 +31,17 @@ instance : AddMonoidWithOne (α × β) :=
     natCast_zero := congr_arg₂ Prod.mk Nat.cast_zero Nat.cast_zero
     natCast_succ := fun n => congr_arg₂ Prod.mk (Nat.cast_succ _) (Nat.cast_succ _) }
 
+#print Prod.fst_natCast /-
 @[simp]
 theorem fst_natCast (n : ℕ) : (n : α × β).fst = n := by induction n <;> simp [*]
 #align prod.fst_nat_cast Prod.fst_natCast
+-/
 
+#print Prod.snd_natCast /-
 @[simp]
 theorem snd_natCast (n : ℕ) : (n : α × β).snd = n := by induction n <;> simp [*]
 #align prod.snd_nat_cast Prod.snd_natCast
+-/
 
 end Prod

448144f7

bump to nightly-2023-05-28-06

mathlib commit https://github.com/leanprover-community/mathlib/commit/917c3c072e487b3cccdbfeff17e75b40e45f66cb

ba5d8b97

Diff

@@ -31,22 +31,10 @@ instance : AddMonoidWithOne (α × β) :=
     natCast_zero := congr_arg₂ Prod.mk Nat.cast_zero Nat.cast_zero
     natCast_succ := fun n => congr_arg₂ Prod.mk (Nat.cast_succ _) (Nat.cast_succ _) }
 
-/- warning: prod.fst_nat_cast -> Prod.fst_natCast is a dubious translation:
-lean 3 declaration is
-  forall {α : Type.{u1}} {β : Type.{u2}} [_inst_1 : AddMonoidWithOne.{u1} α] [_inst_2 : AddMonoidWithOne.{u2} β] (n : Nat), Eq.{succ u1} α (Prod.fst.{u1, u2} α β ((fun (a : Type) (b : Sort.{max (succ u1) (succ u2)}) [self : HasLiftT.{1, max (succ u1) (succ u2)} a b] => self.0) Nat (Prod.{u1, u2} α β) (HasLiftT.mk.{1, max (succ u1) (succ u2)} Nat (Prod.{u1, u2} α β) (CoeTCₓ.coe.{1, max (succ u1) (succ u2)} Nat (Prod.{u1, u2} α β) (Nat.castCoe.{max u1 u2} (Prod.{u1, u2} α β) (AddMonoidWithOne.toNatCast.{max u1 u2} (Prod.{u1, u2} α β) (Prod.addMonoidWithOne.{u1, u2} α β _inst_1 _inst_2))))) n)) ((fun (a : Type) (b : Type.{u1}) [self : HasLiftT.{1, succ u1} a b] => self.0) Nat α (HasLiftT.mk.{1, succ u1} Nat α (CoeTCₓ.coe.{1, succ u1} Nat α (Nat.castCoe.{u1} α (AddMonoidWithOne.toNatCast.{u1} α _inst_1)))) n)
-but is expected to have type
-  forall {α : Type.{u2}} {β : Type.{u1}} [_inst_1 : AddMonoidWithOne.{u2} α] [_inst_2 : AddMonoidWithOne.{u1} β] (n : Nat), Eq.{succ u2} α (Prod.fst.{u2, u1} α β (Nat.cast.{max u2 u1} (Prod.{u2, u1} α β) (AddMonoidWithOne.toNatCast.{max u2 u1} (Prod.{u2, u1} α β) (Prod.instAddMonoidWithOneProd.{u2, u1} α β _inst_1 _inst_2)) n)) (Nat.cast.{u2} α (AddMonoidWithOne.toNatCast.{u2} α _inst_1) n)
-Case conversion may be inaccurate. Consider using '#align prod.fst_nat_cast Prod.fst_natCastₓ'. -/
 @[simp]
 theorem fst_natCast (n : ℕ) : (n : α × β).fst = n := by induction n <;> simp [*]
 #align prod.fst_nat_cast Prod.fst_natCast
 
-/- warning: prod.snd_nat_cast -> Prod.snd_natCast is a dubious translation:
-lean 3 declaration is
-  forall {α : Type.{u1}} {β : Type.{u2}} [_inst_1 : AddMonoidWithOne.{u1} α] [_inst_2 : AddMonoidWithOne.{u2} β] (n : Nat), Eq.{succ u2} β (Prod.snd.{u1, u2} α β ((fun (a : Type) (b : Sort.{max (succ u1) (succ u2)}) [self : HasLiftT.{1, max (succ u1) (succ u2)} a b] => self.0) Nat (Prod.{u1, u2} α β) (HasLiftT.mk.{1, max (succ u1) (succ u2)} Nat (Prod.{u1, u2} α β) (CoeTCₓ.coe.{1, max (succ u1) (succ u2)} Nat (Prod.{u1, u2} α β) (Nat.castCoe.{max u1 u2} (Prod.{u1, u2} α β) (AddMonoidWithOne.toNatCast.{max u1 u2} (Prod.{u1, u2} α β) (Prod.addMonoidWithOne.{u1, u2} α β _inst_1 _inst_2))))) n)) ((fun (a : Type) (b : Type.{u2}) [self : HasLiftT.{1, succ u2} a b] => self.0) Nat β (HasLiftT.mk.{1, succ u2} Nat β (CoeTCₓ.coe.{1, succ u2} Nat β (Nat.castCoe.{u2} β (AddMonoidWithOne.toNatCast.{u2} β _inst_2)))) n)
-but is expected to have type
-  forall {α : Type.{u1}} {β : Type.{u2}} [_inst_1 : AddMonoidWithOne.{u1} α] [_inst_2 : AddMonoidWithOne.{u2} β] (n : Nat), Eq.{succ u2} β (Prod.snd.{u1, u2} α β (Nat.cast.{max u1 u2} (Prod.{u1, u2} α β) (AddMonoidWithOne.toNatCast.{max u1 u2} (Prod.{u1, u2} α β) (Prod.instAddMonoidWithOneProd.{u1, u2} α β _inst_1 _inst_2)) n)) (Nat.cast.{u2} β (AddMonoidWithOne.toNatCast.{u2} β _inst_2) n)
-Case conversion may be inaccurate. Consider using '#align prod.snd_nat_cast Prod.snd_natCastₓ'. -/
 @[simp]
 theorem snd_natCast (n : ℕ) : (n : α × β).snd = n := by induction n <;> simp [*]
 #align prod.snd_nat_cast Prod.snd_natCast

448144f7

bump to nightly-2023-02-21-16

mathlib commit https://github.com/leanprover-community/mathlib/commit/bd9851ca476957ea4549eb19b40e7b5ade9428cc

1107b979

Changes in mathlib4

mathlib3

mathlib4

ee0c179c

chore: add lemmas for nat literals corresponding to lemmas for nat casts (#8006)

I loogled for every occurrence of "cast", Nat and "natCast" and where the casted nat was n, and made sure there were corresponding @[simp] lemmas for 0, 1, and OfNat.ofNat n. This is necessary in general for simp confluence. Example:

import Mathlib

variable {α : Type*} [LinearOrderedRing α] (m n : ℕ) [m.AtLeastTwo] [n.AtLeastTwo]

example : ((OfNat.ofNat m : ℕ) : α) ≤ ((OfNat.ofNat n : ℕ) : α) ↔ (OfNat.ofNat m : ℕ) ≤ (OfNat.ofNat n : ℕ) := by
  simp only [Nat.cast_le] -- this `@[simp]` lemma can apply

example : ((OfNat.ofNat m : ℕ) : α) ≤ ((OfNat.ofNat n : ℕ) : α) ↔ (OfNat.ofNat m : α) ≤ (OfNat.ofNat n : α) := by
  simp only [Nat.cast_ofNat] -- and so can this one

example : (OfNat.ofNat m : α) ≤ (OfNat.ofNat n : α) ↔ (OfNat.ofNat m : ℕ) ≤ (OfNat.ofNat n : ℕ) := by
  simp -- fails! `simp` doesn't have a lemma to bridge their results. confluence issue.

As far as I know, the only file this PR leaves with ofNat gaps is PartENat.lean. #8002 is addressing that file in parallel.

Co-authored-by: Eric Wieser <wieser.eric@gmail.com>

bbe9baad

Diff

@@ -28,8 +28,20 @@ instance instAddMonoidWithOne : AddMonoidWithOne (α × β) :=
 theorem fst_natCast (n : ℕ) : (n : α × β).fst = n := by induction n <;> simp [*]
 #align prod.fst_nat_cast Prod.fst_natCast
 
+-- See note [no_index around OfNat.ofNat]
+@[simp]
+theorem fst_ofNat (n : ℕ) [n.AtLeastTwo] :
+    (no_index (OfNat.ofNat n : α × β)).1 = (OfNat.ofNat n : α) :=
+  rfl
+
 @[simp]
 theorem snd_natCast (n : ℕ) : (n : α × β).snd = n := by induction n <;> simp [*]
 #align prod.snd_nat_cast Prod.snd_natCast
 
+-- See note [no_index around OfNat.ofNat]
+@[simp]
+theorem snd_ofNat (n : ℕ) [n.AtLeastTwo] :
+    (no_index (OfNat.ofNat n : α × β)).2 = (OfNat.ofNat n : β) :=
+  rfl
+
 end Prod

ee0c179c

chore: reduce imports (#9830)

This uses the improved shake script from #9772 to reduce imports across mathlib. The corresponding noshake.json file has been added to #9772.

Co-authored-by: Mario Carneiro <di.gama@gmail.com>

f4c4ca61

Diff

@@ -3,7 +3,6 @@ Copyright (c) 2014 Mario Carneiro. All rights reserved.
 Released under Apache 2.0 license as described in the file LICENSE.
 Authors: Mario Carneiro
 -/
-import Mathlib.Data.Nat.Cast.Basic
 import Mathlib.Algebra.Group.Prod
 
 #align_import data.nat.cast.prod from "leanprover-community/mathlib"@"ee0c179cd3c8a45aa5bffbf1b41d8dbede452865"

ee0c179c

chore: banish Type _ and Sort _ (#6499)

We remove all possible occurences of Type _ and Sort _ in favor of Type* and Sort*.

This has nice performance benefits.

32de3f67

Diff

@@ -13,7 +13,7 @@ import Mathlib.Algebra.Group.Prod
 -/
 
 
-variable {α β : Type _}
+variable {α β : Type*}
 
 namespace Prod

ee0c179c

chore: ensure all instances referred to directly have explicit names (#6423)

Per https://github.com/leanprover/lean4/issues/2343, we are going to need to change the automatic generation of instance names, as they become too long.

This PR ensures that everywhere in Mathlib that refers to an instance by name, that name is given explicitly, rather than being automatically generated.

There are four exceptions, which are now commented, with links to https://github.com/leanprover/lean4/issues/2343.

This was implemented by running Mathlib against a modified Lean that appended _ᾰ to all automatically generated names, and fixing everything.

Co-authored-by: Scott Morrison <scott.morrison@gmail.com>

65a35f78

Diff

@@ -19,8 +19,8 @@ namespace Prod
 
 variable [AddMonoidWithOne α] [AddMonoidWithOne β]
 
-instance : AddMonoidWithOne (α × β) :=
-  { Prod.instAddMonoidSum, @instOneProd α β _ _ with
+instance instAddMonoidWithOne : AddMonoidWithOne (α × β) :=
+  { Prod.instAddMonoid, @Prod.instOne α β _ _ with
     natCast := fun n => (n, n)
     natCast_zero := congr_arg₂ Prod.mk Nat.cast_zero Nat.cast_zero
     natCast_succ := fun _ => congr_arg₂ Prod.mk (Nat.cast_succ _) (Nat.cast_succ _) }

ee0c179c

chore: script to replace headers with #align_import statements (#5979)

depends on: #5966

Co-authored-by: Eric Wieser <wieser.eric@gmail.com> Co-authored-by: Scott Morrison <scott.morrison@gmail.com>

89aa3a3b

Diff

@@ -2,15 +2,12 @@
 Copyright (c) 2014 Mario Carneiro. All rights reserved.
 Released under Apache 2.0 license as described in the file LICENSE.
 Authors: Mario Carneiro
-
-! This file was ported from Lean 3 source module data.nat.cast.prod
-! leanprover-community/mathlib commit ee0c179cd3c8a45aa5bffbf1b41d8dbede452865
-! Please do not edit these lines, except to modify the commit id
-! if you have ported upstream changes.
 -/
 import Mathlib.Data.Nat.Cast.Basic
 import Mathlib.Algebra.Group.Prod
 
+#align_import data.nat.cast.prod from "leanprover-community/mathlib"@"ee0c179cd3c8a45aa5bffbf1b41d8dbede452865"
+
 /-!
 # The product of two `AddMonoidWithOne`s.
 -/

ee0c179c

chore: fix upper/lowercase in comments (#4360)

Run a non-interactive version of fix-comments.py on all files.
Go through the diff and manually add/discard/edit chunks.

27d257fc

Diff

@@ -12,7 +12,7 @@ import Mathlib.Data.Nat.Cast.Basic
 import Mathlib.Algebra.Group.Prod
 
 /-!
-# The product of two `add_monoid_with_one`s.
+# The product of two `AddMonoidWithOne`s.
 -/

ee0c179c

chore: add source headers to ported theory files (#1094)

The script used to do this is included. The yaml file was obtained from https://raw.githubusercontent.com/wiki/leanprover-community/mathlib/mathlib4-port-status.md

f168625e

Diff

@@ -2,6 +2,11 @@
 Copyright (c) 2014 Mario Carneiro. All rights reserved.
 Released under Apache 2.0 license as described in the file LICENSE.
 Authors: Mario Carneiro
+
+! This file was ported from Lean 3 source module data.nat.cast.prod
+! leanprover-community/mathlib commit ee0c179cd3c8a45aa5bffbf1b41d8dbede452865
+! Please do not edit these lines, except to modify the commit id
+! if you have ported upstream changes.
 -/
 import Mathlib.Data.Nat.Cast.Basic
 import Mathlib.Algebra.Group.Prod

`data.nat.cast.prod` ⟷ `Mathlib.Data.Nat.Cast.Prod`

Changes since the initial port

Changes in mathlib3

Changes in mathlib3port

Changes in mathlib4

Dependencies 2 + 100

data.nat.cast.prod ⟷ Mathlib.Data.Nat.Cast.Prod

Changes since the initial port

Changes in mathlib3

Changes in mathlib3port

Changes in mathlib4

Dependencies 2 + 100

`data.nat.cast.prod` ⟷ `Mathlib.Data.Nat.Cast.Prod`