group_theory.group_action.embedding | Mathlib porting status

Changes since the initial port

The following section lists changes to this file in mathlib3 and mathlib4 that occured after the initial port. Most recent changes are shown first. Hovering over a commit will show all commits associated with the same mathlib3 commit.

Changes in mathlib3

a437a249

(last sync)

Changes in mathlib3port

mathlib3

mathlib3port

baba818b

bump to nightly-2024-01-19-06

mathlib commit https://github.com/leanprover-community/mathlib/commit/65a1391a0106c9204fe45bc73a039f056558cb83

33b57512

Diff

@@ -71,7 +71,7 @@ instance [Group G] [MulAction G β] [MulAction Gᵐᵒᵖ β] [IsCentralScalar G
 
 @[to_additive]
 instance [Group G] [MulAction G β] : MulAction G (α ↪ β) :=
-  FunLike.coe_injective.MulAction _ coe_smul
+  DFunLike.coe_injective.MulAction _ coe_smul
 
 end Function.Embedding

baba818b

bump to nightly-2023-09-24-06

mathlib commit https://github.com/leanprover-community/mathlib/commit/ce64cd319bb6b3e82f31c2d38e79080d377be451

5655435f

Diff

@@ -3,8 +3,8 @@ Copyright (c) 2022 Eric Wieser. All rights reserved.
 Released under Apache 2.0 license as described in the file LICENSE.
 Authors: Eric Wieser
 -/
-import Mathbin.GroupTheory.GroupAction.Group
-import Mathbin.GroupTheory.GroupAction.Pi
+import GroupTheory.GroupAction.Group
+import GroupTheory.GroupAction.Pi
 
 #align_import group_theory.group_action.embedding from "leanprover-community/mathlib"@"baba818b9acea366489e8ba32d2cc0fcaf50a1f7"

baba818b

bump to nightly-2023-07-20-09

mathlib commit https://github.com/leanprover-community/mathlib/commit/8ea5598db6caeddde6cb734aa179cc2408dbd345

9c56d0dd

Diff

@@ -2,15 +2,12 @@
 Copyright (c) 2022 Eric Wieser. All rights reserved.
 Released under Apache 2.0 license as described in the file LICENSE.
 Authors: Eric Wieser
-
-! This file was ported from Lean 3 source module group_theory.group_action.embedding
-! leanprover-community/mathlib commit baba818b9acea366489e8ba32d2cc0fcaf50a1f7
-! Please do not edit these lines, except to modify the commit id
-! if you have ported upstream changes.
 -/
 import Mathbin.GroupTheory.GroupAction.Group
 import Mathbin.GroupTheory.GroupAction.Pi
 
+#align_import group_theory.group_action.embedding from "leanprover-community/mathlib"@"baba818b9acea366489e8ba32d2cc0fcaf50a1f7"
+
 /-!
 # Group actions on embeddings

baba818b

bump to nightly-2023-06-13-21

mathlib commit https://github.com/leanprover-community/mathlib/commit/9fb8964792b4237dac6200193a0d533f1b3f7423

829520ac

Diff

@@ -34,24 +34,30 @@ namespace Function.Embedding
 instance [Group G] [MulAction G β] : SMul G (α ↪ β) :=
   ⟨fun g f => f.trans (MulAction.toPerm g).toEmbedding⟩
 
+#print Function.Embedding.smul_def /-
 @[to_additive]
 theorem smul_def [Group G] [MulAction G β] (g : G) (f : α ↪ β) :
     g • f = f.trans (MulAction.toPerm g).toEmbedding :=
   rfl
 #align function.embedding.smul_def Function.Embedding.smul_def
 #align function.embedding.vadd_def Function.Embedding.vadd_def
+-/
 
+#print Function.Embedding.smul_apply /-
 @[simp, to_additive]
 theorem smul_apply [Group G] [MulAction G β] (g : G) (f : α ↪ β) (a : α) : (g • f) a = g • f a :=
   rfl
 #align function.embedding.smul_apply Function.Embedding.smul_apply
 #align function.embedding.vadd_apply Function.Embedding.vadd_apply
+-/
 
+#print Function.Embedding.coe_smul /-
 @[to_additive]
 theorem coe_smul [Group G] [MulAction G β] (g : G) (f : α ↪ β) : ⇑(g • f) = g • f :=
   rfl
 #align function.embedding.coe_smul Function.Embedding.coe_smul
 #align function.embedding.coe_vadd Function.Embedding.coe_vadd
+-/
 
 instance [Group G] [Group G'] [SMul G G'] [MulAction G β] [MulAction G' β] [IsScalarTower G G' β] :
     IsScalarTower G G' (α ↪ β) :=

baba818b

bump to nightly-2023-05-28-06

mathlib commit https://github.com/leanprover-community/mathlib/commit/917c3c072e487b3cccdbfeff17e75b40e45f66cb

ba5d8b97

Diff

@@ -34,12 +34,6 @@ namespace Function.Embedding
 instance [Group G] [MulAction G β] : SMul G (α ↪ β) :=
   ⟨fun g f => f.trans (MulAction.toPerm g).toEmbedding⟩
 
-/- warning: function.embedding.smul_def -> Function.Embedding.smul_def is a dubious translation:
-lean 3 declaration is
-  forall {G : Type.{u1}} {α : Type.{u2}} {β : Type.{u3}} [_inst_1 : Group.{u1} G] [_inst_2 : MulAction.{u1, u3} G β (DivInvMonoid.toMonoid.{u1} G (Group.toDivInvMonoid.{u1} G _inst_1))] (g : G) (f : Function.Embedding.{succ u2, succ u3} α β), Eq.{succ (max u2 u3)} (Function.Embedding.{succ u2, succ u3} α β) (SMul.smul.{u1, max u2 u3} G (Function.Embedding.{succ u2, succ u3} α β) (Function.Embedding.hasSmul.{u1, u2, u3} G α β _inst_1 _inst_2) g f) (Function.Embedding.trans.{succ u2, succ u3, succ u3} α β β f (Equiv.toEmbedding.{succ u3, succ u3} β β (MulAction.toPerm.{u1, u3} G β _inst_1 _inst_2 g)))
-but is expected to have type
-  forall {G : Type.{u3}} {α : Type.{u1}} {β : Type.{u2}} [_inst_1 : Group.{u3} G] [_inst_2 : MulAction.{u3, u2} G β (DivInvMonoid.toMonoid.{u3} G (Group.toDivInvMonoid.{u3} G _inst_1))] (g : G) (f : Function.Embedding.{succ u1, succ u2} α β), Eq.{max (succ u1) (succ u2)} (Function.Embedding.{succ u1, succ u2} α β) (HSMul.hSMul.{u3, max u1 u2, max u1 u2} G (Function.Embedding.{succ u1, succ u2} α β) (Function.Embedding.{succ u1, succ u2} α β) (instHSMul.{u3, max u1 u2} G (Function.Embedding.{succ u1, succ u2} α β) (Function.Embedding.smul.{u3, u1, u2} G α β _inst_1 _inst_2)) g f) (Function.Embedding.trans.{succ u1, succ u2, succ u2} α β β f (Equiv.toEmbedding.{succ u2, succ u2} β β (MulAction.toPerm.{u3, u2} G β _inst_1 _inst_2 g)))
-Case conversion may be inaccurate. Consider using '#align function.embedding.smul_def Function.Embedding.smul_defₓ'. -/
 @[to_additive]
 theorem smul_def [Group G] [MulAction G β] (g : G) (f : α ↪ β) :
     g • f = f.trans (MulAction.toPerm g).toEmbedding :=
@@ -47,24 +41,12 @@ theorem smul_def [Group G] [MulAction G β] (g : G) (f : α ↪ β) :
 #align function.embedding.smul_def Function.Embedding.smul_def
 #align function.embedding.vadd_def Function.Embedding.vadd_def
 
-/- warning: function.embedding.smul_apply -> Function.Embedding.smul_apply is a dubious translation:
-lean 3 declaration is
-  forall {G : Type.{u1}} {α : Type.{u2}} {β : Type.{u3}} [_inst_1 : Group.{u1} G] [_inst_2 : MulAction.{u1, u3} G β (DivInvMonoid.toMonoid.{u1} G (Group.toDivInvMonoid.{u1} G _inst_1))] (g : G) (f : Function.Embedding.{succ u2, succ u3} α β) (a : α), Eq.{succ u3} β (coeFn.{max 1 (succ u2) (succ u3), max (succ u2) (succ u3)} (Function.Embedding.{succ u2, succ u3} α β) (fun (_x : Function.Embedding.{succ u2, succ u3} α β) => α -> β) (Function.Embedding.hasCoeToFun.{succ u2, succ u3} α β) (SMul.smul.{u1, max u2 u3} G (Function.Embedding.{succ u2, succ u3} α β) (Function.Embedding.hasSmul.{u1, u2, u3} G α β _inst_1 _inst_2) g f) a) (SMul.smul.{u1, u3} G β (MulAction.toHasSmul.{u1, u3} G β (DivInvMonoid.toMonoid.{u1} G (Group.toDivInvMonoid.{u1} G _inst_1)) _inst_2) g (coeFn.{max 1 (succ u2) (succ u3), max (succ u2) (succ u3)} (Function.Embedding.{succ u2, succ u3} α β) (fun (_x : Function.Embedding.{succ u2, succ u3} α β) => α -> β) (Function.Embedding.hasCoeToFun.{succ u2, succ u3} α β) f a))
-but is expected to have type
-  forall {G : Type.{u3}} {α : Type.{u1}} {β : Type.{u2}} [_inst_1 : Group.{u3} G] [_inst_2 : MulAction.{u3, u2} G β (DivInvMonoid.toMonoid.{u3} G (Group.toDivInvMonoid.{u3} G _inst_1))] (g : G) (f : Function.Embedding.{succ u1, succ u2} α β) (a : α), Eq.{succ u2} ((fun (x._@.Mathlib.Data.FunLike.Embedding._hyg.19 : α) => β) a) (FunLike.coe.{max (succ u1) (succ u2), succ u1, succ u2} (Function.Embedding.{succ u1, succ u2} α β) α (fun (_x : α) => (fun (x._@.Mathlib.Data.FunLike.Embedding._hyg.19 : α) => β) _x) (EmbeddingLike.toFunLike.{max (succ u1) (succ u2), succ u1, succ u2} (Function.Embedding.{succ u1, succ u2} α β) α β (Function.instEmbeddingLikeEmbedding.{succ u1, succ u2} α β)) (HSMul.hSMul.{u3, max u1 u2, max u1 u2} G (Function.Embedding.{succ u1, succ u2} α β) (Function.Embedding.{succ u1, succ u2} α β) (instHSMul.{u3, max u1 u2} G (Function.Embedding.{succ u1, succ u2} α β) (Function.Embedding.smul.{u3, u1, u2} G α β _inst_1 _inst_2)) g f) a) (HSMul.hSMul.{u3, u2, u2} G ((fun (x._@.Mathlib.Data.FunLike.Embedding._hyg.19 : α) => β) a) ((fun (x._@.Mathlib.Data.FunLike.Embedding._hyg.19 : α) => β) a) (instHSMul.{u3, u2} G ((fun (x._@.Mathlib.Data.FunLike.Embedding._hyg.19 : α) => β) a) (MulAction.toSMul.{u3, u2} G ((fun (x._@.Mathlib.Data.FunLike.Embedding._hyg.19 : α) => β) a) (DivInvMonoid.toMonoid.{u3} G (Group.toDivInvMonoid.{u3} G _inst_1)) _inst_2)) g (FunLike.coe.{max (succ u1) (succ u2), succ u1, succ u2} (Function.Embedding.{succ u1, succ u2} α β) α (fun (_x : α) => (fun (x._@.Mathlib.Data.FunLike.Embedding._hyg.19 : α) => β) _x) (EmbeddingLike.toFunLike.{max (succ u1) (succ u2), succ u1, succ u2} (Function.Embedding.{succ u1, succ u2} α β) α β (Function.instEmbeddingLikeEmbedding.{succ u1, succ u2} α β)) f a))
-Case conversion may be inaccurate. Consider using '#align function.embedding.smul_apply Function.Embedding.smul_applyₓ'. -/
 @[simp, to_additive]
 theorem smul_apply [Group G] [MulAction G β] (g : G) (f : α ↪ β) (a : α) : (g • f) a = g • f a :=
   rfl
 #align function.embedding.smul_apply Function.Embedding.smul_apply
 #align function.embedding.vadd_apply Function.Embedding.vadd_apply
 
-/- warning: function.embedding.coe_smul -> Function.Embedding.coe_smul is a dubious translation:
-lean 3 declaration is
-  forall {G : Type.{u1}} {α : Type.{u2}} {β : Type.{u3}} [_inst_1 : Group.{u1} G] [_inst_2 : MulAction.{u1, u3} G β (DivInvMonoid.toMonoid.{u1} G (Group.toDivInvMonoid.{u1} G _inst_1))] (g : G) (f : Function.Embedding.{succ u2, succ u3} α β), Eq.{succ (max u2 u3)} (α -> β) (coeFn.{succ (max u2 u3), succ (max u2 u3)} (Function.Embedding.{succ u2, succ u3} α β) (fun (_x : Function.Embedding.{succ u2, succ u3} α β) => α -> β) (Function.Embedding.hasCoeToFun.{succ u2, succ u3} α β) (SMul.smul.{u1, max u2 u3} G (Function.Embedding.{succ u2, succ u3} α β) (Function.Embedding.hasSmul.{u1, u2, u3} G α β _inst_1 _inst_2) g f)) (SMul.smul.{u1, max u2 u3} G (α -> β) (Function.hasSMul.{u2, u1, u3} α G β (MulAction.toHasSmul.{u1, u3} G β (DivInvMonoid.toMonoid.{u1} G (Group.toDivInvMonoid.{u1} G _inst_1)) _inst_2)) g (coeFn.{max 1 (succ u2) (succ u3), max (succ u2) (succ u3)} (Function.Embedding.{succ u2, succ u3} α β) (fun (_x : Function.Embedding.{succ u2, succ u3} α β) => α -> β) (Function.Embedding.hasCoeToFun.{succ u2, succ u3} α β) f))
-but is expected to have type
-  forall {G : Type.{u3}} {α : Type.{u1}} {β : Type.{u2}} [_inst_1 : Group.{u3} G] [_inst_2 : MulAction.{u3, u2} G β (DivInvMonoid.toMonoid.{u3} G (Group.toDivInvMonoid.{u3} G _inst_1))] (g : G) (f : Function.Embedding.{succ u1, succ u2} α β), Eq.{max (succ u1) (succ u2)} (forall (ᾰ : α), (fun (x._@.Mathlib.Data.FunLike.Embedding._hyg.19 : α) => β) ᾰ) (FunLike.coe.{max (succ u1) (succ u2), succ u1, succ u2} (Function.Embedding.{succ u1, succ u2} α β) α (fun (_x : α) => (fun (x._@.Mathlib.Data.FunLike.Embedding._hyg.19 : α) => β) _x) (EmbeddingLike.toFunLike.{max (succ u1) (succ u2), succ u1, succ u2} (Function.Embedding.{succ u1, succ u2} α β) α β (Function.instEmbeddingLikeEmbedding.{succ u1, succ u2} α β)) (HSMul.hSMul.{u3, max u1 u2, max u1 u2} G (Function.Embedding.{succ u1, succ u2} α β) (Function.Embedding.{succ u1, succ u2} α β) (instHSMul.{u3, max u1 u2} G (Function.Embedding.{succ u1, succ u2} α β) (Function.Embedding.smul.{u3, u1, u2} G α β _inst_1 _inst_2)) g f)) (HSMul.hSMul.{u3, max u1 u2, max u1 u2} G (forall (a : α), (fun (x._@.Mathlib.Data.FunLike.Embedding._hyg.19 : α) => β) a) (forall (ᾰ : α), (fun (x._@.Mathlib.Data.FunLike.Embedding._hyg.19 : α) => β) ᾰ) (instHSMul.{u3, max u1 u2} G (forall (a : α), (fun (x._@.Mathlib.Data.FunLike.Embedding._hyg.19 : α) => β) a) (Pi.instSMul.{u1, u2, u3} α G (fun (a : α) => (fun (x._@.Mathlib.Data.FunLike.Embedding._hyg.19 : α) => β) a) (fun (i : α) => MulAction.toSMul.{u3, u2} G ((fun (x._@.Mathlib.Data.FunLike.Embedding._hyg.19 : α) => β) i) (DivInvMonoid.toMonoid.{u3} G (Group.toDivInvMonoid.{u3} G _inst_1)) _inst_2))) g (FunLike.coe.{max (succ u1) (succ u2), succ u1, succ u2} (Function.Embedding.{succ u1, succ u2} α β) α (fun (_x : α) => (fun (x._@.Mathlib.Data.FunLike.Embedding._hyg.19 : α) => β) _x) (EmbeddingLike.toFunLike.{max (succ u1) (succ u2), succ u1, succ u2} (Function.Embedding.{succ u1, succ u2} α β) α β (Function.instEmbeddingLikeEmbedding.{succ u1, succ u2} α β)) f))
-Case conversion may be inaccurate. Consider using '#align function.embedding.coe_smul Function.Embedding.coe_smulₓ'. -/
 @[to_additive]
 theorem coe_smul [Group G] [MulAction G β] (g : G) (f : α ↪ β) : ⇑(g • f) = g • f :=
   rfl

baba818b

bump to nightly-2023-02-21-16

mathlib commit https://github.com/leanprover-community/mathlib/commit/bd9851ca476957ea4549eb19b40e7b5ade9428cc

1107b979

Changes in mathlib4

mathlib3

mathlib4

a437a249

chore(*): rename FunLike to DFunLike (#9785)

This prepares for the introduction of a non-dependent synonym of FunLike, which helps a lot with keeping #8386 readable.

This is entirely search-and-replace in 680197f combined with manual fixes in 4145626, e900597 and b8428f8. The commands that generated this change:

sed -i 's/\bFunLike\b/DFunLike/g' {Archive,Counterexamples,Mathlib,test}/**/*.lean
sed -i 's/\btoFunLike\b/toDFunLike/g' {Archive,Counterexamples,Mathlib,test}/**/*.lean
sed -i 's/import Mathlib.Data.DFunLike/import Mathlib.Data.FunLike/g' {Archive,Counterexamples,Mathlib,test}/**/*.lean
sed -i 's/\bHom_FunLike\b/Hom_DFunLike/g' {Archive,Counterexamples,Mathlib,test}/**/*.lean     
sed -i 's/\binstFunLike\b/instDFunLike/g' {Archive,Counterexamples,Mathlib,test}/**/*.lean
sed -i 's/\bfunLike\b/instDFunLike/g' {Archive,Counterexamples,Mathlib,test}/**/*.lean
sed -i 's/\btoo many metavariables to apply `fun_like.has_coe_to_fun`/too many metavariables to apply `DFunLike.hasCoeToFun`/g' {Archive,Counterexamples,Mathlib,test}/**/*.lean

Co-authored-by: Anne Baanen <Vierkantor@users.noreply.github.com>

82656743

Diff

@@ -62,6 +62,6 @@ instance [Group G] [MulAction G β] [MulAction Gᵐᵒᵖ β] [IsCentralScalar G
 
 @[to_additive]
 instance [Group G] [MulAction G β] : MulAction G (α ↪ β) :=
-  FunLike.coe_injective.mulAction _ coe_smul
+  DFunLike.coe_injective.mulAction _ coe_smul
 
 end Function.Embedding

a437a249

chore: banish Type _ and Sort _ (#6499)

We remove all possible occurences of Type _ and Sort _ in favor of Type* and Sort*.

This has nice performance benefits.

32de3f67

Diff

@@ -20,7 +20,7 @@ Note that unlike the `Pi` instance, this requires `G` to be a group.
 
 universe u v w
 
-variable {G G' α β : Type _}
+variable {G G' α β : Type*}
 
 namespace Function.Embedding

a437a249

chore: script to replace headers with #align_import statements (#5979)

depends on: #5966

Co-authored-by: Eric Wieser <wieser.eric@gmail.com> Co-authored-by: Scott Morrison <scott.morrison@gmail.com>

89aa3a3b

Diff

@@ -2,15 +2,12 @@
 Copyright (c) 2022 Eric Wieser. All rights reserved.
 Released under Apache 2.0 license as described in the file LICENSE.
 Authors: Eric Wieser
-
-! This file was ported from Lean 3 source module group_theory.group_action.embedding
-! leanprover-community/mathlib commit a437a2499163d85d670479f69f625f461cc5fef9
-! Please do not edit these lines, except to modify the commit id
-! if you have ported upstream changes.
 -/
 import Mathlib.GroupTheory.GroupAction.Group
 import Mathlib.GroupTheory.GroupAction.Pi
 
+#align_import group_theory.group_action.embedding from "leanprover-community/mathlib"@"a437a2499163d85d670479f69f625f461cc5fef9"
+
 /-!
 # Group actions on embeddings

a437a249

feat: improve the way to_additive deals with attributes (#1314)

The new syntax for any attributes that need to be copied by to_additive is @[to_additive (attrs := simp, ext, simps)]
Adds the auxiliary declarations generated by the simp and simps attributes to the to_additive-dictionary.
Future issue: Does not yet translate auxiliary declarations for other attributes (including custom simp-attributes). In particular it's possible that norm_cast might generate some auxiliary declarations.
Fixes #950
Fixes #953
Fixes #1149
This moves the interaction between to_additive and simps from the Simps file to the toAdditive file for uniformity.
Make the same changes to @[reassoc]

Co-authored-by: Johan Commelin <johan@commelin.net> Co-authored-by: Scott Morrison <scott.morrison@gmail.com>

56bf4cd6

Diff

@@ -38,7 +38,7 @@ theorem smul_def [Group G] [MulAction G β] (g : G) (f : α ↪ β) :
 #align function.embedding.smul_def Function.Embedding.smul_def
 #align function.embedding.vadd_def Function.Embedding.vadd_def
 
-@[simp, to_additive]
+@[to_additive (attr := simp)]
 theorem smul_apply [Group G] [MulAction G β] (g : G) (f : α ↪ β) (a : α) : (g • f) a = g • f a :=
   rfl
 #align function.embedding.smul_apply Function.Embedding.smul_apply

a437a249

feat: port GroupTheory/GroupAction/Embedding (#1277)

Everything seems to compile. This is my first port so I may be unaware of some style/comment conventions. Please, do let me know about these or any tips/tricks there are for porting! Thanks.

Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com> Co-authored-by: Frédéric Dupuis <dupuisf@iro.umontreal.ca>

c4e1de24

`group_theory.group_action.embedding` ⟷ `Mathlib.GroupTheory.GroupAction.Embedding`

Changes since the initial port

Changes in mathlib3

Changes in mathlib3port

Changes in mathlib4

Dependencies 3 + 138

group_theory.group_action.embedding ⟷ Mathlib.GroupTheory.GroupAction.Embedding

Changes since the initial port

Changes in mathlib3

Changes in mathlib3port

Changes in mathlib4

Dependencies 3 + 138

`group_theory.group_action.embedding` ⟷ `Mathlib.GroupTheory.GroupAction.Embedding`