group_theory.group_action.option | Mathlib porting status

Changes since the initial port

The following section lists changes to this file in mathlib3 and mathlib4 that occured after the initial port. Most recent changes are shown first. Hovering over a commit will show all commits associated with the same mathlib3 commit.

Changes in mathlib3

f1a2caaf

(last sync)

Changes in mathlib3port

mathlib3

mathlib3port

448144f7

bump to nightly-2023-09-24-06

mathlib commit https://github.com/leanprover-community/mathlib/commit/ce64cd319bb6b3e82f31c2d38e79080d377be451

5655435f

Diff

@@ -3,7 +3,7 @@ Copyright (c) 2022 Yaël Dillies. All rights reserved.
 Released under Apache 2.0 license as described in the file LICENSE.
 Authors: Yaël Dillies
 -/
-import Mathbin.GroupTheory.GroupAction.Defs
+import GroupTheory.GroupAction.Defs
 
 #align_import group_theory.group_action.option from "leanprover-community/mathlib"@"448144f7ae193a8990cb7473c9e9a01990f64ac7"

448144f7

bump to nightly-2023-08-17-09

mathlib commit https://github.com/leanprover-community/mathlib/commit/32a7e535287f9c73f2e4d2aef306a39190f0b504

60285dcc

Diff

@@ -83,7 +83,7 @@ instance [Monoid M] [MulAction M α] : MulAction M (Option α)
     where
   smul := (· • ·)
   one_smul b := by cases b; exacts [rfl, congr_arg some (one_smul _ _)]
-  mul_smul a₁ a₂ b := by cases b; exacts [rfl, congr_arg some (mul_smul _ _ _)]
+  hMul_smul a₁ a₂ b := by cases b; exacts [rfl, congr_arg some (mul_smul _ _ _)]
 
 end Option

448144f7

bump to nightly-2023-07-20-09

mathlib commit https://github.com/leanprover-community/mathlib/commit/8ea5598db6caeddde6cb734aa179cc2408dbd345

9c56d0dd

Diff

@@ -2,14 +2,11 @@
 Copyright (c) 2022 Yaël Dillies. All rights reserved.
 Released under Apache 2.0 license as described in the file LICENSE.
 Authors: Yaël Dillies
-
-! This file was ported from Lean 3 source module group_theory.group_action.option
-! leanprover-community/mathlib commit 448144f7ae193a8990cb7473c9e9a01990f64ac7
-! Please do not edit these lines, except to modify the commit id
-! if you have ported upstream changes.
 -/
 import Mathbin.GroupTheory.GroupAction.Defs
 
+#align_import group_theory.group_action.option from "leanprover-community/mathlib"@"448144f7ae193a8990cb7473c9e9a01990f64ac7"
+
 /-!
 # Option instances for additive and multiplicative actions

448144f7

bump to nightly-2023-06-01-16

mathlib commit https://github.com/leanprover-community/mathlib/commit/cca40788df1b8755d5baf17ab2f27dacc2e17acb

b9c87c70

Diff

@@ -66,7 +66,7 @@ theorem smul_some : a • some b = some (a • b) :=
 
 @[to_additive]
 instance [SMul M N] [IsScalarTower M N α] : IsScalarTower M N (Option α) :=
-  ⟨fun a b x => by cases x; exacts[rfl, congr_arg some (smul_assoc _ _ _)]⟩
+  ⟨fun a b x => by cases x; exacts [rfl, congr_arg some (smul_assoc _ _ _)]⟩
 
 @[to_additive]
 instance [SMulCommClass M N α] : SMulCommClass M N (Option α) :=
@@ -74,7 +74,7 @@ instance [SMulCommClass M N α] : SMulCommClass M N (Option α) :=
 
 @[to_additive]
 instance [SMul Mᵐᵒᵖ α] [IsCentralScalar M α] : IsCentralScalar M (Option α) :=
-  ⟨fun a x => by cases x; exacts[rfl, congr_arg some (op_smul_eq_smul _ _)]⟩
+  ⟨fun a x => by cases x; exacts [rfl, congr_arg some (op_smul_eq_smul _ _)]⟩
 
 @[to_additive]
 instance [FaithfulSMul M α] : FaithfulSMul M (Option α) :=
@@ -85,8 +85,8 @@ end SMul
 instance [Monoid M] [MulAction M α] : MulAction M (Option α)
     where
   smul := (· • ·)
-  one_smul b := by cases b; exacts[rfl, congr_arg some (one_smul _ _)]
-  mul_smul a₁ a₂ b := by cases b; exacts[rfl, congr_arg some (mul_smul _ _ _)]
+  one_smul b := by cases b; exacts [rfl, congr_arg some (one_smul _ _)]
+  mul_smul a₁ a₂ b := by cases b; exacts [rfl, congr_arg some (mul_smul _ _ _)]
 
 end Option

448144f7

bump to nightly-2023-05-28-04

mathlib commit https://github.com/leanprover-community/mathlib/commit/917c3c072e487b3cccdbfeff17e75b40e45f66cb

6797a637

Diff

@@ -66,9 +66,7 @@ theorem smul_some : a • some b = some (a • b) :=
 
 @[to_additive]
 instance [SMul M N] [IsScalarTower M N α] : IsScalarTower M N (Option α) :=
-  ⟨fun a b x => by
-    cases x
-    exacts[rfl, congr_arg some (smul_assoc _ _ _)]⟩
+  ⟨fun a b x => by cases x; exacts[rfl, congr_arg some (smul_assoc _ _ _)]⟩
 
 @[to_additive]
 instance [SMulCommClass M N α] : SMulCommClass M N (Option α) :=
@@ -76,9 +74,7 @@ instance [SMulCommClass M N α] : SMulCommClass M N (Option α) :=
 
 @[to_additive]
 instance [SMul Mᵐᵒᵖ α] [IsCentralScalar M α] : IsCentralScalar M (Option α) :=
-  ⟨fun a x => by
-    cases x
-    exacts[rfl, congr_arg some (op_smul_eq_smul _ _)]⟩
+  ⟨fun a x => by cases x; exacts[rfl, congr_arg some (op_smul_eq_smul _ _)]⟩
 
 @[to_additive]
 instance [FaithfulSMul M α] : FaithfulSMul M (Option α) :=
@@ -89,12 +85,8 @@ end SMul
 instance [Monoid M] [MulAction M α] : MulAction M (Option α)
     where
   smul := (· • ·)
-  one_smul b := by
-    cases b
-    exacts[rfl, congr_arg some (one_smul _ _)]
-  mul_smul a₁ a₂ b := by
-    cases b
-    exacts[rfl, congr_arg some (mul_smul _ _ _)]
+  one_smul b := by cases b; exacts[rfl, congr_arg some (one_smul _ _)]
+  mul_smul a₁ a₂ b := by cases b; exacts[rfl, congr_arg some (mul_smul _ _ _)]
 
 end Option

448144f7

bump to nightly-2023-02-21-16

mathlib commit https://github.com/leanprover-community/mathlib/commit/bd9851ca476957ea4549eb19b40e7b5ade9428cc

1107b979

Changes in mathlib4

mathlib3

mathlib4

f1a2caaf

chore: Replace (· op ·) a by (a op ·) (#8843)

I used the regex $\(· (.) ·$ (.)\), replacing with ($2 $1 ·).

d14658b4

Diff

@@ -35,7 +35,7 @@ instance : SMul M (Option α) :=
   ⟨fun a => Option.map <| (a • ·)⟩
 
 @[to_additive]
-theorem smul_def : a • x = x.map ((· • ·) a) :=
+theorem smul_def : a • x = x.map (a • ·) :=
   rfl
 #align option.smul_def Option.smul_def
 #align option.vadd_def Option.vadd_def

f1a2caaf

chore: banish Type _ and Sort _ (#6499)

We remove all possible occurences of Type _ and Sort _ in favor of Type* and Sort*.

This has nice performance benefits.

32de3f67

Diff

@@ -22,7 +22,7 @@ multiplication is defined by `a • some b = some (a • b)` and `a • none = n
 -/
 
 
-variable {M N α : Type _}
+variable {M N α : Type*}
 
 namespace Option

f1a2caaf

chore: script to replace headers with #align_import statements (#5979)

depends on: #5966

Co-authored-by: Eric Wieser <wieser.eric@gmail.com> Co-authored-by: Scott Morrison <scott.morrison@gmail.com>

89aa3a3b

Diff

@@ -2,14 +2,11 @@
 Copyright (c) 2022 Yaël Dillies. All rights reserved.
 Released under Apache 2.0 license as described in the file LICENSE.
 Authors: Yaël Dillies
-
-! This file was ported from Lean 3 source module group_theory.group_action.option
-! leanprover-community/mathlib commit f1a2caaf51ef593799107fe9a8d5e411599f3996
-! Please do not edit these lines, except to modify the commit id
-! if you have ported upstream changes.
 -/
 import Mathlib.GroupTheory.GroupAction.Defs
 
+#align_import group_theory.group_action.option from "leanprover-community/mathlib"@"f1a2caaf51ef593799107fe9a8d5e411599f3996"
+
 /-!
 # Option instances for additive and multiplicative actions

f1a2caaf

chore: add space after exacts (#4945)

Too often tempted to change these during other PRs, so doing a mass edit here.

Co-authored-by: Scott Morrison <scott.morrison@anu.edu.au>

bf799bb9

Diff

@@ -59,7 +59,7 @@ theorem smul_some : a • some b = some (a • b) :=
 instance [SMul M N] [IsScalarTower M N α] : IsScalarTower M N (Option α) :=
   ⟨fun a b x => by
     cases x
-    exacts[rfl, congr_arg some (smul_assoc _ _ _)]⟩
+    exacts [rfl, congr_arg some (smul_assoc _ _ _)]⟩
 
 @[to_additive]
 instance [SMulCommClass M N α] : SMulCommClass M N (Option α) :=
@@ -69,7 +69,7 @@ instance [SMulCommClass M N α] : SMulCommClass M N (Option α) :=
 instance [SMul Mᵐᵒᵖ α] [IsCentralScalar M α] : IsCentralScalar M (Option α) :=
   ⟨fun a x => by
     cases x
-    exacts[rfl, congr_arg some (op_smul_eq_smul _ _)]⟩
+    exacts [rfl, congr_arg some (op_smul_eq_smul _ _)]⟩
 
 @[to_additive]
 instance [FaithfulSMul M α] : FaithfulSMul M (Option α) :=
@@ -82,9 +82,9 @@ instance [Monoid M] [MulAction M α] :
   smul := (· • ·)
   one_smul b := by
     cases b
-    exacts[rfl, congr_arg some (one_smul _ _)]
+    exacts [rfl, congr_arg some (one_smul _ _)]
   mul_smul a₁ a₂ b := by
     cases b
-    exacts[rfl, congr_arg some (mul_smul _ _ _)]
+    exacts [rfl, congr_arg some (mul_smul _ _ _)]
 
 end Option

f1a2caaf

chore: add #align statements for to_additive decls (#1816)

Co-authored-by: Floris van Doorn <fpvdoorn@gmail.com>

ed378238

Diff

@@ -41,16 +41,19 @@ instance : SMul M (Option α) :=
 theorem smul_def : a • x = x.map ((· • ·) a) :=
   rfl
 #align option.smul_def Option.smul_def
+#align option.vadd_def Option.vadd_def
 
 @[to_additive (attr := simp)]
 theorem smul_none : a • (none : Option α) = none :=
   rfl
 #align option.smul_none Option.smul_none
+#align option.vadd_none Option.vadd_none
 
 @[to_additive (attr := simp)]
 theorem smul_some : a • some b = some (a • b) :=
   rfl
 #align option.smul_some Option.smul_some
+#align option.vadd_some Option.vadd_some
 
 @[to_additive]
 instance [SMul M N] [IsScalarTower M N α] : IsScalarTower M N (Option α) :=

f1a2caaf

feat: improve the way to_additive deals with attributes (#1314)

The new syntax for any attributes that need to be copied by to_additive is @[to_additive (attrs := simp, ext, simps)]
Adds the auxiliary declarations generated by the simp and simps attributes to the to_additive-dictionary.
Future issue: Does not yet translate auxiliary declarations for other attributes (including custom simp-attributes). In particular it's possible that norm_cast might generate some auxiliary declarations.
Fixes #950
Fixes #953
Fixes #1149
This moves the interaction between to_additive and simps from the Simps file to the toAdditive file for uniformity.
Make the same changes to @[reassoc]

Co-authored-by: Johan Commelin <johan@commelin.net> Co-authored-by: Scott Morrison <scott.morrison@gmail.com>

56bf4cd6

Diff

@@ -42,12 +42,12 @@ theorem smul_def : a • x = x.map ((· • ·) a) :=
   rfl
 #align option.smul_def Option.smul_def
 
-@[simp, to_additive]
+@[to_additive (attr := simp)]
 theorem smul_none : a • (none : Option α) = none :=
   rfl
 #align option.smul_none Option.smul_none
 
-@[simp, to_additive]
+@[to_additive (attr := simp)]
 theorem smul_some : a • some b = some (a • b) :=
   rfl
 #align option.smul_some Option.smul_some

f1a2caaf

chore: fix casing per naming scheme (#1183)

Fix a lot of wrong casing mostly in the docstrings but also sometimes in def/theorem names. E.g. fin 2 --> Fin 2, add_monoid_hom --> AddMonoidHom

Remove \n from to_additive docstrings that were inserted by mathport.

Move files and directories with Gcd and Smul to GCD and SMul

71723d8b

Diff

@@ -33,7 +33,7 @@ section SMul
 
 variable [SMul M α] [SMul N α] (a : M) (b : α) (x : Option α)
 
-@[to_additive Option.hasVadd]
+@[to_additive Option.VAdd]
 instance : SMul M (Option α) :=
   ⟨fun a => Option.map <| (a • ·)⟩

f1a2caaf

chore: add source headers to ported theory files (#1094)

The script used to do this is included. The yaml file was obtained from https://raw.githubusercontent.com/wiki/leanprover-community/mathlib/mathlib4-port-status.md

f168625e

Diff

@@ -2,6 +2,11 @@
 Copyright (c) 2022 Yaël Dillies. All rights reserved.
 Released under Apache 2.0 license as described in the file LICENSE.
 Authors: Yaël Dillies
+
+! This file was ported from Lean 3 source module group_theory.group_action.option
+! leanprover-community/mathlib commit f1a2caaf51ef593799107fe9a8d5e411599f3996
+! Please do not edit these lines, except to modify the commit id
+! if you have ported upstream changes.
 -/
 import Mathlib.GroupTheory.GroupAction.Defs

`group_theory.group_action.option` ⟷ `Mathlib.GroupTheory.GroupAction.Option`

Changes since the initial port

Changes in mathlib3

Changes in mathlib3port

Changes in mathlib4

Dependencies 32

group_theory.group_action.option ⟷ Mathlib.GroupTheory.GroupAction.Option

Changes since the initial port

Changes in mathlib3

Changes in mathlib3port

Changes in mathlib4

Dependencies 32

`group_theory.group_action.option` ⟷ `Mathlib.GroupTheory.GroupAction.Option`