group_theory.group_action.support | Mathlib porting status

Changes since the initial port

The following section lists changes to this file in mathlib3 and mathlib4 that occured after the initial port. Most recent changes are shown first. Hovering over a commit will show all commits associated with the same mathlib3 commit.

Changes in mathlib3

9003f287

(last sync)

Changes in mathlib3port

mathlib3

mathlib3port

f2f413b9

bump to nightly-2024-04-06-08

mathlib commit https://github.com/leanprover-community/mathlib/commit/65a1391a0106c9204fe45bc73a039f056558cb83

e34029c9

Diff

@@ -3,7 +3,7 @@ Copyright (c) 2022 Yaël Dillies. All rights reserved.
 Released under Apache 2.0 license as described in the file LICENSE.
 Authors: Yaël Dillies
 -/
-import Data.Set.Pointwise.Smul
+import Data.Set.Pointwise.SMul
 
 #align_import group_theory.group_action.support from "leanprover-community/mathlib"@"f2f413b9d4be3a02840d0663dace76e8fe3da053"

f2f413b9

bump to nightly-2024-03-17-08

mathlib commit https://github.com/leanprover-community/mathlib/commit/65a1391a0106c9204fe45bc73a039f056558cb83

22f01ce4

Diff

@@ -71,8 +71,8 @@ theorem Supports.smul (g : H) (h : Supports G s b) : Supports G (g • s) (g •
   rintro g' hg'
   rw [smul_comm, h]
   rintro a ha
-  have := Set.ball_image_iff.1 hg' a ha
-  rwa [smul_comm, smul_left_cancel_iff] at this 
+  have := Set.forall_mem_image.1 hg' a ha
+  rwa [smul_comm, smul_left_cancel_iff] at this
 #align mul_action.supports.smul MulAction.Supports.smul
 #align add_action.supports.vadd AddAction.Supports.vadd
 -/

f2f413b9

bump to nightly-2023-09-24-06

mathlib commit https://github.com/leanprover-community/mathlib/commit/ce64cd319bb6b3e82f31c2d38e79080d377be451

5655435f

Diff

@@ -3,7 +3,7 @@ Copyright (c) 2022 Yaël Dillies. All rights reserved.
 Released under Apache 2.0 license as described in the file LICENSE.
 Authors: Yaël Dillies
 -/
-import Mathbin.Data.Set.Pointwise.Smul
+import Data.Set.Pointwise.Smul
 
 #align_import group_theory.group_action.support from "leanprover-community/mathlib"@"f2f413b9d4be3a02840d0663dace76e8fe3da053"

f2f413b9

bump to nightly-2023-07-20-09

mathlib commit https://github.com/leanprover-community/mathlib/commit/8ea5598db6caeddde6cb734aa179cc2408dbd345

9c56d0dd

Diff

@@ -2,14 +2,11 @@
 Copyright (c) 2022 Yaël Dillies. All rights reserved.
 Released under Apache 2.0 license as described in the file LICENSE.
 Authors: Yaël Dillies
-
-! This file was ported from Lean 3 source module group_theory.group_action.support
-! leanprover-community/mathlib commit f2f413b9d4be3a02840d0663dace76e8fe3da053
-! Please do not edit these lines, except to modify the commit id
-! if you have ported upstream changes.
 -/
 import Mathbin.Data.Set.Pointwise.Smul
 
+#align_import group_theory.group_action.support from "leanprover-community/mathlib"@"f2f413b9d4be3a02840d0663dace76e8fe3da053"
+
 /-!
 # Support of an element under an action action

f2f413b9

bump to nightly-2023-06-13-21

mathlib commit https://github.com/leanprover-community/mathlib/commit/9fb8964792b4237dac6200193a0d533f1b3f7423

829520ac

Diff

@@ -53,17 +53,20 @@ theorem supports_of_mem (ha : a ∈ s) : Supports G s a := fun g h => h ha
 
 variable {G}
 
+#print MulAction.Supports.mono /-
 @[to_additive]
 theorem Supports.mono (h : s ⊆ t) (hs : Supports G s b) : Supports G t b := fun g hg =>
   hs _ fun a ha => hg <| h ha
 #align mul_action.supports.mono MulAction.Supports.mono
 #align add_action.supports.mono AddAction.Supports.mono
+-/
 
 end SMul
 
 variable [Group H] [SMul G α] [SMul G β] [MulAction H α] [SMul H β] [SMulCommClass G H β]
   [SMulCommClass G H α] {s t : Set α} {b : β}
 
+#print MulAction.Supports.smul /-
 -- TODO: This should work without `smul_comm_class`
 @[to_additive]
 theorem Supports.smul (g : H) (h : Supports G s b) : Supports G (g • s) (g • b) :=
@@ -75,6 +78,7 @@ theorem Supports.smul (g : H) (h : Supports G s b) : Supports G (g • s) (g •
   rwa [smul_comm, smul_left_cancel_iff] at this 
 #align mul_action.supports.smul MulAction.Supports.smul
 #align add_action.supports.vadd AddAction.Supports.vadd
+-/
 
 end MulAction

f2f413b9

bump to nightly-2023-06-01-16

mathlib commit https://github.com/leanprover-community/mathlib/commit/cca40788df1b8755d5baf17ab2f27dacc2e17acb

b9c87c70

Diff

@@ -72,7 +72,7 @@ theorem Supports.smul (g : H) (h : Supports G s b) : Supports G (g • s) (g •
   rw [smul_comm, h]
   rintro a ha
   have := Set.ball_image_iff.1 hg' a ha
-  rwa [smul_comm, smul_left_cancel_iff] at this
+  rwa [smul_comm, smul_left_cancel_iff] at this 
 #align mul_action.supports.smul MulAction.Supports.smul
 #align add_action.supports.vadd AddAction.Supports.vadd

f2f413b9

bump to nightly-2023-05-28-18

mathlib commit https://github.com/leanprover-community/mathlib/commit/917c3c072e487b3cccdbfeff17e75b40e45f66cb

8d353152

Diff

@@ -23,7 +23,7 @@ This is crucial in Fourier-Motzkin constructions.
 -/
 
 
-open Pointwise
+open scoped Pointwise
 
 variable {G H α β : Type _}

f2f413b9

bump to nightly-2023-05-28-06

mathlib commit https://github.com/leanprover-community/mathlib/commit/917c3c072e487b3cccdbfeff17e75b40e45f66cb

ba5d8b97

Diff

@@ -53,12 +53,6 @@ theorem supports_of_mem (ha : a ∈ s) : Supports G s a := fun g h => h ha
 
 variable {G}
 
-/- warning: mul_action.supports.mono -> MulAction.Supports.mono is a dubious translation:
-lean 3 declaration is
-  forall {G : Type.{u1}} {α : Type.{u2}} {β : Type.{u3}} [_inst_1 : SMul.{u1, u2} G α] [_inst_2 : SMul.{u1, u3} G β] {s : Set.{u2} α} {t : Set.{u2} α} {b : β}, (HasSubset.Subset.{u2} (Set.{u2} α) (Set.hasSubset.{u2} α) s t) -> (MulAction.Supports.{u1, u2, u3} G α β _inst_1 _inst_2 s b) -> (MulAction.Supports.{u1, u2, u3} G α β _inst_1 _inst_2 t b)
-but is expected to have type
-  forall {G : Type.{u2}} {α : Type.{u3}} {β : Type.{u1}} [_inst_1 : SMul.{u2, u3} G α] [_inst_2 : SMul.{u2, u1} G β] {s : Set.{u3} α} {t : Set.{u3} α} {b : β}, (HasSubset.Subset.{u3} (Set.{u3} α) (Set.instHasSubsetSet.{u3} α) s t) -> (MulAction.Supports.{u2, u3, u1} G α β _inst_1 _inst_2 s b) -> (MulAction.Supports.{u2, u3, u1} G α β _inst_1 _inst_2 t b)
-Case conversion may be inaccurate. Consider using '#align mul_action.supports.mono MulAction.Supports.monoₓ'. -/
 @[to_additive]
 theorem Supports.mono (h : s ⊆ t) (hs : Supports G s b) : Supports G t b := fun g hg =>
   hs _ fun a ha => hg <| h ha
@@ -70,12 +64,6 @@ end SMul
 variable [Group H] [SMul G α] [SMul G β] [MulAction H α] [SMul H β] [SMulCommClass G H β]
   [SMulCommClass G H α] {s t : Set α} {b : β}
 
-/- warning: mul_action.supports.smul -> MulAction.Supports.smul is a dubious translation:
-lean 3 declaration is
-  forall {G : Type.{u1}} {H : Type.{u2}} {α : Type.{u3}} {β : Type.{u4}} [_inst_1 : Group.{u2} H] [_inst_2 : SMul.{u1, u3} G α] [_inst_3 : SMul.{u1, u4} G β] [_inst_4 : MulAction.{u2, u3} H α (DivInvMonoid.toMonoid.{u2} H (Group.toDivInvMonoid.{u2} H _inst_1))] [_inst_5 : SMul.{u2, u4} H β] [_inst_6 : SMulCommClass.{u1, u2, u4} G H β _inst_3 _inst_5] [_inst_7 : SMulCommClass.{u1, u2, u3} G H α _inst_2 (MulAction.toHasSmul.{u2, u3} H α (DivInvMonoid.toMonoid.{u2} H (Group.toDivInvMonoid.{u2} H _inst_1)) _inst_4)] {s : Set.{u3} α} {b : β} (g : H), (MulAction.Supports.{u1, u3, u4} G α β _inst_2 _inst_3 s b) -> (MulAction.Supports.{u1, u3, u4} G α β _inst_2 _inst_3 (SMul.smul.{u2, u3} H (Set.{u3} α) (Set.smulSet.{u2, u3} H α (MulAction.toHasSmul.{u2, u3} H α (DivInvMonoid.toMonoid.{u2} H (Group.toDivInvMonoid.{u2} H _inst_1)) _inst_4)) g s) (SMul.smul.{u2, u4} H β _inst_5 g b))
-but is expected to have type
-  forall {G : Type.{u4}} {H : Type.{u1}} {α : Type.{u3}} {β : Type.{u2}} [_inst_1 : Group.{u1} H] [_inst_2 : SMul.{u4, u3} G α] [_inst_3 : SMul.{u4, u2} G β] [_inst_4 : MulAction.{u1, u3} H α (DivInvMonoid.toMonoid.{u1} H (Group.toDivInvMonoid.{u1} H _inst_1))] [_inst_5 : SMul.{u1, u2} H β] [_inst_6 : SMulCommClass.{u4, u1, u2} G H β _inst_3 _inst_5] [_inst_7 : SMulCommClass.{u4, u1, u3} G H α _inst_2 (MulAction.toSMul.{u1, u3} H α (DivInvMonoid.toMonoid.{u1} H (Group.toDivInvMonoid.{u1} H _inst_1)) _inst_4)] {s : Set.{u3} α} {b : β} (g : H), (MulAction.Supports.{u4, u3, u2} G α β _inst_2 _inst_3 s b) -> (MulAction.Supports.{u4, u3, u2} G α β _inst_2 _inst_3 (HSMul.hSMul.{u1, u3, u3} H (Set.{u3} α) (Set.{u3} α) (instHSMul.{u1, u3} H (Set.{u3} α) (Set.smulSet.{u1, u3} H α (MulAction.toSMul.{u1, u3} H α (DivInvMonoid.toMonoid.{u1} H (Group.toDivInvMonoid.{u1} H _inst_1)) _inst_4))) g s) (HSMul.hSMul.{u1, u2, u2} H β β (instHSMul.{u1, u2} H β _inst_5) g b))
-Case conversion may be inaccurate. Consider using '#align mul_action.supports.smul MulAction.Supports.smulₓ'. -/
 -- TODO: This should work without `smul_comm_class`
 @[to_additive]
 theorem Supports.smul (g : H) (h : Supports G s b) : Supports G (g • s) (g • b) :=

f2f413b9

bump to nightly-2023-02-21-16

mathlib commit https://github.com/leanprover-community/mathlib/commit/bd9851ca476957ea4549eb19b40e7b5ade9428cc

1107b979

Changes in mathlib4

mathlib3

mathlib4

9003f287

chore: Remove ball and bex from lemma names (#10816)

ball for "bounded forall" and bex for "bounded exists" are from experience very confusing abbreviations. This PR renames them to forall_mem and exists_mem in the few Set lemma names that mention them.

Also deprecate ball_image_of_ball, mem_image_elim, mem_image_elim_on since those lemmas are duplicates of the renamed lemmas (apart from argument order and implicitness, which I am also fixing by making the binder in the RHS of forall_mem_image semi-implicit), have obscure names and are completely unused.

c697e040

Diff

@@ -59,7 +59,7 @@ theorem Supports.smul (g : H) (h : Supports G s b) : Supports G (g • s) (g •
   rintro g' hg'
   rw [smul_comm, h]
   rintro a ha
-  have := Set.ball_image_iff.1 hg' a ha
+  have := Set.forall_mem_image.1 hg' ha
   rwa [smul_comm, smul_left_cancel_iff] at this
 #align mul_action.supports.smul MulAction.Supports.smul
 #align add_action.supports.vadd AddAction.Supports.vadd

9003f287

chore: banish Type _ and Sort _ (#6499)

We remove all possible occurences of Type _ and Sort _ in favor of Type* and Sort*.

This has nice performance benefits.

32de3f67

Diff

@@ -18,7 +18,7 @@ This is crucial in Fourier-Motzkin constructions.
 
 open Pointwise
 
-variable {G H α β : Type _}
+variable {G H α β : Type*}
 
 namespace MulAction

9003f287

chore: script to replace headers with #align_import statements (#5979)

depends on: #5966

Co-authored-by: Eric Wieser <wieser.eric@gmail.com> Co-authored-by: Scott Morrison <scott.morrison@gmail.com>

89aa3a3b

Diff

@@ -2,14 +2,11 @@
 Copyright (c) 2022 Yaël Dillies. All rights reserved.
 Released under Apache 2.0 license as described in the file LICENSE.
 Authors: Yaël Dillies
-
-! This file was ported from Lean 3 source module group_theory.group_action.support
-! leanprover-community/mathlib commit 9003f28797c0664a49e4179487267c494477d853
-! Please do not edit these lines, except to modify the commit id
-! if you have ported upstream changes.
 -/
 import Mathlib.Data.Set.Pointwise.SMul
 
+#align_import group_theory.group_action.support from "leanprover-community/mathlib"@"9003f28797c0664a49e4179487267c494477d853"
+
 /-!
 # Support of an element under an action action

9003f287

chore: bye-bye, solo bys! (#3825)

This PR puts, with one exception, every single remaining by that lies all by itself on its own line to the previous line, thus matching the current behaviour of start-port.sh. The exception is when the by begins the second or later argument to a tuple or anonymous constructor; see https://github.com/leanprover-community/mathlib4/pull/3825#discussion_r1186702599.

Essentially this is s/\n *by$/ by/g, but with manual editing to satisfy the linter's max-100-char-line requirement. The Python style linter is also modified to catch these "isolated bys".

14167e48

Diff

@@ -58,8 +58,7 @@ variable [Group H] [SMul G α] [SMul G β] [MulAction H α] [SMul H β] [SMulCom
 
 -- TODO: This should work without `SMulCommClass`
 @[to_additive]
-theorem Supports.smul (g : H) (h : Supports G s b) : Supports G (g • s) (g • b) :=
-  by
+theorem Supports.smul (g : H) (h : Supports G s b) : Supports G (g • s) (g • b) := by
   rintro g' hg'
   rw [smul_comm, h]
   rintro a ha

9003f287

chore: add #align statements for to_additive decls (#1816)

Co-authored-by: Floris van Doorn <fpvdoorn@gmail.com>

ed378238

Diff

@@ -34,12 +34,14 @@ variable (G) [SMul G α] [SMul G β]
 def Supports (s : Set α) (b : β) :=
   ∀ g : G, (∀ ⦃a⦄, a ∈ s → g • a = a) → g • b = b
 #align mul_action.supports MulAction.Supports
+#align add_action.supports AddAction.Supports
 
 variable {s t : Set α} {a : α} {b : β}
 
 @[to_additive]
 theorem supports_of_mem (ha : a ∈ s) : Supports G s a := fun _ h => h ha
 #align mul_action.supports_of_mem MulAction.supports_of_mem
+#align add_action.supports_of_mem AddAction.supports_of_mem
 
 variable {G}
 
@@ -47,6 +49,7 @@ variable {G}
 theorem Supports.mono (h : s ⊆ t) (hs : Supports G s b) : Supports G t b := fun _ hg =>
   (hs _) fun _ ha => hg <| h ha
 #align mul_action.supports.mono MulAction.Supports.mono
+#align add_action.supports.mono AddAction.Supports.mono
 
 end SMul
 
@@ -63,5 +66,6 @@ theorem Supports.smul (g : H) (h : Supports G s b) : Supports G (g • s) (g •
   have := Set.ball_image_iff.1 hg' a ha
   rwa [smul_comm, smul_left_cancel_iff] at this
 #align mul_action.supports.smul MulAction.Supports.smul
+#align add_action.supports.vadd AddAction.Supports.vadd
 
 end MulAction

9003f287

feat: port GroupTheory.GroupAction.Support (#1560)

Co-authored-by: maxwell-thum <119913396+maxwell-thum@users.noreply.github.com>

ef7866bd

`group_theory.group_action.support` ⟷ `Mathlib.GroupTheory.GroupAction.Support`

Changes since the initial port

Changes in mathlib3

Changes in mathlib3port

Changes in mathlib4

Dependencies 3 + 156

group_theory.group_action.support ⟷ Mathlib.GroupTheory.GroupAction.Support

Changes since the initial port

Changes in mathlib3

Changes in mathlib3port

Changes in mathlib4

Dependencies 3 + 156

`group_theory.group_action.support` ⟷ `Mathlib.GroupTheory.GroupAction.Support`