group_theory.subgroup.saturated | Mathlib porting status

Changes since the initial port

The following section lists changes to this file in mathlib3 and mathlib4 that occured after the initial port. Most recent changes are shown first. Hovering over a commit will show all commits associated with the same mathlib3 commit.

Changes in mathlib3

f7fc89d5

(last sync)

Changes in mathlib3port

mathlib3

mathlib3port

fac36901

bump to nightly-2024-04-06-08

mathlib commit https://github.com/leanprover-community/mathlib/commit/65a1391a0106c9204fe45bc73a039f056558cb83

e34029c9

Diff

@@ -50,14 +50,14 @@ theorem saturated_iff_zpow {H : Subgroup G} :
   by
   constructor
   · rintro hH ⟨n⟩ g hgn
-    · simp only [Int.coe_nat_eq_zero, Int.ofNat_eq_coe, zpow_coe_nat] at hgn ⊢
+    · simp only [Int.natCast_eq_zero, Int.ofNat_eq_coe, zpow_natCast] at hgn ⊢
       exact hH hgn
     · suffices g ^ (n + 1) ∈ H by refine' (hH this).imp _ id;
         simp only [IsEmpty.forall_iff, Nat.succ_ne_zero]
       simpa only [inv_mem_iff, zpow_negSucc] using hgn
   · intro h n g hgn
     specialize h n g
-    simp only [Int.coe_nat_eq_zero, zpow_coe_nat] at h
+    simp only [Int.natCast_eq_zero, zpow_natCast] at h
     apply h hgn
 #align subgroup.saturated_iff_zpow Subgroup.saturated_iff_zpow
 #align add_subgroup.saturated_iff_zsmul AddSubgroup.saturated_iff_zsmul

fac36901

bump to nightly-2024-03-17-08

mathlib commit https://github.com/leanprover-community/mathlib/commit/65a1391a0106c9204fe45bc73a039f056558cb83

22f01ce4

Diff

@@ -57,7 +57,7 @@ theorem saturated_iff_zpow {H : Subgroup G} :
       simpa only [inv_mem_iff, zpow_negSucc] using hgn
   · intro h n g hgn
     specialize h n g
-    simp only [Int.coe_nat_eq_zero, zpow_coe_nat] at h 
+    simp only [Int.coe_nat_eq_zero, zpow_coe_nat] at h
     apply h hgn
 #align subgroup.saturated_iff_zpow Subgroup.saturated_iff_zpow
 #align add_subgroup.saturated_iff_zsmul AddSubgroup.saturated_iff_zsmul

fac36901

bump to nightly-2024-02-29-08

mathlib commit https://github.com/leanprover-community/mathlib/commit/65a1391a0106c9204fe45bc73a039f056558cb83

74acbaea

Diff

@@ -50,14 +50,14 @@ theorem saturated_iff_zpow {H : Subgroup G} :
   by
   constructor
   · rintro hH ⟨n⟩ g hgn
-    · simp only [Int.coe_nat_eq_zero, Int.ofNat_eq_coe, zpow_ofNat] at hgn ⊢
+    · simp only [Int.coe_nat_eq_zero, Int.ofNat_eq_coe, zpow_coe_nat] at hgn ⊢
       exact hH hgn
     · suffices g ^ (n + 1) ∈ H by refine' (hH this).imp _ id;
         simp only [IsEmpty.forall_iff, Nat.succ_ne_zero]
       simpa only [inv_mem_iff, zpow_negSucc] using hgn
   · intro h n g hgn
     specialize h n g
-    simp only [Int.coe_nat_eq_zero, zpow_ofNat] at h 
+    simp only [Int.coe_nat_eq_zero, zpow_coe_nat] at h 
     apply h hgn
 #align subgroup.saturated_iff_zpow Subgroup.saturated_iff_zpow
 #align add_subgroup.saturated_iff_zsmul AddSubgroup.saturated_iff_zsmul

fac36901

bump to nightly-2023-09-24-06

mathlib commit https://github.com/leanprover-community/mathlib/commit/ce64cd319bb6b3e82f31c2d38e79080d377be451

5655435f

Diff

@@ -3,7 +3,7 @@ Copyright (c) 2021 Johan Commelin. All rights reserved.
 Released under Apache 2.0 license as described in the file LICENSE.
 Authors: Johan Commelin
 -/
-import Mathbin.GroupTheory.Subgroup.Basic
+import GroupTheory.Subgroup.Basic
 
 #align_import group_theory.subgroup.saturated from "leanprover-community/mathlib"@"fac369018417f980cec5fcdafc766a69f88d8cfe"

fac36901

bump to nightly-2023-07-20-09

mathlib commit https://github.com/leanprover-community/mathlib/commit/8ea5598db6caeddde6cb734aa179cc2408dbd345

9c56d0dd

Diff

@@ -2,14 +2,11 @@
 Copyright (c) 2021 Johan Commelin. All rights reserved.
 Released under Apache 2.0 license as described in the file LICENSE.
 Authors: Johan Commelin
-
-! This file was ported from Lean 3 source module group_theory.subgroup.saturated
-! leanprover-community/mathlib commit fac369018417f980cec5fcdafc766a69f88d8cfe
-! Please do not edit these lines, except to modify the commit id
-! if you have ported upstream changes.
 -/
 import Mathbin.GroupTheory.Subgroup.Basic
 
+#align_import group_theory.subgroup.saturated from "leanprover-community/mathlib"@"fac369018417f980cec5fcdafc766a69f88d8cfe"
+
 /-!
 # Saturated subgroups

fac36901

bump to nightly-2023-06-13-21

mathlib commit https://github.com/leanprover-community/mathlib/commit/9fb8964792b4237dac6200193a0d533f1b3f7423

829520ac

Diff

@@ -37,13 +37,16 @@ def Saturated (H : Subgroup G) : Prop :=
 #align add_subgroup.saturated AddSubgroup.Saturated
 -/
 
+#print Subgroup.saturated_iff_npow /-
 @[to_additive]
 theorem saturated_iff_npow {H : Subgroup G} :
     Saturated H ↔ ∀ (n : ℕ) (g : G), g ^ n ∈ H → n = 0 ∨ g ∈ H :=
   Iff.rfl
 #align subgroup.saturated_iff_npow Subgroup.saturated_iff_npow
 #align add_subgroup.saturated_iff_nsmul AddSubgroup.saturated_iff_nsmul
+-/
 
+#print Subgroup.saturated_iff_zpow /-
 @[to_additive]
 theorem saturated_iff_zpow {H : Subgroup G} :
     Saturated H ↔ ∀ (n : ℤ) (g : G), g ^ n ∈ H → n = 0 ∨ g ∈ H :=
@@ -61,16 +64,19 @@ theorem saturated_iff_zpow {H : Subgroup G} :
     apply h hgn
 #align subgroup.saturated_iff_zpow Subgroup.saturated_iff_zpow
 #align add_subgroup.saturated_iff_zsmul AddSubgroup.saturated_iff_zsmul
+-/
 
 end Subgroup
 
 namespace AddSubgroup
 
+#print AddSubgroup.ker_saturated /-
 theorem ker_saturated {A₁ A₂ : Type _} [AddCommGroup A₁] [AddCommGroup A₂] [NoZeroSMulDivisors ℕ A₂]
     (f : A₁ →+ A₂) : f.ker.Saturated := by
   intro n g hg
   simpa only [f.mem_ker, nsmul_eq_smul, f.map_nsmul, smul_eq_zero] using hg
 #align add_subgroup.ker_saturated AddSubgroup.ker_saturated
+-/
 
 end AddSubgroup

fac36901

bump to nightly-2023-06-01-16

mathlib commit https://github.com/leanprover-community/mathlib/commit/cca40788df1b8755d5baf17ab2f27dacc2e17acb

b9c87c70

Diff

@@ -50,14 +50,14 @@ theorem saturated_iff_zpow {H : Subgroup G} :
   by
   constructor
   · rintro hH ⟨n⟩ g hgn
-    · simp only [Int.coe_nat_eq_zero, Int.ofNat_eq_coe, zpow_ofNat] at hgn⊢
+    · simp only [Int.coe_nat_eq_zero, Int.ofNat_eq_coe, zpow_ofNat] at hgn ⊢
       exact hH hgn
     · suffices g ^ (n + 1) ∈ H by refine' (hH this).imp _ id;
         simp only [IsEmpty.forall_iff, Nat.succ_ne_zero]
       simpa only [inv_mem_iff, zpow_negSucc] using hgn
   · intro h n g hgn
     specialize h n g
-    simp only [Int.coe_nat_eq_zero, zpow_ofNat] at h
+    simp only [Int.coe_nat_eq_zero, zpow_ofNat] at h 
     apply h hgn
 #align subgroup.saturated_iff_zpow Subgroup.saturated_iff_zpow
 #align add_subgroup.saturated_iff_zsmul AddSubgroup.saturated_iff_zsmul

fac36901

bump to nightly-2023-05-28-06

mathlib commit https://github.com/leanprover-community/mathlib/commit/917c3c072e487b3cccdbfeff17e75b40e45f66cb

ba5d8b97

Diff

@@ -37,12 +37,6 @@ def Saturated (H : Subgroup G) : Prop :=
 #align add_subgroup.saturated AddSubgroup.Saturated
 -/
 
-/- warning: subgroup.saturated_iff_npow -> Subgroup.saturated_iff_npow is a dubious translation:
-lean 3 declaration is
-  forall {G : Type.{u1}} [_inst_1 : Group.{u1} G] {H : Subgroup.{u1} G _inst_1}, Iff (Subgroup.Saturated.{u1} G _inst_1 H) (forall (n : Nat) (g : G), (Membership.Mem.{u1, u1} G (Subgroup.{u1} G _inst_1) (SetLike.hasMem.{u1, u1} (Subgroup.{u1} G _inst_1) G (Subgroup.setLike.{u1} G _inst_1)) (HPow.hPow.{u1, 0, u1} G Nat G (instHPow.{u1, 0} G Nat (Monoid.Pow.{u1} G (DivInvMonoid.toMonoid.{u1} G (Group.toDivInvMonoid.{u1} G _inst_1)))) g n) H) -> (Or (Eq.{1} Nat n (OfNat.ofNat.{0} Nat 0 (OfNat.mk.{0} Nat 0 (Zero.zero.{0} Nat Nat.hasZero)))) (Membership.Mem.{u1, u1} G (Subgroup.{u1} G _inst_1) (SetLike.hasMem.{u1, u1} (Subgroup.{u1} G _inst_1) G (Subgroup.setLike.{u1} G _inst_1)) g H)))
-but is expected to have type
-  forall {G : Type.{u1}} [_inst_1 : Group.{u1} G] {H : Subgroup.{u1} G _inst_1}, Iff (Subgroup.Saturated.{u1} G _inst_1 H) (forall (n : Nat) (g : G), (Membership.mem.{u1, u1} G (Subgroup.{u1} G _inst_1) (SetLike.instMembership.{u1, u1} (Subgroup.{u1} G _inst_1) G (Subgroup.instSetLikeSubgroup.{u1} G _inst_1)) (HPow.hPow.{u1, 0, u1} G Nat G (instHPow.{u1, 0} G Nat (Monoid.Pow.{u1} G (DivInvMonoid.toMonoid.{u1} G (Group.toDivInvMonoid.{u1} G _inst_1)))) g n) H) -> (Or (Eq.{1} Nat n (OfNat.ofNat.{0} Nat 0 (instOfNatNat 0))) (Membership.mem.{u1, u1} G (Subgroup.{u1} G _inst_1) (SetLike.instMembership.{u1, u1} (Subgroup.{u1} G _inst_1) G (Subgroup.instSetLikeSubgroup.{u1} G _inst_1)) g H)))
-Case conversion may be inaccurate. Consider using '#align subgroup.saturated_iff_npow Subgroup.saturated_iff_npowₓ'. -/
 @[to_additive]
 theorem saturated_iff_npow {H : Subgroup G} :
     Saturated H ↔ ∀ (n : ℕ) (g : G), g ^ n ∈ H → n = 0 ∨ g ∈ H :=
@@ -50,12 +44,6 @@ theorem saturated_iff_npow {H : Subgroup G} :
 #align subgroup.saturated_iff_npow Subgroup.saturated_iff_npow
 #align add_subgroup.saturated_iff_nsmul AddSubgroup.saturated_iff_nsmul
 
-/- warning: subgroup.saturated_iff_zpow -> Subgroup.saturated_iff_zpow is a dubious translation:
-lean 3 declaration is
-  forall {G : Type.{u1}} [_inst_1 : Group.{u1} G] {H : Subgroup.{u1} G _inst_1}, Iff (Subgroup.Saturated.{u1} G _inst_1 H) (forall (n : Int) (g : G), (Membership.Mem.{u1, u1} G (Subgroup.{u1} G _inst_1) (SetLike.hasMem.{u1, u1} (Subgroup.{u1} G _inst_1) G (Subgroup.setLike.{u1} G _inst_1)) (HPow.hPow.{u1, 0, u1} G Int G (instHPow.{u1, 0} G Int (DivInvMonoid.Pow.{u1} G (Group.toDivInvMonoid.{u1} G _inst_1))) g n) H) -> (Or (Eq.{1} Int n (OfNat.ofNat.{0} Int 0 (OfNat.mk.{0} Int 0 (Zero.zero.{0} Int Int.hasZero)))) (Membership.Mem.{u1, u1} G (Subgroup.{u1} G _inst_1) (SetLike.hasMem.{u1, u1} (Subgroup.{u1} G _inst_1) G (Subgroup.setLike.{u1} G _inst_1)) g H)))
-but is expected to have type
-  forall {G : Type.{u1}} [_inst_1 : Group.{u1} G] {H : Subgroup.{u1} G _inst_1}, Iff (Subgroup.Saturated.{u1} G _inst_1 H) (forall (n : Int) (g : G), (Membership.mem.{u1, u1} G (Subgroup.{u1} G _inst_1) (SetLike.instMembership.{u1, u1} (Subgroup.{u1} G _inst_1) G (Subgroup.instSetLikeSubgroup.{u1} G _inst_1)) (HPow.hPow.{u1, 0, u1} G Int G (instHPow.{u1, 0} G Int (DivInvMonoid.Pow.{u1} G (Group.toDivInvMonoid.{u1} G _inst_1))) g n) H) -> (Or (Eq.{1} Int n (OfNat.ofNat.{0} Int 0 (instOfNatInt 0))) (Membership.mem.{u1, u1} G (Subgroup.{u1} G _inst_1) (SetLike.instMembership.{u1, u1} (Subgroup.{u1} G _inst_1) G (Subgroup.instSetLikeSubgroup.{u1} G _inst_1)) g H)))
-Case conversion may be inaccurate. Consider using '#align subgroup.saturated_iff_zpow Subgroup.saturated_iff_zpowₓ'. -/
 @[to_additive]
 theorem saturated_iff_zpow {H : Subgroup G} :
     Saturated H ↔ ∀ (n : ℤ) (g : G), g ^ n ∈ H → n = 0 ∨ g ∈ H :=
@@ -78,12 +66,6 @@ end Subgroup
 
 namespace AddSubgroup
 
-/- warning: add_subgroup.ker_saturated -> AddSubgroup.ker_saturated is a dubious translation:
-lean 3 declaration is
-  forall {A₁ : Type.{u1}} {A₂ : Type.{u2}} [_inst_1 : AddCommGroup.{u1} A₁] [_inst_2 : AddCommGroup.{u2} A₂] [_inst_3 : NoZeroSMulDivisors.{0, u2} Nat A₂ Nat.hasZero (AddZeroClass.toHasZero.{u2} A₂ (AddMonoid.toAddZeroClass.{u2} A₂ (SubNegMonoid.toAddMonoid.{u2} A₂ (AddGroup.toSubNegMonoid.{u2} A₂ (AddCommGroup.toAddGroup.{u2} A₂ _inst_2))))) (AddMonoid.SMul.{u2} A₂ (SubNegMonoid.toAddMonoid.{u2} A₂ (AddGroup.toSubNegMonoid.{u2} A₂ (AddCommGroup.toAddGroup.{u2} A₂ _inst_2))))] (f : AddMonoidHom.{u1, u2} A₁ A₂ (AddMonoid.toAddZeroClass.{u1} A₁ (SubNegMonoid.toAddMonoid.{u1} A₁ (AddGroup.toSubNegMonoid.{u1} A₁ (AddCommGroup.toAddGroup.{u1} A₁ _inst_1)))) (AddMonoid.toAddZeroClass.{u2} A₂ (SubNegMonoid.toAddMonoid.{u2} A₂ (AddGroup.toSubNegMonoid.{u2} A₂ (AddCommGroup.toAddGroup.{u2} A₂ _inst_2))))), AddSubgroup.Saturated.{u1} A₁ (AddCommGroup.toAddGroup.{u1} A₁ _inst_1) (AddMonoidHom.ker.{u1, u2} A₁ (AddCommGroup.toAddGroup.{u1} A₁ _inst_1) A₂ (AddMonoid.toAddZeroClass.{u2} A₂ (SubNegMonoid.toAddMonoid.{u2} A₂ (AddGroup.toSubNegMonoid.{u2} A₂ (AddCommGroup.toAddGroup.{u2} A₂ _inst_2)))) f)
-but is expected to have type
-  forall {A₁ : Type.{u2}} {A₂ : Type.{u1}} [_inst_1 : AddCommGroup.{u2} A₁] [_inst_2 : AddCommGroup.{u1} A₂] [_inst_3 : NoZeroSMulDivisors.{0, u1} Nat A₂ (LinearOrderedCommMonoidWithZero.toZero.{0} Nat Nat.linearOrderedCommMonoidWithZero) (NegZeroClass.toZero.{u1} A₂ (SubNegZeroMonoid.toNegZeroClass.{u1} A₂ (SubtractionMonoid.toSubNegZeroMonoid.{u1} A₂ (SubtractionCommMonoid.toSubtractionMonoid.{u1} A₂ (AddCommGroup.toDivisionAddCommMonoid.{u1} A₂ _inst_2))))) (AddMonoid.SMul.{u1} A₂ (SubNegMonoid.toAddMonoid.{u1} A₂ (AddGroup.toSubNegMonoid.{u1} A₂ (AddCommGroup.toAddGroup.{u1} A₂ _inst_2))))] (f : AddMonoidHom.{u2, u1} A₁ A₂ (AddMonoid.toAddZeroClass.{u2} A₁ (SubNegMonoid.toAddMonoid.{u2} A₁ (AddGroup.toSubNegMonoid.{u2} A₁ (AddCommGroup.toAddGroup.{u2} A₁ _inst_1)))) (AddMonoid.toAddZeroClass.{u1} A₂ (SubNegMonoid.toAddMonoid.{u1} A₂ (AddGroup.toSubNegMonoid.{u1} A₂ (AddCommGroup.toAddGroup.{u1} A₂ _inst_2))))), AddSubgroup.Saturated.{u2} A₁ (AddCommGroup.toAddGroup.{u2} A₁ _inst_1) (AddMonoidHom.ker.{u2, u1} A₁ (AddCommGroup.toAddGroup.{u2} A₁ _inst_1) A₂ (AddMonoid.toAddZeroClass.{u1} A₂ (SubNegMonoid.toAddMonoid.{u1} A₂ (AddGroup.toSubNegMonoid.{u1} A₂ (AddCommGroup.toAddGroup.{u1} A₂ _inst_2)))) f)
-Case conversion may be inaccurate. Consider using '#align add_subgroup.ker_saturated AddSubgroup.ker_saturatedₓ'. -/
 theorem ker_saturated {A₁ A₂ : Type _} [AddCommGroup A₁] [AddCommGroup A₂] [NoZeroSMulDivisors ℕ A₂]
     (f : A₁ →+ A₂) : f.ker.Saturated := by
   intro n g hg

fac36901

bump to nightly-2023-05-28-04

mathlib commit https://github.com/leanprover-community/mathlib/commit/917c3c072e487b3cccdbfeff17e75b40e45f66cb

6797a637

Diff

@@ -64,8 +64,7 @@ theorem saturated_iff_zpow {H : Subgroup G} :
   · rintro hH ⟨n⟩ g hgn
     · simp only [Int.coe_nat_eq_zero, Int.ofNat_eq_coe, zpow_ofNat] at hgn⊢
       exact hH hgn
-    · suffices g ^ (n + 1) ∈ H by
-        refine' (hH this).imp _ id
+    · suffices g ^ (n + 1) ∈ H by refine' (hH this).imp _ id;
         simp only [IsEmpty.forall_iff, Nat.succ_ne_zero]
       simpa only [inv_mem_iff, zpow_negSucc] using hgn
   · intro h n g hgn

fac36901

bump to nightly-2023-02-21-16

mathlib commit https://github.com/leanprover-community/mathlib/commit/bd9851ca476957ea4549eb19b40e7b5ade9428cc

1107b979

Changes in mathlib4

mathlib3

mathlib4

f7fc89d5

chore: split Algebra.Module.Basic (#12501)

Similar to #12486, which did this for Algebra.Algebra.Basic.

Splits Algebra.Module.Defs off Algebra.Module.Basic. Most imports only need the Defs file, which has significantly smaller imports. The remaining Algebra.Module.Basic is now a grab-bag of unrelated results, and should probably be split further or rehomed.

This is mostly motivated by the wasted effort during minimization upon encountering Algebra.Module.Basic.

Co-authored-by: Scott Morrison <scott.morrison@gmail.com> Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>

7d5102df

Diff

@@ -3,8 +3,8 @@ Copyright (c) 2021 Johan Commelin. All rights reserved.
 Released under Apache 2.0 license as described in the file LICENSE.
 Authors: Johan Commelin
 -/
+import Mathlib.Algebra.Module.Defs
 import Mathlib.GroupTheory.Subgroup.Basic
-import Mathlib.Algebra.Module.Basic
 
 #align_import group_theory.subgroup.saturated from "leanprover-community/mathlib"@"f7fc89d5d5ff1db2d1242c7bb0e9062ce47ef47c"

f7fc89d5

chore(Data/Int): Rename coe_nat to natCast (#11637)

Reduce the diff of #11499

Renames

All in the Int namespace:

ofNat_eq_cast → ofNat_eq_natCast
cast_eq_cast_iff_Nat → natCast_inj
natCast_eq_ofNat → ofNat_eq_natCast
coe_nat_sub → natCast_sub
coe_nat_nonneg → natCast_nonneg
sign_coe_add_one → sign_natCast_add_one
nat_succ_eq_int_succ → natCast_succ
succ_neg_nat_succ → succ_neg_natCast_succ
coe_pred_of_pos → natCast_pred_of_pos
coe_nat_div → natCast_div
coe_nat_ediv → natCast_ediv
sign_coe_nat_of_nonzero → sign_natCast_of_ne_zero
toNat_coe_nat → toNat_natCast
toNat_coe_nat_add_one → toNat_natCast_add_one
coe_nat_dvd → natCast_dvd_natCast
coe_nat_dvd_left → natCast_dvd
coe_nat_dvd_right → dvd_natCast
le_coe_nat_sub → le_natCast_sub
succ_coe_nat_pos → succ_natCast_pos
coe_nat_modEq_iff → natCast_modEq_iff
coe_natAbs → natCast_natAbs
coe_nat_eq_zero → natCast_eq_zero
coe_nat_ne_zero → natCast_ne_zero
coe_nat_ne_zero_iff_pos → natCast_ne_zero_iff_pos
abs_coe_nat → abs_natCast
coe_nat_nonpos_iff → natCast_nonpos_iff

Also rename Nat.coe_nat_dvd to Nat.cast_dvd_cast

392a24a9

Diff

@@ -44,7 +44,7 @@ theorem saturated_iff_zpow {H : Subgroup G} :
   constructor
   · intros hH n g hgn
     induction' n with n n
-    · simp only [Int.coe_nat_eq_zero, Int.ofNat_eq_coe, zpow_natCast] at hgn ⊢
+    · simp only [Int.natCast_eq_zero, Int.ofNat_eq_coe, zpow_natCast] at hgn ⊢
       exact hH hgn
     · suffices g ^ (n + 1) ∈ H by
         refine' (hH this).imp _ id
@@ -52,7 +52,7 @@ theorem saturated_iff_zpow {H : Subgroup G} :
       simpa only [inv_mem_iff, zpow_negSucc] using hgn
   · intro h n g hgn
     specialize h n g
-    simp only [Int.coe_nat_eq_zero, zpow_natCast] at h
+    simp only [Int.natCast_eq_zero, zpow_natCast] at h
     apply h hgn
 #align subgroup.saturated_iff_zpow Subgroup.saturated_iff_zpow
 #align add_subgroup.saturated_iff_zsmul AddSubgroup.saturated_iff_zsmul

f7fc89d5

chore: Rename zpow_coe_nat to zpow_natCast (#11528)

... and add a deprecated alias for the old name. This is mostly just me discovering the power of F2

75dad162

Diff

@@ -44,7 +44,7 @@ theorem saturated_iff_zpow {H : Subgroup G} :
   constructor
   · intros hH n g hgn
     induction' n with n n
-    · simp only [Int.coe_nat_eq_zero, Int.ofNat_eq_coe, zpow_coe_nat] at hgn ⊢
+    · simp only [Int.coe_nat_eq_zero, Int.ofNat_eq_coe, zpow_natCast] at hgn ⊢
       exact hH hgn
     · suffices g ^ (n + 1) ∈ H by
         refine' (hH this).imp _ id
@@ -52,7 +52,7 @@ theorem saturated_iff_zpow {H : Subgroup G} :
       simpa only [inv_mem_iff, zpow_negSucc] using hgn
   · intro h n g hgn
     specialize h n g
-    simp only [Int.coe_nat_eq_zero, zpow_coe_nat] at h
+    simp only [Int.coe_nat_eq_zero, zpow_natCast] at h
     apply h hgn
 #align subgroup.saturated_iff_zpow Subgroup.saturated_iff_zpow
 #align add_subgroup.saturated_iff_zsmul AddSubgroup.saturated_iff_zsmul

f7fc89d5

fix: correct statement of zpow_ofNat and ofNat_zsmul (#10969)

Previously these were syntactically identical to the corresponding zpow_coe_nat and coe_nat_zsmul lemmas, now they are about OfNat.ofNat.

Unfortunately, almost every call site uses the ofNat name to refer to Nat.cast, so the downstream proofs had to be adjusted too.

d5525380

Diff

@@ -44,7 +44,7 @@ theorem saturated_iff_zpow {H : Subgroup G} :
   constructor
   · intros hH n g hgn
     induction' n with n n
-    · simp only [Int.coe_nat_eq_zero, Int.ofNat_eq_coe, zpow_ofNat] at hgn ⊢
+    · simp only [Int.coe_nat_eq_zero, Int.ofNat_eq_coe, zpow_coe_nat] at hgn ⊢
       exact hH hgn
     · suffices g ^ (n + 1) ∈ H by
         refine' (hH this).imp _ id
@@ -52,7 +52,7 @@ theorem saturated_iff_zpow {H : Subgroup G} :
       simpa only [inv_mem_iff, zpow_negSucc] using hgn
   · intro h n g hgn
     specialize h n g
-    simp only [Int.coe_nat_eq_zero, zpow_ofNat] at h
+    simp only [Int.coe_nat_eq_zero, zpow_coe_nat] at h
     apply h hgn
 #align subgroup.saturated_iff_zpow Subgroup.saturated_iff_zpow
 #align add_subgroup.saturated_iff_zsmul AddSubgroup.saturated_iff_zsmul

f7fc89d5

chore: reduce imports (#9830)

This uses the improved shake script from #9772 to reduce imports across mathlib. The corresponding noshake.json file has been added to #9772.

Co-authored-by: Mario Carneiro <di.gama@gmail.com>

f4c4ca61

Diff

@@ -4,6 +4,7 @@ Released under Apache 2.0 license as described in the file LICENSE.
 Authors: Johan Commelin
 -/
 import Mathlib.GroupTheory.Subgroup.Basic
+import Mathlib.Algebra.Module.Basic
 
 #align_import group_theory.subgroup.saturated from "leanprover-community/mathlib"@"f7fc89d5d5ff1db2d1242c7bb0e9062ce47ef47c"

f7fc89d5

chore: banish Type _ and Sort _ (#6499)

We remove all possible occurences of Type _ and Sort _ in favor of Type* and Sort*.

This has nice performance benefits.

32de3f67

Diff

@@ -18,7 +18,7 @@ subgroup, subgroups
 
 namespace Subgroup
 
-variable {G : Type _} [Group G]
+variable {G : Type*} [Group G]
 
 /-- A subgroup `H` of `G` is *saturated* if for all `n : ℕ` and `g : G` with `g^n ∈ H`
 we have `n = 0` or `g ∈ H`. -/
@@ -60,7 +60,7 @@ end Subgroup
 
 namespace AddSubgroup
 
-theorem ker_saturated {A₁ A₂ : Type _} [AddCommGroup A₁] [AddCommGroup A₂] [NoZeroSMulDivisors ℕ A₂]
+theorem ker_saturated {A₁ A₂ : Type*} [AddCommGroup A₁] [AddCommGroup A₂] [NoZeroSMulDivisors ℕ A₂]
     (f : A₁ →+ A₂) : f.ker.Saturated := by
   intro n g hg
   simpa only [f.mem_ker, nsmul_eq_smul, f.map_nsmul, smul_eq_zero] using hg

f7fc89d5

chore: script to replace headers with #align_import statements (#5979)

depends on: #5966

Co-authored-by: Eric Wieser <wieser.eric@gmail.com> Co-authored-by: Scott Morrison <scott.morrison@gmail.com>

89aa3a3b

Diff

@@ -2,14 +2,11 @@
 Copyright (c) 2021 Johan Commelin. All rights reserved.
 Released under Apache 2.0 license as described in the file LICENSE.
 Authors: Johan Commelin
-
-! This file was ported from Lean 3 source module group_theory.subgroup.saturated
-! leanprover-community/mathlib commit f7fc89d5d5ff1db2d1242c7bb0e9062ce47ef47c
-! Please do not edit these lines, except to modify the commit id
-! if you have ported upstream changes.
 -/
 import Mathlib.GroupTheory.Subgroup.Basic
 
+#align_import group_theory.subgroup.saturated from "leanprover-community/mathlib"@"f7fc89d5d5ff1db2d1242c7bb0e9062ce47ef47c"
+
 /-!
 # Saturated subgroups

f7fc89d5

chore: clean up spacing around at and goals (#5387)

Changes are of the form

some_tactic at h⊢ -> some_tactic at h ⊢
some_tactic at h -> some_tactic at h

2a870323

Diff

@@ -46,7 +46,7 @@ theorem saturated_iff_zpow {H : Subgroup G} :
   constructor
   · intros hH n g hgn
     induction' n with n n
-    · simp only [Int.coe_nat_eq_zero, Int.ofNat_eq_coe, zpow_ofNat] at hgn⊢
+    · simp only [Int.coe_nat_eq_zero, Int.ofNat_eq_coe, zpow_ofNat] at hgn ⊢
       exact hH hgn
     · suffices g ^ (n + 1) ∈ H by
         refine' (hH this).imp _ id

f7fc89d5

feat: port GroupTheory.Subgroup.Saturated (#1884)

Co-authored-by: Moritz Firsching <firsching@google.com>

a34afbb0

`group_theory.subgroup.saturated` ⟷ `Mathlib.GroupTheory.Subgroup.Saturated`

Changes since the initial port

Changes in mathlib3

Changes in mathlib3port

Changes in mathlib4

Renames

Dependencies 4 + 202

group_theory.subgroup.saturated ⟷ Mathlib.GroupTheory.Subgroup.Saturated

Changes since the initial port

Changes in mathlib3

Changes in mathlib3port

Changes in mathlib4

Renames

Dependencies 4 + 202

`group_theory.subgroup.saturated` ⟷ `Mathlib.GroupTheory.Subgroup.Saturated`