number_theory.frobenius_number | Mathlib porting status

Changes since the initial port

The following section lists changes to this file in mathlib3 and mathlib4 that occured after the initial port. Most recent changes are shown first. Hovering over a commit will show all commits associated with the same mathlib3 commit.

Changes in mathlib3

1126441d

(last sync)

Changes in mathlib3port

mathlib3

mathlib3port

327c3c0d

bump to nightly-2024-04-06-08

mathlib commit https://github.com/leanprover-community/mathlib/commit/65a1391a0106c9204fe45bc73a039f056558cb83

e34029c9

Diff

@@ -3,7 +3,7 @@ Copyright (c) 2021 Alex Zhao. All rights reserved.
 Released under Apache 2.0 license as described in the file LICENSE.
 Authors: Alex Zhao
 -/
-import Data.Nat.Modeq
+import Data.Nat.ModEq
 import GroupTheory.Submonoid.Basic
 import GroupTheory.Submonoid.Membership
 import Tactic.Ring

327c3c0d

bump to nightly-2024-03-17-08

mathlib commit https://github.com/leanprover-community/mathlib/commit/65a1391a0106c9204fe45bc73a039f056558cb83

22f01ce4

Diff

@@ -68,10 +68,10 @@ theorem frobeniusNumber_pair (cop : Coprime m n) (hm : 1 < m) (hn : 1 < n) :
   · push_neg
     intro a b h
     apply cop.mul_add_mul_ne_mul (add_one_ne_zero a) (add_one_ne_zero b)
-    simp only [Nat.sub_sub, smul_eq_mul] at h ; zify at h ⊢
+    simp only [Nat.sub_sub, smul_eq_mul] at h; zify at h ⊢
     rw [← sub_eq_zero] at h ⊢; rw [← h]
     ring
-  · intro k hk; dsimp at hk ; contrapose! hk
+  · intro k hk; dsimp at hk; contrapose! hk
     let x := chinese_remainder cop 0 k
     have hx : x.val < m * n := chinese_remainder_lt_mul cop 0 k (ne_bot_of_gt hm) (ne_bot_of_gt hn)
     suffices key : x.1 ≤ k

327c3c0d

bump to nightly-2023-09-24-06

mathlib commit https://github.com/leanprover-community/mathlib/commit/ce64cd319bb6b3e82f31c2d38e79080d377be451

5655435f

Diff

@@ -3,11 +3,11 @@ Copyright (c) 2021 Alex Zhao. All rights reserved.
 Released under Apache 2.0 license as described in the file LICENSE.
 Authors: Alex Zhao
 -/
-import Mathbin.Data.Nat.Modeq
-import Mathbin.GroupTheory.Submonoid.Basic
-import Mathbin.GroupTheory.Submonoid.Membership
-import Mathbin.Tactic.Ring
-import Mathbin.Tactic.Zify
+import Data.Nat.Modeq
+import GroupTheory.Submonoid.Basic
+import GroupTheory.Submonoid.Membership
+import Tactic.Ring
+import Tactic.Zify
 
 #align_import number_theory.frobenius_number from "leanprover-community/mathlib"@"327c3c0d9232d80e250dc8f65e7835b82b266ea5"

327c3c0d

bump to nightly-2023-09-20-06

mathlib commit https://github.com/leanprover-community/mathlib/commit/ce64cd319bb6b3e82f31c2d38e79080d377be451

e28e6964

Diff

@@ -59,7 +59,7 @@ variable {m n : ℕ}
 #print frobeniusNumber_pair /-
 /-- The **Chicken Mcnugget theorem** stating that the Frobenius number
   of positive numbers `m` and `n` is `m * n - m - n`. -/
-theorem frobeniusNumber_pair (cop : coprime m n) (hm : 1 < m) (hn : 1 < n) :
+theorem frobeniusNumber_pair (cop : Coprime m n) (hm : 1 < m) (hn : 1 < n) :
     FrobeniusNumber (m * n - m - n) {m, n} :=
   by
   simp_rw [FrobeniusNumber, AddSubmonoid.mem_closure_pair]

327c3c0d

bump to nightly-2023-07-20-09

mathlib commit https://github.com/leanprover-community/mathlib/commit/8ea5598db6caeddde6cb734aa179cc2408dbd345

9c56d0dd

Diff

@@ -2,11 +2,6 @@
 Copyright (c) 2021 Alex Zhao. All rights reserved.
 Released under Apache 2.0 license as described in the file LICENSE.
 Authors: Alex Zhao
-
-! This file was ported from Lean 3 source module number_theory.frobenius_number
-! leanprover-community/mathlib commit 327c3c0d9232d80e250dc8f65e7835b82b266ea5
-! Please do not edit these lines, except to modify the commit id
-! if you have ported upstream changes.
 -/
 import Mathbin.Data.Nat.Modeq
 import Mathbin.GroupTheory.Submonoid.Basic
@@ -14,6 +9,8 @@ import Mathbin.GroupTheory.Submonoid.Membership
 import Mathbin.Tactic.Ring
 import Mathbin.Tactic.Zify
 
+#align_import number_theory.frobenius_number from "leanprover-community/mathlib"@"327c3c0d9232d80e250dc8f65e7835b82b266ea5"
+
 /-!
 # Frobenius Number in Two Variables

327c3c0d

bump to nightly-2023-06-04-18

mathlib commit https://github.com/leanprover-community/mathlib/commit/5f25c089cb34db4db112556f23c50d12da81b297

3fb4268b

Diff

@@ -53,7 +53,7 @@ open Nat
 upper bound on the complement of the additive submonoid generated by `s`.
 In other words, it is the largest number that can not be expressed as a sum of numbers in `s`. -/
 def FrobeniusNumber (n : ℕ) (s : Set ℕ) : Prop :=
-  IsGreatest { k | k ∉ AddSubmonoid.closure s } n
+  IsGreatest {k | k ∉ AddSubmonoid.closure s} n
 #align is_frobenius_number FrobeniusNumber
 -/
 
@@ -71,7 +71,7 @@ theorem frobeniusNumber_pair (cop : coprime m n) (hm : 1 < m) (hn : 1 < n) :
   · push_neg
     intro a b h
     apply cop.mul_add_mul_ne_mul (add_one_ne_zero a) (add_one_ne_zero b)
-    simp only [Nat.sub_sub, smul_eq_mul] at h ; zify  at h ⊢
+    simp only [Nat.sub_sub, smul_eq_mul] at h ; zify at h ⊢
     rw [← sub_eq_zero] at h ⊢; rw [← h]
     ring
   · intro k hk; dsimp at hk ; contrapose! hk

327c3c0d

bump to nightly-2023-06-01-16

mathlib commit https://github.com/leanprover-community/mathlib/commit/cca40788df1b8755d5baf17ab2f27dacc2e17acb

b9c87c70

Diff

@@ -71,10 +71,10 @@ theorem frobeniusNumber_pair (cop : coprime m n) (hm : 1 < m) (hn : 1 < n) :
   · push_neg
     intro a b h
     apply cop.mul_add_mul_ne_mul (add_one_ne_zero a) (add_one_ne_zero b)
-    simp only [Nat.sub_sub, smul_eq_mul] at h; zify  at h⊢
-    rw [← sub_eq_zero] at h⊢; rw [← h]
+    simp only [Nat.sub_sub, smul_eq_mul] at h ; zify  at h ⊢
+    rw [← sub_eq_zero] at h ⊢; rw [← h]
     ring
-  · intro k hk; dsimp at hk; contrapose! hk
+  · intro k hk; dsimp at hk ; contrapose! hk
     let x := chinese_remainder cop 0 k
     have hx : x.val < m * n := chinese_remainder_lt_mul cop 0 k (ne_bot_of_gt hm) (ne_bot_of_gt hn)
     suffices key : x.1 ≤ k

327c3c0d

bump to nightly-2023-05-28-04

mathlib commit https://github.com/leanprover-community/mathlib/commit/917c3c072e487b3cccdbfeff17e75b40e45f66cb

6797a637

Diff

@@ -71,14 +71,10 @@ theorem frobeniusNumber_pair (cop : coprime m n) (hm : 1 < m) (hn : 1 < n) :
   · push_neg
     intro a b h
     apply cop.mul_add_mul_ne_mul (add_one_ne_zero a) (add_one_ne_zero b)
-    simp only [Nat.sub_sub, smul_eq_mul] at h
-    zify  at h⊢
-    rw [← sub_eq_zero] at h⊢
-    rw [← h]
+    simp only [Nat.sub_sub, smul_eq_mul] at h; zify  at h⊢
+    rw [← sub_eq_zero] at h⊢; rw [← h]
     ring
-  · intro k hk
-    dsimp at hk
-    contrapose! hk
+  · intro k hk; dsimp at hk; contrapose! hk
     let x := chinese_remainder cop 0 k
     have hx : x.val < m * n := chinese_remainder_lt_mul cop 0 k (ne_bot_of_gt hm) (ne_bot_of_gt hn)
     suffices key : x.1 ≤ k

327c3c0d

bump to nightly-2023-02-21-16

mathlib commit https://github.com/leanprover-community/mathlib/commit/bd9851ca476957ea4549eb19b40e7b5ade9428cc

1107b979

Changes in mathlib4

mathlib3

mathlib4

1126441d

chore: bump to v4.1.0-rc1 (2nd attempt) (#7216)

Co-authored-by: Eric Wieser <wieser.eric@gmail.com> Co-authored-by: Scott Morrison <scott.morrison@gmail.com>

bfaffcf1

Diff

@@ -53,7 +53,7 @@ variable {m n : ℕ}
 
 /-- The **Chicken McNugget theorem** stating that the Frobenius number
   of positive numbers `m` and `n` is `m * n - m - n`. -/
-theorem frobeniusNumber_pair (cop : coprime m n) (hm : 1 < m) (hn : 1 < n) :
+theorem frobeniusNumber_pair (cop : Coprime m n) (hm : 1 < m) (hn : 1 < n) :
     FrobeniusNumber (m * n - m - n) {m, n} := by
   simp_rw [FrobeniusNumber, AddSubmonoid.mem_closure_pair]
   have hmn : m + n ≤ m * n := add_le_mul hm hn

1126441d

Revert "chore: bump to v4.1.0-rc1 (#7174)" (#7198)

This reverts commit 6f8e8104. Unfortunately this bump was not linted correctly, as CI did not run runLinter Mathlib.

We can unrevert once that's fixed.

40b58304

Diff

@@ -53,7 +53,7 @@ variable {m n : ℕ}
 
 /-- The **Chicken McNugget theorem** stating that the Frobenius number
   of positive numbers `m` and `n` is `m * n - m - n`. -/
-theorem frobeniusNumber_pair (cop : Coprime m n) (hm : 1 < m) (hn : 1 < n) :
+theorem frobeniusNumber_pair (cop : coprime m n) (hm : 1 < m) (hn : 1 < n) :
     FrobeniusNumber (m * n - m - n) {m, n} := by
   simp_rw [FrobeniusNumber, AddSubmonoid.mem_closure_pair]
   have hmn : m + n ≤ m * n := add_le_mul hm hn

1126441d

chore: bump to v4.1.0-rc1 (#7174)

Some changes have already been review and delegated in #6910 and #7148.

The diff that needs looking at is https://github.com/leanprover-community/mathlib4/pull/7174/commits/64d6d07ee18163627c8f517eb31455411921c5ac

The std bump PR was insta-merged already!

Co-authored-by: leanprover-community-mathlib4-bot <leanprover-community-mathlib4-bot@users.noreply.github.com> Co-authored-by: Scott Morrison <scott.morrison@gmail.com>

6f8e8104

Diff

@@ -53,7 +53,7 @@ variable {m n : ℕ}
 
 /-- The **Chicken McNugget theorem** stating that the Frobenius number
   of positive numbers `m` and `n` is `m * n - m - n`. -/
-theorem frobeniusNumber_pair (cop : coprime m n) (hm : 1 < m) (hn : 1 < n) :
+theorem frobeniusNumber_pair (cop : Coprime m n) (hm : 1 < m) (hn : 1 < n) :
     FrobeniusNumber (m * n - m - n) {m, n} := by
   simp_rw [FrobeniusNumber, AddSubmonoid.mem_closure_pair]
   have hmn : m + n ≤ m * n := add_le_mul hm hn

1126441d

chore: avoid lean3 style have/suffices (#6964)

Many proofs use the "stream of consciousness" style from Lean 3, rather than have ... := or suffices ... from/by.

This PR updates a fraction of these to the preferred Lean 4 style.

I think a good goal would be to delete the "deferred" versions of have, suffices, and let at the bottom of Mathlib.Tactic.Have

(Anyone who would like to contribute more cleanup is welcome to push directly to this branch.)

Co-authored-by: Scott Morrison <scott.morrison@gmail.com>

bdc47f68

Diff

@@ -71,8 +71,8 @@ theorem frobeniusNumber_pair (cop : coprime m n) (hm : 1 < m) (hn : 1 < n) :
     contrapose! hk
     let x := chineseRemainder cop 0 k
     have hx : x.val < m * n := chineseRemainder_lt_mul cop 0 k (ne_bot_of_gt hm) (ne_bot_of_gt hn)
-    suffices key : x.1 ≤ k
-    · obtain ⟨a, ha⟩ := modEq_zero_iff_dvd.mp x.2.1
+    suffices key : x.1 ≤ k by
+      obtain ⟨a, ha⟩ := modEq_zero_iff_dvd.mp x.2.1
       obtain ⟨b, hb⟩ := (modEq_iff_dvd' key).mp x.2.2
       exact ⟨a, b, by rw [mul_comm, ← ha, mul_comm, ← hb, Nat.add_sub_of_le key]⟩
     refine' ModEq.le_of_lt_add x.2.2 (lt_of_le_of_lt _ (add_lt_add_right hk n))

1126441d

chore: script to replace headers with #align_import statements (#5979)

depends on: #5966

Co-authored-by: Eric Wieser <wieser.eric@gmail.com> Co-authored-by: Scott Morrison <scott.morrison@gmail.com>

89aa3a3b

Diff

@@ -2,11 +2,6 @@
 Copyright (c) 2021 Alex Zhao. All rights reserved.
 Released under Apache 2.0 license as described in the file LICENSE.
 Authors: Alex Zhao
-
-! This file was ported from Lean 3 source module number_theory.frobenius_number
-! leanprover-community/mathlib commit 1126441d6bccf98c81214a0780c73d499f6721fe
-! Please do not edit these lines, except to modify the commit id
-! if you have ported upstream changes.
 -/
 import Mathlib.Data.Nat.ModEq
 import Mathlib.GroupTheory.Submonoid.Basic
@@ -14,6 +9,8 @@ import Mathlib.GroupTheory.Submonoid.Membership
 import Mathlib.Tactic.Ring
 import Mathlib.Tactic.Zify
 
+#align_import number_theory.frobenius_number from "leanprover-community/mathlib"@"1126441d6bccf98c81214a0780c73d499f6721fe"
+
 /-!
 # Frobenius Number in Two Variables

1126441d

chore: fix many typos (#4967)

These are all doc fixes

6f9e51c3

Diff

@@ -54,7 +54,7 @@ def FrobeniusNumber (n : ℕ) (s : Set ℕ) : Prop :=
 
 variable {m n : ℕ}
 
-/-- The **Chicken Mcnugget theorem** stating that the Frobenius number
+/-- The **Chicken McNugget theorem** stating that the Frobenius number
   of positive numbers `m` and `n` is `m * n - m - n`. -/
 theorem frobeniusNumber_pair (cop : coprime m n) (hm : 1 < m) (hn : 1 < n) :
     FrobeniusNumber (m * n - m - n) {m, n} := by

1126441d

feat: port NumberTheory.FrobeniusNumber (#1719)

3c7a8ea5

`number_theory.frobenius_number` ⟷ `Mathlib.NumberTheory.FrobeniusNumber`

Changes since the initial port

Changes in mathlib3

Changes in mathlib3port

Changes in mathlib4

Dependencies 4 + 219

number_theory.frobenius_number ⟷ Mathlib.NumberTheory.FrobeniusNumber

Changes since the initial port

Changes in mathlib3

Changes in mathlib3port

Changes in mathlib4

Dependencies 4 + 219

`number_theory.frobenius_number` ⟷ `Mathlib.NumberTheory.FrobeniusNumber`