number_theory.primorial | Mathlib porting status

Changes since the initial port

The following section lists changes to this file in mathlib3 and mathlib4 that occured after the initial port. Most recent changes are shown first. Hovering over a commit will show all commits associated with the same mathlib3 commit.

Changes in mathlib3

0a0ec350

(last sync)

Changes in mathlib3port

mathlib3

mathlib3port

3e32bc90

bump to nightly-2024-03-17-08

mathlib commit https://github.com/leanprover-community/mathlib/commit/65a1391a0106c9204fe45bc73a039f056558cb83

22f01ce4

Diff

@@ -76,7 +76,7 @@ theorem primorial_add_dvd {m n : ℕ} (h : n ≤ m) : (m + n)# ∣ m# * choose (
       mul_dvd_mul_left _ <|
         prod_primes_dvd _ (fun k hk => (mem_filter.1 hk).2.Prime) fun p hp =>
           by
-          rw [mem_filter, mem_Ico] at hp 
+          rw [mem_filter, mem_Ico] at hp
           exact
             hp.2.dvd_choose_add hp.1.1 (h.trans_lt (m.lt_succ_self.trans_le hp.1.1))
               (Nat.lt_succ_iff.1 hp.1.2)

3e32bc90

bump to nightly-2023-09-24-06

mathlib commit https://github.com/leanprover-community/mathlib/commit/ce64cd319bb6b3e82f31c2d38e79080d377be451

5655435f

Diff

@@ -3,11 +3,11 @@ Copyright (c) 2020 Patrick Stevens. All rights reserved.
 Released under Apache 2.0 license as described in the file LICENSE.
 Authors: Patrick Stevens, Yury Kudryashov
 -/
-import Mathbin.Algebra.BigOperators.Associated
-import Mathbin.Data.Nat.Choose.Sum
-import Mathbin.Data.Nat.Choose.Dvd
-import Mathbin.Data.Nat.Parity
-import Mathbin.Data.Nat.Prime
+import Algebra.BigOperators.Associated
+import Data.Nat.Choose.Sum
+import Data.Nat.Choose.Dvd
+import Data.Nat.Parity
+import Data.Nat.Prime
 
 #align_import number_theory.primorial from "leanprover-community/mathlib"@"3e32bc908f617039c74c06ea9a897e30c30803c2"

3e32bc90

bump to nightly-2023-07-20-09

mathlib commit https://github.com/leanprover-community/mathlib/commit/8ea5598db6caeddde6cb734aa179cc2408dbd345

9c56d0dd

Diff

@@ -2,11 +2,6 @@
 Copyright (c) 2020 Patrick Stevens. All rights reserved.
 Released under Apache 2.0 license as described in the file LICENSE.
 Authors: Patrick Stevens, Yury Kudryashov
-
-! This file was ported from Lean 3 source module number_theory.primorial
-! leanprover-community/mathlib commit 3e32bc908f617039c74c06ea9a897e30c30803c2
-! Please do not edit these lines, except to modify the commit id
-! if you have ported upstream changes.
 -/
 import Mathbin.Algebra.BigOperators.Associated
 import Mathbin.Data.Nat.Choose.Sum
@@ -14,6 +9,8 @@ import Mathbin.Data.Nat.Choose.Dvd
 import Mathbin.Data.Nat.Parity
 import Mathbin.Data.Nat.Prime
 
+#align_import number_theory.primorial from "leanprover-community/mathlib"@"3e32bc908f617039c74c06ea9a897e30c30803c2"
+
 /-!
 # Primorial

3e32bc90

bump to nightly-2023-06-13-21

mathlib commit https://github.com/leanprover-community/mathlib/commit/9fb8964792b4237dac6200193a0d533f1b3f7423

829520ac

Diff

@@ -44,7 +44,6 @@ def primorial (n : ℕ) : ℕ :=
 #align primorial primorial
 -/
 
--- mathport name: «expr #»
 local notation x "#" => primorial x
 
 #print primorial_pos /-
@@ -62,6 +61,7 @@ theorem primorial_succ {n : ℕ} (hn1 : n ≠ 1) (hn : Odd n) : (n + 1)# = n# :=
 #align primorial_succ primorial_succ
 -/
 
+#print primorial_add /-
 theorem primorial_add (m n : ℕ) :
     (m + n)# = m# * ∏ p in filter Nat.Prime (Ico (m + 1) (m + n + 1)), p :=
   by
@@ -69,6 +69,7 @@ theorem primorial_add (m n : ℕ) :
   exacts [zero_le _, add_le_add_right (Nat.le_add_right _ _) _,
     disjoint_filter_filter <| Ico_disjoint_Ico_consecutive _ _ _]
 #align primorial_add primorial_add
+-/
 
 #print primorial_add_dvd /-
 theorem primorial_add_dvd {m n : ℕ} (h : n ≤ m) : (m + n)# ∣ m# * choose (m + n) m :=

3e32bc90

bump to nightly-2023-06-09-07

mathlib commit https://github.com/leanprover-community/mathlib/commit/7e5137f579de09a059a5ce98f364a04e221aabf0

16afdc39

Diff

@@ -82,7 +82,6 @@ theorem primorial_add_dvd {m n : ℕ} (h : n ≤ m) : (m + n)# ∣ m# * choose (
           exact
             hp.2.dvd_choose_add hp.1.1 (h.trans_lt (m.lt_succ_self.trans_le hp.1.1))
               (Nat.lt_succ_iff.1 hp.1.2)
-    
 #align primorial_add_dvd primorial_add_dvd
 -/
 
@@ -107,7 +106,6 @@ theorem primorial_le_4_pow (n : ℕ) : n# ≤ 4 ^ n :=
         (mul_le_mul' (ihn _ <| succ_lt_succ <| (lt_add_iff_pos_left _).2 hm)
           (choose_middle_le_pow _))
       _ ≤ 4 ^ (m + m + 1) := by rw [← pow_add, add_right_comm]
-      
   · rcases Decidable.eq_or_ne n 1 with (rfl | hn)
     · decide
     ·
@@ -115,7 +113,6 @@ theorem primorial_le_4_pow (n : ℕ) : n# ≤ 4 ^ n :=
         (n + 1)# = n# := primorial_succ hn ho
         _ ≤ 4 ^ n := (ihn n n.lt_succ_self)
         _ ≤ 4 ^ (n + 1) := pow_le_pow_of_le_right four_pos n.le_succ
-        
 #align primorial_le_4_pow primorial_le_4_pow
 -/

3e32bc90

bump to nightly-2023-06-01-16

mathlib commit https://github.com/leanprover-community/mathlib/commit/cca40788df1b8755d5baf17ab2f27dacc2e17acb

b9c87c70

Diff

@@ -66,7 +66,7 @@ theorem primorial_add (m n : ℕ) :
     (m + n)# = m# * ∏ p in filter Nat.Prime (Ico (m + 1) (m + n + 1)), p :=
   by
   rw [primorial, primorial, ← Ico_zero_eq_range, ← prod_union, ← filter_union, Ico_union_Ico_eq_Ico]
-  exacts[zero_le _, add_le_add_right (Nat.le_add_right _ _) _,
+  exacts [zero_le _, add_le_add_right (Nat.le_add_right _ _) _,
     disjoint_filter_filter <| Ico_disjoint_Ico_consecutive _ _ _]
 #align primorial_add primorial_add
 
@@ -78,7 +78,7 @@ theorem primorial_add_dvd {m n : ℕ} (h : n ≤ m) : (m + n)# ∣ m# * choose (
       mul_dvd_mul_left _ <|
         prod_primes_dvd _ (fun k hk => (mem_filter.1 hk).2.Prime) fun p hp =>
           by
-          rw [mem_filter, mem_Ico] at hp
+          rw [mem_filter, mem_Ico] at hp 
           exact
             hp.2.dvd_choose_add hp.1.1 (h.trans_lt (m.lt_succ_self.trans_le hp.1.1))
               (Nat.lt_succ_iff.1 hp.1.2)

3e32bc90

bump to nightly-2023-05-28-18

mathlib commit https://github.com/leanprover-community/mathlib/commit/917c3c072e487b3cccdbfeff17e75b40e45f66cb

8d353152

Diff

@@ -34,7 +34,7 @@ open Finset
 
 open Nat
 
-open BigOperators Nat
+open scoped BigOperators Nat
 
 #print primorial /-
 /-- The primorial `n#` of `n` is the product of the primes less than or equal to `n`.

3e32bc90

bump to nightly-2023-05-28-06

mathlib commit https://github.com/leanprover-community/mathlib/commit/917c3c072e487b3cccdbfeff17e75b40e45f66cb

ba5d8b97

Diff

@@ -62,12 +62,6 @@ theorem primorial_succ {n : ℕ} (hn1 : n ≠ 1) (hn : Odd n) : (n + 1)# = n# :=
 #align primorial_succ primorial_succ
 -/
 
-/- warning: primorial_add -> primorial_add is a dubious translation:
-lean 3 declaration is
-  forall (m : Nat) (n : Nat), Eq.{1} Nat (primorial (HAdd.hAdd.{0, 0, 0} Nat Nat Nat (instHAdd.{0} Nat Nat.hasAdd) m n)) (HMul.hMul.{0, 0, 0} Nat Nat Nat (instHMul.{0} Nat Nat.hasMul) (primorial m) (Finset.prod.{0, 0} Nat Nat Nat.commMonoid (Finset.filter.{0} Nat Nat.Prime (fun (a : Nat) => Nat.decidablePrime a) (Finset.Ico.{0} Nat (PartialOrder.toPreorder.{0} Nat (OrderedCancelAddCommMonoid.toPartialOrder.{0} Nat (StrictOrderedSemiring.toOrderedCancelAddCommMonoid.{0} Nat Nat.strictOrderedSemiring))) Nat.locallyFiniteOrder (HAdd.hAdd.{0, 0, 0} Nat Nat Nat (instHAdd.{0} Nat Nat.hasAdd) m (OfNat.ofNat.{0} Nat 1 (OfNat.mk.{0} Nat 1 (One.one.{0} Nat Nat.hasOne)))) (HAdd.hAdd.{0, 0, 0} Nat Nat Nat (instHAdd.{0} Nat Nat.hasAdd) (HAdd.hAdd.{0, 0, 0} Nat Nat Nat (instHAdd.{0} Nat Nat.hasAdd) m n) (OfNat.ofNat.{0} Nat 1 (OfNat.mk.{0} Nat 1 (One.one.{0} Nat Nat.hasOne)))))) (fun (p : Nat) => p)))
-but is expected to have type
-  forall (m : Nat) (n : Nat), Eq.{1} Nat (primorial (HAdd.hAdd.{0, 0, 0} Nat Nat Nat (instHAdd.{0} Nat instAddNat) m n)) (HMul.hMul.{0, 0, 0} Nat Nat Nat (instHMul.{0} Nat instMulNat) (primorial m) (Finset.prod.{0, 0} Nat Nat Nat.commMonoid (Finset.filter.{0} Nat Nat.Prime (fun (a : Nat) => Nat.decidablePrime a) (Finset.Ico.{0} Nat (PartialOrder.toPreorder.{0} Nat (StrictOrderedSemiring.toPartialOrder.{0} Nat Nat.strictOrderedSemiring)) instLocallyFiniteOrderNatToPreorderToPartialOrderStrictOrderedSemiring (HAdd.hAdd.{0, 0, 0} Nat Nat Nat (instHAdd.{0} Nat instAddNat) m (OfNat.ofNat.{0} Nat 1 (instOfNatNat 1))) (HAdd.hAdd.{0, 0, 0} Nat Nat Nat (instHAdd.{0} Nat instAddNat) (HAdd.hAdd.{0, 0, 0} Nat Nat Nat (instHAdd.{0} Nat instAddNat) m n) (OfNat.ofNat.{0} Nat 1 (instOfNatNat 1))))) (fun (p : Nat) => p)))
-Case conversion may be inaccurate. Consider using '#align primorial_add primorial_addₓ'. -/
 theorem primorial_add (m n : ℕ) :
     (m + n)# = m# * ∏ p in filter Nat.Prime (Ico (m + 1) (m + n + 1)), p :=
   by

3e32bc90

bump to nightly-2023-05-28-04

mathlib commit https://github.com/leanprover-community/mathlib/commit/917c3c072e487b3cccdbfeff17e75b40e45f66cb

6797a637

Diff

@@ -104,8 +104,7 @@ theorem primorial_le_4_pow (n : ℕ) : n# ≤ 4 ^ n :=
   induction' n using Nat.strong_induction_on with n ihn
   cases n; · rfl
   rcases n.even_or_odd with (⟨m, rfl⟩ | ho)
-  · rcases m.eq_zero_or_pos with (rfl | hm)
-    · decide
+  · rcases m.eq_zero_or_pos with (rfl | hm); · decide
     calc
       (m + m + 1)# = (m + 1 + m)# := by rw [add_right_comm]
       _ ≤ (m + 1)# * choose (m + 1 + m) (m + 1) := (primorial_add_le m.le_succ)

3e32bc90

bump to nightly-2023-05-16-16

mathlib commit https://github.com/leanprover-community/mathlib/commit/0b9eaaa7686280fad8cce467f5c3c57ee6ce77f8

9cb92e8c

Diff

@@ -62,7 +62,12 @@ theorem primorial_succ {n : ℕ} (hn1 : n ≠ 1) (hn : Odd n) : (n + 1)# = n# :=
 #align primorial_succ primorial_succ
 -/
 
-#print primorial_add /-
+/- warning: primorial_add -> primorial_add is a dubious translation:
+lean 3 declaration is
+  forall (m : Nat) (n : Nat), Eq.{1} Nat (primorial (HAdd.hAdd.{0, 0, 0} Nat Nat Nat (instHAdd.{0} Nat Nat.hasAdd) m n)) (HMul.hMul.{0, 0, 0} Nat Nat Nat (instHMul.{0} Nat Nat.hasMul) (primorial m) (Finset.prod.{0, 0} Nat Nat Nat.commMonoid (Finset.filter.{0} Nat Nat.Prime (fun (a : Nat) => Nat.decidablePrime a) (Finset.Ico.{0} Nat (PartialOrder.toPreorder.{0} Nat (OrderedCancelAddCommMonoid.toPartialOrder.{0} Nat (StrictOrderedSemiring.toOrderedCancelAddCommMonoid.{0} Nat Nat.strictOrderedSemiring))) Nat.locallyFiniteOrder (HAdd.hAdd.{0, 0, 0} Nat Nat Nat (instHAdd.{0} Nat Nat.hasAdd) m (OfNat.ofNat.{0} Nat 1 (OfNat.mk.{0} Nat 1 (One.one.{0} Nat Nat.hasOne)))) (HAdd.hAdd.{0, 0, 0} Nat Nat Nat (instHAdd.{0} Nat Nat.hasAdd) (HAdd.hAdd.{0, 0, 0} Nat Nat Nat (instHAdd.{0} Nat Nat.hasAdd) m n) (OfNat.ofNat.{0} Nat 1 (OfNat.mk.{0} Nat 1 (One.one.{0} Nat Nat.hasOne)))))) (fun (p : Nat) => p)))
+but is expected to have type
+  forall (m : Nat) (n : Nat), Eq.{1} Nat (primorial (HAdd.hAdd.{0, 0, 0} Nat Nat Nat (instHAdd.{0} Nat instAddNat) m n)) (HMul.hMul.{0, 0, 0} Nat Nat Nat (instHMul.{0} Nat instMulNat) (primorial m) (Finset.prod.{0, 0} Nat Nat Nat.commMonoid (Finset.filter.{0} Nat Nat.Prime (fun (a : Nat) => Nat.decidablePrime a) (Finset.Ico.{0} Nat (PartialOrder.toPreorder.{0} Nat (StrictOrderedSemiring.toPartialOrder.{0} Nat Nat.strictOrderedSemiring)) instLocallyFiniteOrderNatToPreorderToPartialOrderStrictOrderedSemiring (HAdd.hAdd.{0, 0, 0} Nat Nat Nat (instHAdd.{0} Nat instAddNat) m (OfNat.ofNat.{0} Nat 1 (instOfNatNat 1))) (HAdd.hAdd.{0, 0, 0} Nat Nat Nat (instHAdd.{0} Nat instAddNat) (HAdd.hAdd.{0, 0, 0} Nat Nat Nat (instHAdd.{0} Nat instAddNat) m n) (OfNat.ofNat.{0} Nat 1 (instOfNatNat 1))))) (fun (p : Nat) => p)))
+Case conversion may be inaccurate. Consider using '#align primorial_add primorial_addₓ'. -/
 theorem primorial_add (m n : ℕ) :
     (m + n)# = m# * ∏ p in filter Nat.Prime (Ico (m + 1) (m + n + 1)), p :=
   by
@@ -70,7 +75,6 @@ theorem primorial_add (m n : ℕ) :
   exacts[zero_le _, add_le_add_right (Nat.le_add_right _ _) _,
     disjoint_filter_filter <| Ico_disjoint_Ico_consecutive _ _ _]
 #align primorial_add primorial_add
--/
 
 #print primorial_add_dvd /-
 theorem primorial_add_dvd {m n : ℕ} (h : n ≤ m) : (m + n)# ∣ m# * choose (m + n) m :=

3e32bc90

bump to nightly-2023-03-01-20

mathlib commit https://github.com/leanprover-community/mathlib/commit/4c586d291f189eecb9d00581aeb3dd998ac34442

20cadee0

Diff

@@ -104,10 +104,11 @@ theorem primorial_le_4_pow (n : ℕ) : n# ≤ 4 ^ n :=
     · decide
     calc
       (m + m + 1)# = (m + 1 + m)# := by rw [add_right_comm]
-      _ ≤ (m + 1)# * choose (m + 1 + m) (m + 1) := primorial_add_le m.le_succ
+      _ ≤ (m + 1)# * choose (m + 1 + m) (m + 1) := (primorial_add_le m.le_succ)
       _ = (m + 1)# * choose (2 * m + 1) m := by rw [choose_symm_add, two_mul, add_right_comm]
       _ ≤ 4 ^ (m + 1) * 4 ^ m :=
-        mul_le_mul' (ihn _ <| succ_lt_succ <| (lt_add_iff_pos_left _).2 hm) (choose_middle_le_pow _)
+        (mul_le_mul' (ihn _ <| succ_lt_succ <| (lt_add_iff_pos_left _).2 hm)
+          (choose_middle_le_pow _))
       _ ≤ 4 ^ (m + m + 1) := by rw [← pow_add, add_right_comm]
       
   · rcases Decidable.eq_or_ne n 1 with (rfl | hn)
@@ -115,7 +116,7 @@ theorem primorial_le_4_pow (n : ℕ) : n# ≤ 4 ^ n :=
     ·
       calc
         (n + 1)# = n# := primorial_succ hn ho
-        _ ≤ 4 ^ n := ihn n n.lt_succ_self
+        _ ≤ 4 ^ n := (ihn n n.lt_succ_self)
         _ ≤ 4 ^ (n + 1) := pow_le_pow_of_le_right four_pos n.le_succ
         
 #align primorial_le_4_pow primorial_le_4_pow

3e32bc90

bump to nightly-2023-02-21-16

mathlib commit https://github.com/leanprover-community/mathlib/commit/bd9851ca476957ea4549eb19b40e7b5ade9428cc

1107b979

Changes in mathlib4

mathlib3

mathlib4

0a0ec350

chore: remove mathport name: <expression> lines (#11928)

Quoting [@digama0](https://github.com/digama0):

These were actually never meant to go in the file, they are basically debugging information and only useful on significantly broken mathport files. You can safely remove all of them.

11431c65

Diff

@@ -36,7 +36,6 @@ def primorial (n : ℕ) : ℕ :=
   ∏ p in filter Nat.Prime (range (n + 1)), p
 #align primorial primorial
 
--- mathport name: «expr #»
 local notation x "#" => primorial x
 
 theorem primorial_pos (n : ℕ) : 0 < n# :=

0a0ec350

chore: script to replace headers with #align_import statements (#5979)

depends on: #5966

Co-authored-by: Eric Wieser <wieser.eric@gmail.com> Co-authored-by: Scott Morrison <scott.morrison@gmail.com>

89aa3a3b

Diff

@@ -2,11 +2,6 @@
 Copyright (c) 2020 Patrick Stevens. All rights reserved.
 Released under Apache 2.0 license as described in the file LICENSE.
 Authors: Patrick Stevens, Yury Kudryashov
-
-! This file was ported from Lean 3 source module number_theory.primorial
-! leanprover-community/mathlib commit 0a0ec35061ed9960bf0e7ffb0335f44447b58977
-! Please do not edit these lines, except to modify the commit id
-! if you have ported upstream changes.
 -/
 import Mathlib.Algebra.BigOperators.Associated
 import Mathlib.Data.Nat.Choose.Sum
@@ -14,6 +9,8 @@ import Mathlib.Data.Nat.Choose.Dvd
 import Mathlib.Data.Nat.Parity
 import Mathlib.Data.Nat.Prime
 
+#align_import number_theory.primorial from "leanprover-community/mathlib"@"0a0ec35061ed9960bf0e7ffb0335f44447b58977"
+
 /-!
 # Primorial

0a0ec350

feat: port NumberTheory.Primorial (#2137)

Co-authored-by: Johan Commelin <johan@commelin.net>

064d0412

`number_theory.primorial` ⟷ `Mathlib.NumberTheory.Primorial`

Changes since the initial port

Changes in mathlib3

Changes in mathlib3port

Changes in mathlib4

Dependencies 8 + 286

number_theory.primorial ⟷ Mathlib.NumberTheory.Primorial

Changes since the initial port

Changes in mathlib3

Changes in mathlib3port

Changes in mathlib4

Dependencies 8 + 286

`number_theory.primorial` ⟷ `Mathlib.NumberTheory.Primorial`