ring_theory.ring_hom.finite_type | Mathlib porting status

Changes since the initial port

The following section lists changes to this file in mathlib3 and mathlib4 that occured after the initial port. Most recent changes are shown first. Hovering over a commit will show all commits associated with the same mathlib3 commit.

Changes in mathlib3

64fc7238

(last sync)

Changes in mathlib3port

mathlib3

mathlib3port

2a0ce625

bump to nightly-2024-02-01-06

mathlib commit https://github.com/leanprover-community/mathlib/commit/65a1391a0106c9204fe45bc73a039f056558cb83

5433bded

Diff

@@ -49,18 +49,54 @@ theorem finiteType_ofLocalizationSpanTarget : OfLocalizationSpanTarget @FiniteTy
   introv R hs H
   skip
   classical
+  letI := f.to_algebra
+  replace H : ∀ r : s, Algebra.FiniteType R (Localization.Away (r : S))
+  · intro r; convert H r; ext; rw [Algebra.smul_def]; rfl
+  replace H := fun r => (H r).1
+  constructor
+  -- Suppose `s : finset S` spans `S`, and each `Sᵣ` is finitely generated as an `R`-algebra.
+  -- Say `t r : finset Sᵣ` generates `Sᵣ`. By assumption, we may find `lᵢ` such that
+  -- `∑ lᵢ * sᵢ = 1`. I claim that all `s` and `l` and the numerators of `t` and generates `S`.
+  choose t ht using H
+  obtain ⟨l, hl⟩ :=
+    (Finsupp.mem_span_iff_total S (s : Set S) 1).mp
+      (show (1 : S) ∈ Ideal.span (s : Set S) by rw [hs]; trivial)
+  let sf := fun x : s => IsLocalization.finsetIntegerMultiple (Submonoid.powers (x : S)) (t x)
+  use s.attach.bUnion sf ∪ s ∪ l.support.image l
+  rw [eq_top_iff]
+  -- We need to show that every `x` falls in the subalgebra generated by those elements.
+  -- Since all `s` and `l` are in the subalgebra, it suffices to check that `sᵢ ^ nᵢ • x` falls in
+  -- the algebra for each `sᵢ` and some `nᵢ`.
+  rintro x -
+  apply Subalgebra.mem_of_span_eq_top_of_smul_pow_mem _ (s : Set S) l hl _ _ x _
+  · intro x hx
+    apply Algebra.subset_adjoin
+    rw [Finset.coe_union, Finset.coe_union]
+    exact Or.inl (Or.inr hx)
+  · intro i
+    by_cases h : l i = 0; · rw [h]; exact zero_mem _
+    apply Algebra.subset_adjoin
+    rw [Finset.coe_union, Finset.coe_image]
+    exact Or.inr (Set.mem_image_of_mem _ (finsupp.mem_support_iff.mpr h))
+  · intro r
+    rw [Finset.coe_union, Finset.coe_union, Finset.coe_biUnion]
+    -- Since all `sᵢ` and numerators of `t r` are in the algebra, it suffices to show that the
+    -- image of `x` in `Sᵣ` falls in the `R`-adjoin of `t r`, which is of course true.
+    obtain ⟨⟨_, n₂, rfl⟩, hn₂⟩ :=
+      IsLocalization.exists_smul_mem_of_mem_adjoin (Submonoid.powers (r : S)) x (t r)
+        (Algebra.adjoin R _) _ _ _
+    · exact ⟨n₂, hn₂⟩
+    · intro x hx
+      apply Algebra.subset_adjoin
+      refine' Or.inl (Or.inl ⟨_, ⟨r, rfl⟩, _, ⟨s.mem_attach r, rfl⟩, hx⟩)
+    · rw [Submonoid.powers_eq_closure, Submonoid.closure_le, Set.singleton_subset_iff]
+      apply Algebra.subset_adjoin
+      exact Or.inl (Or.inr r.2)
+    · rw [ht]; trivial
 #align ring_hom.finite_type_of_localization_span_target RingHom.finiteType_ofLocalizationSpanTarget
 -/
 
 #print RingHom.finiteType_is_local /-
--- Suppose `s : finset S` spans `S`, and each `Sᵣ` is finitely generated as an `R`-algebra.
--- Say `t r : finset Sᵣ` generates `Sᵣ`. By assumption, we may find `lᵢ` such that
--- `∑ lᵢ * sᵢ = 1`. I claim that all `s` and `l` and the numerators of `t` and generates `S`.
--- We need to show that every `x` falls in the subalgebra generated by those elements.
--- Since all `s` and `l` are in the subalgebra, it suffices to check that `sᵢ ^ nᵢ • x` falls in
--- the algebra for each `sᵢ` and some `nᵢ`.
--- Since all `sᵢ` and numerators of `t r` are in the algebra, it suffices to show that the
--- image of `x` in `Sᵣ` falls in the `R`-adjoin of `t r`, which is of course true.
 theorem finiteType_is_local : PropertyIsLocal @FiniteType :=
   ⟨localization_finiteType, finiteType_ofLocalizationSpanTarget, finiteType_stableUnderComposition,
     finiteType_holdsForLocalizationAway⟩

2a0ce625

bump to nightly-2024-01-31-06

mathlib commit https://github.com/leanprover-community/mathlib/commit/65a1391a0106c9204fe45bc73a039f056558cb83

61100fe9

Diff

@@ -49,54 +49,18 @@ theorem finiteType_ofLocalizationSpanTarget : OfLocalizationSpanTarget @FiniteTy
   introv R hs H
   skip
   classical
-  letI := f.to_algebra
-  replace H : ∀ r : s, Algebra.FiniteType R (Localization.Away (r : S))
-  · intro r; convert H r; ext; rw [Algebra.smul_def]; rfl
-  replace H := fun r => (H r).1
-  constructor
-  -- Suppose `s : finset S` spans `S`, and each `Sᵣ` is finitely generated as an `R`-algebra.
-  -- Say `t r : finset Sᵣ` generates `Sᵣ`. By assumption, we may find `lᵢ` such that
-  -- `∑ lᵢ * sᵢ = 1`. I claim that all `s` and `l` and the numerators of `t` and generates `S`.
-  choose t ht using H
-  obtain ⟨l, hl⟩ :=
-    (Finsupp.mem_span_iff_total S (s : Set S) 1).mp
-      (show (1 : S) ∈ Ideal.span (s : Set S) by rw [hs]; trivial)
-  let sf := fun x : s => IsLocalization.finsetIntegerMultiple (Submonoid.powers (x : S)) (t x)
-  use s.attach.bUnion sf ∪ s ∪ l.support.image l
-  rw [eq_top_iff]
-  -- We need to show that every `x` falls in the subalgebra generated by those elements.
-  -- Since all `s` and `l` are in the subalgebra, it suffices to check that `sᵢ ^ nᵢ • x` falls in
-  -- the algebra for each `sᵢ` and some `nᵢ`.
-  rintro x -
-  apply Subalgebra.mem_of_span_eq_top_of_smul_pow_mem _ (s : Set S) l hl _ _ x _
-  · intro x hx
-    apply Algebra.subset_adjoin
-    rw [Finset.coe_union, Finset.coe_union]
-    exact Or.inl (Or.inr hx)
-  · intro i
-    by_cases h : l i = 0; · rw [h]; exact zero_mem _
-    apply Algebra.subset_adjoin
-    rw [Finset.coe_union, Finset.coe_image]
-    exact Or.inr (Set.mem_image_of_mem _ (finsupp.mem_support_iff.mpr h))
-  · intro r
-    rw [Finset.coe_union, Finset.coe_union, Finset.coe_biUnion]
-    -- Since all `sᵢ` and numerators of `t r` are in the algebra, it suffices to show that the
-    -- image of `x` in `Sᵣ` falls in the `R`-adjoin of `t r`, which is of course true.
-    obtain ⟨⟨_, n₂, rfl⟩, hn₂⟩ :=
-      IsLocalization.exists_smul_mem_of_mem_adjoin (Submonoid.powers (r : S)) x (t r)
-        (Algebra.adjoin R _) _ _ _
-    · exact ⟨n₂, hn₂⟩
-    · intro x hx
-      apply Algebra.subset_adjoin
-      refine' Or.inl (Or.inl ⟨_, ⟨r, rfl⟩, _, ⟨s.mem_attach r, rfl⟩, hx⟩)
-    · rw [Submonoid.powers_eq_closure, Submonoid.closure_le, Set.singleton_subset_iff]
-      apply Algebra.subset_adjoin
-      exact Or.inl (Or.inr r.2)
-    · rw [ht]; trivial
 #align ring_hom.finite_type_of_localization_span_target RingHom.finiteType_ofLocalizationSpanTarget
 -/
 
 #print RingHom.finiteType_is_local /-
+-- Suppose `s : finset S` spans `S`, and each `Sᵣ` is finitely generated as an `R`-algebra.
+-- Say `t r : finset Sᵣ` generates `Sᵣ`. By assumption, we may find `lᵢ` such that
+-- `∑ lᵢ * sᵢ = 1`. I claim that all `s` and `l` and the numerators of `t` and generates `S`.
+-- We need to show that every `x` falls in the subalgebra generated by those elements.
+-- Since all `s` and `l` are in the subalgebra, it suffices to check that `sᵢ ^ nᵢ • x` falls in
+-- the algebra for each `sᵢ` and some `nᵢ`.
+-- Since all `sᵢ` and numerators of `t r` are in the algebra, it suffices to show that the
+-- image of `x` in `Sᵣ` falls in the `R`-adjoin of `t r`, which is of course true.
 theorem finiteType_is_local : PropertyIsLocal @FiniteType :=
   ⟨localization_finiteType, finiteType_ofLocalizationSpanTarget, finiteType_stableUnderComposition,
     finiteType_holdsForLocalizationAway⟩

2a0ce625

bump to nightly-2023-09-24-06

mathlib commit https://github.com/leanprover-community/mathlib/commit/ce64cd319bb6b3e82f31c2d38e79080d377be451

5655435f

Diff

@@ -3,8 +3,8 @@ Copyright (c) 2021 Andrew Yang. All rights reserved.
 Released under Apache 2.0 license as described in the file LICENSE.
 Authors: Andrew Yang
 -/
-import Mathbin.RingTheory.LocalProperties
-import Mathbin.RingTheory.Localization.InvSubmonoid
+import RingTheory.LocalProperties
+import RingTheory.Localization.InvSubmonoid
 
 #align_import ring_theory.ring_hom.finite_type from "leanprover-community/mathlib"@"2a0ce625dbb0ffbc7d1316597de0b25c1ec75303"

2a0ce625

bump to nightly-2023-07-20-09

mathlib commit https://github.com/leanprover-community/mathlib/commit/8ea5598db6caeddde6cb734aa179cc2408dbd345

9c56d0dd

Diff

@@ -2,15 +2,12 @@
 Copyright (c) 2021 Andrew Yang. All rights reserved.
 Released under Apache 2.0 license as described in the file LICENSE.
 Authors: Andrew Yang
-
-! This file was ported from Lean 3 source module ring_theory.ring_hom.finite_type
-! leanprover-community/mathlib commit 2a0ce625dbb0ffbc7d1316597de0b25c1ec75303
-! Please do not edit these lines, except to modify the commit id
-! if you have ported upstream changes.
 -/
 import Mathbin.RingTheory.LocalProperties
 import Mathbin.RingTheory.Localization.InvSubmonoid
 
+#align_import ring_theory.ring_hom.finite_type from "leanprover-community/mathlib"@"2a0ce625dbb0ffbc7d1316597de0b25c1ec75303"
+
 /-!
 
 # The meta properties of finite-type ring homomorphisms.

2a0ce625

bump to nightly-2023-06-18-23

mathlib commit https://github.com/leanprover-community/mathlib/commit/2a0ce625dbb0ffbc7d1316597de0b25c1ec75303

3b5e23dc

Diff

@@ -27,10 +27,13 @@ namespace RingHom
 
 open scoped Pointwise
 
+#print RingHom.finiteType_stableUnderComposition /-
 theorem finiteType_stableUnderComposition : StableUnderComposition @FiniteType := by introv R hf hg;
   exact hg.comp hf
 #align ring_hom.finite_type_stable_under_composition RingHom.finiteType_stableUnderComposition
+-/
 
+#print RingHom.finiteType_holdsForLocalizationAway /-
 theorem finiteType_holdsForLocalizationAway : HoldsForLocalizationAway @FiniteType :=
   by
   introv R _
@@ -39,7 +42,9 @@ theorem finiteType_holdsForLocalizationAway : HoldsForLocalizationAway @FiniteTy
     rw [Algebra.smul_def]; rfl
   exact IsLocalization.finiteType_of_monoid_fg (Submonoid.powers r) S
 #align ring_hom.finite_type_holds_for_localization_away RingHom.finiteType_holdsForLocalizationAway
+-/
 
+#print RingHom.finiteType_ofLocalizationSpanTarget /-
 theorem finiteType_ofLocalizationSpanTarget : OfLocalizationSpanTarget @FiniteType :=
   by
   -- Setup algebra intances.
@@ -92,15 +97,20 @@ theorem finiteType_ofLocalizationSpanTarget : OfLocalizationSpanTarget @FiniteTy
       exact Or.inl (Or.inr r.2)
     · rw [ht]; trivial
 #align ring_hom.finite_type_of_localization_span_target RingHom.finiteType_ofLocalizationSpanTarget
+-/
 
+#print RingHom.finiteType_is_local /-
 theorem finiteType_is_local : PropertyIsLocal @FiniteType :=
   ⟨localization_finiteType, finiteType_ofLocalizationSpanTarget, finiteType_stableUnderComposition,
     finiteType_holdsForLocalizationAway⟩
 #align ring_hom.finite_type_is_local RingHom.finiteType_is_local
+-/
 
+#print RingHom.finiteType_respectsIso /-
 theorem finiteType_respectsIso : RingHom.RespectsIso @RingHom.FiniteType :=
   RingHom.finiteType_is_local.RespectsIso
 #align ring_hom.finite_type_respects_iso RingHom.finiteType_respectsIso
+-/
 
 end RingHom

2a0ce625

bump to nightly-2023-06-18-05

mathlib commit https://github.com/leanprover-community/mathlib/commit/2a0ce625dbb0ffbc7d1316597de0b25c1ec75303

cd92954f

Diff

@@ -4,7 +4,7 @@ Released under Apache 2.0 license as described in the file LICENSE.
 Authors: Andrew Yang
 
 ! This file was ported from Lean 3 source module ring_theory.ring_hom.finite_type
-! leanprover-community/mathlib commit 64fc7238fb41b1a4f12ff05e3d5edfa360dd768c
+! leanprover-community/mathlib commit 2a0ce625dbb0ffbc7d1316597de0b25c1ec75303
 ! Please do not edit these lines, except to modify the commit id
 ! if you have ported upstream changes.
 -/
@@ -15,6 +15,9 @@ import Mathbin.RingTheory.Localization.InvSubmonoid
 
 # The meta properties of finite-type ring homomorphisms.
 
+> THIS FILE IS SYNCHRONIZED WITH MATHLIB4.
+> Any changes to this file require a corresponding PR to mathlib4.
+
 The main result is `ring_hom.finite_is_local`.
 
 -/

64fc7238

bump to nightly-2023-06-04-18

mathlib commit https://github.com/leanprover-community/mathlib/commit/5f25c089cb34db4db112556f23c50d12da81b297

3fb4268b

Diff

@@ -44,50 +44,50 @@ theorem finiteType_ofLocalizationSpanTarget : OfLocalizationSpanTarget @FiniteTy
   introv R hs H
   skip
   classical
-    letI := f.to_algebra
-    replace H : ∀ r : s, Algebra.FiniteType R (Localization.Away (r : S))
-    · intro r; convert H r; ext; rw [Algebra.smul_def]; rfl
-    replace H := fun r => (H r).1
-    constructor
-    -- Suppose `s : finset S` spans `S`, and each `Sᵣ` is finitely generated as an `R`-algebra.
-    -- Say `t r : finset Sᵣ` generates `Sᵣ`. By assumption, we may find `lᵢ` such that
-    -- `∑ lᵢ * sᵢ = 1`. I claim that all `s` and `l` and the numerators of `t` and generates `S`.
-    choose t ht using H
-    obtain ⟨l, hl⟩ :=
-      (Finsupp.mem_span_iff_total S (s : Set S) 1).mp
-        (show (1 : S) ∈ Ideal.span (s : Set S) by rw [hs]; trivial)
-    let sf := fun x : s => IsLocalization.finsetIntegerMultiple (Submonoid.powers (x : S)) (t x)
-    use s.attach.bUnion sf ∪ s ∪ l.support.image l
-    rw [eq_top_iff]
-    -- We need to show that every `x` falls in the subalgebra generated by those elements.
-    -- Since all `s` and `l` are in the subalgebra, it suffices to check that `sᵢ ^ nᵢ • x` falls in
-    -- the algebra for each `sᵢ` and some `nᵢ`.
-    rintro x -
-    apply Subalgebra.mem_of_span_eq_top_of_smul_pow_mem _ (s : Set S) l hl _ _ x _
+  letI := f.to_algebra
+  replace H : ∀ r : s, Algebra.FiniteType R (Localization.Away (r : S))
+  · intro r; convert H r; ext; rw [Algebra.smul_def]; rfl
+  replace H := fun r => (H r).1
+  constructor
+  -- Suppose `s : finset S` spans `S`, and each `Sᵣ` is finitely generated as an `R`-algebra.
+  -- Say `t r : finset Sᵣ` generates `Sᵣ`. By assumption, we may find `lᵢ` such that
+  -- `∑ lᵢ * sᵢ = 1`. I claim that all `s` and `l` and the numerators of `t` and generates `S`.
+  choose t ht using H
+  obtain ⟨l, hl⟩ :=
+    (Finsupp.mem_span_iff_total S (s : Set S) 1).mp
+      (show (1 : S) ∈ Ideal.span (s : Set S) by rw [hs]; trivial)
+  let sf := fun x : s => IsLocalization.finsetIntegerMultiple (Submonoid.powers (x : S)) (t x)
+  use s.attach.bUnion sf ∪ s ∪ l.support.image l
+  rw [eq_top_iff]
+  -- We need to show that every `x` falls in the subalgebra generated by those elements.
+  -- Since all `s` and `l` are in the subalgebra, it suffices to check that `sᵢ ^ nᵢ • x` falls in
+  -- the algebra for each `sᵢ` and some `nᵢ`.
+  rintro x -
+  apply Subalgebra.mem_of_span_eq_top_of_smul_pow_mem _ (s : Set S) l hl _ _ x _
+  · intro x hx
+    apply Algebra.subset_adjoin
+    rw [Finset.coe_union, Finset.coe_union]
+    exact Or.inl (Or.inr hx)
+  · intro i
+    by_cases h : l i = 0; · rw [h]; exact zero_mem _
+    apply Algebra.subset_adjoin
+    rw [Finset.coe_union, Finset.coe_image]
+    exact Or.inr (Set.mem_image_of_mem _ (finsupp.mem_support_iff.mpr h))
+  · intro r
+    rw [Finset.coe_union, Finset.coe_union, Finset.coe_biUnion]
+    -- Since all `sᵢ` and numerators of `t r` are in the algebra, it suffices to show that the
+    -- image of `x` in `Sᵣ` falls in the `R`-adjoin of `t r`, which is of course true.
+    obtain ⟨⟨_, n₂, rfl⟩, hn₂⟩ :=
+      IsLocalization.exists_smul_mem_of_mem_adjoin (Submonoid.powers (r : S)) x (t r)
+        (Algebra.adjoin R _) _ _ _
+    · exact ⟨n₂, hn₂⟩
     · intro x hx
       apply Algebra.subset_adjoin
-      rw [Finset.coe_union, Finset.coe_union]
-      exact Or.inl (Or.inr hx)
-    · intro i
-      by_cases h : l i = 0; · rw [h]; exact zero_mem _
+      refine' Or.inl (Or.inl ⟨_, ⟨r, rfl⟩, _, ⟨s.mem_attach r, rfl⟩, hx⟩)
+    · rw [Submonoid.powers_eq_closure, Submonoid.closure_le, Set.singleton_subset_iff]
       apply Algebra.subset_adjoin
-      rw [Finset.coe_union, Finset.coe_image]
-      exact Or.inr (Set.mem_image_of_mem _ (finsupp.mem_support_iff.mpr h))
-    · intro r
-      rw [Finset.coe_union, Finset.coe_union, Finset.coe_biUnion]
-      -- Since all `sᵢ` and numerators of `t r` are in the algebra, it suffices to show that the
-      -- image of `x` in `Sᵣ` falls in the `R`-adjoin of `t r`, which is of course true.
-      obtain ⟨⟨_, n₂, rfl⟩, hn₂⟩ :=
-        IsLocalization.exists_smul_mem_of_mem_adjoin (Submonoid.powers (r : S)) x (t r)
-          (Algebra.adjoin R _) _ _ _
-      · exact ⟨n₂, hn₂⟩
-      · intro x hx
-        apply Algebra.subset_adjoin
-        refine' Or.inl (Or.inl ⟨_, ⟨r, rfl⟩, _, ⟨s.mem_attach r, rfl⟩, hx⟩)
-      · rw [Submonoid.powers_eq_closure, Submonoid.closure_le, Set.singleton_subset_iff]
-        apply Algebra.subset_adjoin
-        exact Or.inl (Or.inr r.2)
-      · rw [ht]; trivial
+      exact Or.inl (Or.inr r.2)
+    · rw [ht]; trivial
 #align ring_hom.finite_type_of_localization_span_target RingHom.finiteType_ofLocalizationSpanTarget
 
 theorem finiteType_is_local : PropertyIsLocal @FiniteType :=

64fc7238

bump to nightly-2023-05-28-18

mathlib commit https://github.com/leanprover-community/mathlib/commit/917c3c072e487b3cccdbfeff17e75b40e45f66cb

8d353152

Diff

@@ -22,7 +22,7 @@ The main result is `ring_hom.finite_is_local`.
 
 namespace RingHom
 
-open Pointwise
+open scoped Pointwise
 
 theorem finiteType_stableUnderComposition : StableUnderComposition @FiniteType := by introv R hf hg;
   exact hg.comp hf

64fc7238

bump to nightly-2023-05-28-04

mathlib commit https://github.com/leanprover-community/mathlib/commit/917c3c072e487b3cccdbfeff17e75b40e45f66cb

6797a637

Diff

@@ -24,9 +24,7 @@ namespace RingHom
 
 open Pointwise
 
-theorem finiteType_stableUnderComposition : StableUnderComposition @FiniteType :=
-  by
-  introv R hf hg
+theorem finiteType_stableUnderComposition : StableUnderComposition @FiniteType := by introv R hf hg;
   exact hg.comp hf
 #align ring_hom.finite_type_stable_under_composition RingHom.finiteType_stableUnderComposition
 
@@ -34,12 +32,8 @@ theorem finiteType_holdsForLocalizationAway : HoldsForLocalizationAway @FiniteTy
   by
   introv R _
   skip
-  suffices Algebra.FiniteType R S by
-    change Algebra.FiniteType _ _
-    convert this
-    ext
-    rw [Algebra.smul_def]
-    rfl
+  suffices Algebra.FiniteType R S by change Algebra.FiniteType _ _; convert this; ext;
+    rw [Algebra.smul_def]; rfl
   exact IsLocalization.finiteType_of_monoid_fg (Submonoid.powers r) S
 #align ring_hom.finite_type_holds_for_localization_away RingHom.finiteType_holdsForLocalizationAway
 
@@ -52,11 +46,7 @@ theorem finiteType_ofLocalizationSpanTarget : OfLocalizationSpanTarget @FiniteTy
   classical
     letI := f.to_algebra
     replace H : ∀ r : s, Algebra.FiniteType R (Localization.Away (r : S))
-    · intro r
-      convert H r
-      ext
-      rw [Algebra.smul_def]
-      rfl
+    · intro r; convert H r; ext; rw [Algebra.smul_def]; rfl
     replace H := fun r => (H r).1
     constructor
     -- Suppose `s : finset S` spans `S`, and each `Sᵣ` is finitely generated as an `R`-algebra.
@@ -65,9 +55,7 @@ theorem finiteType_ofLocalizationSpanTarget : OfLocalizationSpanTarget @FiniteTy
     choose t ht using H
     obtain ⟨l, hl⟩ :=
       (Finsupp.mem_span_iff_total S (s : Set S) 1).mp
-        (show (1 : S) ∈ Ideal.span (s : Set S) by
-          rw [hs]
-          trivial)
+        (show (1 : S) ∈ Ideal.span (s : Set S) by rw [hs]; trivial)
     let sf := fun x : s => IsLocalization.finsetIntegerMultiple (Submonoid.powers (x : S)) (t x)
     use s.attach.bUnion sf ∪ s ∪ l.support.image l
     rw [eq_top_iff]
@@ -81,9 +69,7 @@ theorem finiteType_ofLocalizationSpanTarget : OfLocalizationSpanTarget @FiniteTy
       rw [Finset.coe_union, Finset.coe_union]
       exact Or.inl (Or.inr hx)
     · intro i
-      by_cases h : l i = 0
-      · rw [h]
-        exact zero_mem _
+      by_cases h : l i = 0; · rw [h]; exact zero_mem _
       apply Algebra.subset_adjoin
       rw [Finset.coe_union, Finset.coe_image]
       exact Or.inr (Set.mem_image_of_mem _ (finsupp.mem_support_iff.mpr h))
@@ -101,8 +87,7 @@ theorem finiteType_ofLocalizationSpanTarget : OfLocalizationSpanTarget @FiniteTy
       · rw [Submonoid.powers_eq_closure, Submonoid.closure_le, Set.singleton_subset_iff]
         apply Algebra.subset_adjoin
         exact Or.inl (Or.inr r.2)
-      · rw [ht]
-        trivial
+      · rw [ht]; trivial
 #align ring_hom.finite_type_of_localization_span_target RingHom.finiteType_ofLocalizationSpanTarget
 
 theorem finiteType_is_local : PropertyIsLocal @FiniteType :=

64fc7238

bump to nightly-2023-05-14-08

mathlib commit https://github.com/leanprover-community/mathlib/commit/e3fb84046afd187b710170887195d50bada934ee

d31da313

Diff

@@ -88,7 +88,7 @@ theorem finiteType_ofLocalizationSpanTarget : OfLocalizationSpanTarget @FiniteTy
       rw [Finset.coe_union, Finset.coe_image]
       exact Or.inr (Set.mem_image_of_mem _ (finsupp.mem_support_iff.mpr h))
     · intro r
-      rw [Finset.coe_union, Finset.coe_union, Finset.coe_bunionᵢ]
+      rw [Finset.coe_union, Finset.coe_union, Finset.coe_biUnion]
       -- Since all `sᵢ` and numerators of `t r` are in the algebra, it suffices to show that the
       -- image of `x` in `Sᵣ` falls in the `R`-adjoin of `t r`, which is of course true.
       obtain ⟨⟨_, n₂, rfl⟩, hn₂⟩ :=

64fc7238

bump to nightly-2023-02-21-16

mathlib commit https://github.com/leanprover-community/mathlib/commit/bd9851ca476957ea4549eb19b40e7b5ade9428cc

1107b979

Changes in mathlib4

mathlib3

mathlib4

64fc7238

chore: remove stream-of-consciousness uses of have, replace and suffices (#10640)

No changes to tactic file, it's just boring fixes throughout the library.

This follows on from #6964.

Co-authored-by: sgouezel <sebastien.gouezel@univ-rennes1.fr> Co-authored-by: Eric Wieser <wieser.eric@gmail.com>

a13e8040

Diff

@@ -41,8 +41,8 @@ theorem finiteType_ofLocalizationSpanTarget : OfLocalizationSpanTarget @FiniteTy
   introv R hs H
   classical
   letI := f.toAlgebra
-  replace H : ∀ r : s, Algebra.FiniteType R (Localization.Away (r : S))
-  · intro r; simp_rw [RingHom.FiniteType] at H; convert H r; ext; simp_rw [Algebra.smul_def]; rfl
+  replace H : ∀ r : s, Algebra.FiniteType R (Localization.Away (r : S)) := by
+    intro r; simp_rw [RingHom.FiniteType] at H; convert H r; ext; simp_rw [Algebra.smul_def]; rfl
   replace H := fun r => (H r).1
   constructor
   -- Suppose `s : Finset S` spans `S`, and each `Sᵣ` is finitely generated as an `R`-algebra.

64fc7238

chore: script to replace headers with #align_import statements (#5979)

depends on: #5966

Co-authored-by: Eric Wieser <wieser.eric@gmail.com> Co-authored-by: Scott Morrison <scott.morrison@gmail.com>

89aa3a3b

Diff

@@ -2,15 +2,12 @@
 Copyright (c) 2021 Andrew Yang. All rights reserved.
 Released under Apache 2.0 license as described in the file LICENSE.
 Authors: Andrew Yang
-
-! This file was ported from Lean 3 source module ring_theory.ring_hom.finite_type
-! leanprover-community/mathlib commit 64fc7238fb41b1a4f12ff05e3d5edfa360dd768c
-! Please do not edit these lines, except to modify the commit id
-! if you have ported upstream changes.
 -/
 import Mathlib.RingTheory.LocalProperties
 import Mathlib.RingTheory.Localization.InvSubmonoid
 
+#align_import ring_theory.ring_hom.finite_type from "leanprover-community/mathlib"@"64fc7238fb41b1a4f12ff05e3d5edfa360dd768c"
+
 /-!
 
 # The meta properties of finite-type ring homomorphisms.

64fc7238

feat: port RingTheory.RingHom.FiniteType (#5075)

4cf5b945

`ring_theory.ring_hom.finite_type` ⟷ `Mathlib.RingTheory.RingHom.FiniteType`

Changes since the initial port

Changes in mathlib3

Changes in mathlib3port

Changes in mathlib4

Dependencies 10 + 688

ring_theory.ring_hom.finite_type ⟷ Mathlib.RingTheory.RingHom.FiniteType

Changes since the initial port

Changes in mathlib3

Changes in mathlib3port

Changes in mathlib4

Dependencies 10 + 688

`ring_theory.ring_hom.finite_type` ⟷ `Mathlib.RingTheory.RingHom.FiniteType`