Zulip Chat Archive
Stream: general
Topic: Can we make `staging` a protected branch?
Eric Wieser (Nov 17 2020 at 15:27):
I just pushed to it by accident...
Eric Wieser (Nov 17 2020 at 15:29):
Looks like bors corrected my mistake, but it would obviously be better were I not able to make it in the first place...
Johan Commelin (Nov 17 2020 at 15:36):
cc @Bryan Gin-ge Chen
Eric Wieser (Nov 17 2020 at 15:38):
Obviously also we should not protect it from :eye: itself
Bryan Gin-ge Chen (Nov 17 2020 at 15:38):
I think when we set this up originally, I protected staging*
which unfortunately broke things as bors needs to be able to delete staging.tmp*
branches, so we just removed that rule entirely.
We could add a new rule just for staging
, but as you noticed, bors doesn't actually pay any attention to what's on staging
; it just force-pushes a commit there and then later pushes that commit onto master
.
Bryan Gin-ge Chen (Nov 17 2020 at 15:53):
Since I screwed this up before, I'm inclined to not mess with the settings right now, but if I have time later I might play around with bors in another test repo and see what works best.
Last updated: Dec 20 2023 at 11:08 UTC