Zulip Chat Archive
Stream: general
Topic: Comments on GitHub
Fangming Li (John) (Jul 05 2024 at 16:21):
I have created a pull request #13885 and my supervisor @Kevin Buzzard has left some comments. However, I can only see the sentence "This looks fine to me, I've left some comments which are mostly about docstrings." that he sent after all the comments, but cannot see the comments. I have tried various methods including: logging out and signing in again, using a different browser, accessing the pull request page using another device. But I still cannot see his comments. How can I solve this problem? The following is a picture of my screen:
Fangming Li (John) (Jul 05 2024 at 16:24):
DC2F4808-91A8-4EB1-B772-D8C952935B2C.jpg
Bryan Gin-ge Chen (Jul 05 2024 at 16:25):
For what it's worth, the latest comments I see from Kevin are from 3 weeks ago. Maybe he forgot to submit them?
Kevin Buzzard (Jul 05 2024 at 17:54):
Oh apologies you're right, they were still marked as "pending". My fault! Submitted now.
Bulhwi Cha (Jul 07 2024 at 01:10):
Bulhwi Cha said:
I added a review to batteries#782 but it's labeled "Pending." So, I guess it's currently visible only to me.
Oh, I've also made this mistake before.
Last updated: May 02 2025 at 03:31 UTC