Zulip Chat Archive

Stream: general

Topic: GitHub merge-conflict label


Martin Dvořák (Nov 25 2023 at 09:03):

When I get a merge-conflict label on a Mathlib PR, can I view on GitHub where the conflict is?

Johan Commelin (Nov 25 2023 at 10:59):

Usually there is a button "Resolve conflicts" close to where the merge button normally is.

Martin Dvořák (Nov 25 2023 at 11:12):

Ah! It's just a conflict in the Mathlib.lean file. IMO it's pretty dumb we have to maintain this file.

Johan Commelin (Nov 25 2023 at 12:11):

Yep. At least we should have a bot that fixes these conflicts.

Martin Dvořák (Nov 25 2023 at 12:31):

The current merge-conflict mechanisms imply that other PRs can kick my PR out / to the end of #queue .

Jireh Loreaux (Nov 25 2023 at 14:09):

I think several maintainers look at the queue in both ascending and descending order. I do anyway.


Last updated: Dec 20 2023 at 11:08 UTC