Zulip Chat Archive

Stream: general

Topic: Noisy files and CI


Damiano Testa (May 13 2024 at 23:02):

I believe that the current CI setup allows some noisy files to pass through CI.

You can take a look at #12884, where a file with a logInfo gets a CI pass.

I modified the "noisy" step of CI in #12886 to catch this sort of issue. You can see that the same file fails the new CI in #12885.

Kim Morrison (May 13 2024 at 23:21):

:writing:

Damiano Testa (May 13 2024 at 23:49):

Comments added!

Damiano Testa (May 14 2024 at 13:26):

In fact, our current tests for noisiness allow sorry in examples (#12912) and probably also in theorems (#12913).

Damiano Testa (May 14 2024 at 13:27):

I think that it all boils down to the fact that lake no longer prepends stdout/stderr to messages, but has switched to info/warning/error. The current CI filters the output by scanning for the no-longer-used words.


Last updated: May 02 2025 at 03:31 UTC