PR with dependencies

Stream: general

[Jireh Loreaux]

What is the correct way to submit a PR with a dependency? Do I just branch from the branch of the original PR and GitHub will figure it out?

[Alex J. Best]

Yes, the diff will still look like its against master, so the second PR will look like its PRing both sets of changes, until the first PR is merged, then you can git pull master from the second PR to update the diff. The bot will let you know when all dependencies are merged if you use the syntax in the example PR message

[Yaël Dillies]

Yup, and when opening the PR, write - [ ] depends on #[number of the previous PR]

[Eric Wieser]

(your [ ] and - are swapped)