Zulip Chat Archive

Stream: general

Topic: Segfaults in CI are a pass?


Eric Wieser (Mar 10 2022 at 15:14):

I just made #12568, which segfaults for me every time in gitpod. However, github reports that it built everything downstream of file#algebra/order/monoid in just 16s!

I assume what actually happened is that the build segfaulted in CI too, but CI considered that a pass?

Eric Wieser (Mar 10 2022 at 15:22):

Ah, seems only the build step swallowed the error, lint and tests segfault too and report it

Eric Wieser (Mar 10 2022 at 16:33):

Here's a #mwe for the segfault:

import algebra.group.with_one

-- segfault without this line
-- attribute [semireducible] with_zero

def segfault_please : with_zero   
| 0 := 0
| (n : ) := n

Gabriel Ebner (Mar 10 2022 at 17:44):

:scream:

Gabriel Ebner (Mar 10 2022 at 17:46):

Ah, seems only the build step swallowed the error, lint and tests segfault too and report it

Is this because we don't set pipefail in ci?

Gabriel Ebner (Mar 10 2022 at 17:49):

lean#695


Last updated: Dec 20 2023 at 11:08 UTC