Zulip Chat Archive

Stream: general

Topic: Split analysis.normed_space.basic


Yury G. Kudryashov (Oct 09 2021 at 21:09):

Hi, it looks to me that src#analysis.normed_space.basic is a huge with a few (related) topics mixed together. I'm moving (semi_)normed_group to a separate file in #9642. I plan to further split it into normed.ring, normed.field, normed.space (or normed.module because I think that we should generalize to normed modules over normed rings), and normed.algebra.

Yury G. Kudryashov (Oct 09 2021 at 21:09):

Any objections?

Yaël Dillies (Oct 09 2021 at 21:21):

The bot should really support filenames... Does src#analysis/convex/basic work?

Yaël Dillies (Oct 09 2021 at 21:22):

Nope

Yaël Dillies (Oct 09 2021 at 21:25):

Do you plan on migrating the rest of analysis.normed_space. to analysis.normed.? I think that's justified. Or at least move it to analysis.normed.space.

Yaël Dillies (Oct 09 2021 at 21:26):

The file splits seem to align on what we already have in other hierarchies, so I'm all for it.

Yaël Dillies (Oct 09 2021 at 21:26):

Feel free to expand the docstrings as you go along.

Yury G. Kudryashov (Oct 09 2021 at 21:42):

I want to make the "split file" PRs atomic, so I'll review code / docstrings / var names in separate PRs.

Yaël Dillies (Oct 09 2021 at 21:44):

Yeah sure! I didn't obviously mean in the same PR.

Yury G. Kudryashov (Oct 10 2021 at 16:06):

It would be nice if someone approves or rejects #9642.

Yury G. Kudryashov (Oct 10 2021 at 16:07):

It is +1K,-1K but actually there is no new code here (I even resisted the temptation to rename vars in the same commit).


Last updated: Dec 20 2023 at 11:08 UTC