Zulip Chat Archive
Stream: general
Topic: data.fin.vec_notation imports
Ruben Van de Velde (Dec 09 2022 at 10:02):
data.fin.vec_notation
imports a dozen files about lists just to implement a has_repr
instance. Do people have thoughts on that? Not sure myself; it just seemed surprising
Anne Baanen (Dec 09 2022 at 10:48):
I'm slightly in favour: making the notation roundtrip with repr
is useful, list
is relatively low-level and I don't recall seeing vector notation used in low-level parts of the library.
Anne Baanen (Dec 09 2022 at 10:48):
If we can reduce the imports without reducing functionality, then that would of course be even better.
Eric Wieser (Dec 09 2022 at 10:57):
We could switch to using of_fn
instead of fin_range
which would push back the imports a bit
Last updated: Dec 20 2023 at 11:08 UTC