Zulip Chat Archive
Stream: general
Topic: doc gen fails on 4.12.0-rc1
Yaël Dillies (Sep 03 2024 at 18:28):
I get strange CI errors in APAP that seem to mean that doc-gen wasn't updated to 4.12.0-rc1. @Bryan Gin-ge Chen, thoughts?
Henrik Böving (Sep 03 2024 at 18:29):
https://github.com/leanprover/doc-gen4/pull/217 it was indeed not updated because it fails to build due to dependency issues (among other things)
Yaël Dillies (Sep 03 2024 at 18:29):
Aha! Can I help?
Bryan Gin-ge Chen (Sep 03 2024 at 18:30):
I unfortunately have no experience with doc-gen4 or its CI (yet?) so I have nothing to contribute here...
Henrik Böving (Sep 03 2024 at 18:31):
The PR already exists: https://github.com/dupuisf/BibtexQuery/pull/10
Yaël Dillies (Sep 03 2024 at 18:31):
Sorry, I will erase the association between you and doc-gen4 from my brain :robot:
Henrik Böving (Sep 03 2024 at 18:32):
@Tobias Grosser would have to set the toolchain correct and then @Frédéric Dupuis would have to merge (I think Frederic can also change the content of that branch because he is the maintainer, it depends on how the PR was set up by Tobias).
Henrik Böving (Sep 03 2024 at 18:33):
There does also seem to be a small change necessary to doc-gen itself which I can make really quick
Henrik Böving (Sep 03 2024 at 18:38):
But yeah the main blocker is bibtex query so I guess waiting for Frederic and maybe Tobias is in order^^
Julian Berman (Sep 03 2024 at 18:40):
(#general > BibtexQuery CI is tangentially related)
Henrik Böving (Sep 03 2024 at 18:49):
doc-gen part is done
Tobias Grosser (Sep 03 2024 at 19:12):
https://github.com/dupuisf/BibtexQuery/pull/10 is done.
Tobias Grosser (Sep 03 2024 at 19:12):
Waiting for @Frédéric Dupuis to review and merge.
Tobias Grosser (Sep 03 2024 at 19:13):
Feel free to already do a review to catch any obvious errors I may have made.
Frédéric Dupuis (Sep 03 2024 at 20:45):
I just merged -- thanks Tobias, and sorry everyone for being slow here, this caught me on a very busy day.
Tobias Grosser (Sep 03 2024 at 20:52):
This was pretty quick.
Tobias Grosser (Sep 03 2024 at 20:52):
Thank you
Henrik Böving (Sep 03 2024 at 20:56):
on the update now!
Henrik Böving (Sep 03 2024 at 21:18):
done! @Yaël Dillies ping
Kim Morrison (Sep 03 2024 at 23:16):
Thanks all!
Yaël Dillies (Sep 04 2024 at 07:24):
All working good again on my end :smiley:
Last updated: May 02 2025 at 03:31 UTC