emacs yasnippet key bindings

Stream: general

[Yury G. Kudryashov]

Is there any reason to include custom keybindings for yasnippet in yasnippet-lean?

[Yury G. Kudryashov]

Given that it conflicts with the default keybinding for "search".

[Simon Hudon]

I don't remember making those custom keybindings. What are they?

[Yury G. Kudryashov]

https://github.com/leanprover-community/yasnippet-lean/blob/master/yasnippet-lean.el#L67

[Simon Hudon]

We can remove them. Do you want to PR it? I think @Sebastian Ullrich and @Jesse Michael Han might have something to say since they also use emacs. I don't think there are many of us

[Jesse Michael Han]

i don't use those keybindings and just manually type M-x yas-new-snippet since i don't add new snippets very often; i'm OK with removing them

[Yury G. Kudryashov]

There are default keybindings in yasnippet for all three functions (starting with C-c instead of C-s). I think that those who don't like defauflt keybindings can easily change them in ~/.emacs.d/init.el, and one package shouldn't change default keybindings of another package.

[Yury G. Kudryashov]

I'll PR removal of the bindings tonight.

[Yury G. Kudryashov]

https://github.com/leanprover-community/yasnippet-lean/pull/3 and https://github.com/leanprover-community/yasnippet-lean/pull/4

[Simon Hudon]

Merged

[Simon Hudon]

I'm pretty new to uploading packages to melpa but we don't seem to have to upgrade it since no version is listed here: https://github.com/melpa/melpa/blob/master/recipes/yasnippet-lean

[Yury G. Kudryashov]

Let's see if melpa will have a new version tomorrow.