Zulip Chat Archive

Stream: general

Topic: github


Scott Morrison (Feb 01 2019 at 22:31):

What am I meant to do with old PRs, that I had pushed as branches on leanprover-community/mathlib?

Scott Morrison (Feb 01 2019 at 22:32):

It seems I can no longer push to them, which is probably an intentional effect of the new maintainer setup.

Scott Morrison (Feb 01 2019 at 22:32):

Should I close those PRs and make new ones from my own fork?

Kenny Lau (Feb 01 2019 at 22:33):

I believe you should change the remote to the fork and push them there

Scott Morrison (Feb 01 2019 at 22:33):

I should I still be able to push to non-master branches?

Kenny Lau (Feb 01 2019 at 22:33):

And for the new PR's you can push them to the non-master branches

Scott Morrison (Feb 01 2019 at 22:34):

I'm confused. Are you saying that I can make new branches on leanprover-community/mathlib, but can't push to old branches?

Kenny Lau (Feb 01 2019 at 22:35):

I'm saying that for old PR's, you can change the remote to the backup fork and push them there (if you push without changing remote, you'll create a new branch in leanprover-community/mathlib); for new PR's push to leanprover-community/mathlib directly

Simon Hudon (Feb 01 2019 at 22:36):

I second @Kenny Lau's suggestion

Scott Morrison (Feb 01 2019 at 22:43):

It seems I can't push to leanprover-community/mathlib anymore?

Kenny Lau (Feb 01 2019 at 22:44):

you should be able to...

Scott Morrison (Feb 01 2019 at 22:46):

I'd missed the invitation. All good now.


Last updated: Dec 20 2023 at 11:08 UTC