Zulip Chat Archive

Stream: general

Topic: lines per commit

Johan Commelin (Dec 08 2021 at 07:25):

Can someone please generate a plot for the number of lines per commit to mathlib master? My hypothesis is that commits have been getting much smaller compared to two years ago (which is perfectly fine, and explained by the split-your-PRs policy).
I would just like to see the data, but I don't have time to dig this out of the logs myself. If someone could do it for me, that would be awesome!

Yaël Dillies (Dec 08 2021 at 07:29):

Oh yes, I have seen the monster PR from when mathlib was starting!

Patrick Johnson (Dec 08 2021 at 09:26):

You mean mathlib3, right? Here is the plot starting from commit deb16814 and ending with commit 4d56716d:


X-axis represents commits from older (left) to newer (right). Blue is how many files are changed, green and red are insertions and deletions. You can find raw data here.

Patrick Johnson (Dec 08 2021 at 09:30):

Here are only insertions and deletions, taking average of each 40 consecutive points:

Johan Commelin (Dec 08 2021 at 09:30):

aah, that shows the trend a lot better

Johan Commelin (Dec 08 2021 at 09:31):


Julian Berman (Dec 08 2021 at 15:56):

In the programming world there are discussions and research papers trying to make suggestions about optimal lengths for pull requests

Julian Berman (Dec 08 2021 at 15:56):

They center around things like the attention span of people, how long it takes them to read lines of code on average, and number of defects they tend to uncover during that period

Julian Berman (Dec 08 2021 at 15:56):

I'd still be curious what alternate metrics or considerations there are for this world

Last updated: Aug 03 2023 at 10:10 UTC