Zulip Chat Archive

Stream: general

Topic: mul in add_group_filter_basis_of_comm


Filippo A. E. Nuccio (Sep 22 2022 at 12:54):

In docs#add_group_filter_basis_of_comm the third (resp. fourth) field is called mul (resp. inv), but wouldn't it more reasonable to call it add (resp. sub)? Also, in the doc at the end I think we should have "add_group_filter_basis constructor in the additive commutative group case", no?

Yaël Dillies (Sep 22 2022 at 12:56):

This is generated by to_additive so there's not much you can do about the field names.

Anne Baanen (Sep 22 2022 at 12:57):

The docstring can be tweaked easily though :)

Filippo A. E. Nuccio (Sep 22 2022 at 12:58):

Oh yes, I just realised by clicking on the source. I will simply pull a doc PR then.


Last updated: Dec 20 2023 at 11:08 UTC