Zulip Chat Archive
Stream: general
Topic: polynomial refactor
Kenny Lau (Jul 22 2020 at 10:20):
Here is a shoutout to @Jalex Stark for refactoring data.polynomial
in #3407
Scott Morrison (Jul 22 2020 at 11:08):
Here's #3512, as a follow-up.
Scott Morrison (Jul 22 2020 at 11:09):
The major things I still want to do with polynomials are:
- a bit more work trying to switch to bundled homs (but it's hard, as we have maps that have variable structure as we strengthen the assumptions)
- adding some
@[irreducible]
annotations
Jalex Stark (Jul 22 2020 at 11:56):
I only split up the file to make room for Scott to actually improve the code
Scott Morrison (Jul 22 2020 at 12:05):
Splitting it up was very useful. Previously, every time I'd look at that file, I'd think "wow, everything is in the wrong place" but then I wouldn't attempt to unjumble it. It is somehow much more satisfying to move a declaration from one file to another, so something gets done. :-)
Jalex Stark (Jul 22 2020 at 12:06):
Yeah files are a great psychological trick, in addition to controlling the flow of imports
Last updated: Dec 20 2023 at 11:08 UTC