ready-to-merge tag etiquette

Stream: general

[Henry Swanson]

I've gotten approval on #7526, and I'm trying to figure out the merging process. The contribution page says that after approval, the ready-to-merge tag will be automatically added. But since it isn't, is it appropriate to just add it manually? Or is that something a maintainer must do?

[Bryan Gin-ge Chen]

We use bors to merge our PRs, so wait for a maintainer to comment with bors d+ or bors r+.

[Henry Swanson]

Bors can only be invoked by maintainers, yes, but I'm not sure whether the tag is my responsibility or not (I imagine that, without it, it's harder for them to find PRs that are ready to merge)

[Bryan Gin-ge Chen]

The ready-to-merge and delegated tags are managed by automation; the main ones that we humans track are awaiting-review and awaiting-author.

[Henry Swanson]

Alrighty, that makes things clear. Thanks!

[Scott Morrison]

In particular: please mark your PRs as awaiting-review (and remove awaiting-author) if you're looking for maintainers to come back (and hopefully merge).

[Scott Morrison]

It's also completely okay to write a post in the "PR reviews" stream asking for someone to come have a look.

[Scott Morrison]

It's very helpful also if PR authors mark conversations as resolved themselves (as long as they are at least moderately confident they've dealt with the request). Otherwise it takes extra time when a different reviewer comes along, to try to parse that state of previous conversations.