How to suggest a change to an unchanged file?

Stream: new members

[Stuart Presnell]

If someone else's PR has changed a file, I know how to see this on the "Files changed" page on github.com and how to highlight one or more lines to suggest changes. If a file hasn't been changed by the PR what's the appropriate way to suggest a change to it? (For example, if the PR is failing CI with an "Unchanged files with check annotations" error, and I want to suggest a fix to that file.)

[Stuart Presnell]

If it were my own PR I could just checkout the branch, commit the change, and push the commit. But on someone else's PR this feels impolite (although the intention is to save them the trouble of finding and fixing the problem). So this is partly a how-to-use-github question and partly an etiquette question.

[Eric Wieser]

Ignoring the topic of etiquette: there's no way to make a suggestion that github will recognize as such in this case - your options are:

• Make a regular comment indicating roughly where to make the change
• Pushing to the branch
• Making a PR against the PR branch

[Eric Wieser]

Ignoring the topic of etiquette: there's no way to make a suggestion that github will recognize as such in this case - your options are:

• Make a regular comment indicating roughly where to make the change
• Push to the branch
• Make a PR against the PR branch

[Arthur Paulino]

What I usually do is to branch out from the person's branch, change what I want to suggest, then opening a PR into the person's branch