Zulip Chat Archive

Stream: new members

Topic: Open Polynomials PR


Gareth Ma (Jun 16 2024 at 00:33):

I have an open PR on some simple polynomial lemmas here, I found them useful while working on some proofs. If someone could review it that would be great :)

Bolton Bailey (Jun 16 2024 at 04:41):

Welcome to mathlib contribution! If you want someone to review the PR, you should put the awaiting-review label on it

Gareth Ma (Jun 16 2024 at 14:22):

Thanks, just curious why isn't this added automatically :D

Bolton Bailey (Jun 16 2024 at 14:34):

Contributors often want to continue work on their PRs, even after they are passing CI. I think its technically supposed to be the case that every PR is labeled either WIP awaiting-review or awaiting-author. You can read more here.

Gareth Ma (Jun 16 2024 at 19:41):

Ah interesting. I was thinking that if someone wants to keep working on a PR before being reviewed, they can mark it as draft. But I guess that turns off CI

Bolton Bailey (Jun 16 2024 at 21:09):

No actually I think ci works either way, it’s just redundant as a system

Bolton Bailey (Jun 16 2024 at 21:11):

In fact I have had people review draft prs of mine before that weren’t marked in any way, the system is just a free for all

Yaël Dillies (Jun 16 2024 at 21:49):

... or awaiting-zulip


Last updated: May 02 2025 at 03:31 UTC