Zulip Chat Archive

Stream: new members

Topic: PR Awaiting Author


Sebastian Monnet (Feb 01 2022 at 12:03):

My PR, #11168, was tagged as "awaiting author" a while ago and I'm not sure why. It seems to me like I addressed all the issues in people's comments and the PR passed all checks when they were performed. Can anybody see what the problem is?

I also added the "awaiting review" label on the PR in case someone could answer on GitHub, but I thought I might as well ask here too.

Johan Commelin (Feb 01 2022 at 12:05):

@Sebastian Monnet It seems that I added the label 29 days ago. Since then a lot has happened on that PR. If you feel that you done everything you should, please remove the label again!

Johan Commelin (Feb 01 2022 at 12:05):

Note that there are still open conversations blocks. If those are finished, please click "Resolve conversation".

Johan Commelin (Feb 01 2022 at 12:05):

That way we can easily see where there is still ongoing conversation.

Sebastian Monnet (Feb 01 2022 at 12:06):

Johan Commelin said:

Sebastian Monnet It seems that I added the label 29 days ago. Since then a lot has happened on that PR. If you feel that you done everything you should, please remove the label again!

Oh hahaha, that's embarrassing! Thanks

Sebastian Monnet (Feb 01 2022 at 12:06):

Of course, it'll probably fail checks now, after all this time:(


Last updated: Dec 20 2023 at 11:08 UTC