Probable misformatting of curly braces

Stream: new members

[Sebastian Monnet]

The linter on my PR (#11780) says Warning: WRN_BRC: Probable misformatting of curly braces three times and then finishes with Error: Process completed with exit code 123.. I'm not sure how to fix this error, since I don't know where in the code the problem is. I suspect I'm missing something obvious. Can anyone help?

[Eric Rodriguez]

mathlib brace style is like this:

begin
  my_tactic_that_splits_things,
  { tactic1,
    tactic2,
    tactic3 },
  { tactic1 }
end

edit: ignore my lack of indents, Yaël is right!

[Anne Baanen]

Unfortunately, GitHub filters out the actual location of the error. You can see the errors if you click on the files changed tab, for example src/field_theory/krull_topology.lean line 138

[Yaël Dillies]

Eric Rodriguez said:

mathlib brace style is like this:

begin
my_tactic_that_splits_things,
{ tactic1,
  tactic2,
  tactic3 },
{ tactic1 }
end

begin
  my_tactic_that_splits_things,
  { tactic1,
    tactic2,
    tactic3 },
  { tactic1 }
end

actually

[Daniel Roca González]

One more thing: you can use the #lint command to make sure you have everything in order before pushing: that way you don't have to wait for GitHub to process your PR.

[Yaël Dillies]

Not quite, Daniel. #lint only runs the code linters, not the style ones.

[Yaël Dillies]

But, yes, do run #lint and Ctrl+F .{101} (for long lines) before pushing anything to Github.

[Eric Rodriguez]

You can turn on editor rulers on VSCode, Yaël, if youwant to make things a bit easier ^^

[Yaël Dillies]

I do! But the font is not quite monospace, and staring at the line ends of a 500 lines file is so much longer than Ctrl+F ing six characters.

[Eric Wieser]

Yeah, font issues make the rulers pretty useless sadly.

[Eric Rodriguez]

for me they've worked pretty flawlessly - but tbf I use a weird font in Cascadia Code

[Anne Baanen]

:set colorcolumn=100 works beautifully for me in nvim :)