fork or branch

Stream: new members

[Joachim Breitner]

The instructions at https://leanprover-community.github.io/contribute/index.html suggest that people ask for non-master push permissions before they contribute. Is that preferred over just opening PRs from a fork?

[Arthur Paulino]

From my experience with other projects, I usually prefer branches in the original repo if possible. It's easier for other people to collaborate or even take over in some cases. I often see the former scenario -- multiple people pushing commits to a branch -- happening with mathlib. And I've seen the later scenario happening too, especially with old branches.

[Alex J. Best]

Most of the CI tools we have are set up with branches on the non-forked mathlib repo in mind, so yes you should follow the instructions to have full access to the tooling.

[Joachim Breitner]

Ok, can someone add me? I’m nomeata on Github :-)

[Alex J. Best]

@maintainers :up:

[Bhavik Mehta]

Done!

[Bhavik Mehta]

By the way @Joachim Breitner, welcome :D incredible.pm was one of the things that got me interested in theorem proving in the first place!

[Joachim Breitner]

Oh, that’s great to hear :-D