Zulip Chat Archive

Stream: PR reviews

Topic: !3#17828 feat(combinatorics/quiver/covering)


Scott Morrison (Jul 27 2023 at 08:35):

This not-too-late mathlib3 PR by @Rémi Bottinelli had extensive review by @Yaël Dillies, but then the last message was a request from @Yaël Dillies for @Kyle Miller or @Bhavik Mehta to have a look.

Would one of the named people mind saying something about this PR, and what still needs to happen to get it over the line?

Kyle Miller (Jul 27 2023 at 16:10):

I did a bit of polishing work on this PR, and it's ready for another review (pinging @Yaël Dillies or @Bhavik Mehta ?).

There was a question by @Yaël Dillies of whether is_covering should be boosted to being equivalences rather than mere bijections, but let's leave that for a future investigation.

Scott Morrison (Jul 28 2023 at 07:28):

LGTM. I've hit merge. @Rémi Bottinelli, @Antoine Labelle, output from mathport should be ready in <24 hours, and hopefully then this file can be ported as for any other file. Please ping here if you'd like any help with the forward port!


Last updated: Dec 20 2023 at 11:08 UTC