Zulip Chat Archive

Stream: PR reviews

Topic: !3#17923


Scott Morrison (Jul 25 2023 at 05:27):

@Joël Riou, I've just hit merge on your mathlib3 PR !3#17923. It should be ready for forward porting to Mathlib4 via mathport in about 24 hours. You did so much porting that I'm sure you'll have no trouble, but please just ping here if anything goes awry, or it would be helpful to have someone else take it over.

Joël Riou (Jul 27 2023 at 17:53):

Thanks! The forward port PR is #6186.

Joël Riou (Jul 30 2023 at 05:58):

Now that #6186 is merged, I am not sure what to do with the last two Dold-Kan PRs !3#17925 and !3#17926. Should it be merged in mathlib3? or should I port them directly to mathlib4?

Scott Morrison (Jul 30 2023 at 07:27):

I think this is up to your preference, whatever you think will be smoothest. I just :peace_sign:'d !3#17925, if that helps!


Last updated: Dec 20 2023 at 11:08 UTC