Zulip Chat Archive
Stream: PR reviews
Topic: !4#3303 dot notation aliases
Ruben Van de Velde (Apr 10 2023 at 06:02):
It seems like this one would clear quite a large chunk of the out of sync list - would be nice if someone had time to review
Yaël Dillies (Apr 10 2023 at 07:23):
Yeah, the diff is not huge, but it's across many files.
Eric Wieser (Apr 10 2023 at 07:30):
I will review this on Thursday if no one else gets there first
Jeremy Tan (Apr 10 2023 at 07:30):
I'm already reviewing it
Eric Wieser (Apr 10 2023 at 07:43):
Are you familiar with how to review forward-ports,Jeremy?
Jeremy Tan (Apr 10 2023 at 08:07):
Yes, I found errors
Yaël Dillies (Apr 10 2023 at 08:51):
For those interested, #18785 deduplicates the instance that was accidentally duplicated (instead of moved) in #18698.
Notification Bot (Apr 10 2023 at 10:00):
Jeremy Tan has marked this topic as resolved.
Notification Bot (Apr 10 2023 at 10:00):
Jeremy Tan has marked this topic as unresolved.
Last updated: Dec 20 2023 at 11:08 UTC