Zulip Chat Archive
Stream: PR reviews
Topic: !4#3640 fixing #aligns
Jeremy Tan (Apr 25 2023 at 11:21):
I'd like to have a quick review and merge of !4#3640, which comprehensively fixes style nitpicks on #align
statements
Kevin Buzzard (Apr 25 2023 at 12:12):
So good they merged it twice!
Eric Wieser (Apr 25 2023 at 12:45):
@Jeremy Tan, if you're up for a challenge it would be great to have a CI job that catches multi-line aligns
Eric Wieser (Apr 25 2023 at 12:45):
Probably you could just add it to the style linter
Jeremy Tan (Apr 25 2023 at 14:52):
And now that the above is done, !4#3630 on fixing _root_
namespacing can be reviewed and merged
Last updated: Dec 20 2023 at 11:08 UTC