Zulip Chat Archive
Stream: PR reviews
Topic: !4#3961
Matthew Ballard (Jun 07 2023 at 22:57):
There was some duplication of existing API in topology.homotopy.product
in !4#2984. I fixed the actual errors but perhaps someone else might have a stronger opinion on the correct homes for results @Yury G. Kudryashov
Yury G. Kudryashov (Jun 07 2023 at 22:58):
I'm sorry for creating this mess. I should've looked at mathlib3 before adding new definitions. I'll have a look at the PR tonight.
Matthew Ballard (Jun 07 2023 at 22:58):
No worries. I just want to make sure the people invested get heard.
Eric Wieser (Jun 07 2023 at 23:11):
This is one of the reasons I was hesitant about contributing "new" content to mathlib4 before the port is over
Yury G. Kudryashov (Jun 08 2023 at 00:10):
And now I agree with you...
Last updated: Dec 20 2023 at 11:08 UTC